- 15 Sep, 2023 1 commit
-
-
Daco Harkes authored
Speeds up the native assets target in the backend by 1. changing other targets `gen_dart_plugin_registrant` and `release_unpack_ios` to do async I/O, 2. not reparsing the package config, and 3. not calling `dart pub deps --json` for 0 or 1 packages (fixed package:native_assets_builder). * https://github.com/flutter/flutter/issues/134427 ``` [ +2 ms] native_assets: Starting due to {} [ +2 ms] Skipping target: gen_localizations [ +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset} [ +33 ms] gen_dart_plugin_registrant: Complete [ +107 ms] release_unpack_ios: Complete [ +60 ms] Writing native_assets.yaml. [ +7 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/be2692bbfbc0b9a27fcd2422d52354c6/native_assets.yaml done. [ ] native_assets: Complete ``` -> ``` [ +4 ms] native_assets: Starting due to {} [ ] Skipping target: gen_localizations [ +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset} [ +31 ms] Writing native_assets.yaml. [ +8 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/f9451a65a465bfab70d004e21d6cc1d6/native_assets.yaml done. [ +1 ms] native_assets: Complete ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 10 Sep, 2023 1 commit
-
-
Daco Harkes authored
Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code. For more info see: * https://github.com/flutter/flutter/issues/129757 ### Implementation details for MacOS and iOS. Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file). The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target. The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets. ### Example vs template The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209. ### Tests This PR adds new tests to cover the various use cases. * dev/devicelab/bin/tasks/native_assets_ios.dart * Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode. * dev/devicelab/bin/tasks/native_assets_ios_simulator.dart * Runs an example app with native assets, doing hot reload and hot restart. * packages/flutter_tools/test/integration.shard/native_assets_test.dart * Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester. * packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart * Unit tests the new Target in the backend. * packages/flutter_tools/test/general.shard/ios/native_assets_test.dart * packages/flutter_tools/test/general.shard/macos/native_assets_test.dart * Unit tests the native assets being packaged on a iOS/MacOS build. It also extends various existing tests: * dev/devicelab/bin/tasks/module_test_ios.dart * Exercises the add2app scenario. * packages/flutter_tools/test/general.shard/features_test.dart * Unit test the new feature flag.
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 28 Mar, 2023 1 commit
-
-
stuartmorgan authored
Don't rethrow Dart plugin registration exceptions
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 09 Mar, 2023 1 commit
-
-
stuartmorgan authored
Improve Dart plugin registration handling
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes * fix after merge conflicts * review
-
- 09 Jan, 2023 1 commit
-
-
Jenn Magder authored
-
- 19 Aug, 2022 1 commit
-
-
Jackson Gardner authored
-
- 12 Jul, 2022 1 commit
-
-
Anurag Roy authored
-
- 02 Jul, 2022 1 commit
-
-
David Iglesias authored
-
- 23 Jun, 2022 1 commit
-
-
Christopher Fujino authored
-
- 12 May, 2022 1 commit
-
-
David Iglesias authored
-
- 26 Apr, 2022 1 commit
-
-
Jonah Williams authored
-
- 15 Apr, 2022 1 commit
-
-
Jenn Magder authored
-
- 14 Apr, 2022 1 commit
-
-
DetachHead authored
-
- 29 Mar, 2022 1 commit
-
-
gaaclarke authored
-
- 22 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 21 Mar, 2022 1 commit
-
-
gaaclarke authored
-
- 02 Mar, 2022 1 commit
-
-
gaaclarke authored
* Starts using the `--source` flag to compile the dart registrant. * updated general.shard tests * Fixed the resident compiler flow * added integration test * made the integration test self contained * renamed generated_main to dart_plugin_registrant * cleaned up for review * added task runner for ci * added bringup and TESTOWNERS * updated failure message
-
- 22 Feb, 2022 1 commit
-
-
Tomasz Gucio authored
-
- 02 Feb, 2022 1 commit
-
-
Collin Jackson authored
-
- 26 Jan, 2022 1 commit
-
-
Daco Harkes authored
-
- 19 Jan, 2022 1 commit
-
-
stuartmorgan authored
-
- 13 Jan, 2022 1 commit
-
-
stuartmorgan authored
-
- 04 Jan, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 5257f029.
-
Daco Harkes authored
* Building shared C source code as part of the native build for platforms Android, iOS, Linux desktop, MacOS desktop, and Windows desktop. * Sample code doing a synchronous FFI call. * Sample code doing a long running synchronous FFI call on a helper isolate. * Use of `package:ffigen` to generate the bindings.
-
- 11 Nov, 2021 1 commit
-
-
Greg Spencer authored
-
- 02 Nov, 2021 1 commit
-
-
Jenn Magder authored
-
- 20 Oct, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 11 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 01 Oct, 2021 2 commits
-
-
stuartmorgan authored
-
stuartmorgan authored
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR: - Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins. - Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future. Fixes https://github.com/flutter/flutter/issues/88794
-
- 21 Jul, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 03 Jun, 2021 1 commit
-
-
Jenn Magder authored
-
- 02 Jun, 2021 1 commit
-
-
stuartmorgan authored
-
- 01 Jun, 2021 1 commit
-
-
Jenn Magder authored
-