Commits · 223f32e09ec3c85afa907bb6f5fadf0d97cf02a6 · abdullh.alsoleman / Front-End

28 Nov, 2023 24 commits

Roll Flutter Engine from fd3a33f8b239 to 97ede154dcd8 (2 revisions) (#139168) · 223f32e0

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/fd3a33f8b239...97ede154dcd8

2023-11-28 jonahwilliams@google.com [Impeller] Skip mask blur with 0 sigma. (flutter/engine#48457)
2023-11-28 jonahwilliams@google.com [Impeller] match sigma scaling to Skia scaling. (flutter/engine#48434)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

223f32e0

Roll Flutter Engine from d375d5b95d59 to fd3a33f8b239 (2 revisions) (#139163) · 95a8f000

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/d375d5b95d59...fd3a33f8b239

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 8752700a2565 to f07025afd712 (1 revision) (flutter/engine#48462)
2023-11-28 30870216+gaaclarke@users.noreply.github.com [Impeller] implements incorporating the gaussian blur snapshot transform (flutter/engine#48426)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95a8f000

Roll Flutter Engine from e4b18fa3661e to d375d5b95d59 (2 revisions) (#139157) · 1676877c

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/e4b18fa3661e...d375d5b95d59

2023-11-28 jonahwilliams@google.com [Impeller] Recycle descriptor sets. (flutter/engine#48343)
2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 88443909711b to 8752700a2565 (3 revisions) (flutter/engine#48460)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1676877c

Added keyboardType & textInputAction props to SearchBar, SearchAnchor & SearchAnchor.bar (#138553) · 18b239fb
Tirth authored Nov 28, 2023
```
Added `keyboardType` & `textInputAction` props to `SearchBar`, `SearchAnchor` & `SearchAnchor.bar`

Fixes #138483
```
18b239fb

Fix header formatting typo in PopupMenuButton docs (#139084) · 89edac40

Jim Kalafut authored Nov 28, 2023

I believe this was intended (in #128351) to be a heading, but currently in the [published docs](https://api.flutter.dev/flutter/material/PopupMenuButton-class.html) it is rendered as:

 ```
/// ## Updating to MenuAnchor
```

89edac40

Fix turbulence seed for all tests with ink sparkles (#138757) · 92ad558e

Kate Lovett authored Nov 28, 2023

Fixes https://github.com/flutter/flutter/issues/138753

This makes sure that InkSparkles are always fixed for testing rather than random.

92ad558e

Renable macOS 13 tests (#139083) · 358e3913

Victoria Ashworth authored Nov 28, 2023

A workaround was added for https://github.com/flutter/flutter/issues/138238, so let's re-enable macOS 13 tests

358e3913

Roll Flutter Engine from 8715e9b9119d to e4b18fa3661e (1 revision) (#139142) · 65e9c427

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/8715e9b9119d...e4b18fa3661e

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 259041aed940 to 88443909711b (1 revision) (flutter/engine#48449)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65e9c427

Roll Packages from e774e8887ce2 to 3c054661a3a6 (2 revisions) (#139140) · edf27865

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/packages/compare/e774e8887ce2...3c054661a3a6

2023-11-28 engine-flutter-autoroll@skia.org Manual roll Flutter from b5f163a6 to 6bf3ccd4 (20 revisions) (flutter/packages#5495)
2023-11-27 43054281+camsim99@users.noreply.github.com [quick_actions_android] Run tests on AVDs running Android 34 (flutter/packages#5220)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

edf27865

Roll Flutter Engine from 6ad827e9a71b to 8715e9b9119d (1 revision) (#139136) · 91274cf6

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/6ad827e9a71b...8715e9b9119d

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 7db11e437559 to 259041aed940 (1 revision) (flutter/engine#48446)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

91274cf6

Roll Flutter Engine from c18d3df967dc to 6ad827e9a71b (1 revision) (#139135) · 7794715a

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/c18d3df967dc...6ad827e9a71b

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 38e60fd69349 to 7db11e437559 (1 revision) (flutter/engine#48445)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7794715a

Roll Flutter Engine from 1caa7478db0d to c18d3df967dc (1 revision) (#139133) · 92588b45

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/1caa7478db0d...c18d3df967dc

2023-11-28 kjlubick@users.noreply.github.com Replace all calls to SkTypeface::Make with SkFontMgr ones (flutter/engine#48319)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92588b45

Roll Flutter Engine from 4f217e1f9afe to 1caa7478db0d (1 revision) (#139129) · 82adb05c

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/4f217e1f9afe...1caa7478db0d

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 4ab39e85a055 to 38e60fd69349 (1 revision) (flutter/engine#48439)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82adb05c

Fix textScalerOf and maybeTextScalerOf documentations (#139123) · a28f4e3a

Bruno Leroux authored Nov 28, 2023

## Description

This PR fixes an inversion on `MediaQuery.textScalerOf` and  `MediaQuery.maybeTextScalerOf `documentation.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/139071

## Tests

Documentation only

a28f4e3a

Roll Flutter Engine from c25cc65720de to 4f217e1f9afe (1 revision) (#139126) · 897c2f85

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/c25cc65720de...4f217e1f9afe

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from ee5ede6f90cf to 4ab39e85a055 (1 revision) (flutter/engine#48438)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

897c2f85

Roll Flutter Engine from 3381d3ff0df7 to c25cc65720de (1 revision) (#139121) · 9c9a9d18

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/3381d3ff0df7...c25cc65720de

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 4a74daba343b to ee5ede6f90cf (2 revisions) (flutter/engine#48437)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c9a9d18

Roll Flutter Engine from 96137d05fabc to 3381d3ff0df7 (4 revisions) (#139119) · f64cae35

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/96137d05fabc...3381d3ff0df7

2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 62b4bf2bef5c to 4a74daba343b (1 revision) (flutter/engine#48436)
2023-11-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 8b962b2b9e72 to b58735e626f6 (1 revision) (flutter/engine#48435)
2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 600986ba305d to 62b4bf2bef5c (1 revision) (flutter/engine#48433)
2023-11-28 jonahwilliams@google.com [Impeller] Add benchmarks that measure the time it takes to record canvas operations. (flutter/engine#48374)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f64cae35

Fix intrinsic width of input decorator (#138074) · ad62645f

neko-andrew authored Nov 28, 2023

Fix min intrinsic width of input decorator by removing left or right padding when `prefixIcon` or `suffixIcon` are used.

Fixes #137937.

ad62645f

Run platform_channels_benchmarks on Pixel 7 Pro (#139092) · e49cc812

Zachary Anderson authored Nov 28, 2023

Related to https://github.com/flutter/flutter/issues/138689 for 64-bit
coverage for Dart VM changes in this area

cc @aam

e49cc812

Reland Add platform view wide gamut test (#139101) · 2150424c

Jonah Williams authored Nov 28, 2023

Reland of https://github.com/flutter/flutter/pull/138837

I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.

2150424c

Roll Flutter Engine from 5ffe1f4453e2 to 96137d05fabc (2 revisions) (#139108) · 947488d5

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/5ffe1f4453e2...96137d05fabc

2023-11-28 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fall back to `drawImage` for browsers that don't support `createImageBitmap` (flutter/engine#48336)
2023-11-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qyRH6zYfUEjo9L1x2... to Vqcs_2rbtDfbmu3WX... (flutter/engine#48428)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from qyRH6zYfUEjo to Vqcs_2rbtDfb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

947488d5

Roll Flutter Engine from 8b100cceb236 to 5ffe1f4453e2 (2 revisions) (#139106) · a0952601

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/8b100cceb236...5ffe1f4453e2

2023-11-27 matanlurey@users.noreply.github.com Update `HeaderFilterRegex` once and for all. (flutter/engine#48145)
2023-11-27 flar@google.com SurfaceFrame root DisplayLists will no longer prepare an RTree (flutter/engine#48422)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a0952601

Migrate customer_testing to sharded tests. (#138659) · fe7299d3

godofredoc authored Nov 28, 2023

This will allow Dart Team to run customer tests as part of monorepo and will be a step forward to remove ad_hoc tests.

Bug: https://github.com/dart-lang/sdk/issues/51042
Bug: https://github.com/flutter/flutter/issues/115476

fe7299d3

Roll Flutter Engine from 2be719150ea9 to 8b100cceb236 (1 revision) (#139105) · fc203edc

engine-flutter-autoroll authored Nov 28, 2023

https://github.com/flutter/engine/compare/2be719150ea9...8b100cceb236

2023-11-27 skia-flutter-autoroll@skia.org Roll Dart SDK from ef97fe2415fd to 8b962b2b9e72 (1 revision) (flutter/engine#48425)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc203edc

27 Nov, 2023 16 commits

Roll Flutter Engine from 0a098bd6f761 to 2be719150ea9 (5 revisions) (#139103) · 55e7b8da

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/0a098bd6f761...2be719150ea9

2023-11-27 goderbauer@google.com Dynamic view sizing [dart:ui] (flutter/engine#48090)
2023-11-27 dnfield@google.com Roll shaderc to google/shaderc@37e25539ce199ecaf19fb7f7d27818716d36686d (flutter/engine#48415)
2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 4c964f8c4738 to 600986ba305d (6 revisions) (flutter/engine#48419)
2023-11-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Enable multiview rendering (flutter/engine#48301)
2023-11-27 30870216+gaaclarke@users.noreply.github.com [Impeller] updated gaussian blur tests to use device private textures (flutter/engine#48417)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55e7b8da

Record focus in route entry to move a11y focus to the last focused item (#135771) · 8d429877
hangyu authored Nov 27, 2023
```
issue: #97747 
engine pr:https://github.com/flutter/engine/pull/47114
```
8d429877

Bump DartDoc to 8.0.0 (#139088) · 4727627b

Kallen Tu authored Nov 27, 2023

Bumping DartDoc to 8.0.0. https://pub.dev/packages/dartdoc/changelog

Will be also removing the `@hideConstantImplementations` directive since
the behaviour is default now.
See issue https://github.com/dart-lang/dartdoc/issues/3564.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

4727627b

Roll Flutter Engine from 900ce09b08b2 to 0a098bd6f761 (3 revisions) (#139099) · 12697173

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/900ce09b08b2...0a098bd6f761

2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c9bdb5884670 to ef97fe2415fd (6 revisions) (flutter/engine#48414)
2023-11-27 jonahwilliams@google.com [Impeller] add explainer for Android CPU profiling. (flutter/engine#48407)
2023-11-27 jhy03261997@gmail.com [ios] Send " did gain focus" message from engine to framework (flutter/engine#48252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12697173

Reverts "Wide gamut and platform view integration test." (#139100) · e6a49f8a

auto-submit[bot] authored Nov 27, 2023

Reverts flutter/flutter#138837
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
In https://github.com/flutter/engine/pull/48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.

e6a49f8a

[flutter_tools] fix instructions to disable CLI animations (#139094) · 6bf3ccd4
Christopher Fujino authored Nov 27, 2023
```
Fixes https://github.com/flutter/flutter/issues/139011
```
6bf3ccd4

Roll Flutter Engine from 9fe149249957 to 900ce09b08b2 (3 revisions) (#139095) · 6035c5cc

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/9fe149249957...900ce09b08b2

2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 743fc1cde518 to 4c964f8c4738 (2 revisions) (flutter/engine#48410)
2023-11-27 jonahwilliams@google.com [Impeller] revert non-zero tessellation optimization. (flutter/engine#48234)
2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from b0d81aba3f78 to 743fc1cde518 (3 revisions) (flutter/engine#48406)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6035c5cc

Wide gamut and platform view integration test. (#138837) · 389ebd46

Jonah Williams authored Nov 27, 2023

In https://github.com/flutter/engine/pull/48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.

389ebd46

Add ability to customize `NavigationBar` indicator overlay and fix indicator... · 397fd25b

Taha Tesser authored Nov 27, 2023

Add ability to customize `NavigationBar` indicator overlay and fix indicator shape for the overlay (#138901)

fixes [Provide ability to override `NavigationBar` indicator ink response overlay](https://github.com/flutter/flutter/issues/138850)
fixes [`NavigationBar.indicatorShape` is ignored, `NavigationBarThemeData.indicatorShape` is applied to the indicator inkwell](https://github.com/flutter/flutter/issues/138900)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        bottomNavigationBar: NavigationBarExample(),
      ),
    );
  }
}

class NavigationBarExample extends StatefulWidget {
  const NavigationBarExample({super.key});

  @override
  State<NavigationBarExample> createState() => _NavigationBarExampleState();
}

class _NavigationBarExampleState extends State<NavigationBarExample> {
  int index = 0;

  @override
  Widget build(BuildContext context) {
    return NavigationBar(
      elevation: 0,
      overlayColor: const MaterialStatePropertyAll<Color>(Colors.transparent),
      // indicatorShape: RoundedRectangleBorder(
      //   borderRadius: BorderRadius.circular(4.0),
      // ),
      indicatorColor: Colors.transparent,
      selectedIndex: index,
      onDestinationSelected: (int index) {
        setState(() {
          this.index = index;
        });
      },
      destinations: const <Widget>[
        NavigationDestination(
          selectedIcon: Icon(Icons.home_filled),
          icon: Icon(Icons.home_outlined),
          label: 'Home',
        ),
        NavigationDestination(
          selectedIcon: Icon(Icons.favorite),
          icon: Icon(Icons.favorite_outline),
          label: 'Favorites',
        ),
      ],
    );
  }
}

```

</details>

### Before

#### Cannot override `NavigationBar` Indicator ink well overlay

![Screenshot 2023-11-22 at 18 22 48](https://github.com/flutter/flutter/assets/48603081/06f54335-71ee-4882-afb0-53b614933c38)

#### Indicator shape is ignored for the indicator overlay

![Screenshot 2023-11-22 at 15 29 52](https://github.com/flutter/flutter/assets/48603081/913e0f77-48f4-4c6e-87f3-52c81b78f3d9)

### After

#### Can use `NavigationBar.overlayColor` or `NavigationBarThemeData.NavigationBar` to override default indicator overlay

`overlayColor: MaterialStatePropertyAll<Color>(Colors.red.withOpacity(0.33)),`

![Screenshot 2023-11-22 at 18 22 08](https://github.com/flutter/flutter/assets/48603081/28badae4-a7c7-4bf0-8bcc-278a1f84729d)

`overlayColor: MaterialStatePropertyAll<Color>(Colors.transparent),`

![Screenshot 2023-11-22 at 18 22 25](https://github.com/flutter/flutter/assets/48603081/674b48b1-f66a-4d91-9f10-ad307416ac32)

#### Indicator shape is respected for the indicator overlay

![Screenshot 2023-11-22 at 15 30 36](https://github.com/flutter/flutter/assets/48603081/ae9a3627-787e-45ac-9319-2ea8ea1e6ae6)

397fd25b

Roll Flutter Engine from cc57ace8e2e7 to 9fe149249957 (1 revision) (#139077) · 7b80797d

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/cc57ace8e2e7...9fe149249957

2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1fd14505782 to c9bdb5884670 (10 revisions) (flutter/engine#48402)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b80797d

Add type validation to non-template .arb file parsing logic (#139035) · 1952a6c8

Andrew Kolos authored Nov 27, 2023

Resolves https://github.com/flutter/flutter/issues/138297.

When reading from a .arb file (which contains localizations of strings in the form of a user-defined JSON string-string map), validate the type of values that we read.

See [this comment of mine on #138297](https://github.com/flutter/flutter/issues/138297#issuecomment-1827043260) to see how I arrived at this fix.

1952a6c8

Update Android app project template to apply Kotlin Gradle plugin declaratively (#139006) · e8282edf

Bartek Pacia authored Nov 27, 2023

This PR updates the app templates generated by `flutter create` to use declarative `plugins {}` syntax for applying the Kotlin Gradle Plugin.

I realized this is missing while writing [#9857.](https://github.com/flutter/website/pull/9857)

e8282edf

Prepare for dynamically sized views - pt. 2 (#139079) · 9147a1c1

Michael Goderbauer authored Nov 27, 2023

Towards https://github.com/flutter/flutter/issues/134501.

Required to roll https://github.com/flutter/engine/pull/48090 into the framework.

Two new subclasses of FlutterView were added recently for testing (in https://github.com/flutter/flutter/pull/138849) that I missed in my previous PR (https://github.com/flutter/flutter/pull/138565).

9147a1c1

Prepare for dynamically sized views (#138565) · bf5d2b87

Michael Goderbauer authored Nov 27, 2023

Towards https://github.com/flutter/flutter/issues/134501.

Required to roll https://github.com/flutter/engine/pull/48090 into the framework.

**DO NOT SUBMIT until https://github.com/flutter/flutter/pull/138648 and https://github.com/flutter/engine/pull/48090 are ready.**

bf5d2b87

Write tests for API examples of BottomNavigationBar and IconButton (#138188) · ec639f35

Jasper van Riet authored Nov 27, 2023

This PR writes tests for a few of the API examples (not all), as requested in #130459. For the test names, I used the existing tests in the `api` folder as guide.

ec639f35

Roll Flutter Engine from 9b610ecda771 to cc57ace8e2e7 (2 revisions) (#139072) · 9a930dd6

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/9b610ecda771...cc57ace8e2e7

2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 5f0832787d0f to b0d81aba3f78 (1 revision) (flutter/engine#48401)
2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 9fa62ccefe59 to 5f0832787d0f (1 revision) (flutter/engine#48400)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a930dd6