- 22 Oct, 2023 1 commit
-
-
Todd Volkert authored
Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all. This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback. #testexempt -- we have no way to test calls to the timeline.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 18 Sep, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 08 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description Now that we are using Doxygen for building docs for the embedders, this updates the links to point to the correct URLs. ## Related Issues - https://github.com/flutter/flutter/issues/124833 ## Related PRs - https://github.com/flutter/engine/pull/45561
-
- 31 Aug, 2023 1 commit
-
-
yaakovschectman authored
Add derived classes from the Darwin platform view base classes for MacOS. Functionality is largely the same as the `UiKitView`, but the two are decoupled and and can further diverge in the future as needed. Some unit tests remain skipped for now as the gesture recognizers for MacOS are not yet implemented. https://github.com/flutter/flutter/issues/128519 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Chris Bracken <chris@bracken.jp>
-
- 07 Aug, 2023 1 commit
-
-
Mouad Debbar authored
This wraps up the platform view improvements discussed in https://github.com/flutter/flutter/issues/127030. - Splits `HtmlElementView` into 2 files that are conditionally imported. - The non-web version can be instantiated but it throws if it ends up being built in a widget tree. - Out-of-the-box view factories that create visible & invisible DOM elements given a `tagName` parameter. - New `HtmlElementView.fromTagName()` constructor that uses the default factories to create DOM elements. - Tests covering the new API. Depends on https://github.com/flutter/engine/pull/43828 Fixes https://github.com/flutter/flutter/issues/127030
-
- 18 Jul, 2023 1 commit
-
-
yaakovschectman authored
Move most functionality of `UiKitView` and its supporting classes into superclasses named `DarwinPlatformView`, etc., and create trivial or near-trivial subclasses with the same names as the old classes. I am currently awaiting approval for a macOS workstation that would allow me to run the iOS/macOS tests and make sure all existing functionality is preserved by this refactor. I can ensure that tests will pass, but doing so may need to wait for a while. Addresses [Add AppKitView](https://github.com/flutter/flutter/issues/128519) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by:
Michael Goderbauer <goderbauer@google.com> Co-authored-by:
Chris Bracken <chris@bracken.jp>
-
- 16 Jun, 2023 1 commit
-
-
Mouad Debbar authored
Previously, when the code contained `const HtmlElementView()` it would break even if it's guarded by `if (kIsWeb)`. This PR makes it such that `const HtmlElementView()` is allowed but it still throws if it gets inserted into the widget tree by mistake on non-web platforms. One improvement we can make in the future is to have a conditional import: - `_html_element_view_web.dart` that contains the real `HtmlElementView` that can only be instantiated on web. - `_html_element_view_io.dart` that contains a stub with an unimplemented `build()` method. Fixes https://github.com/flutter/flutter/issues/43532
-
- 15 Jun, 2023 1 commit
-
-
Mouad Debbar authored
This concludes step 1 of the `HtmlElementView` improvements. It's now possible to pass creation params to platform view factories directly from `HtmlElementView`. Here's a sample app using a single factory to render platform views in different colors: <details> <summary>Code sample</summary> ```dart import 'dart:js_interop'; import 'dart:ui_web' as ui_web; import 'package:flutter/material.dart'; import 'package:web/web.dart' as web; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: 'Platform View Demo', home: Scaffold( appBar: AppBar( title: Text('Platform View Demo'), ), body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: [ BoxWrapper('red'), BoxWrapper(null), BoxWrapper('blue'), ], ), ), ), ); } } bool isRegistered = false; class BoxWrapper extends StatelessWidget { const BoxWrapper(this.cssColor); final String? cssColor; void register() { if (isRegistered) return; isRegistered = true; ui_web.platformViewRegistry.registerViewFactory('my-platform-view', ( id, { Object? params, }) { params as String?; final element = web.document.createElement('div'.toJS) as web.HTMLElement; element.textContent = 'Platform View'.toJS; element.style ..lineHeight = '100px'.toJS ..fontSize = '24px'.toJS ..backgroundColor = (params ?? 'pink').toJS ..textAlign = 'center'.toJS; return element; }); } @override Widget build(BuildContext context) { register(); return SizedBox( width: 200, height: 100, child: Card( child: HtmlElementView( viewType: 'my-platform-view', creationParams: cssColor, ), ), ); } } ``` </details>  Depends on https://github.com/flutter/engine/pull/42255 Part of https://github.com/flutter/flutter/issues/127030
-
- 05 Apr, 2023 1 commit
-
-
hellohuanlin authored
[platform_view]fix iOS platform view's focus node leakage
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 08 Feb, 2023 1 commit
-
-
Gabriel Terwesten authored
* Don't call `PlatformViewCreatedCallback`s after `AndroidViewController` is disposed Before this change it was possible that, if a `AndroidViewController` was disposed before we got the notification that the platform view was created, `PlatformViewCreatedCallback`s where called even after calling `AndroidViewController.dispose`. Also makes `_PlatformViewLinkState._onPlatformViewCreated` more carful to only call `setState` when mounted. Closes #84628 Closes #96384 * Allow all widgets to remove listeners from controller * Remove assert * Add expectations to test
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 18 Jan, 2023 1 commit
-
-
Chris Yang authored
* update uikit view documentation * fix
-
- 15 Nov, 2022 1 commit
-
-
Maurice Parrish authored
* add position to layout creation * make position nullable * fix tests * test * clear test size * clear device pixel ratio * add more documentaiton * add comment about localToGlobal
-
- 05 Oct, 2022 1 commit
-
-
stuartmorgan authored
-
- 21 Sep, 2022 1 commit
-
-
stuartmorgan authored
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 12 Aug, 2022 1 commit
-
-
stuartmorgan authored
-
- 11 Aug, 2022 2 commits
-
-
Casey Hillers authored
Merging on red to green the build.
-
stuartmorgan authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 23 Jun, 2022 1 commit
-
-
hellohuanlin authored
-
- 06 Jun, 2022 1 commit
-
-
Nils Reichardt authored
-
- 24 May, 2022 1 commit
-
-
hellohuanlin authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 07 Apr, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 30 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 29 Mar, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 61c30eed.
-
Emmanuel Garcia authored
-
- 24 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
This reverts commit d92fedcc.
-
- 17 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 16 Mar, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 509ddfda.
-
Emmanuel Garcia authored
-
- 14 Mar, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 20 Jul, 2021 1 commit
-
-
Arthas authored
-
- 01 Jul, 2021 1 commit
-
-
Ahmed Ashour authored
-
- 10 Jun, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-