- 08 Feb, 2023 17 commits
-
-
Hans Muller authored
This reverts commit e8eac0d0.
-
Qun Cheng authored
-
Camille Simon authored
-
Gabriel Terwesten authored
* Don't call `PlatformViewCreatedCallback`s after `AndroidViewController` is disposed Before this change it was possible that, if a `AndroidViewController` was disposed before we got the notification that the platform view was created, `PlatformViewCreatedCallback`s where called even after calling `AndroidViewController.dispose`. Also makes `_PlatformViewLinkState._onPlatformViewCreated` more carful to only call `setState` when mounted. Closes #84628 Closes #96384 * Allow all widgets to remove listeners from controller * Remove assert * Add expectations to test
-
engine-flutter-autoroll authored
* 40c2e1169 [local_auth_android] update java complie sdk version to green tree (flutter/plugins#7121) * 81c6fd07a Update release tooling to give a workaround for predictable failing case https://github.com/flutter/flutter/issues/120116 (flutter/plugins#7111) * f59c08db3 Roll Flutter from 3c3c9a1b to e8eac0d0 (21 revisions) (flutter/plugins#7122)
-
Eilidh Southren authored
* remove m3 shadows * fix * fix that test over there
-
MarchMore authored
* Removed "if" on resolving text color at "SnackBarAction" Removed multiple "if" for "resolveForegroundColor" method at "SnackBarAction". At least one of the multiple "if" ("defaults.actionTextColor is MaterialStateColor") led to not applying a custom set color (e.g. MaterialColor "Colors.red") for the action text when using Material 3. The second "if" ("snackBarTheme.actionTextColor is MaterialStateColor") also makes no sense then as the set color of the Theme would lead to the same blocking behaviour of manual color assignment. The last remaining "if" ("widget.textColor is MaterialStateColor") will be unnecessary if the other "if" will be removed, as it will be resolved in the code right afterwards. The three "if" also seems to block the usage of the custom text color or the color at all if the widget is in the "MaterialState.disabled" state. * Adjusted recent modifications to SnackBarAction's text color resolution * Now the "widget.textColor" is checked if it is set. * If it is a MaterialStateColor, it will be used * Otherwise continue with normal resolution (It will be used in the resolution anyways because it's set) * Repeat same steps with "snackBarTheme.actionTextColor" if previous was not set * Repeat same steps with "defaults.actionTextColor" if previous was not set * Reverted the auto formatting changes * Added two test cases to "snack_bar_test" * Test for setting a MaterialColor to a SnackBarAction' label (M3) * Test for setting a MaterialStateColor to a SnackBarAction' label (M3) * Renamed test cases "Snackbar labels can be colored"
-
Hans Muller authored
-
engine-flutter-autoroll authored
* 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377) * 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458) * e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459) * bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues (flutter/engine#38794) * 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462) * ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441) * 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463) * 85958c2ea Update malioc analysis golden file (flutter/engine#39461) * 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466) * bc8d3fca7 Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (flutter/engine#39470) * 28837b3ad Revert "Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (#39470)" (flutter/engine#39475) * bdc5b6b76 Revert "Revert "Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (#39470)" (#39475)" (flutter/engine#39477)
-
Mouad Debbar authored
This reverts commit da36bd6f.
-
Qun Cheng authored
* Add trackOutlineColor for Switch and SwitchListTile * Update tests * Update test * Clean up unnecessary StatefulBUilder in tests * Fix failed test --------- Co-authored-by: Qun Cheng <quncheng@google.com>
-
xubaolin authored
* fix a TextFormField bug * review feedback
-
Zachary Anderson authored
This reverts commit f94fa7ea.
-
Renzo Olivares authored
Add support for extending selection to paragraph on ctrl + shift + arrow up/down on Non-Apple platforms (#120151) * Add support for extending selection to paragraph on ctrl + shift + arrow up/down for common keyboard actions * Add ctrl + shift + arrow up/down common text editing shortcuts/actions * fix analyzer --------- Co-authored-by: Renzo Olivares <roliv@google.com>
-
engine-flutter-autoroll authored
* 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377) * 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458) * e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459) * bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues (flutter/engine#38794) * 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462) * ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441) * 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463) * 85958c2ea Update malioc analysis golden file (flutter/engine#39461) * 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466)
-
Greg Price authored
* Add test for RenderProxyBoxMixin; clarify doc, resolve TODO The TODO comment suggested this mixin would no longer be needed once a Dart issue on inherited constructors was fixed: https://github.com/dart-lang/sdk/issues/31543 That issue is now long since fixed, so I went to go carry out the TODO. But in doing so, I realized that the mixin's documentation was more right than the TODO comment: even with that issue fixed, there is a legitimate use case for this mixin, namely to reuse the implementation of RenderProxyBox in a class that also inherits from some other base class. Moreover, searching GitHub I found an example of a library that makes real use of that capability. So I think the right resolution is to accept that this separation is useful and delete the TODO. Then, add a test with an extremely simplified sketch of that real-world example. In case someone in the future attempts to simplify this mixin away, the test will point us at the use case that would be broken by such a change. Also remove the only in-tree use of the mixin, which was redundant; and expand the mixin's documentation to advise about that case. * Tweak formatting Co-authored-by: Michael Goderbauer <goderbauer@google.com> * Cut comments --------- Co-authored-by: Michael Goderbauer <goderbauer@google.com>
-
Greg Price authored
Fixes #117659 It turns out this was due to the output-suppression timer introduced recently as part of cleaning up the output (#109206); on success, the script would wait 10 minutes for the timeout to expire. This didn't affect CI because this feature doesn't apply in CI (as detected by lack of color on stdout.) Fix the issue by cleaning up the timer on success in the same way as on failure. While here, clean up the final summary messages slightly, and also cut the trailing space that printProgress was leaving on each line.
-
- 07 Feb, 2023 20 commits
-
-
Christopher Fujino authored
This reverts commit f7c2bd05.
-
engine-flutter-autoroll authored
f310ffd14 Roll Skia from 3b1401c4870d to 87dbc81b421f (4 revisions) (flutter/engine#39457) (#120214)
-
Christopher Fujino authored
-
Justin McCandless authored
Correct selection behavior when tabbing into a field on the web.
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by: Qun Cheng <quncheng@google.com>
-
Taha Tesser authored
-
Andrew Kolos authored
* add test * fix * use preexisting testFileSystem * fix variant tests * Revert "use preexisting testFileSystem" This reverts commit b6df288ef4a6ff007ecd984e98a1a3f2001ad242. * nit: grammar
-
engine-flutter-autoroll authored
-
Mouad Debbar authored
-
engine-flutter-autoroll authored
* 883864599 [image_picker] GIF files will animate without permissions. PNG and GIF files will retain their image type if missing permissions. (flutter/plugins#7084) * 7a63dbc8f [camera] flip/change camera while recording - platform interface (flutter/plugins#7011) * c6be93605 Roll Flutter from b8f5394a to 3c3c9a1b (3 revisions) (flutter/plugins#7107) * eb0a6b562 [gh_actions]: Bump github/codeql-action from 2.1.37 to 2.2.1 (flutter/plugins#7059) * dc0d3a02b [camerax] Wrap methods necessary for preview implementation (flutter/plugins#7046) * c9f6bee71 [local_auth]: Bump core from 1.8.0 to 1.9.0 in /packages/local_auth/local_auth_android/android (flutter/plugins#6393) * f5957bde8 [webview_flutter_web] Avoids XHR when possible. (flutter/plugins#7090) * 55f257382 [Espresso] Update expressio dependencies (flutter/plugins#7108) * 76ea8c8ce [url_launcher_ios] Update minimum Flutter version to 3.3 and iOS 11 (flutter/plugins#7110) * 6f985d57b Redistribute ownership of cross-platform plugin components (flutter/plugins#7093)
-
engine-flutter-autoroll authored
* ca47bbc7e Roll Skia from 83da27e4cd3a to 6babb6a1afe6 (1 revision) (flutter/engine#39451) * cabdc9e23 Roll Fuchsia Mac SDK from jD_N9MDLvRtOuBMgY... to zYEsaCaA1cokDUU43... (flutter/engine#39453) * e432b82f4 Roll Fuchsia Linux SDK from wlbzrDXNCXQZV0QdG... to aRqjqB76Z2gNQsrTA... (flutter/engine#39454)
-
Konstantin Sokolovskyi authored
* Fix cut button creation in buttonItemsForToolbarOptions * Remove extra spaces in tests * Replace fails with expects, Add periods in the comments
-
engine-flutter-autoroll authored
-
Eilidh Southren authored
* add icon button property override * Revert "add icon button property override" This reverts commit 6c7f4d30671f417d0f4a311bdb186bd4ebc456c8. * segmented button updates * button changes * fix * put that thing back where it came from * template updates * analyzer fixes * rename parameter * analyzer fixes * string interpolation fix * template updates * test updates
-
engine-flutter-autoroll authored
-
xubaolin authored
* fix a crash bug * review feedback
-
Renzo Olivares authored
Co-authored-by: Renzo Olivares <roliv@google.com>
-
engine-flutter-autoroll authored
* ec45e72a2 Roll Dart SDK from a507a9057730 to f18aa4402c1a (3 revisions) (flutter/engine#39395) * 1f0cb90da Roll Skia from 45a4fdcc0cb0 to 1bc762cbb8ce (1 revision) (flutter/engine#39397) * b19b263de Roll Fuchsia Mac SDK from j6dhXDhI_KUUyqTSF... to f7zsdfKoUWP6RD8S_... (flutter/engine#39398) * a6cc2517b Roll Fuchsia Linux SDK from Z6Bdg2fbH4n5ptsKZ... to V9ahWWCSVIMrpc9LX... (flutter/engine#39399) * af02efb3f Revert "Roll Dart SDK from a507a9057730 to f18aa4402c1a (3 revisions) (#39395)" (flutter/engine#39422) * aa0ff2173 Migrate engine_v2_builds to python3. (flutter/engine#39404) * a87b7455a Use jdk 11 in the engine. (flutter/engine#39375) * 75722215e Fix cpp-wrappers archive. (flutter/engine#39400) * 696049ef1 Roll Fuchsia Mac SDK from f7zsdfKoUWP6RD8S_... to jD_N9MDLvRtOuBMgY... (flutter/engine#39439) * 0c61605a7 Roll Fuchsia Linux SDK from V9ahWWCSVIMrpc9LX... to wlbzrDXNCXQZV0QdG... (flutter/engine#39435) * 6024bef6b Roll Skia from 1bc762cbb8ce to 7e2c9f54c0fd (23 revisions) (flutter/engine#39440) * 0315d0601 [Windows] Fix the 'engine restart resets keyboard' test (flutter/engine#39380) * 165126e70 iOS keyboard animation synchronization (flutter/engine#37604)
-
Jenn Magder authored
* Run verify_binaries_codesigned on release branches * Revert branches
-
Sam Rawlins authored
* Remove unreachable_from_main linter rule * Comment out * Update analysis_options.yaml --------- Co-authored-by: Michael Goderbauer <goderbauer@google.com>
-
- 06 Feb, 2023 3 commits
-
-
Jenn Magder authored
-
Justin McCandless authored
The context menu examples on the docs site now work on the web.
-
林洵锋 authored
* Fix flutter_tools stuck when using custom LLDB prompt * Remove trailing space character * Fix local variable name * Add comment * Remove trailing space character * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart Co-authored-by: Jenn Magder <magder@google.com> * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart Co-authored-by: Jenn Magder <magder@google.com> * Remove trailing space character --------- Co-authored-by: Jenn Magder <magder@google.com>
-