1. 19 Apr, 2022 1 commit
  2. 18 Apr, 2022 1 commit
  3. 14 Apr, 2022 1 commit
  4. 07 Apr, 2022 1 commit
  5. 06 Apr, 2022 1 commit
  6. 30 Mar, 2022 1 commit
  7. 23 Mar, 2022 1 commit
  8. 03 Feb, 2022 1 commit
  9. 24 Jan, 2022 1 commit
  10. 12 Dec, 2021 1 commit
  11. 14 Oct, 2021 2 commits
  12. 12 Oct, 2021 1 commit
  13. 08 Oct, 2021 3 commits
  14. 15 Jul, 2021 1 commit
  15. 14 Jul, 2021 3 commits
  16. 13 Jul, 2021 2 commits
  17. 01 Jul, 2021 1 commit
  18. 23 Jun, 2021 1 commit
  19. 19 May, 2021 1 commit
  20. 28 Apr, 2021 1 commit
  21. 08 Mar, 2021 1 commit
  22. 06 Mar, 2021 1 commit
  23. 04 Mar, 2021 1 commit
  24. 27 Feb, 2021 1 commit
  25. 16 Feb, 2021 1 commit
  26. 12 Feb, 2021 1 commit
    • Nathan Walker's avatar
      ListTile Material Ripple and Shape Patch (#74373) · 422916d2
      Nathan Walker authored
      This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.
      422916d2
  27. 09 Feb, 2021 1 commit
  28. 04 Feb, 2021 1 commit
  29. 27 Jan, 2021 1 commit
  30. 20 Jan, 2021 2 commits
    • Greg Spencer's avatar
      Revert "ListTile Material Ripple and Shape Patch (#73618)" (#74335) · 2e3d3e65
      Greg Spencer authored
      This reverts commit 024c49da because it breaks Google internal tests.
      2e3d3e65
    • Nathan Walker's avatar
      ListTile Material Ripple and Shape Patch (#73618) · 024c49da
      Nathan Walker authored
      This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.
      
      List which issues are fixed by this PR. You must list at least one issue.
      
      Fixes #73616
      Fixes #63877
      Fixes #67117
      
      If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
      
      I modified a handful of tests related to ListTiles. The tests I changed had implementation-specific ways of checking the ListTile color. I have rewritten those so that instead of checking for a ColoredBox with a specific color, they check that a path is painted with the correct color.
      
      I added the following tests to list_tile_test.dart:
      
      "ListTile shows Material ripple effects on top of tileColor" (Regression test for #73616)
      "ListTile shape is painted correctly" (Regression test for #63877)
      I added the following test to sliver_prototype_item_extent_test.dart:
      
      "SliverPrototypeExtentList prototypeItem paint transform is zero" (Regression test for #67117)
      024c49da
  31. 14 Jan, 2021 1 commit
  32. 10 Nov, 2020 1 commit
  33. 07 Nov, 2020 1 commit