- 30 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add missing trailing commas * add more missing trailing commas * add more and more missing trailing commas
-
- 28 Sep, 2019 1 commit
-
-
Greg Spencer authored
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
-
- 27 Sep, 2019 2 commits
-
-
Greg Spencer authored
This reverts commit eb3e2f55 because of a suspected analyzer bug. Reverting to investigate.
-
Greg Spencer authored
This addresses comments in the original PR (#41245) that introduced Intent.doNothing, adds tests, and fixes an issue with it.
-
- 24 Sep, 2019 2 commits
-
-
Alexandre Ardhuin authored
-
Greg Spencer authored
There were four or five different implementations in various tests for sendFakeKeyEvent, which roughly all did the same thing. I was going to add yet another one, and decided that it needed to be generalized and centralized. This replaces those instances with something that just takes a LogicalKeyboardKey so that it's self-documenting, and can be used with multiple platforms. This adds two functions to widget tester: sendKeyDownEvent and sendKeyUpEvent which simulate key up/down from a physical keyboard. It also adds global functions simulateKeyDownEvent and simulateKeyUpEvent that can be called without a widget tester. All are async functions protected by the async guard.
-
- 23 Aug, 2019 1 commit
-
-
Greg Spencer authored
This fixes the hashCode calculation for KeySet<T> so that it doesn't depend on the insertion order of the keys in the set. The fix involves switching from Set<T> to HashSet<T> internally, so that the iteration order is stable around the hash values of the inserted keys, and not the insertion order. This matters when hashList is called in KeySet<T>.hashCode to build the hash value of the contents of the internal set. Fixes #38919
-
- 21 Aug, 2019 1 commit
-
- 09 Aug, 2019 2 commits
-
-
Michael Klimushyn authored
This reverts commit 92ef2b9c. This requires either runApp() or WidgetsFlutterBinding.ensureInitialized() to have been called before using any MethodChannels. Plugins broadly rely on MethodChannels and right now there's no general requirements that they be constructed within the runApp call, so the ecosystem breakages from this are broader than originally thought. Reverting for now.
-
adazh authored
-
- 06 Jun, 2019 1 commit
-
-
Greg Spencer authored
This fixes a rather embarrassing bug in ShortcutManager that happened because I forgot to add the tests I meant to add. This fixes the bug, and adds the tests.
-
- 04 Jun, 2019 1 commit
-
-
Greg Spencer authored
This implements the keyboard shortcut handling and action invocation in order to provide a place in the infrastructure for keyboard events to trigger actions. This will allow binding of key events to actions like "move the focus to the next widget" and "activate button".
-