- 12 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 11 Jul, 2023 6 commits
-
-
Chris Bobbe authored
Fixes #130187. Fixes #130187 by removing the mistaken paragraph; see there for details.
-
Tsukuru Tanimichi authored
https://api.flutter.dev/flutter/material/material-library.html Links in `material` library docs are outdated
-
Polina Cherkasova authored
-
Qun Cheng authored
Fixes #125199 This PR is to add a new property `expandedInsets` so that the `DropdownMenu` can be expandable and has some margins around. <details><summary>Example: Setting `expandedInsets` to `EdgeInsets.zero`</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const DropdownMenuExample()); class DropdownMenuExample extends StatefulWidget { const DropdownMenuExample({super.key}); @override State<DropdownMenuExample> createState() => _DropdownMenuExampleState(); } class _DropdownMenuExampleState extends State<DropdownMenuExample> { final TextEditingController colorController = TextEditingController(); ColorLabel? selectedColor; @override Widget build(BuildContext context) { final List<DropdownMenuEntry<ColorLabel>> colorEntries = <DropdownMenuEntry<ColorLabel>>[]; for (final ColorLabel color in ColorLabel.values) { colorEntries.add( DropdownMenuEntry<ColorLabel>(value: color, label: color.label, enabled: color.label != 'Grey'), ); } return MaterialApp( theme: ThemeData( useMaterial3: true, colorSchemeSeed: Colors.green, ), home: Scaffold( body: Center( child: Container( width: 500, height: 500, color: Colors.orange, child: DropdownMenu<ColorLabel>( expandedInsets: EdgeInsets.zero, inputDecorationTheme: const InputDecorationTheme( filled: true, fillColor: Colors.white, border: OutlineInputBorder(), ), controller: colorController, dropdownMenuEntries: colorEntries, onSelected: (ColorLabel? color) { setState(() { selectedColor = color; }); }, // expandedInsets: EdgeInsets.only(left: 35.0, right: 20.0, top: 80), ), ), ), ), ); } } enum ColorLabel { blue('Blue', Colors.blue), pink('Pink', Colors.pink), green('Green', Colors.green), yellow('Yellow', Colors.yellow), grey('Grey', Colors.grey); const ColorLabel(this.label, this.color); final String label; final Color color; } ``` <img width="500" alt="Screenshot 2023-06-28 at 11 33 20 PM" src="https://github.com/flutter/flutter/assets/36861262/e703f8a2-6e7c-45a0-86cf-d96da6dc157a"> </details>
-
Darshan Rander authored
The ExpansionTile was not following `shape` from ExpansionTileTheme as it was assigning wrong parameter to the tween. fixes #129785
-
Ian Hickson authored
-
- 10 Jul, 2023 1 commit
-
-
Rydmike authored
Fixes the reversed default icon color constants brightness documentation for `kDefaultIconLightColor` and `kDefaultIconDarkColor`. FIX: https://github.com/flutter/flutter/issues/130230
-
- 07 Jul, 2023 7 commits
-
-
hangyu authored
Add a threshold when comparing screen order for selectables. So when the vertical position diff is within the threshold, will compare the horizontal position. This fixes https://github.com/flutter/flutter/issues/111021 and https://github.com/flutter/flutter/issues/127942
-
Alexander Aprelev authored
Manual roll is needed because incoming dart sdk requires updated version vm_snapshot_analysis (>=0.7.4). https://github.com/flutter/engine/compare/5ae09b8b4fa381e8723ed5382a26eafd0d97236f...7c83ea3e854202aea22405a947ac1b8f18c5a72c ``` 7c83ea3e85 Reland "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (#43457)" (#43472) 9ef3e8d533 Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) (#43471) ``` Remove implementation of SuitePlatform from the test as well. Remove use of fake cwd from SuitePlatform as it can't be properly faked.
-
Jesús S Guerrero authored
Reverts flutter/flutter#127776 Currently breaking google testing
-
Polina Cherkasova authored
-
Chris Bobbe authored
Allows positioning Autocomplete options above the field (previously hardcoded to under the field).
-
fzyzcjy authored
You know, I like to see beautiful code, so really hope we have auto formatter, such that all these (at least such formatting error) can be done automatically!
-
Hans Muller authored
Reverts flutter/flutter#114303 The breaking API change in flutter/flutter#114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: https://github.com/flutter/flutter/issues/130062. Fixes https://github.com/flutter/flutter/issues/130062
-
- 06 Jul, 2023 7 commits
-
-
fzyzcjy authored
Removed two unnecessary `if` conditions.
-
Polina Cherkasova authored
-
Gil Nobrega authored
Adds optional visual labels to Cupertino's on/off switch for accessibility.
-
Henrique Nascimento authored
This pull request introduces the `buildFlexibleSpace` method to the `SearchDelegate` class in the material library. It allows users to add a flexible space widget to the `AppBar` in a `_SearchPage`, providing more customization options. This PR does not fix any specific issue as there are no open issues related to this feature.
-
luckysmg authored
iOS OCR keyboard input support.
-
Ian Hickson authored
Previously, if you changed buttons during a long-press gesture, if it was before the gesture was accepted we would discard it, and if it was after the gesture was accepted we would silently end it without firing any of the relevant events. This silent cancelation behavior is terrible because it means there's no way for consumers to know what state they're in, so you end up with widgets that thing they're still being long-pressed even though nothing is happening. We could change the behavior in three ways, as far as I can tell: - we could send a cancel event when you change buttons. This would introduce a new kind of transition (start->cancel) which I don't think we currently require people to support. This would therefore not fix existing code and would make future code more complicated to handle a really obscure user action that it seems unlikely anyone cares about. - we could send an end event when you change buttons. This would mean the action commits, even though the user is still holding the mouse button down. This seems slightly better than the previous option but still not ideal as it means nudging the mouse button commits you even though you're still holding the button down. - we could ignore button changes after the long-press has been accepted. I implemented the last one in this PR.
-
Michael Goderbauer authored
PLUS: clean-up of all the unreachable stuff.
-
- 05 Jul, 2023 5 commits
-
-
Snonky authored
-
Hans Muller authored
Reland https://github.com/flutter/flutter/pull/129556/ which had failed an internal test (see Google internal link b/288993600) and was reverted in https://github.com/flutter/flutter/pull/129645. This PR must be landed with G3 Fix cl/543755631
-
Myles Moylan authored
This PR is adding a file of two simple unit tests in order to improve code coverage (covering two simple classes within the annotations.dart file). The issue this is fixing is the lack of complete test coverage for the annotations.dart file.
-
ipcjs authored
When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem. #99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>
-
Pierre-Louis authored
Sample code is added, documentation condensed, and links to guidelines updated. For b/258360306
-
- 04 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 01 Jul, 2023 1 commit
-
-
Parker Lougheed authored
Removes the remaining links to the old linter site, to the guaranteed dart.dev/lints redirect. Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
-
- 30 Jun, 2023 9 commits
-
-
Qun Cheng authored
-
Greg Price authored
Fixes #129532. This ensures that when a test properly uses `debugNetworkImageHttpClientProvider` to tell `NetworkImage` to use a fake `HttpClient`, we don't go ahead and try to instantiate `HttpClient` anyway and generate a misleading warning.
-
Hans Muller authored
Updated some of the golden image tests that were temporarily changed in https://github.com/flutter/flutter/pull/128914 to have M2 and M3 versions. Updated the linear_gradient_0 example to M3 (which will require updating its golden image as well). More info in https://github.com/flutter/flutter/issues/127064
-
Qun Cheng authored
Updated unit tests for `Radio` to have M2 and M3 versions. More info in https://github.com/flutter/flutter/issues/127064
-
Qun Cheng authored
Updated and reorganized unit tests for `Switch` to have M2 and M3 versions. More info in https://github.com/flutter/flutter/issues/127064
-
Qun Cheng authored
Updated and reorganized unit tests for `SwitchListTile` to have M2 and M3 versions. More info in https://github.com/flutter/flutter/issues/127064
-
Taha Tesser authored
fixes [NavigationDrawer selected item has wrong icon color [Material3 spec]](https://github.com/flutter/flutter/issues/129572) ### Description This PR fixes a mistake in the `NavigationDrawer` defaults, where generated token value returns a `null`. This issue can be detected when you want to customize the selected icon color for `NavigationDrawerDestination` using a custom color scheme. ### Code sample <details> <summary>expanded to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, themeMode: ThemeMode.light, theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue).copyWith( onSecondaryContainer: Colors.red, ), useMaterial3: true, ), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: const Text('NavigationDrawer Sample'), ), drawer: const NavigationDrawer( children: <Widget>[ NavigationDrawerDestination( icon: Icon(Icons.favorite_outline_rounded), label: Text('Favorite'), selectedIcon: Icon(Icons.favorite_rounded), ), NavigationDrawerDestination( icon: Icon(Icons.favorite_outline_rounded), label: Text('Favorite'), ), ], ), ); } } ``` </details> ### Before <img width="1053" alt="Screenshot 2023-06-27 at 13 24 38" src="https://github.com/flutter/flutter/assets/48603081/18c13a73-688f-4586-bb60-bddef45d173f"> ### After <img width="1053" alt="Screenshot 2023-06-27 at 13 24 25" src="https://github.com/flutter/flutter/assets/48603081/8a1427c6-517f-424a-b0bd-24bad7c5fbb0">
-
Bruno Leroux authored
## Description This PR fixes two test failures in `basic_test.dart` which surfaced when switching to M3 (see https://github.com/flutter/flutter/pull/127501) Those failures are related to M3 typography which sets line height to 1.43. Forcing line height to 1.0 seems reasonable for these particular tests. With this change these two test are successful for both M2 and M3. ## Related Issue fixes https://github.com/flutter/flutter/issues/129713 ## Tests Updates 2 tests.
-
Qun Cheng authored
Fixes #120349 This PR enables `DropdownMenu` to automatically scroll to the first matching item when `enableSearch` is true. <details><summary>video example</summary> https://github.com/flutter/flutter/assets/36861262/1a7a956c-c186-44ca-9a52-d94dc21cac8a </details>
-
- 29 Jun, 2023 1 commit
-
-
Taha Tesser authored
This updates the `RadioListTile` test which was modified in https://github.com/flutter/flutter/pull/128839 ### Description - Update the layout to the proper order `MaterialApp` -> `Material` -> `RadioListTile` - Add M3 overlay test. (fixed problem faced in https://github.com/flutter/flutter/pull/128839) - Separate the M2 overlay test.
-
- 28 Jun, 2023 1 commit
-
-
Justin McCandless authored
Fixes InputDecoration (TextField) layout when 1. RTL 2. prefixIcon and 3. left/right contentPadding is asymmetric.
-