1. 08 Mar, 2018 1 commit
  2. 10 Jan, 2018 1 commit
    • Ian Hickson's avatar
      Make DecoratedBox repaint after being reparented (#13927) · 316d8e1c
      Ian Hickson authored
      Fixes https://github.com/flutter/flutter/issues/12553
      
      The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached.
      
      This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here.
      
      (This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
      316d8e1c
  3. 21 Dec, 2017 1 commit
  4. 07 Dec, 2017 1 commit
    • Ian Hickson's avatar
      Move image logic from services/ to painting/. (#13409) · 44e228eb
      Ian Hickson authored
      This allows the scheduler library to depend on the services library
      and the painting library to depend on the scheduler library without
      the services library having to depend on the scheduler library.
      
      While I was at it I also cleaned up some of the binding logic: the
      licenses logic can now be overridden (and the test library does so),
      and the image cache can now be overridden as well.
      44e228eb
  5. 20 Oct, 2017 2 commits
  6. 18 Oct, 2017 2 commits
  7. 17 Oct, 2017 1 commit
  8. 05 Oct, 2017 1 commit
  9. 03 Oct, 2017 1 commit
    • Ian Hickson's avatar
      Move Border into its own file (#12364) · ce930db3
      Ian Hickson authored
      I'm about to add the BoxBorder and BorderDirectional classes to
      this new file, but figured it would make review easier if the move
      of the existing class happened first.
      ce930db3
  10. 02 Oct, 2017 1 commit
  11. 24 Sep, 2017 1 commit
  12. 23 Sep, 2017 1 commit
  13. 22 Sep, 2017 1 commit
  14. 21 Sep, 2017 1 commit
  15. 20 Sep, 2017 1 commit
  16. 15 Sep, 2017 1 commit
    • Ian Hickson's avatar
      Split TableBorder from Border (#12104) · 9d59fb0c
      Ian Hickson authored
      This will enable both to be RTL'ed.
      
      Also, factor out common border painting code into paintBorder.
      Also, make Border paint uniform non-rounded borders using drawRect.
      Also, add some documentation about an issue that wasted an hour of my life.
      Also, factor out all the border painting code into TableBorder.paint.
      9d59fb0c
  17. 12 Sep, 2017 1 commit
  18. 01 Sep, 2017 1 commit
  19. 09 Aug, 2017 1 commit
  20. 03 Aug, 2017 1 commit
  21. 27 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Increase the touch slop. (#11419) · 87445e59
      Ian Hickson authored
      It was 8.0. It's now arbitrarily 18.0.
      
      Changing this required adjusting some tests. Adjusting the tests
      required debugging the tests. Debugging the tests required some tools
      to help debugging gesture recognizers and gesture arenas, so I added
      some. It also required updating some toString() methods which resulted
      in some changes to the tree diagnostics logic.
      
      Also I cleaned up some docs while I was at it.
      87445e59
  22. 25 Jul, 2017 1 commit
  23. 12 Jun, 2017 1 commit
  24. 06 Jun, 2017 1 commit
  25. 05 Jun, 2017 2 commits
  26. 31 May, 2017 1 commit
  27. 27 May, 2017 1 commit
    • Ian Hickson's avatar
      Much work on the documentation (#10331) · f50caddf
      Ian Hickson authored
      Minor fixes throughout, e.g. removing trailing commas from the end of sample code expressions, changing headings to "sample code" more consistently, removing stale todos, fix typos in a private method name, minor grammar fixes, added some clarifications to CircularProgressIndicator, LinearProgressIndicator, CrossAxisAlignment, added some cross-references to various members, made it slightly clearer that layout algorithms are implementation details.
      
      Clarified "elevation" throughout.
      
      Added docs to InkResponse and InkWell.
      
      Added sample code for: SliverAppBar, Card, ListTile, EdgeInsets, Row, Column, CustomScrollView, ListView, SliverFixedExtentList, and SliverGrid.
      
      Fixes #10317.
      Fixes #10316.
      Fixes #10267. (sort of, see comment therein)
      Fixes #9331. (sort of, see comment therein)
      Fixes #9407. (sort of, see comment therein)
      f50caddf
  28. 24 May, 2017 2 commits
  29. 10 May, 2017 4 commits
  30. 09 May, 2017 1 commit
  31. 28 Apr, 2017 1 commit
  32. 27 Apr, 2017 2 commits