- 25 May, 2023 6 commits
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/117627 ### Behavior changes: 1. If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for `waitDuration`. 2. A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones. 3. The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/37ebad2d5c27...2be736c390ee 2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UYN_Tk7M6_5d2aGIj... to nLnQzTesaABpgroOl... (flutter/engine#42307) 2023-05-25 bdero@google.com [Impeller] Simplify CreateContentsForGeometry overloads (flutter/engine#42306) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from UYN_Tk7M6_5d to nLnQzTesaABp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/62a83490ee60...37ebad2d5c27 2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 150d534341a4 to 7ec172b433f1 (1 revision) (flutter/engine#42305) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1bed04a4375a...62a83490ee60 2023-05-25 54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/engine#42299) 2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bea16a7dcbd to 96e29af6e0c6 (1 revision) (flutter/engine#42303) 2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 76bae143aded to 150d534341a4 (2 revisions) (flutter/engine#42301) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6a361090a367...1bed04a4375a 2023-05-24 30870216+gaaclarke@users.noreply.github.com [Impeller] Turn on vulkan tests for mac CI. (flutter/engine#42225) 2023-05-24 jonahwilliams@google.com [Impeller] fix UV and color blending. (flutter/engine#42293) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9ba461efd3fe...6a361090a367 2023-05-24 godofredoc@google.com Use engine_v2 builds on recipe testing. (flutter/engine#42298) 2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Golden test for text with a shader and a transform (flutter/engine#42291) 2023-05-24 skia-flutter-autoroll@skia.org Roll Skia from 593ece8f74c7 to 76bae143aded (13 revisions) (flutter/engine#42295) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 24 May, 2023 21 commits
-
-
Casey Hillers authored
Reverts flutter/flutter#127524 Bad YAML format is blocking presubmit PRs.
-
Mouad Debbar authored
Now that `platformViewRegistry` is [exposed](https://github.com/flutter/engine/pull/41877) through `dart:ui_web`, we can do some cleanup here. Part of https://github.com/flutter/flutter/issues/126831
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c641f6307f08...9ba461efd3fe 2023-05-24 mdebbar@google.com [web] Remove comment about dart:html migration (flutter/engine#42290) 2023-05-24 mdebbar@google.com [web] Hide JS types from dart:ui_web (flutter/engine#42252) 2023-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qoLy9E5PjnAlICjUb... to RSSC61ubl9JXmn4JO... (flutter/engine#42287) 2023-05-24 marcianx@gmail.com [web] Update a11y announcements to append divs instead of setting content. (flutter/engine#42258) 2023-05-24 jonahwilliams@google.com [Impeller] fix Xcode frame capture. (flutter/engine#42289) 2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Create an autorelease pool for Impeller tests running on macOS. (flutter/engine#42265) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qoLy9E5PjnAl to RSSC61ubl9JX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
lsaudon authored
`TextFormField` does not have all the parameters of `TextField`. Added: ```dart UndoHistoryController? undoController, AppPrivateCommandCallback? onAppPrivateCommand, bool? cursorOpacityAnimates, ui.BoxHeightStyle selectionHeightStyle = ui.BoxHeightStyle.tight, ui.BoxWidthStyle selectionWidthStyle = ui.BoxWidthStyle.tight, DragStartBehavior dragStartBehavior = DragStartBehavior.start, ContentInsertionConfiguration? contentInsertionConfiguration, Clip clipBehavior = Clip.hardEdge, bool scribbleEnabled = true, bool canRequestFocus = true, ```
-
-
LongCatIsLooong authored
Improves `TextPainter.layout` caching when only the input constraints change: - removes the double layout calls in `TextPainter._layoutParagraph`: now double layout is only needed when `TextAlign` is not left, and the input `maxWidth == double.infinity`. - skip calls to `ui.Paragraph.layout` when it's guaranteed that there's no soft line breaks before/after the layout call. This doesn't introduce new APIs but may slightly shift text rendered on screen. This reduces the number of `layout` calls but since shaping results are already cached so it only skips the relatively cheap line-breaking process when possible. 528 scuba failures but all of them seem reasonable.
-
dependabot[bot] authored
Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (#127533) Bumps [actions/labeler](https://github.com/actions/labeler) from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/labeler/commit/0776a679364a9a16110aac8d0f40f5e11009e327"><code>0776a67</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/571">#571</a> from akv-platform/remove-implicit-dependencies</li> <li><a href="https://github.com/actions/labeler/commit/08382d15cbe3356793d4187dcd9792a2d10cb03c"><code>08382d1</code></a> Move eslint-plugin-node to dev dependencies</li> <li><a href="https://github.com/actions/labeler/commit/d1dd326cccf2f7c059720fe6ad43b76abd786264"><code>d1dd326</code></a> Install eslint-plugin-node</li> <li><a href="https://github.com/actions/labeler/commit/91076827ed0d4506993bae4f3cf7aacc578c9a3f"><code>9107682</code></a> Update configuration files</li> <li>See full diff in <a href="https://github.com/actions/labeler/compare/2713f7303c96cb1e69627957ec16eea0fd7f94a4...0776a679364a9a16110aac8d0f40f5e11009e327">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
Bruno Leroux authored
## Description This PR fixes a precision error in ~~`ClampingScrollPhysics`~~ `ScrollPosition` that leads to `StretchingOverscrollIndicator` stretching its content unexpectedly in some devices (see https://github.com/flutter/flutter/issues/126561 where this is visible in `TabBarView` and the test added in this PR where it reproduces with a `PageView`). ~~This PR also contains a change to `nested_scroll_view.dart` because the first change (the one in `ClampingScrollPhysics`) breaks the precision error test added by https://github.com/flutter/flutter/pull/87801.~~ ## Related Issue Fixes https://github.com/flutter/flutter/issues/126561 ## Tests Adds 1 test.
-
Devin authored
fixes https://github.com/flutter/flutter/issues/123315 -------- This PR makes changes to the _actionHandler function used on the Slider.Dart Widget for Key Events. It ensures onChangeStart is called at the beginning of a Key Event and onChangeEnd at the end of one. This PR includes a test for the changes made. I ran all existing tests after my changes were made and they passed.
-
Brandon DeRosier authored
Rolls engine to head with [fixes](https://github.com/flutter/flutter/pull/127505) corresponding to the [latest Dart roll](https://github.com/flutter/engine/pull/42286).
-
Casey Hillers authored
Based on recent feedback. Give more information in the CP template.
-
Sun Jiao authored
-
Victoria Ashworth authored
Reland https://github.com/flutter/flutter/pull/127222 that was reverted in https://github.com/flutter/flutter/pull/127405. Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.
-
Victoria Ashworth authored
This reverts commit 2b3cd7f4. Fixes https://github.com/flutter/flutter/issues/127281.
-
Chris Yang authored
Changes the test owners to @vashworth while I'm OOO.
-
Chris Bracken authored
The Linux platform channels sample makes a call to the libupower function `up_client_get_devices`, which was deprecated in libupower 0.99.8 in favour of `up_client_get_devices2`. The prod bots have been migrated to focal, which ships libupower 0.99.11 in which the old function is deprecated and the new one is available. The try bots have not yet been migrated and remain on bionic, which ships libupower 0.99.7 in which the old function is not deprecated and the new one is not available. This marks the line in question to ignore deprecation warnings. Once all bots have migrated to focal, we'll migrate to the new function. See tracking issue below. See: https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices Issue: https://github.com/flutter/flutter/issues/127506 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/d449a17f8706...fba97fa4cc86 2023-05-24 godofredoc@google.com Update infra reviewers and add label. (flutter/packages#4068) 2023-05-23 JeroenWeener@users.noreply.github.com [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065) 2023-05-23 stuartmorgan@google.com [in_app_purchase] Fix Java lints (flutter/packages#4032) 2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 34371894 to f86c529b (22 revisions) (flutter/packages#4066) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/eebcf36cd38f...0c41b02cd5a6 2023-05-24 bdero@google.com [Impeller] Set the coverage hint on everything (flutter/engine#42264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/aba9dc4640c2...eebcf36cd38f 2023-05-24 bdero@google.com [Impeller] Limit rrect blur kernel to 1000x1000 (flutter/engine#42269) 2023-05-24 godofredoc@google.com Add builders for second level cache of builders. (flutter/engine#42271) 2023-05-24 jonahwilliams@google.com [Impeller] remove framebuffer blending from atlas, fix transform scale (flutter/engine#42254) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/76afb431a740...aba9dc4640c2 2023-05-23 30870216+gaaclarke@users.noreply.github.com Turned back on debug unit tests (flutter/engine#42261) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fc6df9512aa2...76afb431a740 2023-05-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 90b4df96e9dc to 7546e99f8a50 (3 revisions) (flutter/engine#42260) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 28946eda0f6d to 69f7860093b4 (6 revisions) (flutter/engine#42262) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 292879d286e9 to 28946eda0f6d (5 revisions) (flutter/engine#42257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 23 May, 2023 13 commits
-
-
dependabot[bot] authored
Bump actions/labeler from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4 (#127438) Bumps [actions/labeler](https://github.com/actions/labeler) from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/labeler/commit/2713f7303c96cb1e69627957ec16eea0fd7f94a4"><code>2713f73</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.6 to 5.59.7 (<a href="https://redirect.github.com/actions/labeler/issues/572">#572</a>)</li> <li><a href="https://github.com/actions/labeler/commit/a4eda65d3dd04bf2609bd957219885eac0efebdf"><code>a4eda65</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.6 to 5.59.7 (<a href="https://redirect.github.com/actions/labeler/issues/573">#573</a>)</li> <li><a href="https://github.com/actions/labeler/commit/5c4deb8a24f8a41657d61c18894d8e700cdee67a"><code>5c4deb8</code></a> Revert "fix: correct reading of sync-labels input. (<a href="https://redirect.github.com/actions/labeler/issues/480">#480</a>)" (<a href="https://redirect.github.com/actions/labeler/issues/564">#564</a>)</li> <li><a href="https://github.com/actions/labeler/commit/61662e8f41cc6781d48b2fd405c5cd6420128af6"><code>61662e8</code></a> Bump eslint from 8.40.0 to 8.41.0 (<a href="https://redirect.github.com/actions/labeler/issues/569">#569</a>)</li> <li>See full diff in <a href="https://github.com/actions/labeler/compare/6b107e7a7ee5e054e0bcce60de5181d21e2f00fb...2713f7303c96cb1e69627957ec16eea0fd7f94a4">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3535e0d301dd...fc6df9512aa2 2023-05-23 jonahwilliams@google.com [Impeller] Encode render passes concurrently on iOS. (flutter/engine#42028) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
chunhtai authored
I think the flake is due to setclipboard or semantics update race condition. I migrated the test to use integration test package which relies less on timing fixes https://github.com/flutter/flutter/issues/124636
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/23b04314d5d2...3535e0d301dd 2023-05-23 103135467+sealesj@users.noreply.github.com Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256) 2023-05-23 103135467+sealesj@users.noreply.github.com Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247) 2023-05-23 jonahwilliams@google.com Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ccf50f344d5d...23b04314d5d2 2023-05-23 aam@google.com Roll buildroot to 5cab8e095066d8f3de063943af26b7336aa52662 (flutter/engine#42251) 2023-05-23 103135467+sealesj@users.noreply.github.com Vulnerability scanning print failed command in case of error (flutter/engine#42190) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936) ## How we determine the channel name Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time. I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird. This PR changes the logic to uses the current branch as the channel name. ## How we display channels The main reason this PR exists is to add channel descriptions to the `flutter channel` list: ``` ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel Flutter channels: master (tip of tree, for contributors) main (tip of tree, follows master channel) beta (updated monthly, recommended for experienced users) stable (updated quarterly, for new users and for production app releases) * foo_bar Currently not on an official channel. ianh@burmese:~/dev/flutter/packages/flutter_tools$ ``` ## Other changes I made a few other changes while I was at it: * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on. * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`. * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context. * Simplified some of the code. * Made some of the tests more strict (checking all output rather than just some aspects of it). * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly. * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy). * Tweaked the help text for the `downgrade` command to be clearer. * Removed some misleading text in some error messages. * Made the `.metadata` generator consistent with the template file. * Removed some obsolete code to do with the `dev` branch. ## Reviewer notes I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
-
Tomasz Gucio authored
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/126705 Follow up fix after https://github.com/flutter/flutter/pull/126875 did NOT work.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a6e37bde65fd...ccf50f344d5d 2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 2023-05-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 2023-05-23 zanderso@users.noreply.github.com Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 2023-05-23 aam@google.com Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 2023-05-23 mdebbar@google.com [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
NikolajHarderNota authored
Adds barrierLabel as optional param in showModalBottomSheet Fixes #83180
-
Justin McCandless authored
This PR changes the character boundary behavior of obscured fields to be based on code points instead of code units. So it used to be possible to traverse and delete obscured text inside of code points (and breaking a code point like that would cause a crash): ![output2](https://github.com/flutter/flutter/assets/389558/674c89a4-c47d-4cdc-a402-4cadb5d2f73b) But now moving the cursor and deleting is based on code points: ![output1](https://github.com/flutter/flutter/assets/389558/e46301f7-b5af-48d2-812a-0ad649f1383b) ### Native behavior Native iOS deletes part of the emoji, native Mac deletes the whole emoji. See https://github.com/flutter/flutter/issues/122381#issuecomment-1482042620. So it's unclear what the desired behavior should actually be. ### Resources Fixes https://github.com/flutter/flutter/issues/122381 I thought this might not fix the case where a broken emoji is directly pasted into the field, but it seems to work by trying this: �âð
© âð¦âð¦ CC @LongCatIsLooong -
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/168b0bf3f70d...a6e37bde65fd 2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DzmjiSg6XC0JUfbKP... to aAjEDVse7qfMt0NqE... (flutter/engine#42245) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from DzmjiSg6XC0J to aAjEDVse7qfM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Reverts flutter/flutter#127222
-