Commits · 1b18b1327a590ad295ad53bb758ce0eac006e577 · abdullh.alsoleman / Front-End

17 Sep, 2023 2 commits

Roll Flutter Engine from e07bb975ee85 to 57a4ff3c7ff8 (1 revision) (#134895) · 1b18b132

engine-flutter-autoroll authored Sep 17, 2023

https://github.com/flutter/engine/compare/e07bb975ee85...57a4ff3c7ff8

2023-09-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IJXVQbD3CpkL2_ihZ... to AjL85L6CVMEuMWPVZ... (flutter/engine#45937)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from IJXVQbD3CpkL to AjL85L6CVMEu

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b18b132

Roll Flutter Engine from 444689fd4060 to e07bb975ee85 (1 revision) (#134889) · 13a03cef

engine-flutter-autoroll authored Sep 17, 2023

https://github.com/flutter/engine/compare/444689fd4060...e07bb975ee85

2023-09-17 skia-flutter-autoroll@skia.org Roll Skia from 2eaaa5bf7dae to a160e7fb80db (1 revision) (flutter/engine#45933)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13a03cef

16 Sep, 2023 13 commits

Roll Flutter Engine from 8c2203bb6c3b to 444689fd4060 (1 revision) (#134886) · 1bad8c4f

engine-flutter-autoroll authored Sep 16, 2023

https://github.com/flutter/engine/compare/8c2203bb6c3b...444689fd4060

2023-09-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3Tb9CQTTiBv1lb673... to IJXVQbD3CpkL2_ihZ... (flutter/engine#45928)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3Tb9CQTTiBv1 to IJXVQbD3CpkL

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1bad8c4f

Fix memory leak in CupertinoActionSheet (#134885) · 854bbb90
Kostia Sokolovskyi authored Sep 16, 2023

854bbb90
Add disposal mechanism for created Layers to TestRecordingPaintingContext. (#134768) · 60fae58a
Polina Cherkasova authored Sep 16, 2023
```
Contributes to https://github.com/flutter/flutter/issues/134575
```
60fae58a

Manual roll Flutter Engine from 490925676b91 to 8c2203bb6c3b (6 revisions) (#134882) · c66ca4f1

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/490925676b91...8c2203bb6c3b

2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from b33e0e6706b0 to 2eaaa5bf7dae (1 revision) (flutter/engine#45926)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from a1f8fb54299a to b33e0e6706b0 (1 revision) (flutter/engine#45923)
2023-09-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from -_edKGA5GTkDFxVgl... to 3Tb9CQTTiBv1lb673... (flutter/engine#45922)
2023-09-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 029d6d73c860 to a0ca39c63c16 (1 revision) (flutter/engine#45921)
2023-09-16 matanlurey@users.noreply.github.com [Impeller] `vk::CommandPool` resets via `ResourceManager` (flutter/engine#45654)
2023-09-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wWzXsy6kx1sp8Km34... to ZhY53WD7bFJSA3xoO... (flutter/engine#45919)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wWzXsy6kx1sp to ZhY53WD7bFJS
fuchsia/sdk/core/mac-amd64 from -_edKGA5GTkD to 3Tb9CQTTiBv1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c66ca4f1

Manual roll Flutter Engine from cdcbdcc7ccba to 490925676b91 (5 revisions) (#134879) · d9cffa05

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/cdcbdcc7ccba...490925676b91

2023-09-16 matanlurey@users.noreply.github.com Add a single MacOS+Vulkan+SwiftShader CI test (flutter/engine#45918)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) (flutter/engine#45917)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) (flutter/engine#45915)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from c19cc483c619 to 4851cd29e1dd (1 revision) (flutter/engine#45913)
2023-09-16 skia-flutter-autoroll@skia.org Roll Dart SDK from e9452310189b to 029d6d73c860 (1 revision) (flutter/engine#45912)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9cffa05

Manual roll Flutter Engine from 30b7e9ded7a0 to cdcbdcc7ccba (5 revisions) (#134877) · 042c0757

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/30b7e9ded7a0...cdcbdcc7ccba

2023-09-16 jonahwilliams@google.com Revert "[Impeller] construct text
frames on UI thread." (flutter/engine#45910)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 7c179932cc06 to
c19cc483c619 (1 revision) (flutter/engine#45911)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 917fd16e6f26 to
7c179932cc06 (1 revision) (flutter/engine#45907)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 0057898979a1 to
917fd16e6f26 (1 revision) (flutter/engine#45906)
2023-09-15 matanlurey@users.noreply.github.com Do not convert an open
path to a closed rect. (flutter/engine#45903)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

042c0757

Manual roll Flutter Engine from 326faf1762d6 to 30b7e9ded7a0 (5 revisions) (#134876) · e5e36ad3

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/326faf1762d6...30b7e9ded7a0

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 7f88bda24f7f to 0057898979a1 (1 revision) (flutter/engine#45904)
2023-09-15 matanlurey@users.noreply.github.com [Impeller] Test `FenceWaiterVK` and fix termination bugs (flutter/engine#45870)
2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) (flutter/engine#45902)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) (flutter/engine#45901)
2023-09-15 jonahwilliams@google.com [Impeller] dont cache failed render target allocations. (flutter/engine#45895)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e5e36ad3

Manual roll Flutter Engine from 51e643de62aa to 326faf1762d6 (6 revisions) (#134875) · e1428bff

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/51e643de62aa...326faf1762d6

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from c79441fc8016 to 4f26f22daa4b (1 revision) (flutter/engine#45893)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 58c509b1a24a to c79441fc8016 (1 revision) (flutter/engine#45892)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from fffef1047640 to 58c509b1a24a (2 revisions) (flutter/engine#45888)
2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 65117290c3b0 to a5ee0055cf20 (1 revision) (flutter/engine#45887)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from --OUw__L3ekVTG-5c... to -_edKGA5GTkDFxVgl... (flutter/engine#45886)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from de56f293eb41 to fffef1047640 (2 revisions) (flutter/engine#45885)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from --OUw__L3ekV to -_edKGA5GTkD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1428bff

Manual roll Flutter Engine from d623ecf43c66 to 51e643de62aa (5 revisions) (#134865) · b8dc118b

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/d623ecf43c66...51e643de62aa

2023-09-15 zanderso@users.noreply.github.com Adds a --quiet flag to run_tests.py (flutter/engine#45880)
2023-09-15 reidbaker@google.com Update AGP and Kotlin for scenario app (flutter/engine#45549)
2023-09-15 kjlubick@users.noreply.github.com Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881)
2023-09-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Introduce mock vulkan context builder (flutter/engine#45834)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b8dc118b

Manual roll Flutter Engine from c0eaf2633686 to d623ecf43c66 (5 revisions) (#134861) · 0032d9bb

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/c0eaf2633686...d623ecf43c66

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 3492fc567816 to
de56f293eb41 (1 revision) (flutter/engine#45878)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 6e286034109e to
3492fc567816 (1 revision) (flutter/engine#45876)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 824b1973703d to
6e286034109e (1 revision) (flutter/engine#45875)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 4f7aafd0c853 to
824b1973703d (1 revision) (flutter/engine#45871)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from c0cabb0f93c9 to
4f7aafd0c853 (1 revision) (flutter/engine#45868)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0032d9bb

Manual roll Flutter Engine from 5aa9db365ed6 to c0eaf2633686 (5 revisions) (#134860) · ae743699

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/5aa9db365ed6...c0eaf2633686

2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
c0a505f9d1dd to 65117290c3b0 (1 revision) (flutter/engine#45867)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
FF4r9-tqhioBbRG9f... to --OUw__L3ekVTG-5c... (flutter/engine#45866)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
MzLcTzBiWJ7o3Q2_Z... to ES0r-mYplPOBYHvUQ... (flutter/engine#45865)
2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
7e4d9f4d8e52 to c0a505f9d1dd (1 revision) (flutter/engine#45864)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 7aa8bfaa63fc to
c0cabb0f93c9 (1 revision) (flutter/engine#45863)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from MzLcTzBiWJ7o to ES0r-mYplPOB
  fuchsia/sdk/core/mac-amd64 from FF4r9-tqhioB to --OUw__L3ekV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ae743699

Manual roll Flutter Engine from 67dd12f8dfca to 5aa9db365ed6 (5 revisions) (#134856) · 30cd285c

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/67dd12f8dfca...5aa9db365ed6

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 37ea783440ea to
7aa8bfaa63fc (1 revision) (flutter/engine#45861)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 8c9e378c4902 to
37ea783440ea (1 revision) (flutter/engine#45859)
2023-09-14 findyou795@gmail.com Reduce unnecessary
Dart_TimelineGetMicros call (flutter/engine#45637)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 9b7c116ed6c2 to
8c9e378c4902 (3 revisions) (flutter/engine#45858)
2023-09-14 15619084+vashworth@users.noreply.github.com Set tests to run
on macOS 12 (flutter/engine#45855)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

30cd285c

Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (#134791) · 18ad09ef

engine-flutter-autoroll authored Sep 16, 2023

https://github.com/flutter/engine/compare/45bc4307cda3...67dd12f8dfca

2023-09-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
2023-09-14 kustermann@google.com Remove @pragma('vm:entry-point')
annotations on members that aren't accessed from C++
(flutter/engine#45697)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 6bc9f5886ddf to
9b7c116ed6c2 (1 revision) (flutter/engine#45853)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch
linux_android_debug_engine from goma to reclient (flutter/engine#45345)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch goma to
reclient fro standalone targets (flutter/engine#45804)
2023-09-14 109111084+yaakovschectman@users.noreply.github.com Handle
external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18ad09ef

15 Sep, 2023 11 commits

Makes scheme and target optional parameter when getting universal lin… (#134571) · 367203b3

chunhtai authored Sep 15, 2023

â¦k settings

the show build settings xcode command can only accept one of the target or scheme flag. Therefore I make them optional.

367203b3

Dispose layers in test. (#134802) · f629dc87
Polina Cherkasova authored Sep 15, 2023

f629dc87

[Windows_android channels_integration_test] Column -> ListView (#134836) · ec471480

LongCatIsLooong authored Sep 15, 2023

This should fix https://github.com/flutter/flutter/issues/134636. 

The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow.

```
     RenderParagraph#66251 relayoutBoundary=up3
â creator: RichText â Text-[<'status'>] â Column â
â   FutureBuilder<TestStepResult> â Padding â
â   KeyedSubtree-[GlobalKey#0f29e] â _BodyBuilder â MediaQuery â
â   LayoutId-[<_ScaffoldSlot.body>] â CustomMultiChildLayout â
â   _ActionsScope â Actions â â¯
|  parentData: offset=Offset(0.0, 600.0); flex=null; fit=null
```

![flutter_01](https://github.com/flutter/flutter/assets/31859944/5e700d21-3c5e-4990-bfb5-153f44f1c517)

ec471480

moved hello_world_impeller to a 7pro (#134830) · 43260cce

gaaclarke authored Sep 15, 2023

arm64 is necessary for this test

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

43260cce

Speed up native assets target (#134523) · 8ebb8d4f

Daco Harkes authored Sep 15, 2023

Speeds up the native assets target in the backend by

1. changing other targets `gen_dart_plugin_registrant` and
`release_unpack_ios` to do async I/O,
2. not reparsing the package config, and
3. not calling `dart pub deps --json` for 0 or 1 packages (fixed
package:native_assets_builder).

* https://github.com/flutter/flutter/issues/134427

```
           [   +2 ms] native_assets: Starting due to {}
           [   +2 ms] Skipping target: gen_localizations
           [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
           [  +33 ms] gen_dart_plugin_registrant: Complete
           [ +107 ms] release_unpack_ios: Complete
           [  +60 ms] Writing native_assets.yaml.
           [   +7 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/be2692bbfbc0b9a27fcd2422d52354c6/native_assets.yaml done.
           [        ] native_assets: Complete
```

->

```
           [   +4 ms] native_assets: Starting due to {}
           [        ] Skipping target: gen_localizations
           [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
           [  +31 ms] Writing native_assets.yaml.
           [   +8 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/f9451a65a465bfab70d004e21d6cc1d6/native_assets.yaml done.
           [   +1 ms] native_assets: Complete
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ebb8d4f

Date picker dialog state should dispose members. (#134804) · 72b69f94
Polina Cherkasova authored Sep 15, 2023

72b69f94

Roll Packages from 275b76ccffa5 to bc8c2f20910b (7 revisions) (#134823) · 0b9551e6

engine-flutter-autoroll authored Sep 15, 2023

https://github.com/flutter/packages/compare/275b76ccffa5...bc8c2f20910b

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 stuartmorgan@google.com [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2524052335ec to 367f9ea16bfa (3 revisions) (flutter/packages#4929)
2023-09-14 stuartmorgan@google.com [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter from 61b890bf to 58ba6c29 (16 revisions) (flutter/packages#4928)
2023-09-14 43054281+camsim99@users.noreply.github.com Manual Roll of Flutter from 4e7a07af to 61b890bf (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b9551e6

Fix navigation rail hover misplaced when direction is RTL and extended is true (#134815) · 2a7ad01e

Bruno Leroux authored Sep 15, 2023

## Description

This PR fixes `NavigationRail` hover position when text direction is set to RTL and `NavigationRail.extended` is true.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134361.

## Tests

Adds 1 test.

2a7ad01e

Applied the logo to the Discord badge. (#134339) · 0b540a87

K9i - Kota Hayashi authored Sep 15, 2023

Before
<img width="414" alt="image" src="https://github.com/flutter/flutter/assets/90010509/af386804-a8a2-43b9-a7fd-6e79df400734">

After

<img width="412" alt="image" src="https://github.com/flutter/flutter/assets/90010509/5e289946-7690-414a-8ff0-9abeb861842b">

0b540a87

Fix memory leak in ListWheelScrollView (#134732) · 09acfe63
Kostia Sokolovskyi authored Sep 15, 2023

09acfe63
Move two tests on Pixel 7 from staging to prod (#134784) · 1e4a1be6
Zachary Anderson authored Sep 15, 2023
```
Related https://github.com/flutter/flutter/issues/134698
```
1e4a1be6

14 Sep, 2023 14 commits

Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (#134789) · 0f4ca515

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/683bca53d4d7...45bc4307cda3

2023-09-14 goderbauer@google.com Enable private field promotion (flutter/engine#45722)
2023-09-14 bdero@google.com [Impeller] Add Entity::RenderingMode enum. (flutter/engine#45845)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0f4ca515

[web] provide serviceWorkerVersion to the getNewServiceWorker function (#131240) · 783f2f48

Pavel Mazhnik authored Sep 14, 2023

Fixes https://github.com/flutter/flutter/issues/130212

Fix `Unresolved variable or type 'serviceWorkerVersion'` in the `_getNewServiceWorker` function.

Supersedes https://github.com/flutter/flutter/pull/130206

783f2f48

Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (#134778) · 98bee677

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/3a3a2807c3b6...683bca53d4d7

2023-09-14 bdero@google.com [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847)
2023-09-14 bdero@google.com [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98bee677

Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (#134769) · ab715b20

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/035932d64017...3a3a2807c3b6

2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 9bdf01416042 to 0f003d5748bc (4 revisions) (flutter/engine#45841)
2023-09-14 jacksongardner@google.com Declare the js context as nullable in skwasm surface callback (flutter/engine#45810)
2023-09-14 matanlurey@users.noreply.github.com [Impeller] Release a texture during Playground teardown (flutter/engine#45832)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 87025d1e162c to 9bdf01416042 (1 revision) (flutter/engine#45835)
2023-09-14 matanlurey@users.noreply.github.com Make `fml::ScopedCleanupClosure` `std::move`-able and add unit tests. (flutter/engine#45772)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab715b20

Allows page removal that contains Localhistoryentry (#134757) · 0e521942

chunhtai authored Sep 14, 2023

fixes https://github.com/flutter/flutter/issues/97836
fixes https://github.com/flutter/flutter/issues/134752
fixes https://github.com/flutter/flutter/issues/118645

0e521942

Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (#134763) · 6ec1ff23

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/e0b5b6c4eb76...035932d64017

2023-09-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 1ee7ef8bbc65 to d25e8d682c8f (22 revisions) (flutter/engine#45836)
2023-09-14 godofredoc@google.com Update webdriver imports. (flutter/engine#45816)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ec1ff23

Cover more test/widgets tests with leak tracking #3 (#134576) · ff10c52a
Kostia Sokolovskyi authored Sep 14, 2023

ff10c52a

Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (#134755) · ba233b8a

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/2cd34d23c1a2...e0b5b6c4eb76

2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 54253f58533d to 87025d1e162c (1 revision) (flutter/engine#45833)
2023-09-14 bdero@google.com [Impeller] Incorporate filters in subpass coverage. (flutter/engine#45778)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba233b8a

Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (#134693) · eb4b97d6

Victoria Ashworth authored Sep 14, 2023

Test added in https://github.com/flutter/flutter/pull/134493 requires an
older version of Xcode because default version of Xcode is not
compatible with macOS version in CI.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

eb4b97d6

Cover some Services tests with leak tracing (#134381) · 54673633
derdilla authored Sep 14, 2023

54673633

Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (#134749) · d2ff2417

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/4160ebacdae2...2cd34d23c1a2

2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 91d5a781ebaf to 54253f58533d (2 revisions) (flutter/engine#45829)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 08fb9768d1b8 to 91d5a781ebaf (3 revisions) (flutter/engine#45828)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from f4jtyOMeNSKGqqI4y... to FF4r9-tqhioBbRG9f... (flutter/engine#45827)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 45ba26fae9cd to 08fb9768d1b8 (2 revisions) (flutter/engine#45825)
2023-09-14 godofredoc@google.com Fix script (flutter/engine#45598)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5aKvHj_QcSHJkbWjr... to MzLcTzBiWJ7o3Q2_Z... (flutter/engine#45823)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 4bb29f80ed43 to 45ba26fae9cd (1 revision) (flutter/engine#45821)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump html from 0.15.0 to 0.15.4 in /lib/web_ui (flutter/engine#45819)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 5ff47ea11c13 to 4bb29f80ed43 (1 revision) (flutter/engine#45818)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 5f18d2ead8c8 to 5ff47ea11c13 (1 revision) (flutter/engine#45815)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from b2a4969c7782 to 5f18d2ead8c8 (2 revisions) (flutter/engine#45814)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gHhOd3d6V3Zv6CzK2... to f4jtyOMeNSKGqqI4y... (flutter/engine#45813)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from ad51509c8e3f to b2a4969c7782 (3 revisions) (flutter/engine#45812)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ftcEc93bjtc0q2a6s... to 5aKvHj_QcSHJkbWjr... (flutter/engine#45808)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump uuid from 3.0.6 to 4.0.0 in /lib/web_ui (flutter/engine#45794)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 5c7d604c81b0 to ad51509c8e3f (1 revision) (flutter/engine#45802)
2023-09-13 jacksongardner@google.com Compile a platform dill for dart2wasm (flutter/engine#45797)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from a30fbf83f2e9 to 5c7d604c81b0 (2 revisions) (flutter/engine#45800)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ftcEc93bjtc0 to MzLcTzBiWJ7o
fuchsia/sdk/core/mac-amd64 from gHhOd3d6V3Zv to FF4r9-tqhioB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2ff2417

🐛 Setup color tween for `RefreshIndicator` in a better way (#134492) · 5c09ccad
Alex Li authored Sep 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/134489.
```
5c09ccad

Fix NavigationRail hover misplaced when using large icons (#134719) · 9fa09ea4

Bruno Leroux authored Sep 14, 2023

## Description

This PR fixes `NavigationRail` hover position when using enlarged icons whose size is specified using `NavigationRailThemeData.selectedIconTheme` and `NavigationRailThemeData.unselectedIconTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/133799.

## Tests

Adds 1 test, updates 1 test (to replace some magic numbers).

9fa09ea4

Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (#134695) · 63f25b0d

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/cd90cc8469fb...4160ebacdae2

2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from b38989859b81 to a30fbf83f2e9 (3 revisions) (flutter/engine#45796)
2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump quiver from 3.0.0 to 3.2.1 in /lib/web_ui (flutter/engine#45792)
2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump http from 0.13.5 to 1.1.0 in /lib/web_ui (flutter/engine#45791)
2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump archive from 3.1.2 to 3.3.9 in /lib/web_ui (flutter/engine#45795)
2023-09-13 mdebbar@google.com [web] Use DOM to render paragraphs with letter spacing (flutter/engine#45651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

63f25b0d