1. 23 Jul, 2018 1 commit
  2. 16 Jul, 2018 2 commits
  3. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  4. 11 Jun, 2018 2 commits
  5. 30 May, 2018 2 commits
  6. 07 Mar, 2018 1 commit
    • Josh Soref's avatar
      Spelling (#15229) · c5a5945e
      Josh Soref authored
      * spelling: accommodate
      
      * spelling: allotted
      
      * spelling: anonymous
      
      * spelling: artificial
      
      * spelling: associated
      
      * spelling: asset
      
      * spelling: button
      
      * spelling: canvas
      
      * spelling: compatibility
      
      * spelling: coverage
      
      * spelling: condition
      
      * spelling: decoration
      
      * spelling: deferring
      
      * spelling: diameter
      
      * spelling: direction
      
      * spelling: displacement
      
      * spelling: dropdown
      
      * spelling: needing
      
      * spelling: environment
      
      * spelling: exited
      
      * spelling: expansion
      
      * spelling: explore
      
      * spelling: families
      
      * spelling: horizontal
      
      * spelling: increment
      
      * spelling: indices
      
      * spelling: internationalization
      
      * spelling: labrador
      
      * spelling: localizations
      
      * spelling: midflight
      
      * spelling: milliseconds
      
      * spelling: minimum
      
      * spelling: multiple
      
      * spelling: multiplication
      
      * spelling: navigator
      
      * spelling: overridden
      
      * spelling: package
      
      * spelling: performance
      
      * spelling: platform
      
      * spelling: porsche
      
      * spelling: position
      
      * spelling: preceded
      
      * spelling: precede
      
      * spelling: precedence
      
      * spelling: print
      
      * spelling: property
      
      * spelling: readily
      
      * spelling: reproducibility
      
      * spelling: rounded
      
      * spelling: scroll
      
      * spelling: separate
      
      * spelling: separator
      
      * spelling: services
      
      * spelling: specific
      
      * spelling: specify
      
      * spelling: synchronously
      
      * spelling: through
      
      * spelling: timeout
      
      * spelling: triangle
      
      * spelling: trivial
      
      * spelling: unusual
      
      * spelling: then
      
      * spelling: vertically
      
      * spelling: visible
      
      * spelling: visited
      
      * spelling: voice
      c5a5945e
  7. 01 Feb, 2018 1 commit
  8. 17 Oct, 2017 1 commit
  9. 24 Sep, 2017 1 commit
  10. 20 Sep, 2017 1 commit
  11. 31 Aug, 2017 1 commit
  12. 24 Aug, 2017 1 commit
  13. 10 Aug, 2017 1 commit
  14. 04 Aug, 2017 1 commit
  15. 03 Aug, 2017 1 commit
  16. 27 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Increase the touch slop. (#11419) · 87445e59
      Ian Hickson authored
      It was 8.0. It's now arbitrarily 18.0.
      
      Changing this required adjusting some tests. Adjusting the tests
      required debugging the tests. Debugging the tests required some tools
      to help debugging gesture recognizers and gesture arenas, so I added
      some. It also required updating some toString() methods which resulted
      in some changes to the tree diagnostics logic.
      
      Also I cleaned up some docs while I was at it.
      87445e59
  17. 19 May, 2017 1 commit
  18. 15 May, 2017 1 commit
  19. 02 May, 2017 1 commit
    • Ian Hickson's avatar
      Tapping a ScrollView during overscroll got it stuck. (#9721) · f64bfba8
      Ian Hickson authored
      Fixes https://github.com/flutter/flutter/issues/8476
      
      More detailed list of changes in this patch:
      
      * Replaced the didTouch special logic with more generic logic that
        uses Activities instead. Now instead when you tap down the
        Scrollable calls `hold()` which begins a HoldScrollActivity which is
        a hybrid of DragStartDetails and IdleScrollActivity and can be
        canceled. When you let go, it gets canceled and that goes ballistic.
      
      * Make DragGestureRecognizer more aggressive about grabbing pointers,
        otherwise a second pointer in a situation with competing horizontal
        and vertical recognizers always gets taken by the other one.
      
      * Fixed the _GestureSemantics widget to call the "down" callbacks so
        that it follows the same pattern as "real" interactions.
      
      * Added tests for the above.
      
      * Added a hashCode to ScrollActivity.toString (and subclasses).
      
      * Added a toString to ScrollDragController, and include it in
        DragScrollActivity's toString.
      
      * s/coorindator/coordinator/
      
      * Add a comment in DragStartDetails to distinguish it from the
        otherwise identical DragDownDetails, so we're not tempted to merge
        them.
      f64bfba8
  20. 25 Apr, 2017 1 commit
  21. 12 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
  22. 08 Apr, 2017 1 commit
  23. 07 Apr, 2017 1 commit
  24. 15 Mar, 2017 1 commit
  25. 04 Mar, 2017 1 commit
  26. 17 Jan, 2017 2 commits
    • Hans Muller's avatar
      60847a1d
    • Adam Barth's avatar
      Fix several minor bugs and add many tests (#7506) · 2b742289
      Adam Barth authored
      * MultiTapGestureRecognizer previously would assert if there was no
         competition.
       * GestureArenaTeam would always select the first recongizer as the
         winner even if a later recognizer actually accepted the pointer
         sequence.
       * debugPrintStack would fail a type check if maxFrames was non-null.
       * FractionalOffset.lerp would throw a null-pointer exception if its
         second argument was null.
      
      Also, add a number of tests for previously untested lines of code.
      2b742289
  27. 10 Jan, 2017 1 commit
  28. 06 Jan, 2017 1 commit
    • Ian Hickson's avatar
      Changes to the drag gesture detectors and the velocity tracker (#7363) · 11d1d54c
      Ian Hickson authored
      - more dartdocs for the drag typedefs
      
      - more toStrings to aid debugging
      
      - require the position for DragUpdateDetails since we were omitting it
        in some places
      
      - add the primaryVelocity to DragEndDetails so that consumers don't
        have to themselves track the axis in question
      
      - fix the velocity tracker so that it doesn't walk the null data.
        Previously, near time t=0 (which pretty much only matters in tests,
        but it does matter there) we would walk the velocity data and then
        also walk missing data, treating it as Point.zero with t=0.
      
      - simplify some of the velocity tracker; e.g. instead of trying (and
        failing?) to clear the velocity tracker when the pointer stalls,
        just drop the data before a stall during the velocity estimation
        (where we redundantly had another bigger horizon anyway).
      11d1d54c
  29. 09 Dec, 2016 1 commit
  30. 16 Nov, 2016 1 commit
  31. 28 Oct, 2016 1 commit
  32. 15 Oct, 2016 1 commit
    • Adam Barth's avatar
      Ensure delayed multidrag timer is stopped (#6340) · 034d2fcd
      Adam Barth authored
      Previously we were relying on the gesture arena to call us back to
      cancel our timer. However, in the case where we've already been
      accepted, asking the gesture arena to reject us doesn't lead to a
      callback and we fail to stop the timer (and hence trigger an assert).
      
      Fixes #6156
      034d2fcd
  33. 04 Oct, 2016 1 commit
  34. 03 Oct, 2016 1 commit
  35. 30 Sep, 2016 1 commit
  36. 21 Sep, 2016 1 commit
    • James Robinson's avatar
      Isolate imports of generated Dart code from generated path (#5960) · a95c9fdb
      James Robinson authored
      This rewrites imports of various mojom.dart files from the Flutter
      engine repo to instead import normal-looking dart files from the
      (new) flutter_services package. This package handles exporting the
      correct symbols from generated code wherever that may live.
      
      Includes an engine roll to 3551e7a48e2e336777b15c7637af92fd7605b6c5
      which contains the new flutter_services package.
      a95c9fdb