Skip to content

F
Front-End
Switch branch/tag
  1. 18 Jul, 2019 4 commits
  3. 17 Jul, 2019 27 commits
  5. 16 Jul, 2019 9 commits
    • Dan Field's avatar
      Disable flaky tests on Windows (#36317) · 93a3ce7a
      Dan Field authored
      93a3ce7a
    • Todd Volkert's avatar
      Move reporting files to reporting/ (#36017) · aa9a1151
      Todd Volkert authored 
      Slight cleanup of file locations in flutter_tools
to make it easier to see which files are responsible
for data reporting.
      aa9a1151
    • Christopher Fujino's avatar
      Revert "Keep LLDB connection to iOS device alive while running from CLI. (#36194)" (#36293) · 540c7476
      Christopher Fujino authored 
      This reverts commit 5501a1c1.
      540c7476
    • Darren Austin's avatar
      Support for elevation based dark theme overlay color in the Material widget (#35560) · e17f8d36
      Darren Austin authored 
      Added support for a semi-transparent white overlay color for `Material` widgets to indicate their elevation in a dart theme. A new `ThemeData.applyElevationOverlayColor` flag was added to control this behavior, which is off by default for backwards compatibility reasons.
      e17f8d36
    • sjindel-google's avatar
      Keep LLDB connection to iOS device alive while running from CLI. (#36194) · 5501a1c1
      sjindel-google authored 
      ## Description

Instead of detaching from the spawned App process on the device immediately, keep the LLDB client connection open (in autopilot mode) until the App quits or the server connection is lost.

This replicates the behavior of Xcode, which also keeps a debugger attached to the App after launching it.

## Tests

This change will be covered by all running benchmarks (which are launched via "flutter run"/"flutter drive"), and probably be covered by all tests as well.

I also tested the workflow locally -- including cases where the App or Flutter CLI is terminated first.

## Breaking Change

I don't believe this should introduce any breaking changes. The LLDB client automatically exits when the app dies or the device is disconnected, so there shouldn't even be any user-visible changes to the behavior of the tool (besides the output of "-v").
      5501a1c1
    • Zachary Anderson's avatar
      [flutter_tool] Allow analytics without a terminal attached (#36208) · fa65ddf5
      Zachary Anderson authored
      fa65ddf5
    • chunhtai's avatar
      Enable widget load assets in its own package in test (#35991) · 11660159
      chunhtai authored
      11660159
    • Jonah Williams's avatar
      add a kIsWeb constant to foundation (#36135) · a8c4da22
      Jonah Williams authored
      a8c4da22
    • liyuqian's avatar
      Fix flaky peer connection (#36089) · 180aa0c0
      liyuqian authored 
      Fixes https://github.com/flutter/flutter/issues/36091.

Previously, a sendRequest will be sent even if the peer is closed during
a driver test. That will cause a time out without any error information.
Such issue is unreproducible on my Mac Book Pro, but 100% reproducible
on our new Mac mini (2018).

The closing issue is tracked in https://github.com/flutter/flutter/issues/36268

Additional to this fix, we should also patch the jason_rpc_2 so the peer
will throw exception if sendRequest is attempted while the connection is
closed.

**Test**:
tiles_scroll_perf_iphonexs__timeline_summary failed without this patch.
It will pass after this patch.

I'm not sure how to add a unit test for this. Please let me know if you have
some ideas.

This patch will generate the following warning log on the new Mac Mini
```
flutter: Observatory listening on http://127.0.0.1:50192/cZPDF4sW7MM=/  
Installing and launching...                                        10.2s
00:00 +0: scrolling performance test (setUpAll)
[info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:1069/cZPDF4sW7MM=/
[trace] FlutterDriver: Isolate found with number: 3684677742843303
[trace] FlutterDriver: Isolate is paused at start.
[trace] FlutterDriver: Attempting to resume isolate
[trace] FlutterDriver: Waiting for service extension
[info ] FlutterDriver: Connected to Flutter application.
00:00 +0: scrolling performance test complex_layout_scroll_perf
[warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
[warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
00:10 +1: scrolling performance test tiles_scroll_perf
[warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
[warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
00:20 +2: scrolling performance test (tearDownAll)
00:20 +2: All tests passed!
Stopping application instance.
```
      180aa0c0

HIAST - GitLab