1. 13 Feb, 2020 1 commit
    • Greg Spencer's avatar
      Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672) · d57d4935
      Greg Spencer authored
      This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.
      
      The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.
      
      - Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
      d57d4935
  2. 12 Feb, 2020 1 commit
  3. 11 Feb, 2020 2 commits
    • Alexandre Ardhuin's avatar
      f15c887c
    • Greg Spencer's avatar
      Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235) · 8ef5e2f0
      Greg Spencer authored
      This change adds a way to provide explicit focus order for a part of the widget tree.
      
      It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.
      
      It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.
      
      As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.
      
      I was able to do this without breaking the API (AFAICT).
      8ef5e2f0
  4. 08 Feb, 2020 1 commit
  5. 28 Jan, 2020 1 commit
  6. 27 Jan, 2020 1 commit
  7. 23 Jan, 2020 1 commit
  8. 22 Jan, 2020 2 commits
  9. 17 Jan, 2020 1 commit
  10. 16 Jan, 2020 1 commit
  11. 16 Dec, 2019 1 commit
  12. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  13. 28 Oct, 2019 1 commit
  14. 05 Feb, 2018 1 commit
  15. 17 Jan, 2018 1 commit
  16. 23 Apr, 2017 1 commit
  17. 07 Apr, 2017 1 commit
  18. 14 Jan, 2017 1 commit
    • Adam Barth's avatar
      Add SimpleDialogOption (#7494) · ad27fcd3
      Adam Barth authored
      The demo of the SimpleDialog had some useful code that should really be part of
      the framework. This patch extracts it into a SimpleDialogOption widget.
      
      Remove debugCheckHasScaffold because it is unused.
      
      Also, add tests for InkWell, SimpleDialog, and other widgets.
      ad27fcd3
  19. 31 Oct, 2016 1 commit
  20. 17 May, 2016 1 commit
    • Ian Hickson's avatar
      Fix tests (#3977) · f284c1a0
      Ian Hickson authored
      Also, make sure that broken tests actually break the bots.
      
      And add a test to make sure that keeps happening.
      f284c1a0