1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must not be null' comments from various libraries. (#134984) · 8cda3bea
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries.  Each of them only had a few, so I lumped them together.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      8cda3bea
  2. 21 Jan, 2023 1 commit
  3. 12 Sep, 2022 1 commit
  4. 29 Jun, 2022 1 commit
  5. 25 May, 2022 1 commit
  6. 14 Apr, 2022 1 commit
  7. 12 Mar, 2021 1 commit
  8. 14 Dec, 2020 1 commit
  9. 11 Dec, 2020 1 commit
  10. 29 Jul, 2020 1 commit
  11. 11 Jun, 2020 1 commit
  12. 08 Jan, 2020 1 commit
  13. 07 Jan, 2020 1 commit
  14. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  15. 22 Oct, 2019 1 commit
  16. 19 Jun, 2019 1 commit
  17. 04 Apr, 2019 1 commit
  18. 06 Mar, 2019 1 commit
  19. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  20. 27 Feb, 2019 1 commit
    • liyuqian's avatar
      Add LICENSE test to presubmit checks (#28369) · dd5559a5
      liyuqian authored
      ## Description
      
      Also update the existing dart files with missing licenses.
      
      Without the fix, we'll emit the following error message
      ```
      License headers cannot be found at the beginning of the following files.
      
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart
      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
      ```
      
      ## Related Issues
      
      Fixes https://github.com/flutter/flutter/issues/28368
      
      ## Checklist
      
      Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
      
      - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
      - [x] All existing and new tests are passing.
      - [x] I updated/added relevant documentation (doc comments with `///`).
      - [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
      - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [x] I signed the [CLA].
      - [x] I am willing to follow-up on review comments in a timely manner.
      
      ## Breaking Change
      
      Does your PR require Flutter developers to manually update their apps to accommodate your change?
      
      - [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
      - [x] No, this is *not* a breaking change.
      
      <!-- Links -->
      [issue database]: https://github.com/flutter/flutter/issues
      [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
      [Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
      [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
      [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
      [CLA]: https://cla.developers.google.com/
      [Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
      dd5559a5
  21. 29 Jan, 2019 1 commit
  22. 22 Dec, 2018 1 commit
  23. 18 Dec, 2018 1 commit
  24. 19 Nov, 2018 2 commits
  25. 08 Nov, 2018 1 commit
  26. 02 Nov, 2018 3 commits
  27. 01 Nov, 2018 1 commit
  28. 23 Sep, 2018 1 commit
  29. 12 Sep, 2018 1 commit
  30. 07 Sep, 2018 1 commit
  31. 06 Aug, 2018 1 commit