1. 11 Dec, 2020 1 commit
  2. 26 Oct, 2020 1 commit
  3. 22 Oct, 2020 1 commit
  4. 21 Aug, 2020 1 commit
  5. 23 Jul, 2020 1 commit
    • Yazeed Al-Khalaf's avatar
      :black_nib: Spell Check All `.md` Files Related to Flutter :blue_heart: (#61564) · d41b1fbb
      Yazeed Al-Khalaf authored
      * :bug: Fix Spelling Issues in Main README.md
      
      * :bug: Fix spelling issues in dev README.md
      
      * :bug: Fix spelling issues in complex_layout README.md
      
      * :bug: Fix spelling issues in macrobenchmarks README.md
      
      * :bug: Fix spelling issues in platform_views_layout README.md
      
      * :bug: Fix spelling issues in test_Apps/stocks README.md
      
      * :bug: Fix spelling issues in bots README.md
      
      * :black_nib: Spell Check dev/ci README.md
      
      * :black_nib: Spell Check dev/ci/docker_linux README.md
      
      * :black_nib: Spell Check dev/devicelab README.md
      
      * :black_nib: Spell Check dev/docs README.md
      
      * :black_nib: Spell Check dev/snippets README.md
      
      * :black_nib: Spell Check dev/snippets/config/templates README.md
      
      * :black_nib: Spell Check dev/tools/gen_keycodes README.md
      
      * :black_nib: Spell Check dev/tools/vitool README.md
      
      * :black_nib: Spell Check examples/catalog README.md
      
      * :black_nib: Spell Check examples/flutter_view README.md
      
      * :black_nib: Spell Check examples/image_list README.md
      
      * :black_nib: Spell Check examples/layers README.md
      
      * :black_nib: Spell Check examples/platform_channel README.md
      
      * :black_nib: Spell Check examples/platform_channel_swift README.md
      
      * :black_nib: Spell Check examples/platform_view README.md
      
      * :black_nib: Spell Check packages/_flutter_web_build_script README.md
      
      * :black_nib: Spell Check packages/flutter_localizations README.md
      
      * :black_nib: Spell Check packages/flutter_tools README.md
      
      * :black_nib: Spell Check CODE_OF_CONDUCT.md
      
      * :black_nib: Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md
      
      * :black_nib: Spell Check dev/integration_test/android_views README.md
      
      * :black_nib: Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md
      
      * :black_nib: Spell Check dev/integration_tests/flutter_gallery README.md
      
      * :black_nib: Spell Check dev/integration_tests/gradle_deprecated_settings README.md
      
      * :black_nib: Spell Check dev/integration_tests/ios_add2app_life_cycle README.md
      
      * :black_nib: Spell Check dev/integration_tests/ios_host_app README.md
      
      * :black_nib: Spell Check dev/integration_tests/ios_platform_view_tests README.md
      
      * :black_nib: Spell Check dev/automated_tests/flutter_test README.md
      
      * :black_nib: Spell Check .github/PULL_REQUEST_TEMPLATE.md
      
      * :black_nib: Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md
      
      * :black_nib: Spell Check .github/ISSUE_TEMPLATE/BUG.md
      
      * :black_nib: Spell Check .github/ISSUE_TEMPLATE/feature_request.md
      
      * :black_nib: Spell Check .github/ISSUE_TEMPLATE/performance_others.md
      
      * :black_nib: Spell Check .github/ISSUE_TEMPLATE/performance_speed.md
      
      * :black_nib: Spell Check packages/flutter_tools/doc/daemon.md
      
      * :black_nib: Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md
      
      * :black_nib: Minimize line to 80 columns
      
      * :black_nib: Minimize line to 80 columns
      
      * :black_nib: Fix Typo
      
      * :black_nib: Chnaged numbers to 1 for testing purposes
      
      * :black_nib: Changed numbers to 1 for testing purposes
      
      * :x: Remove 'a' which is a typo
      
      * :black_nib: Change a sentence to be better
      
      * :black_nib: Remove 'a' which is a typo
      
      * :black_nib: Fix small issue
      
      * :black_nib: Fix small typo
      
      * :black_nib: Fix some typos
      
      * :x: Remove trailing space
      
      * :x: Remove trailing space
      
      * :bug: Fix small typo
      
      * :black_nib: Fix Typo
      
      * :bug: Fix small bug
      d41b1fbb
  6. 09 Jul, 2020 1 commit
  7. 10 Mar, 2020 1 commit
  8. 15 Nov, 2019 1 commit
  9. 24 Sep, 2019 1 commit
  10. 16 Sep, 2019 2 commits
  11. 09 Jul, 2019 1 commit
  12. 10 Jun, 2019 1 commit
  13. 29 May, 2019 1 commit
    • Todd Volkert's avatar
      Add loading support to Image (#33369) · 68841469
      Todd Volkert authored
      This adds two new builders to the `Image` class:
      
      * `frameBuilder`, which allows callers to control the widget
        created by an [Image].
      * `loadingBuilder`, which allows callers fine-grained control
        over how to display loading progress of an image to the user.
      
      `FadeInImage` can be simplified by migrating to the new API.
      This is done in a follow-on commit.
      
      https://github.com/flutter/flutter/issues/32374
      68841469
  14. 25 May, 2019 1 commit
  15. 24 May, 2019 1 commit
  16. 25 Apr, 2019 1 commit
    • Greg Spencer's avatar
      [Re-Land] Implement focus traversal for desktop platforms. (#31614) · 7775c237
      Greg Spencer authored
      This re-lands the Focus changes in #30040. Correctness changes in routes.dart, and removes the automatic requesting of focus on reparent when there is no current focus, which caused undesirable selections.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      7775c237
  17. 23 Apr, 2019 1 commit
  18. 22 Apr, 2019 1 commit
    • Greg Spencer's avatar
      Implement focus traversal for desktop platforms, shoehorn edition. (#30040) · 4218c0bc
      Greg Spencer authored
      Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.
      
      This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.
      
      It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:
      
      FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.
      
      Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      4218c0bc
  19. 15 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793) · 262f12b4
      Greg Spencer authored
      This converts all remaining "## Sample code" segments into snippets, and fixes
      the snippet generator to handle multiple snippets in the same dartdoc block
      properly.
      
      I also generated, compiled, and ran each of the existing application samples,
      and fixed them up to be more useful and/or just run without errors.
      
      This PR fixes these problems with examples:
      
      1. Switching tabs in a snippet now works if there is more than one snippet in
         a single dartdoc block.
      2. Generation of snippet code now works if there is more than one snippet.
      3. Contrast of text and links in the code sample block has been improved to
         recommended levels.
      4. Added five new snippet templates, including a "freeform" template to make
         it possible to show examples that need to change the app instantiation.
      5. Fixed several examples to run properly, a couple by adding the "Scaffold"
         widget to the template, a couple by just fixing their code.
      6. Fixed visual look of some of the samples when they run by placing many
         samples inside of a Scaffold.
      7. In order to make it easier to run locally, changed the sample analyzer to
         remove the contents of the supplied temp directory before running, since
         having files that hang around is problematic (only a problem when running
         locally with the `--temp` argument).
      8. Added a `SampleCheckerException` class, and handle sample checking
         exceptions more gracefully.
      9. Deprecated the old "## Sample code" designation, and added enforcement for
         the deprecation.
      10. Removed unnecessary `new` from templates (although they never appeared in
         the samples thanks to dartfmt, but still).
      
      Fixes #26398
      Fixes #27411
      262f12b4
  20. 13 Dec, 2018 1 commit
  21. 08 Nov, 2018 1 commit
  22. 05 Nov, 2018 1 commit
    • Greg Spencer's avatar
      Rewrite the analyze-sample-code script to also analyze snippets (#23893) · 202b045b
      Greg Spencer authored
      This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
      
      It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
      
      I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
      
      For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
      202b045b
  23. 23 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Dartdoc snippet extension to inject full featured code snippets in to API docs. (#23281) · 65d3ddd5
      Greg Spencer authored
      This creates a custom dartdoc tool that will generate snippet blocks in our API docs that allow the user to copy easily to the clipboard, and will also embed the snippet code into a template to show it in a larger context with an app.
      
      This PR adds the snippet tool, a template, and a couple of HTML skeleton files, one for snippets that are designed to be in an application setting, and one where it simply puts a nice container around existing snippets, making them easier to copy to the clipboard.
      65d3ddd5