Commits · 15451e49d814abc7f0df9a7e67c979a71a4e998d · abdullh.alsoleman / Front-End

02 Nov, 2023 33 commits

Roll Flutter Engine from 1e2eee05855f to ef4ce9294299 (3 revisions) (#137795) · 15451e49

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/1e2eee05855f...ef4ce9294299

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 306543797674 to 94000281b7d6 (1 revision) (flutter/engine#47614)
2023-11-02 godofredoc@google.com Remove mirroring workflow from engine. (flutter/engine#47603)
2023-11-02 athom@google.com Add a temporary fallback to move run_binary_file_analysis.py (flutter/engine#47598)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15451e49

Protect flutter analyze --suggestions from erroring on missing AGP value. (#137719) · 4d21a026

Reid Baker authored Nov 02, 2023

Fixes #137600
Protect flutter analyze --suggestions from null error when AGP value is missing
Update template with a reference to new agp definition location
Look for AGP version being set in settings.gradle (change to templates happened in https://github.com/flutter/flutter/commit/dbe0ccd8853dabdcb0f94ce2cdef892a1b10e48a#diff-20537fb84ee37894a3f3d9723a06bcf2674290ee25aa83332c2524a1f7546a6d

4d21a026

Provide more information in 'unsupported class file' gradle error (#136756) · 969a8750

Gray Mackall authored Nov 02, 2023

Fixes https://github.com/flutter/flutter/issues/130808. Short context is that the migration guide doesn't help when a user has a newer java version than 17, and this tells them how to fix the error in that situation.

This is an alternative to https://github.com/flutter/flutter/pull/131354, because I think it is a bad idea to introduce branching in how we handle this error with some specialized regexp.

969a8750

Roll Flutter Engine from b11e318b3690 to 1e2eee05855f (4 revisions) (#137789) · 474a8561

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/b11e318b3690...1e2eee05855f

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610)
2023-11-02 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or 13 (flutter/engine#47606)
2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... (flutter/engine#47611)
2023-11-02 dnfield@google.com [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 32ukjtetQl4p to bhSlAQy4VM3P

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

474a8561

Avoid passing a nullable value to potentially non-nullable parameters (#137359) · d796b013

Sam Rawlins authored Nov 02, 2023

Also ignore one case where it is hard to fix.

The code with out the null assertion is legal as per the type signature,
but will throw a runtime exception if the nullable value is null. To
make this exception more explicit, the value must be null-checked before
completing the completer with the value.

The analyzer will soon enforce such checks. See
https://github.com/dart-lang/sdk/issues/53253.

Fixes https://github.com/flutter/flutter/issues/137294

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d796b013

Chore/gradle remove redundant apply (#135348) · 3bc64e8f

Bartek Pacia authored Nov 02, 2023

I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in #123511. At that time, I did not know that it's unnecessary, and did not test removing it â sorry about that.

I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in). More context there.

3bc64e8f

Roll Flutter Engine from 2ec0f74a1e8a to b11e318b3690 (2 revisions) (#137785) · 5a0ef34d

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/2ec0f74a1e8a...b11e318b3690

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 70634da5c783 to 2b3472da9888 (5 revisions) (flutter/engine#47608)
2023-11-02 jonahwilliams@google.com [Impeller] add support for specialization constants. (flutter/engine#47432)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a0ef34d

Migrate api docs from master to main. (#137726) · 90c73055

godofredoc authored Nov 02, 2023

This is the first of a series of changes to migrate to remove master-docs-flutter-dev GCP project.

Bug: https://github.com/flutter/flutter/issues/133877

90c73055

Roll Flutter Engine from 16d54bda1613 to 2ec0f74a1e8a (1 revision) (#137777) · 92ea5e0a

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/16d54bda1613...2ec0f74a1e8a

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) (flutter/engine#47604)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92ea5e0a

Fix mounted checks (#137778) · b09c70a9

Michael Goderbauer authored Nov 02, 2023

Fixes in preparation for https://dart-review.googlesource.com/c/sdk/+/330561.

The change referenced above tightens the `use_build_context_synchronously` to ensure that `mounted` is checked on the appropriate `BuildContext` or `State`. This change fixes up the flutter/flutter in preparation of this new enforcement.

b09c70a9

Fixes `DragTarget` crash if `Draggable.data` is `null` (#133136) · f15f2313

Valentin Vignal authored Nov 02, 2023

Makes the `data` parameter of `Draggable` non-nullable.

Fixes https://github.com/flutter/flutter/issues/84816

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

f15f2313

Cupertino date picker should dispose scroll controllers it created. (#135355) · 7646430c
derdilla authored Nov 02, 2023

7646430c

Roll Flutter Engine from be49d6595ddd to 16d54bda1613 (1 revision) (#137774) · 24adfe1c

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/be49d6595ddd...16d54bda1613

2023-11-02 15619084+vashworth@users.noreply.github.com Fix race condition in Platform View Scenario tests (flutter/engine#47575)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

24adfe1c

Update `IconButton.iconSize` documentation (#137741) · 615dd968

Qun Cheng authored Nov 02, 2023

fixes https://github.com/flutter/flutter/issues/137580

---

This PR is just to add two sentences for `IconButton.iconSize`'s documentation.

615dd968

Remove duplicate padding on CupertinoFormSection (#137039) · 55eb5e11

Jasper van Riet authored Nov 02, 2023

Fixes #128419, removes the duplicate padding that exists around the header and footer on `CupertinoFormSection`. This PR takes the implementation in #129065 and adds tests. I added the ones suggested in the PR review, as well as one more to test that `margin` is passed correctly from `CupertinoFormSection` to `CupertinoListSection`.

Note: I can't quite figure out if this is also a fix to #121543.

Potential review questions:

- Is the use of `offsetMoreOrLessEquals` here correct? I used it because of the vertical positioning. The horizontal positioning is always exact.

### Screenshots
<details>
  <summary>Before</summary>
  
![image](https://github.com/flutter/flutter/assets/5138348/1bce10c9-706a-40c8-a581-2dcb574ed937)
</details>
<details>
  <summary>After</summary>
  
![image](https://github.com/flutter/flutter/assets/5138348/cd1d529b-7be5-45df-af31-0f7760dc3fe9)
</details>

55eb5e11

Roll Flutter Engine from 4ba585b2ad91 to be49d6595ddd (2 revisions) (#137767) · 06a66670

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/4ba585b2ad91...be49d6595ddd

2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pvAbHwPJtOuEpHJN7... to YS7vrarYI-cHvhuBT... (flutter/engine#47602)
2023-11-02 jason-simmons@users.noreply.github.com Update DisplayList tests to explicitly select the Roboto font (flutter/engine#47493)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pvAbHwPJtOuE to YS7vrarYI-cH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06a66670

Roll Flutter Engine from bd23e33a05a0 to 4ba585b2ad91 (1 revision) (#137764) · 2cca5762

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/bd23e33a05a0...4ba585b2ad91

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 54be0f6f205b to 8299245af8a8 (2 revisions) (flutter/engine#47601)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2cca5762

Roll Packages from 6ad40b9a07d3 to 33c2b4e53ad7 (3 revisions) (#137763) · 8d2fe7dc

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/packages/compare/6ad40b9a07d3...33c2b4e53ad7

2023-11-02 ditman@gmail.com [google_sign_in] Enable FedCM for web. Use token expiration. (flutter/packages#5225)
2023-11-01 ditman@gmail.com [video_player_web] Listen to loadedmetadata event from video element. (flutter/packages#5289)
2023-11-01 stuartmorgan@google.com [local_auth] Update iOS to Pigeon 13 (flutter/packages#5269)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d2fe7dc

Marks Windows build_tests_1_6 to be unflaky (#137673) · 87c8e241

Flutter GitHub Bot authored Nov 02, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_1_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_1_6%22).
This test can be marked as unflaky.

87c8e241

Marks Windows build_tests_4_6 to be unflaky (#137674) · 41e92351

Flutter GitHub Bot authored Nov 02, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_4_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_4_6%22).
This test can be marked as unflaky.

41e92351

Roll Flutter Engine from 0dd251e7ef6d to bd23e33a05a0 (1 revision) (#137762) · cb3191ec

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/0dd251e7ef6d...bd23e33a05a0

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from ff5e220c57e4 to 54be0f6f205b (1 revision) (flutter/engine#47599)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb3191ec

Instrument ImageStreamCompleterHandle for LeakTracking (#137482) · 39f29741
Binni Goel authored Nov 02, 2023

39f29741
Instrumented PipelineOwner for leak tracking (#137494) · e2d5e8fd
Binni Goel authored Nov 02, 2023

e2d5e8fd

Roll Flutter Engine from 3c1e8f457e3d to 0dd251e7ef6d (2 revisions) (#137759) · 7308207c

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/3c1e8f457e3d...0dd251e7ef6d

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 86ce6e04fddf to ff5e220c57e4 (1 revision) (flutter/engine#47593)
2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 8a5e27e4607c to 86ce6e04fddf (1 revision) (flutter/engine#47591)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7308207c

Roll Flutter Engine from bc39653b3198 to 3c1e8f457e3d (1 revision) (#137752) · f7d1b35d

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/bc39653b3198...3c1e8f457e3d

2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Lrg_lElxg0BmYp97-... to 32ukjtetQl4pbXfTw... (flutter/engine#47590)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Lrg_lElxg0Bm to 32ukjtetQl4p

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7d1b35d

Roll Flutter Engine from ff8d3a3fc19d to bc39653b3198 (1 revision) (#137751) · 5f649029

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/ff8d3a3fc19d...bc39653b3198

2023-11-02 flar@google.com Add some important comments to some of the FilteContents methods (flutter/engine#47567)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f649029

Roll Flutter Engine from d79de7f6cb04 to ff8d3a3fc19d (2 revisions) (#137750) · 3e7b5ddc

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/d79de7f6cb04...ff8d3a3fc19d

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 66bbeb412a59 to 8a5e27e4607c (1 revision) (flutter/engine#47589)
2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 39776c81d2b8 to 66bbeb412a59 (1 revision) (flutter/engine#47588)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e7b5ddc

Roll Flutter Engine from be629214a65e to d79de7f6cb04 (2 revisions) (#137747) · fcdd5718

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/be629214a65e...d79de7f6cb04

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 65b5bcd6c365 to 39776c81d2b8 (2 revisions) (flutter/engine#47587)
2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G6icdRMZm9dD9Oky1... to pvAbHwPJtOuEpHJN7... (flutter/engine#47585)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from G6icdRMZm9dD to pvAbHwPJtOuE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fcdd5718

Roll Flutter Engine from d92ccb964fcc to be629214a65e (2 revisions) (#137744) · 0d6ec2f4

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/d92ccb964fcc...be629214a65e

2023-11-02 flar@google.com [Impeller] Move all remaining Rect construction to named factories (flutter/engine#47582)
2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 945284d57785 to 65b5bcd6c365 (12 revisions) (flutter/engine#47581)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d6ec2f4

Roll Flutter Engine from eec2ae4ab4f1 to d92ccb964fcc (2 revisions) (#137743) · f948d52c

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/eec2ae4ab4f1...d92ccb964fcc

2023-11-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Expose more methods on `ui.Paragraph`: lines" (flutter/engine#47584)
2023-11-02 31859944+LongCatIsLooong@users.noreply.github.com Expose more methods on `ui.Paragraph`: lines (flutter/engine#46125)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f948d52c

Roll Flutter Engine from 406f0c477afb to eec2ae4ab4f1 (3 revisions) (#137740) · 68ff01a7

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/406f0c477afb...eec2ae4ab4f1

2023-11-02 34871572+gmackall@users.noreply.github.com Change FTL test to high capacity device (flutter/engine#47579)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 613abdf2c895 to 945284d57785 (1 revision) (flutter/engine#47564)
2023-11-01 bdero@google.com Bump impeller-cmake to head (flutter/engine#47563)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68ff01a7

[github] Remove assignees in CP requests (#137729) · 895b4bcb
Casey Hillers authored Nov 02, 2023
```
b/307993619

FRoB will assign the RelEng oncall to these issues.
```
895b4bcb

Update Carousel tokens to v0.202 (#137728) · dee88d19

Qun Cheng authored Nov 02, 2023

This PR is to export the carousel tokens from database. Only carousel tokens are updated.

Related to #125980

dee88d19

01 Nov, 2023 7 commits

Add `Card.filled` and `Card.outlined` factory methods (#136229) · 4a0f261b

Qun Cheng authored Nov 01, 2023

Fixes #119401

This PR is to:
* add `Card.filled` and `Card.outlined` factory methods so that we can use tokens for these two types of cards to generate default theme instead of providing hard-corded values in example.
* update card.2.dart example.
* add test file for card.2.dart example.
* fix some mismatch caused by editing the auto-generated defaults by hand in navigation_bar.dart and navigation_drawer.dart.

4a0f261b

Reverts "Update `framework_test.dart` to remove `ButtonBar` usage and remove... · b47e4c4a

auto-submit[bot] authored Nov 01, 2023

Reverts "Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases" (#137731)

Reverts flutter/flutter#137550
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation

related to https://github.com/flutter/flutter/issues/127955

b47e4c4a

Added EdgeInsetsDirectional.copyWith (#137559) · 43dc3fcf
Tirth authored Nov 01, 2023
```
Added `EdgeInsetsDirectional.copyWith` named constructor.

Fixes #137475
```
43dc3fcf

Update `framework_test.dart` to remove `ButtonBar` usage and remove references... · b1f5d96a

Taha Tesser authored Nov 01, 2023

Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases (#137550)

This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation

related to https://github.com/flutter/flutter/issues/127955

b1f5d96a

Roll Flutter Engine from 49d3ce9c2ae3 to 406f0c477afb (5 revisions) (#137720) · 102e6025

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/49d3ce9c2ae3...406f0c477afb

2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 84e1dc3af49e to 613abdf2c895 (4 revisions) (flutter/engine#47560)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 4594e2ef3ee8 to 84e1dc3af49e (1 revision) (flutter/engine#47558)
2023-11-01 jason-simmons@users.noreply.github.com Consolidate all the copies of the OpenFixtureAsSkData testing helper function (flutter/engine#47491)
2023-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 15558b6ae7d5 to e6df03a57636 (1 revision) (flutter/engine#47556)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 816d41255105 to 4594e2ef3ee8 (1 revision) (flutter/engine#47555)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

102e6025

reset state of CustomSemanticsAction before running tests (#137697) · d843863c

Dan Field authored Nov 01, 2023

Fixes https://github.com/flutter/flutter/issues/137696

This will get the tree green again.

The problem is that `CustomSemanticsAction` has static state in it, and todays test seed order makes things unhappy.

d843863c

Roll Flutter Engine from 8ffc705a55d5 to 49d3ce9c2ae3 (7 revisions) (#137707) · ba75e7a0

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/8ffc705a55d5...49d3ce9c2ae3

2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 8fabb1ce2065 to 816d41255105 (1 revision) (flutter/engine#47553)
2023-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _TyF0etsONe5aqCbM... to G6icdRMZm9dD9Oky1... (flutter/engine#47551)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from b7ac9da3e5ac to 8fabb1ce2065 (1 revision) (flutter/engine#47550)
2023-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 62aceb5e057d to 15558b6ae7d5 (1 revision) (flutter/engine#47549)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from f1983b5af2ef to b7ac9da3e5ac (1 revision) (flutter/engine#47548)
2023-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from x2NzYMNhyodIwDl0I... to Lrg_lElxg0BmYp97-... (flutter/engine#47547)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 83d6345dd3c2 to f1983b5af2ef (2 revisions) (flutter/engine#47541)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _TyF0etsONe5 to G6icdRMZm9dD
fuchsia/sdk/core/mac-amd64 from x2NzYMNhyodI to Lrg_lElxg0Bm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba75e7a0