- 24 Jul, 2020 1 commit
-
-
Jonah Williams authored
The embedder requires that the isolate is unpaused, because the runInView method requires interaction with dart engine APIs that are not thread-safe. These APIs must be run on the same thread that would be blocked by the pause. Simply unpausing is not sufficient, because this does not prevent the isolate from immediately hitting a breakpoint, for example if the breakpoint was placed in a loop or in a frequently called method. Instead, all breakpoints are first disabled and then the isolate resumed.
-
- 20 Jul, 2020 2 commits
-
-
Jonah Williams authored
To support #61407 , the tool needs to check if a single widget reload is feasible, and then conditionally perform a fast reassemble. To accomplish this, the FlutterDevice class will have a WidgetCache injected. This will eventually contain the logic for parsing the invalidated dart script. Concurrent with the devFS update, the widget cache will be updated/checked if a single widget reload is feasible. If so, an expression evaluation with the target type is performed and the success is communicated through the devFS result. An integration test which demonstrates that this works is already present in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/hot_reload_test.dart#L86 Finally, when actually performing the reassemble the tool simply checks if this flag has been set and calls the alternative reassemble method. Cleanups: Remove modules, as this is unused now.
-
Helin Shiah authored
-
- 30 Jun, 2020 1 commit
-
-
Jonah Williams authored
The flutter daemon unconditionally waits for the appFinished signal, even if startup failed. Ensure this future is correctly completed if there is a failure in ResidentRunner.run and not just ResidentRunner.attach. Adds regression tests for run release, debug, debug web, and release web. Adds missing try catch in cold runner startup. Manually tested with release/debug on Android and release/debug on web. Fixes #60613
-
- 26 Jun, 2020 1 commit
-
-
Jonah Williams authored
Last batch of test fixes for general shard.
-
- 25 Jun, 2020 1 commit
-
-
Jonah Williams authored
The global packages path could cause tests to fail when it would be overriden to unexpected (in test setup) values. Remove most usage and make it a configuration on buildInfo, along with most other build information. Cleanup the asset builder to require the .packages path and the resident runners to no longer require it, since they already have the information in build_info. It needs to stick around for the fuchsia deps we do not control. Filled #60232 for remaining work.
-
- 23 Jun, 2020 1 commit
-
-
Jonah Williams authored
* [flutter_tools] track null safety usage * Update flutter_command_test.dart * cleanups
-
- 04 Jun, 2020 1 commit
-
-
Jonah Williams authored
* [flutter_tools] only copy cached dill after startup * shared code * cleanup artifact directory * do not copy if dillOutputPath is given
-
- 03 Jun, 2020 2 commits
-
-
Jonah Williams authored
The linked error has been fixed, removed work around. Updates the test cases to only test for exit instead of error message #33050
-
Jonah Williams authored
Suppress compilation errors on startup so they are not duplicated from the native build step.
-
- 02 Jun, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 39d1e4b7.
-
- 01 Jun, 2020 1 commit
-
-
Jonah Williams authored
Remove copying from the shutdown stage since that seems risky. If the tool copies the first compilation there will still be a decent dill for initialization.
-
- 27 May, 2020 1 commit
-
-
Jonah Williams authored
-
- 18 May, 2020 1 commit
-
-
Jonah Williams authored
Reland: #56167
-
- 10 May, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit f865ac7e.
-
- 08 May, 2020 1 commit
-
-
Jonah Williams authored
* [flutter_tools] integration l10n tool * add runtime skip to build system * Update build_system.dart * add links to issues, comments * Update packages/flutter_tools/test/general.shard/build_system/build_system_test.dart Co-authored-by:
Shi-Hao Hong <shihaohong@google.com> * Update packages/flutter_tools/lib/src/build_system/targets/localizations.dart Co-authored-by:
Shi-Hao Hong <shihaohong@google.com> * Update localizations.dart * switch to gen_l10n localizations * fix tests Co-authored-by:
Shi-Hao Hong <shihaohong@google.com>
-
- 06 May, 2020 1 commit
-
-
Zachary Anderson authored
-
- 05 May, 2020 3 commits
-
-
Jonah Williams authored
Fixes #56194 Remove caching of FlutterView and poll forever if the list of flutter views is empty. Added test for missing release mode logic.
-
Jonah Williams authored
This reverts commit 209bdcb6.
-
Jonah Williams authored
Remove caching of FlutterView. Perhaps the FlutterView RPC might return an empty list if the VM is not quite up yet? We had some old logic to poll the flutter views RPC for up to 200ms. That doesn't seem like a great approach, so instead we could forgo it entirely and trust that either the views come up before the developer tries to interact, or we crash.
-
- 29 Apr, 2020 1 commit
-
-
Jonah Williams authored
Finishes the gradual vm service migration by deleting the flutter tooling's vm_service
-
- 28 Apr, 2020 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
Move FlutterView and related RPCs to the package:vm_service implementation. Update some getIsolate calls with catchError to match previous behavior. - Updates tests that were previously mocking FlutterViews to use real views - Moves the FlutterView cache from VM to FlutterDevice - Catch SentinelException during Isolate.kill
-
- 27 Apr, 2020 4 commits
-
-
Jenn Magder authored
This reverts commit a18e6361.
-
Jonah Williams authored
-
Jonah Williams authored
This reverts commit 2e50fd75.
-
Jonah Williams authored
Move FlutterView and related RPCs to the package:vm_service implementation. Update some getIsolate calls with catchError to match previous behavior. - Updates tests that were previously mocking FlutterViews to use real views - Moves the FlutterView cache from VM to FlutterDevice - Catch SentinelException during Isolate.kill
-
- 23 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 22 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 20 Apr, 2020 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 16 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 15 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 10 Apr, 2020 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 09 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 08 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 07 Apr, 2020 1 commit
-
-
Jason Simmons authored
-
- 06 Apr, 2020 2 commits
-
-
Jonah Williams authored
This reverts commit d6b09626.
-
Jonah Williams authored
-