- 30 Nov, 2017 1 commit
-
-
Michael Goderbauer authored
* ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler. * no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent. * Fixes #13109. * removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
-
- 22 Nov, 2017 1 commit
-
-
Ian Hickson authored
This fixes the popup menu code to do a better job of expanding smoothly regardless of which side of the screen it's on. It still results in a bidirection growth when positioned at the bottom of the screen, so maybe we'll need to animate menus differently, but that's a problem for another patch. Also, improve some docs and provide RelativeRect.toSize which I needed at one point while building this patch (though it didn't survive all the way to the end).
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 15 Nov, 2017 1 commit
-
-
Greg Spencer authored
This makes ListTile expand vertically when text is scaled, or really when whatever is placed inside it is larger than the available space. In order for UnconstrainedBox to be useful here, I needed for it to only unconstrain the child Row in one dimension, so I added a "constrainedAxis" parameter to the UnconstrainedBox. Also, changed one enum test to use a switch instead. I modified the ListTile test to be more representative of the intention of the spec: we were testing with text in the leading and trailing sections, and the design wants icons there. Because there was leading text, and the dense mode only changes the font size on the text lines, the leading text was propping up the minimum size of the tile, making so that the test wasn't really testing any changes in dense mode.
-
- 09 Nov, 2017 1 commit
-
-
Greg Spencer authored
UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning. I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
-
- 04 Nov, 2017 1 commit
-
-
Ian Hickson authored
There was a left-bias when MainAxisSize.min couldn't be honoured.
-
- 03 Nov, 2017 1 commit
-
-
amirh authored
-
- 02 Nov, 2017 1 commit
-
-
Michael Goderbauer authored
* Identify text fields as such to a11y * focus * make travis happy * review comments
-
- 01 Nov, 2017 1 commit
-
-
amirh authored
(in preparation for moving the semantics stuff out of rendering)
-
- 31 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Support value announcment for increase/decrease * ++ * review comments about docs
-
- 24 Oct, 2017 2 commits
-
-
Michael Goderbauer authored
* Support accessibility labels and hints * more tests * ++ * review comments * fix merge * test fix
-
Michael Goderbauer authored
* Without checking compatibility * ++ * ++ * ++ * more docs
-
- 23 Oct, 2017 1 commit
-
-
- 22 Oct, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Oct, 2017 2 commits
-
-
Ian Hickson authored
This avoids some code duplication that existed before and will make further modifications easier.
-
Jason Simmons authored
-
- 18 Oct, 2017 2 commits
-
-
Michael Goderbauer authored
* Oct 12 10:12am * implicit_semantics_test.dart passes * refactoring * works in nice * minor rename * more doc comments * to be explicit check better * fix test * ++ * ++ * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing * doc updates * tiny refactor * fix static errors in tests * fix gesture detector * ++ * ++ * geometry * ++ * remove noGeometry * revert test * + * all tests but scrolling/clipping pass * clipping works * scrolling halfway * sliver tests pass * ALL TESTS PASS * SemanticsNode changed * docs and tiny fixes * card test * more doc comments * remove missed print * more tests * make test pass on Linux * remove changes to intellij proj file * review comments
-
Jason Simmons authored
libtxt's implementation of Paragraph.getBoxesForRange returns the full line height for all characters in a line. Blink had been returning a tighter enclosing rectangle for each individual character.
-
- 17 Oct, 2017 2 commits
-
-
Ian Hickson authored
-
Adam Barth authored
If the flex is empty, there's no space in which to draw the overflow indicator, so we shouldn't bother trying to draw it. Fixes #12532
-
- 07 Oct, 2017 1 commit
-
-
Ian Hickson authored
Also: * Provide a better message when you lerp from infinity to finity constraints. * Make the striped marker support RTL. * By popular demand, dump a warning to the console the first time a particular Flex overflows. (Resets on hot reload.)
-
- 05 Oct, 2017 3 commits
-
-
Adam Barth authored
Fixes #11930
-
Ian Hickson authored
-
Chris Bracken authored
Eliminates Invocation.typeArguments override recently introduced and removed in upstream Dart SDK commit: https://dart-review.googlesource.com/c/sdk/+/10702
-
- 04 Oct, 2017 1 commit
-
-
Ryan Macnak authored
-
- 03 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Drop invisible SemanticsNodes from tree A node is invisible if it is outside of the bounds of the screen and if it is not merged into its (partially) visible parent. Also in this PR: only set `wasAffectedByClip` to true if the nodes has actually been clipped. * Fix other failing tests * renaming * review feedback * more doc
-
- 02 Oct, 2017 5 commits
-
-
Alexander Aprelev authored
This reverts commit f6fe8dc7. This breaks coverage test https://travis-ci.org/flutter/flutter/jobs/282472585
-
Alexander Aprelev authored
* Roll engine * Pick up updated engine with analyzer fix * Add new typeArguments override * Update engine dep * Up dartdoc version to fix name resolution issues
-
gspencergoog authored
* Add framework-side support for system text scale factor. * Rolling engine to e3404b81a53ba3180c7623a6f2190ebb28518f30 Additional changes rolled in with engine change: libtxt: implementation of GetRectsForRange that processes a line at a time - e3404b8 Provide an entropy source to the Dart engine (#4161) - e1aa867 libtxt: search for fallback fonts that can match emoji and CJK characters - 8061df1 Roll skia to e4679fa06a. (#4157) - 267e7a8 Update buildroot to 53fea9aebbcc39c6522731471a1a45960ee0685e (#4160) - 02ea7ae Revert engine Dart roll. (#4158) - 14aab33 Add support for system text scale factor. (#4124) - b2a7f4b Include _http into sky_engine libraries for analyzer (#4154) - b930f10 libtxt: Remove postprocess_line and improve tracking of X offsets - 86f95f0 libtxt: remove redundant line_widths (#4152) - 14bf515 Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151) - 6f1264f
-
Michael Goderbauer authored
* ++ * Allow unmerging of SemanticsNodes * test passing * ++ * remove prints * doc comments * rectify comment * review comments
-
Adam Barth authored
Unlike FractionalOffset, Alignment uses the center as the zero of the coordinate system, which makes the RTL math work out much cleaner. Also, make FractionalOffset into a subclass of Alignment so that clients can continue to use FractionalOffset.
-
- 24 Sep, 2017 2 commits
-
-
Ian Hickson authored
-
Ian Hickson authored
-
- 23 Sep, 2017 1 commit
-
-
Adam Barth authored
Also, fix asserts in TableBorder#paint to match documentation. Fixes #12009
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Sep, 2017 1 commit
-
-
Ian Hickson authored
I inflated instead of deflating. Oops.
-
- 15 Sep, 2017 1 commit
-
-
Ian Hickson authored
This will enable both to be RTL'ed. Also, factor out common border painting code into paintBorder. Also, make Border paint uniform non-rounded borders using drawRect. Also, add some documentation about an issue that wasted an hour of my life. Also, factor out all the border painting code into TableBorder.paint.
-
- 12 Sep, 2017 1 commit
-
-
Jacob Richman authored
Diagnostics object is.
-
- 11 Sep, 2017 2 commits
-
-
Jacob Richman authored
* Refactor SemanticsData and SemanticsNode to use Diagnosticable. * Switch toStringDeep to take named parameters.
-
Ian Hickson authored
-