1. 30 Nov, 2017 1 commit
    • Michael Goderbauer's avatar
      Adapt markNeedsSemanticsUpdate algorithm to new semantics tree compiler (#13274) · 6493c8b4
      Michael Goderbauer authored
      * ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler.
      * no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent.
      * Fixes #13109.
      * removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
      6493c8b4
  2. 22 Nov, 2017 1 commit
    • Ian Hickson's avatar
      Popup menus RTL (#13110) · 34ba6be9
      Ian Hickson authored
      This fixes the popup menu code to do a better job of expanding
      smoothly regardless of which side of the screen it's on. It still
      results in a bidirection growth when positioned at the bottom of the
      screen, so maybe we'll need to animate menus differently, but that's
      a problem for another patch.
      
      Also, improve some docs and provide RelativeRect.toSize which I needed
      at one point while building this patch (though it didn't survive all
      the way to the end).
      34ba6be9
  3. 17 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Fix spelling errors in all the dartdocs. (#13061) · 0259be90
      Greg Spencer authored
      I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.
      
      This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
      0259be90
  4. 15 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Adding accomodations to ListTile for scaleTextFactor. (#12973) · c15c021e
      Greg Spencer authored
      This makes ListTile expand vertically when text is scaled, or really when whatever is placed inside it is larger than the available space.
      
      In order for UnconstrainedBox to be useful here, I needed for it to only unconstrain the child Row in one dimension, so I added a "constrainedAxis" parameter to the UnconstrainedBox.
      
      Also, changed one enum test to use a switch instead.
      
      I modified the ListTile test to be more representative of the intention of the spec: we were testing with text in the leading and trailing sections, and the design wants icons there. Because there was leading text, and the dense mode only changes the font size on the text lines, the leading text was propping up the minimum size of the tile, making so that the test wasn't really testing any changes in dense mode.
      c15c021e
  5. 09 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Add an UnconstrainedBox and factor out debug overflow indicator. (#12856) · 3541ad0a
      Greg Spencer authored
      UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning.
      
      I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
      3541ad0a
  6. 04 Nov, 2017 1 commit
  7. 03 Nov, 2017 1 commit
  8. 02 Nov, 2017 1 commit
  9. 01 Nov, 2017 1 commit
  10. 31 Oct, 2017 1 commit
  11. 24 Oct, 2017 2 commits
  12. 23 Oct, 2017 1 commit
  13. 22 Oct, 2017 1 commit
  14. 20 Oct, 2017 2 commits
  15. 18 Oct, 2017 2 commits
    • Michael Goderbauer's avatar
      Redesign Semantic Tree Compilation Algorithm (#12605) · f8a2bd20
      Michael Goderbauer authored
      * Oct 12 10:12am
      
      * implicit_semantics_test.dart passes
      
      * refactoring
      
      * works in nice
      
      * minor rename
      
      * more doc comments
      
      * to be explicit check better
      
      * fix test
      
      * ++
      
      * ++
      
      * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing
      
      * doc updates
      
      * tiny refactor
      
      * fix static errors in tests
      
      * fix gesture detector
      
      * ++
      
      * ++
      
      * geometry
      
      * ++
      
      * remove noGeometry
      
      * revert test
      
      * +
      
      * all tests but scrolling/clipping pass
      
      * clipping works
      
      * scrolling halfway
      
      * sliver tests pass
      
      * ALL TESTS PASS
      
      * SemanticsNode changed
      
      * docs and tiny fixes
      
      * card test
      
      * more doc comments
      
      * remove missed print
      
      * more tests
      
      * make test pass on Linux
      
      * remove changes to intellij proj file
      
      * review comments
      f8a2bd20
    • Jason Simmons's avatar
      libtxt: adapt a selection rectangle test (#12612) · 264cbf61
      Jason Simmons authored
      libtxt's implementation of Paragraph.getBoxesForRange returns the full line
      height for all characters in a line.  Blink had been returning a tighter
      enclosing rectangle for each individual character.
      264cbf61
  16. 17 Oct, 2017 2 commits
  17. 07 Oct, 2017 1 commit
  18. 05 Oct, 2017 3 commits
  19. 04 Oct, 2017 1 commit
  20. 03 Oct, 2017 1 commit
    • Michael Goderbauer's avatar
      Drop invisible SemanticsNodes from tree (#12358) · 49499457
      Michael Goderbauer authored
      * Drop invisible SemanticsNodes from tree
      
      A node is invisible if it is outside of the bounds of the screen and if it is not merged into its (partially) visible parent.
      
      Also in this PR: only set `wasAffectedByClip` to true if the nodes has actually been clipped.
      
      * Fix other failing tests
      
      * renaming
      
      * review feedback
      
      * more doc
      49499457
  21. 02 Oct, 2017 5 commits
    • Alexander Aprelev's avatar
      Revert "Roll flutter engine (#12307)" (#12365) · fd04d4d1
      Alexander Aprelev authored
      This reverts commit f6fe8dc7.
      
      This breaks coverage test
      https://travis-ci.org/flutter/flutter/jobs/282472585
      fd04d4d1
    • Alexander Aprelev's avatar
      Roll flutter engine (#12307) · f6fe8dc7
      Alexander Aprelev authored
      * Roll engine
      
      * Pick up updated engine with analyzer fix
      
      * Add new typeArguments override
      
      * Update engine dep
      
      * Up dartdoc version to fix name resolution issues
      f6fe8dc7
    • gspencergoog's avatar
      Add framework support for system text scale factor. (#12180) · 18f0d3ae
      gspencergoog authored
      * Add framework-side support for system text scale factor.
      
      * Rolling engine to e3404b81a53ba3180c7623a6f2190ebb28518f30
        Additional changes rolled in with engine change:
          libtxt: implementation of GetRectsForRange that processes a line at a time - e3404b8
          Provide an entropy source to the Dart engine (#4161) - e1aa867
          libtxt: search for fallback fonts that can match emoji and CJK characters - 8061df1
          Roll skia to e4679fa06a. (#4157) - 267e7a8
          Update buildroot to 53fea9aebbcc39c6522731471a1a45960ee0685e (#4160) - 02ea7ae
          Revert engine Dart roll. (#4158) - 14aab33
          Add support for system text scale factor. (#4124) - b2a7f4b
          Include _http into sky_engine libraries for analyzer (#4154) - b930f10
          libtxt: Remove postprocess_line and improve tracking of X offsets - 86f95f0
          libtxt: remove redundant line_widths (#4152) - 14bf515
          Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151) - 6f1264f
      18f0d3ae
    • Michael Goderbauer's avatar
      Make "mergeIntoParent" information available during compile of semantics tree (#12332) · 437e4c08
      Michael Goderbauer authored
      * ++
      
      * Allow unmerging of SemanticsNodes
      
      * test passing
      
      * ++
      
      * remove prints
      
      * doc comments
      
      * rectify comment
      
      * review comments
      437e4c08
    • Adam Barth's avatar
      Add Alignment, which will replace FractionalOffset (#12342) · 2b126bcd
      Adam Barth authored
      Unlike FractionalOffset, Alignment uses the center as the zero of the
      coordinate system, which makes the RTL math work out much cleaner.
      
      Also, make FractionalOffset into a subclass of Alignment so that clients
      can continue to use FractionalOffset.
      2b126bcd
  22. 24 Sep, 2017 2 commits
  23. 23 Sep, 2017 1 commit
  24. 21 Sep, 2017 1 commit
  25. 20 Sep, 2017 1 commit
  26. 15 Sep, 2017 1 commit
    • Ian Hickson's avatar
      Split TableBorder from Border (#12104) · 9d59fb0c
      Ian Hickson authored
      This will enable both to be RTL'ed.
      
      Also, factor out common border painting code into paintBorder.
      Also, make Border paint uniform non-rounded borders using drawRect.
      Also, add some documentation about an issue that wasted an hour of my life.
      Also, factor out all the border painting code into TableBorder.paint.
      9d59fb0c
  27. 12 Sep, 2017 1 commit
  28. 11 Sep, 2017 2 commits