Commits · 11f1ae6f83955965cbe29dd954bb3de12a47ea73 · abdullh.alsoleman / Front-End

23 Jun, 2023 12 commits

Add r: timeout label to bugs/pr closed by no response bot. (#129408) · 11f1ae6f
godofredoc authored Jun 23, 2023
```
Adds r: timeout to bugs closed by inactivity.

Bug: https://github.com/flutter/flutter/issues/104962
```
11f1ae6f

Remove .github/move.yml. (#129409) · 9fa4b53c

godofredoc authored Jun 23, 2023

The file is not being used.

Bug: https://github.com/flutter/flutter/issues/129404

9fa4b53c

Roll Packages from 95bc1c6db547 to d041934b296d (6 revisions) (#129429) · 837e8e0d

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/packages/compare/95bc1c6db547...d041934b296d

2023-06-22 54558023+keyonghan@users.noreply.github.com Enforce Linux targets on VMs (flutter/packages#4268)
2023-06-22 engine-flutter-autoroll@skia.org Roll Flutter from c40baf47 to 042c0366 (20 revisions) (flutter/packages#4278)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.2.0 to 1.6.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#3331)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.mockito:mockito-core from 5.3.1 to 5.4.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4246)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230227 to 20230618 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#4245)
2023-06-22 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump org.mockito:mockito-core from 4.7.0 to 5.3.1 (flutter/packages#4224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

837e8e0d

Roll Flutter Engine from aca26b2afc27 to 27f3498286ff (16 revisions) (#129421) · ef2e00c8

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/aca26b2afc27...27f3498286ff

2023-06-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b30bcd6207e to 81cdbe69a16b (2 revisions) (flutter/engine#43138)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 16d65289e868 to 9211ebf1f2ac (1 revision) (flutter/engine#43137)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from a94abf80dd2f to 6ab865ee1f65 (1 revision) (flutter/engine#43135)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from ac4f52c4f7ff to 16d65289e868 (1 revision) (flutter/engine#43133)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 4ed2d403a329 to ac4f52c4f7ff (2 revisions) (flutter/engine#43130)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from a989b6f1aec5 to 450bc21cc836 (2 revisions) (flutter/engine#43128)
2023-06-23 dnfield@google.com Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112)
2023-06-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 05d99585adab to 7b30bcd6207e (1 revision) (flutter/engine#43123)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Ylc35wOk0_j0NLzDv... to 07vKo_Vaiy_Vw2xxb... (flutter/engine#43119)
2023-06-23 bdero@google.com [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117)
2023-06-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 5265b5ee1afc to 6595192c8352 (1 revision) (flutter/engine#43116)
2023-06-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ecca5857b3ba to 05d99585adab (4 revisions) (flutter/engine#43113)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tcVndpnH_jzG to VSKvLPB4DCID
fuchsia/sdk/core/mac-amd64 from Ylc35wOk0_j0 to 07vKo_Vaiy_V

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef2e00c8

Add comments to .ci.yaml that were removed from recipes. (#129321) · f582c0c5

godofredoc authored Jun 23, 2023

Firebaselab recipe was cleaned up and comments removed. This is adding the still valid comments to the .ci.yaml file.

f582c0c5

Update no response to use core action. (#129405) · 3f90620a

godofredoc authored Jun 23, 2023

This is to use a maintained version of the no-response action.

Bug: https://github.com/flutter/flutter/issues/127450

3f90620a

Revert "[web] Migrate framework to fully use package:web" (#129400) · 363e2f7e

Xilai Zhang authored Jun 23, 2023

Reverts flutter/flutter#128901

context: ([cl/542712088](https://critique.corp.google.com/542712088) , [b/288495136](https://b.corp.google.com/288495136))

363e2f7e

Prepare for making `intl` `toBeginningOfSentenceCase` non-nullable (#127488) · 71228e02

Oleh Prypin authored Jun 23, 2023

I intend to edit `toBeginningOfSentenceCase`'s return value to be non-nullable because it really is never null. That will mean that non-null asserts around it will become flagged as unnecessary, although right now they are necessary. So, apply a workaround - instead use a function that does a non-null assert without triggering any lints even after it becomes unnecessary.

71228e02

[web] Hides that Flutter uses requireJS in debug. (#129032) · 34b42acf

David Iglesias authored Jun 23, 2023

Flutter web uses requireJS in `debug` mode to assemble a DDC-compiled app from a bunch of small files ("modules").

This caused that `canvaskit.js` (and all other modules that used a browserify-like loading header) didn't work because they attempted to use the `define` function provided by Flutter's instance of `requireJS` (which kept the defined modules private, rather than as globals on the page, as the users of the JS expected).

A [fix](https://github.com/flutter/engine/pull/27342) was added to `flutter/engine` to trick loaders into *not* using the `requireJS` module loader, but a recent change in the fix's js-interop layer *subtly* changed its JS output on the page (objects went from `undefined` to `null`), causing this:

* https://github.com/flutter/flutter/issues/126131 (and others)

This PR hides a bit of code that is commonly used by module loaders to decide that they may use the `define` function provided by requireJS (so the engine workaround can be removed).

## Next steps

* https://github.com/flutter/engine/pull/42941

## Issues

Partially addresses: https://github.com/flutter/flutter/issues/126131 (and others)

## Tests

* Added a unit test to ensure the `delete` stays
* Manually tested with the Gallery app in `debug` mode with a bunch of user-supplied scripts that currently fail to load.
  * Also tested hot restart as suggested by @nshahan

34b42acf

Roll Flutter Engine from 86820cbd40c5 to aca26b2afc27 (2 revisions) (#129393) · fcbc53bc

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/86820cbd40c5...aca26b2afc27

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114)
2023-06-22 godofredoc@google.com Add missing android lint to linux_unopt. (flutter/engine#43099)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fcbc53bc

`_TapStatusTrackerMixin` should wait until the next `PointerDownEvent` before... · 3c366b70

Renzo Olivares authored Jun 23, 2023

`_TapStatusTrackerMixin` should wait until the next `PointerDownEvent` before resetting its state when the tap timer has elapsed (#129312)

`_TapStatusTrackerMixin` used by `BaseTapAndDragGestureRecognizer` should wait until the next tap down before resetting its state when the `_consecutiveTapTimer` times out. This is because `BaseTapAndDragGestureRecognizer` may not have fired its tap down/tap up event before the state has been reset preventing it from firing the tap down/tap up callbacks at all because `currentDown` and `currentUp` are reset to `null`.

Fixes #129161

3c366b70

Roll Flutter Engine from 7ff6a65b7183 to 86820cbd40c5 (1 revision) (#129388) · 3df1de4c

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/7ff6a65b7183...86820cbd40c5

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3df1de4c

22 Jun, 2023 21 commits

Roll Flutter Engine from ed477deba7c5 to 7ff6a65b7183 (2 revisions) (#129382) · 14eb1f4c

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/ed477deba7c5...7ff6a65b7183

2023-06-22 43091780+utzcoz@users.noreply.github.com [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14eb1f4c

Revert "Fix Material 3 Scrollable `TabBar`" (#129383) · 087377ea
Kate Lovett authored Jun 22, 2023
```
Reverts flutter/flutter#125974
```
087377ea

Roll Flutter Engine from 703c9a14ac7f to ed477deba7c5 (24 revisions) (#129378) · 7e2f3fab

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/703c9a14ac7f...ed477deba7c5

2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from bbcf54bcb738 to 4ed2d403a329 (7 revisions) (flutter/engine#43105)
2023-06-22 chingjun@google.com Workaround a release blocker after libc++ change (flutter/engine#43091)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102)
2023-06-22 bdero@google.com [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093)
2023-06-22 bdero@google.com [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094)
2023-06-22 103135467+sealesj@users.noreply.github.com Use minor version, ignore patches for CodeQL (flutter/engine#43088)
2023-06-22 dnfield@google.com Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096)
2023-06-22 jonahwilliams@google.com [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089)
2023-06-22 mdebbar@google.com [web] Don't get break type from v8BreakIterator (flutter/engine#43053)
2023-06-22 aam@google.com Roll dart to 3.1.0-239.0.dev (flutter/engine#43083)
2023-06-22 jonahwilliams@google.com Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061)
2023-06-22 jonahwilliams@google.com [Impeller] Add fence waiter trace event. (flutter/engine#43092)
2023-06-22 jonahwilliams@google.com [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085)
2023-06-22 zanderso@users.noreply.github.com Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087)
2023-06-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080)
2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from 7658525166a4 to bbcf54bcb738 (1 revision) (flutter/engine#43079)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078)
2023-06-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QtQznuUmHMTyORqxJ... to Ylc35wOk0_j0NLzDv... (flutter/engine#43076)
2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from a2b3f9b64670 to 7658525166a4 (1 revision) (flutter/engine#43075)
2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from ac263582dda4 to a2b3f9b64670 (1 revision) (flutter/engine#43074)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073)
2023-06-22 bdero@google.com [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 7EZeNE4aGd29 to tcVndpnH_jzG
fuchsia/sdk/core/mac-amd64 from QtQznuUmHMTy to Ylc35wOk0_j0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7e2f3fab

[flutter_tools] delete flutter format command (#129360) · 6f3b0781

Christopher Fujino authored Jun 22, 2023

On the current stable branch (3.10.x), `flutter format` no longer works, and gives an error. This change just deletes the code.

Fixes https://github.com/flutter/flutter/issues/115809

6f3b0781

Unpin path_provider_android (#129205) · 51f65982

gmackall authored Jun 22, 2023

Unpins path_provider_android where it is pinned. Follows the same steps as https://github.com/flutter/flutter/pull/128898.

Fixes https://github.com/flutter/flutter/issues/116376

51f65982

fix: SearchAnchor View not resizing when in nested navigator (#128357) · 39bf9681

Victor Ohashi authored Jun 22, 2023

Similar to what was done on https://github.com/flutter/flutter/pull/127198, look for the closest navigator instead of screen size.

Fixes: https://github.com/flutter/flutter/issues/128344

39bf9681

Fix `Slider` overlay remains when unfocused (#129115) · d99e5fdd
Taha Tesser authored Jun 22, 2023
```
fixes https://github.com/flutter/flutter/issues/129016
```
d99e5fdd

[web] Migrate framework to fully use package:web (#128901) · bec24367

Mouad Debbar authored Jun 22, 2023

Remove `dom.dart`'s JS interop definitions in favor of `package:web`.

Part of https://github.com/flutter/flutter/issues/113402
Part of https://github.com/flutter/flutter/issues/127030

bec24367

Add `onSubmitted` property to `SearchBar` (#129365) · 5140b0f0
Qun Cheng authored Jun 22, 2023
```
Fixes #126551

This PR is to add `onSubmitted` property to `SearchBar`.
```
5140b0f0

Remove unnecessary variable `_hasPrimaryFocus` (#129066) · 042c0366

Ahmed Elsayed authored Jun 22, 2023

`_hasPrimaryFocus` variable and its related code is no longer needed after using `InkWell` for `DropdownButton` at https://github.com/flutter/flutter/pull/95906

042c0366

Fix Material 3 Scrollable `TabBar` (#125974) · 32fde139

Taha Tesser authored Jun 22, 2023

fix https://github.com/flutter/flutter/issues/117722

### Description
1. Fix the divider doesn't stretch to take all the available width in the scrollable tab bar in M3
2. Add `dividerHeight` property.
3. Update the default tab alignment for the scrollable tab bar to match the specs (this is backward compatible for M2 with the new `tabAlignment` property).

### Bug (default tab alignment)

![Screenshot 2023-05-05 at 19 04 40](https://user-images.githubusercontent.com/48603081/236509483-1d03af21-a764-4776-acef-2126560f0d51.png)

### Fix (default tab alignment)

![Screenshot 2023-05-05 at 19 04 15](https://user-images.githubusercontent.com/48603081/236509513-2426d456-c54f-42bd-9545-a14dc6ee7e69.png)

### Code sample

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        //  tabBarTheme: const TabBarTheme(tabAlignment: TabAlignment.start),
          useMaterial3: true,
      ),
      home: const TabBarExample(),
    );
  }
}

class TabBarExample extends StatefulWidget {
  const TabBarExample({super.key});

  @override
  State<TabBarExample> createState() => _TabBarExampleState();
}

class _TabBarExampleState extends State<TabBarExample> {
  bool rtl = false;

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      initialIndex: 1,
      length: 3,
      child: Directionality(
        textDirection:  rtl ? TextDirection.rtl : TextDirection.ltr,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar Sample'),
          ),
          body: const Column(
            children: <Widget>[
              Text('Scrollable-TabAlignment.start'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.start,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Scrollable-TabAlignment.startOffset'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.startOffset,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Scrollable-TabAlignment.center'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.center,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Spacer(),
              Text('Non-scrollable-TabAlignment.fill'),
              TabBar(
                tabAlignment: TabAlignment.fill,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Non-scrollable-TabAlignment.center'),
              TabBar(
                tabAlignment: TabAlignment.center,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Spacer(),
            ],
          ),
          floatingActionButton: FloatingActionButton.extended(
            onPressed: () {
              setState(() {
                rtl = !rtl;
              });
            },
            label: const Text('Switch Direction'),
            icon: const Icon(Icons.swap_horiz),
          ),
        ),
      ),
    );
  }
}
``` 
	
</details>

![Screenshot 2023-06-06 at 18 06 12](https://github.com/flutter/flutter/assets/48603081/5ee5386d-cc64-4025-a020-ed2222cb6031)

32fde139

Fix: Closing bottom sheet and removing FAB cause assertion failure (#128566) · 0da8012c
Masatoshi Tsushima authored Jun 22, 2023
```
Fixes #128562
```
0da8012c

Add `InputDecorationTheme.merge` (#129011) · 2e05371c

Taha Tesser authored Jun 22, 2023

fixes [[Proposal] `InputDecorationTheme.merge()`](https://github.com/flutter/flutter/issues/125471)

2e05371c

Roll Packages from 9af50d46e5d1 to 95bc1c6db547 (6 revisions) (#129351) · 419bf816

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/packages/compare/9af50d46e5d1...95bc1c6db547

2023-06-22 stuartmorgan@google.com [ci] Switch analyze tests to LUCI (flutter/packages#4264)
2023-06-22 ditman@gmail.com Roll Flutter from fc8856eb to c40baf47 (57 revisions) (flutter/packages#4270)
2023-06-22 stuartmorgan@google.com [ci] Add LUCI version of build-all for Android (flutter/packages#4236)
2023-06-21 47866232+chunhtai@users.noreply.github.com [go_router] Adds parent navigator key to ShellRoute and StatefulShellâ¦ (flutter/packages#4201)
2023-06-21 stuartmorgan@google.com [pigeon] Add macOS Obj-C support (flutter/packages#4267)
2023-06-21 stuartmorgan@google.com [tools] Fix format instructions (flutter/packages#4259)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

419bf816

Prevent crashes on range errors when selecting device (#129290) · 18b94b7f

Elias Yishak authored Jun 22, 2023

Prevent the cli from crashing when a user selects a number that is not valid for `flutter run` device selection

Fixes issue:
- https://github.com/flutter/flutter/issues/129191

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

18b94b7f

Revert "Roll Flutter Engine from 703c9a14ac7f to 8cc6d6d5efdb (1 revision)" (#129353) · 7c259dea

Zachary Anderson authored Jun 22, 2023

Reverts flutter/flutter#129339

Reverting for a crasher: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview

7c259dea

Roll Flutter Engine from 703c9a14ac7f to 8cc6d6d5efdb (1 revision) (#129339) · a2739c09

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/703c9a14ac7f...8cc6d6d5efdb

2023-06-22 bdero@google.com [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a2739c09

Roll Flutter Engine from d9530e2b87de to 703c9a14ac7f (1 revision) (#129337) · 70c25d4e

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/d9530e2b87de...703c9a14ac7f

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 076e7c004d20 to 71047dca9f77 (1 revision) (flutter/engine#43071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70c25d4e

Roll Flutter Engine from c6251a69a09a to d9530e2b87de (1 revision) (#129334) · 15d594c2

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/c6251a69a09a...d9530e2b87de

2023-06-22 dnfield@google.com [Impeller] Fix up coverage hints for blending/vertices, fix TiledTextureContents::RenderToSnapshot (flutter/engine#43017)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15d594c2

Roll Flutter Engine from 08aaa88bf67f to c6251a69a09a (10 revisions) (#129331) · c83dce98

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/08aaa88bf67f...c6251a69a09a

2023-06-22 tamird@google.com Remove process-local tempfs (flutter/engine#43056)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 0185ce148be9 to 076e7c004d20 (2 revisions) (flutter/engine#43069)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 96d6135e9ee8 to 0185ce148be9 (4 revisions) (flutter/engine#43068)
2023-06-22 bdero@google.com [Impeller] Uniquely label subpasses and root blit (flutter/engine#43015)
2023-06-22 bdero@google.com [Impeller] Add Rect::Project (flutter/engine#43026)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 32e953e71266 to 96d6135e9ee8 (1 revision) (flutter/engine#43067)
2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ct6r5YjdG2xpZPhkT... to QtQznuUmHMTyORqxJ... (flutter/engine#43065)
2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4mkuVtlGBaumKSe8x... to 7EZeNE4aGd29VfDly... (flutter/engine#43066)
2023-06-21 skia-flutter-autoroll@skia.org Roll ANGLE from 3a3a3c655a96 to ac263582dda4 (60 revisions) (flutter/engine#43062)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7eeb94b1e778 to 32e953e71266 (17 revisions) (flutter/engine#43064)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4mkuVtlGBaum to 7EZeNE4aGd29
fuchsia/sdk/core/mac-amd64 from ct6r5YjdG2xp to QtQznuUmHMTy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c83dce98

Manual roll of packages to 9af50d46e5d118fd8bc6a7b38bae748bf7877c58 (#129328) · b19ebcd1
Jason Simmons authored Jun 22, 2023
```
Required to fix an analyzer error that is blocking the engine roller
```
b19ebcd1

21 Jun, 2023 7 commits

Roll Flutter Engine from 090fae83548a to 08aaa88bf67f (3 revisions) (#129306) · ae1e6f70

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/090fae83548a...08aaa88bf67f

2023-06-21 mark@lazycat.hu Enabling pre-push checks on Windows (flutter/engine#36123)
2023-06-21 godofredoc@google.com Document the use of contexts on engine_v2 tests. (flutter/engine#43013)
2023-06-21 godofredoc@google.com Generate treemap. (flutter/engine#43029)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ae1e6f70

[framework,web] add FlutterTimeline and semantics benchmarks that use it (#128366) · 07772a3d

Yegor authored Jun 21, 2023

## FlutterTimeline

Add a new class `FlutterTimeline` that's a drop-in replacement for `Timeline` from `dart:developer`. In addition to forwarding invocations of `startSync`, `finishSync`, `timeSync`, and `instantSync` to `dart:developer`, provides the following extra methods that make is easy to collect timings for code blocks on a frame-by-frame basis:

* `debugCollect()` - aggregates timings since the last reset, or since the app launched.
* `debugReset()` - forgets all data collected since the previous reset, or since the app launched. This allows clearing data from previous frames so timings can be attributed to the current frame.
* `now` - this was enhanced so that it works on the web by calling `window.performance.now` (in `Timeline` this is a noop in Dart web compilers).
* `collectionEnabled` - a field that controls whether `FlutterTimeline` stores timings in memory. By default this is disabled to avoid unexpected overhead (although the class is designed for minimal and predictable overhead). Specific benchmarks can enable collection to report to Skia Perf.

## Semantics benchmarks

Add `BenchMaterial3Semantics` that benchmarks the cost of semantics when constructing a screen full of Material 3 widgets from nothing. It is expected that semantics will have non-trivial cost in this case, but we should strive to keep it much lower than the rendering cost. This is the case already. This benchmark shows that the cost of semantics is <10%.

Add `BenchMaterial3ScrollSemantics` that benchmarks the cost of scrolling a previously constructed screen full of Material 3 widgets. The expectation should be that semantics will have trivial cost, since we're just shifting some widgets around. As of today, the numbers are not great, with semantics taking >50% of frame time, which is what prompted this PR in the first place. As we optimize this, we want to see this number improve.

07772a3d

Roll pub packages (#128966) · 22005779
Flutter GitHub Bot authored Jun 21, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
22005779
Remove incorrect non-nullable assumption from `ShapeDecoration.lerp` (#129298) · 28ca523a
Pierre-Louis authored Jun 21, 2023
```
Fixes https://github.com/flutter/flutter/issues/129299
```
28ca523a
Gracefully handle negative position in getWordAtOffset (#128464) · 16eb4f2c
Justin McCandless authored Jun 21, 2023
```
Should fix an unreproducible crash in text editing and track it with an assertion.
```
16eb4f2c
[flutter_tools] add a gradle error handler for could not open cache directory (#129222) · 5cef69dd
Christopher Fujino authored Jun 21, 2023
```
Works around part of https://github.com/flutter/flutter/issues/128866
```
5cef69dd

Roll Flutter Engine from f973fb4636d3 to 090fae83548a (5 revisions) (#129293) · d2c4b5a1

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/f973fb4636d3...090fae83548a

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from c983b97d03a8 to 7eeb94b1e778 (4 revisions) (flutter/engine#43045)
2023-06-21 godofredoc@google.com Move android emulator tests to v2. (flutter/engine#43008)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 65f30e5804c7 to c983b97d03a8 (2 revisions) (flutter/engine#43044)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7121db7c6dc2 to 65f30e5804c7 (3 revisions) (flutter/engine#43043)
2023-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 178d3d1184cb to 88fa9330633e (1 revision) (flutter/engine#43041)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2c4b5a1