1. 09 Jan, 2024 1 commit
    • Michael Goderbauer's avatar
      Reapply "Dynamic view sizing" (#140165) (#140918) · 4534a24c
      Michael Goderbauer authored
      This reverts commit
      https://github.com/flutter/flutter/commit/d24c01bd0c41331bd17165e0173b24c5d05d7c0a.
      
      The original change was reverted because it caused some apps to get
      stuck on the splash screen on some phones.
      
      An investigation determined that this was due to a rounding error.
      Example: The device reports a physical size of 1008.0 x 2198.0 with a
      dpr of 1.912500023841858. Flutter would translate that to a logical size
      of 527.0588169589221 x 1149.2810314243163 and use that as the input for
      its layout algorithm. Since the constraints here are tight, the layout
      algorithm would determine that the resulting logical size of the root
      render object must be 527.0588169589221 x 1149.2810314243163.
      Translating this back to physical pixels by applying the dpr resulted in
      a physical size of 1007.9999999999999 x 2198.0 for the frame. Android
      now rejected that frame because it didn't match the expected size of
      1008.0 x 2198.0 and since no frame had been rendered would never take
      down the splash screen.
      
      Prior to dynamically sized views, this wasn't an issue because we would
      hard-code the frame size to whatever the requested size was.
      
      Changes in this PR over the original PR:
      
      * The issue has been fixed now by constraining the calculated physical
      size to the input physical constraints which makes sure that we always
      end up with a size that is acceptable to the operating system.
      * The `ViewConfiguration` was refactored to use the slightly more
      convenient `BoxConstraints` over the `ViewConstraints` to represent
      constraints. Both essentially represent the same thing, but
      `BoxConstraints` are more powerful and we avoid a couple of translations
      between the two by translating the` ViewConstraints` from the
      `FlutterView` to `BoxConstraints` directly when the `ViewConfiguration`
      is created.
      
      All changes over the original PR are contained in the second commit of
      this PR.
      
      Fixes b/316813075
      Part of https://github.com/flutter/flutter/issues/134501.
      4534a24c
  2. 20 Dec, 2023 1 commit
  3. 14 Dec, 2023 1 commit
  4. 29 Nov, 2023 1 commit
  5. 27 Nov, 2023 1 commit
  6. 08 Nov, 2023 1 commit
  7. 31 Oct, 2023 1 commit
  8. 01 Sep, 2023 2 commits
  9. 25 Aug, 2023 1 commit
  10. 23 Aug, 2023 1 commit
    • Michael Goderbauer's avatar
      Remove deprecated *TestValues from TestWindow (#131098) · ad78cf35
      Michael Goderbauer authored
      Part of https://github.com/flutter/flutter/issues/133171.
      
      Removes from `TestWindow`:
      * `localeTestValue`
      * `clearLocaleTestValue`
      * `localesTestValue`
      * `clearLocalesTestValue`
      * `initialLifecycleStateTestValue`
      * `alwaysUse24HourFormatTestValue`
      * `clearAlwaysUse24HourTestValue`
      * `brieflyShowPasswordTestValue`
      * `defaultRouteNameTestValue`
      * `clearDefaultRouteNameTestValue`
      * `semanticsEnabledTestValue`
      * `clearSemanticsEnabledTestValue`
      * `accessibilityFeaturesTestValue`
      * `clearAccessibilityFeaturesTestValue`
      
      These properties have reached the end of their deprecation period.
      ad78cf35
  11. 10 Aug, 2023 1 commit
  12. 07 Jun, 2023 1 commit
  13. 06 Jun, 2023 1 commit
  14. 05 Jun, 2023 1 commit
  15. 02 Jun, 2023 1 commit
  16. 26 May, 2023 1 commit
  17. 21 Mar, 2023 2 commits
  18. 15 Mar, 2023 1 commit
  19. 14 Mar, 2023 2 commits
  20. 13 Mar, 2023 1 commit
  21. 10 Mar, 2023 1 commit
    • Casey Hillers's avatar
      Revert PRs relating to single window assumption (#122369) · 1f426123
      Casey Hillers authored
      * Revert "Remove references to BindingBase.window (#122119)"
      
      This reverts commit c7681f00.
      
      * Revert "Remove another reference to BindingBase.window (#122341)"
      
      This reverts commit 6ec44450.
      
      * Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)"
      
      This reverts commit eb3d317e.
      
      * Revert "Remove single view assumption from TestViewConfiguration (#122352)"
      
      This reverts commit 927289fb.
      
      * Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)"
      
      This reverts commit 67e17e45.
      
      * Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)"
      
      This reverts commit c2a5111c.
      
      * Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)"
      
      This reverts commit 28b65e08.
      
      * Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)"
      
      This reverts commit 01367d52.
      1f426123
  22. 09 Mar, 2023 1 commit
  23. 08 Mar, 2023 1 commit
  24. 07 Mar, 2023 1 commit
  25. 06 Mar, 2023 2 commits
  26. 05 Mar, 2023 1 commit
  27. 02 Mar, 2023 2 commits
  28. 22 Feb, 2023 1 commit
  29. 07 Nov, 2022 1 commit
  30. 26 Oct, 2022 1 commit
  31. 10 Oct, 2022 1 commit
  32. 17 Aug, 2022 1 commit
  33. 16 Aug, 2022 2 commits
  34. 06 Jul, 2022 1 commit