- 09 Jan, 2024 1 commit
-
-
Michael Goderbauer authored
This reverts commit https://github.com/flutter/flutter/commit/d24c01bd0c41331bd17165e0173b24c5d05d7c0a. The original change was reverted because it caused some apps to get stuck on the splash screen on some phones. An investigation determined that this was due to a rounding error. Example: The device reports a physical size of 1008.0 x 2198.0 with a dpr of 1.912500023841858. Flutter would translate that to a logical size of 527.0588169589221 x 1149.2810314243163 and use that as the input for its layout algorithm. Since the constraints here are tight, the layout algorithm would determine that the resulting logical size of the root render object must be 527.0588169589221 x 1149.2810314243163. Translating this back to physical pixels by applying the dpr resulted in a physical size of 1007.9999999999999 x 2198.0 for the frame. Android now rejected that frame because it didn't match the expected size of 1008.0 x 2198.0 and since no frame had been rendered would never take down the splash screen. Prior to dynamically sized views, this wasn't an issue because we would hard-code the frame size to whatever the requested size was. Changes in this PR over the original PR: * The issue has been fixed now by constraining the calculated physical size to the input physical constraints which makes sure that we always end up with a size that is acceptable to the operating system. * The `ViewConfiguration` was refactored to use the slightly more convenient `BoxConstraints` over the `ViewConstraints` to represent constraints. Both essentially represent the same thing, but `BoxConstraints` are more powerful and we avoid a couple of translations between the two by translating the` ViewConstraints` from the `FlutterView` to `BoxConstraints` directly when the `ViewConfiguration` is created. All changes over the original PR are contained in the second commit of this PR. Fixes b/316813075 Part of https://github.com/flutter/flutter/issues/134501.
-
- 20 Dec, 2023 1 commit
-
-
Michael Goderbauer authored
These were not ignoring anything (anymore).
-
- 14 Dec, 2023 1 commit
-
-
Lau Ching Jun authored
Reverts flutter/flutter#138648 This caused the app to be stuck in the splash screen on certain phone models. Context: b/316244317
-
- 29 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Towards https://github.com/flutter/flutter/issues/134501. This change is based on https://github.com/flutter/engine/pull/48090. It changes the `RenderView` to be dynamically sized based on its content if the `FlutterView` it is configured with allows it (i.e. the `FlutterView` has loose `FlutterView.physicalConstraints`). For that, it uses those `physicalConstraints` as input to the layout algorithm by passing them on to its child (after translating them to logical constraints via the device pixel ratio). The resulting `Size` that the `RenderView` would like to be is then communicated back to the engine by passing it to the `FlutterView.render` call. Tests will fail until https://github.com/flutter/engine/pull/48090 has rolled into the framework.
-
- 27 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Towards https://github.com/flutter/flutter/issues/134501. Required to roll https://github.com/flutter/engine/pull/48090 into the framework. **DO NOT SUBMIT until https://github.com/flutter/flutter/pull/138648 and https://github.com/flutter/engine/pull/48090 are ready.**
-
- 08 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery. Related engine PR: https://github.com/flutter/engine/pull/47825
-
- 31 Oct, 2023 1 commit
-
-
Hrishikesh Kadam authored
-
- 01 Sep, 2023 2 commits
-
-
Renzo Olivares authored
Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue (#133178) Part of: https://github.com/flutter/flutter/issues/133171
-
Renzo Olivares authored
Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue (#133176) Part of: https://github.com/flutter/flutter/issues/133171
-
- 25 Aug, 2023 1 commit
-
-
Kate Lovett authored
-
- 23 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Part of https://github.com/flutter/flutter/issues/133171. Removes from `TestWindow`: * `localeTestValue` * `clearLocaleTestValue` * `localesTestValue` * `clearLocalesTestValue` * `initialLifecycleStateTestValue` * `alwaysUse24HourFormatTestValue` * `clearAlwaysUse24HourTestValue` * `brieflyShowPasswordTestValue` * `defaultRouteNameTestValue` * `clearDefaultRouteNameTestValue` * `semanticsEnabledTestValue` * `clearSemanticsEnabledTestValue` * `accessibilityFeaturesTestValue` * `clearAccessibilityFeaturesTestValue` These properties have reached the end of their deprecation period.
-
- 10 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/132274.
-
- 07 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
- 06 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
- 05 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
- 02 Jun, 2023 1 commit
-
-
- 26 May, 2023 1 commit
-
-
pdblasi-google authored
* Adds `TestDisplay` * Updates `TestPlatformDispatcher` to wrap all `Display`s and relate them to their appropriate `TestFlutterView` * Updates `TestFlutterView` to tie `devicePixelRatio` to its display as per the documentation on `Display` Closes #127225
-
- 21 Mar, 2023 2 commits
-
-
Michael Goderbauer authored
Deprecate BindingBase.window
-
pdblasi-google authored
Deprecates `TestWindow`
-
- 15 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland: Updates `flutter/test/material` to no longer use `TestWindow`
-
- 14 Mar, 2023 2 commits
-
-
yaakovschectman authored
This reverts commit b2fc5f97.
-
pdblasi-google authored
Updates `flutter/test/material` to no longer use `TestWindow`
-
- 13 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland (3): Removes single window assumptions from `flutter_test`
-
- 10 Mar, 2023 1 commit
-
-
Casey Hillers authored
* Revert "Remove references to BindingBase.window (#122119)" This reverts commit c7681f00. * Revert "Remove another reference to BindingBase.window (#122341)" This reverts commit 6ec44450. * Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)" This reverts commit eb3d317e. * Revert "Remove single view assumption from TestViewConfiguration (#122352)" This reverts commit 927289fb. * Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)" This reverts commit 67e17e45. * Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)" This reverts commit c2a5111c. * Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)" This reverts commit 28b65e08. * Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)" This reverts commit 01367d52.
-
- 09 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland (2): Removes single window assumptions from `flutter_test`
-
- 08 Mar, 2023 1 commit
-
-
Casey Hillers authored
Revert "Reland: Removes single window assumptions from `flutter_test`"
-
- 07 Mar, 2023 1 commit
-
-
pdblasi-google authored
Reland: Removes single window assumptions from `flutter_test`
-
- 06 Mar, 2023 2 commits
-
-
pdblasi-google authored
This reverts commit f2dd19d5.
-
pdblasi-google authored
Removes single window assumptions from `flutter_test`
-
- 05 Mar, 2023 1 commit
-
-
Jason Simmons authored
-
- 02 Mar, 2023 2 commits
-
-
Michael Goderbauer authored
Remove all traces of ViewConfiguration/PlatformConfiguration
-
Michael Goderbauer authored
-
- 22 Feb, 2023 1 commit
-
-
Michael Goderbauer authored
* Rename WindowPadding to ViewPadding * dart fix * typos
-
- 07 Nov, 2022 1 commit
-
-
Jason Simmons authored
This restores the updateSemantics capability in TestWindow that had been removed in https://github.com/flutter/flutter/pull/113382
-
- 26 Oct, 2022 1 commit
-
-
Alex Wallen authored
-
- 10 Oct, 2022 1 commit
-
-
Jonah Williams authored
-
- 17 Aug, 2022 1 commit
-
-
Camille Simon authored
-
- 16 Aug, 2022 2 commits
-
-
Jonah Williams authored
This reverts commit ff9fe356.
-
Camille Simon authored
-
- 06 Jul, 2022 1 commit
-
-
Xilai Zhang authored
* Revert "Reland "Clipping if only one character text overflows (#99146)" (#102130)" This reverts commit 3f43d9f3. * Revert "Implement frameData for TestWindow (#105537)" This reverts commit 21841d7e.
-