Commits · 102e60254477fb470c3b7c8a4b3dcc015ef9d9bf · abdullh.alsoleman / Front-End

01 Nov, 2023 14 commits

Roll Flutter Engine from 49d3ce9c2ae3 to 406f0c477afb (5 revisions) (#137720) · 102e6025

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/49d3ce9c2ae3...406f0c477afb

2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 84e1dc3af49e to 613abdf2c895 (4 revisions) (flutter/engine#47560)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 4594e2ef3ee8 to 84e1dc3af49e (1 revision) (flutter/engine#47558)
2023-11-01 jason-simmons@users.noreply.github.com Consolidate all the copies of the OpenFixtureAsSkData testing helper function (flutter/engine#47491)
2023-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 15558b6ae7d5 to e6df03a57636 (1 revision) (flutter/engine#47556)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 816d41255105 to 4594e2ef3ee8 (1 revision) (flutter/engine#47555)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

102e6025

reset state of CustomSemanticsAction before running tests (#137697) · d843863c

Dan Field authored Nov 01, 2023

Fixes https://github.com/flutter/flutter/issues/137696

This will get the tree green again.

The problem is that `CustomSemanticsAction` has static state in it, and todays test seed order makes things unhappy.

d843863c

Roll Flutter Engine from 8ffc705a55d5 to 49d3ce9c2ae3 (7 revisions) (#137707) · ba75e7a0

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/8ffc705a55d5...49d3ce9c2ae3

2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 8fabb1ce2065 to 816d41255105 (1 revision) (flutter/engine#47553)
2023-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _TyF0etsONe5aqCbM... to G6icdRMZm9dD9Oky1... (flutter/engine#47551)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from b7ac9da3e5ac to 8fabb1ce2065 (1 revision) (flutter/engine#47550)
2023-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 62aceb5e057d to 15558b6ae7d5 (1 revision) (flutter/engine#47549)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from f1983b5af2ef to b7ac9da3e5ac (1 revision) (flutter/engine#47548)
2023-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from x2NzYMNhyodIwDl0I... to Lrg_lElxg0BmYp97-... (flutter/engine#47547)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 83d6345dd3c2 to f1983b5af2ef (2 revisions) (flutter/engine#47541)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _TyF0etsONe5 to G6icdRMZm9dD
fuchsia/sdk/core/mac-amd64 from x2NzYMNhyodI to Lrg_lElxg0Bm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba75e7a0

Unified analytics events migration for `BuildEvent` (#137562) · 70456f5b
Elias Yishak authored Nov 01, 2023
```
Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251
```
70456f5b

Fix. typos (#137479) · 01b88540

Binni Goel authored Nov 01, 2023

## Description

This PR fixes typos in 
- `editable_text_show_on_screen_test.dart`
- `form_test.dart`
- `framework.dart`

01b88540

Bumping version tag of provisioning profile cipd package. (#137710) · c6179370

yusuf-goog authored Nov 01, 2023

Bug:https://github.com/flutter/flutter/issues/137166

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c6179370

Roll Packages from c9fec61b6cde to 6ad40b9a07d3 (7 revisions) (#137702) · 9e48db47

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/packages/compare/c9fec61b6cde...6ad40b9a07d3

2023-11-01 engine-flutter-autoroll@skia.org Roll Flutter from e12d1a79 to 29b25165 (34 revisions) (flutter/packages#5290)
2023-11-01 stuartmorgan@google.com [file_selector] Updates iOS to Pigeon 13 (flutter/packages#5268)
2023-10-31 github@alexv525.com [camera_avfoundation] ð Fix inverted orientation strings (flutter/packages#5261)
2023-10-31 43054281+camsim99@users.noreply.github.com [tool] Add option for Android compile SDK version to update-dependencies command (flutter/packages#5010)
2023-10-31 stuartmorgan@google.com [video_player] Update iOS/macOS to Pigeon 13 (flutter/packages#5270)
2023-10-31 tessertaha@gmail.com [video_player] Update example app to replace `ButtonBar` with `OverflowBar` (flutter/packages#5274)
2023-10-31 stuartmorgan@google.com [image_picker] Update iOS to Pigeon 13 (flutter/packages#5266)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e48db47

Add no-shuffle to reorderable_list_test.dart (#137698) · 26300476
Zachary Anderson authored Nov 01, 2023
```
For https://github.com/flutter/flutter/issues/137696
```
26300476

Roll Flutter Engine from 5ef5e6da9075 to 8ffc705a55d5 (2 revisions) (#137664) · 29b25165

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/5ef5e6da9075...8ffc705a55d5

2023-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 448293573e98 to 62aceb5e057d (1 revision) (flutter/engine#47540)
2023-11-01 skia-flutter-autoroll@skia.org Roll Skia from 34ef20100acc to 83d6345dd3c2 (1 revision) (flutter/engine#47538)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29b25165

Roll Flutter Engine from a0ac6b432cdf to 5ef5e6da9075 (1 revision) (#137657) · 5022d284

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/a0ac6b432cdf...5ef5e6da9075

2023-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 99fa0283f9d7 to 448293573e98 (1 revision) (flutter/engine#47534)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5022d284

Roll Flutter Engine from db06c2e10459 to a0ac6b432cdf (8 revisions) (#137656) · 1333e16a

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/db06c2e10459...a0ac6b432cdf

2023-11-01 bdero@google.com [Impeller] Include cstdint everywhere that uint32_t is used. (flutter/engine#47533)
2023-11-01 bdero@google.com [Impeller] Fix nullopt access and simplify coverage computation in GetSubpassCoverage. (flutter/engine#47347)
2023-11-01 bdero@google.com [Impeller] OpenGLES: Ensure frag/vert textures are bound with unique texture units. (flutter/engine#47218)
2023-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LCfhx_lTRJI51G0zc... to _TyF0etsONe5aqCbM... (flutter/engine#47532)
2023-11-01 jonahwilliams@google.com [Impeller] stencil buffer record/replay instead of MSAA storage. (flutter/engine#47397)
2023-11-01 chris@bracken.jp [macOS] Delete FlutterCompositor tests (flutter/engine#47527)
2023-10-31 bdero@google.com [Impeller] Place Rect statics under the Rect template. (flutter/engine#47529)
2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from aaa225e0cc6d to 34ef20100acc (1 revision) (flutter/engine#47530)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LCfhx_lTRJI5 to _TyF0etsONe5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1333e16a

Add dependency on leak_tracker and leak_tracker_testing to flutter_test. (#137646) · d50f1fa9
Polina Cherkasova authored Nov 01, 2023

d50f1fa9

Roll Flutter Engine from 406b7d71ca37 to db06c2e10459 (5 revisions) (#137651) · 635f18d3

engine-flutter-autoroll authored Nov 01, 2023

https://github.com/flutter/engine/compare/406b7d71ca37...db06c2e10459

2023-10-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rg_Ici1tgAVF93cn9... to x2NzYMNhyodIwDl0I... (flutter/engine#47528)
2023-10-31 30870216+gaaclarke@users.noreply.github.com [Impeller] updated ios benchmark link (flutter/engine#47515)
2023-10-31 30870216+gaaclarke@users.noreply.github.com Made clang tidy use arm64 if on an arm64 mac. (flutter/engine#47494)
2023-10-31 bdero@google.com [Impeller] Allow 3D scenes to render when MSAA is not supported. (flutter/engine#47217)
2023-10-31 matanlurey@users.noreply.github.com Surgically remove `.*dither.*` from the Engine (flutter/engine#46750)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rg_Ici1tgAVF to x2NzYMNhyodI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

635f18d3

Roll pub packages (#137650) · c9e9c085
flutter-pub-roller-bot authored Nov 01, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
c9e9c085

31 Oct, 2023 23 commits

Manual roll Flutter Engine from 39be0fc34503 to 406b7d71ca37 (8 revisions) (#137649) · 58c06e0f

engine-flutter-autoroll authored Oct 31, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/39be0fc34503...406b7d71ca37

2023-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from eecb650a0fb9 to 99fa0283f9d7 (1 revision) (flutter/engine#47526)
2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from 998e19071734 to aaa225e0cc6d (1 revision) (flutter/engine#47524)
2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from cc751f5d50ea to 998e19071734 (1 revision) (flutter/engine#47522)
2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from 2f7e5dbb8521 to cc751f5d50ea (1 revision) (flutter/engine#47519)
2023-10-31 jacksongardner@google.com Move flutter.js into the engine. (flutter/engine#47240)
2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from b3360479118f to 2f7e5dbb8521 (1 revision) (flutter/engine#47517)
2023-10-31 jason-simmons@users.noreply.github.com [Impeller] Do not return a null Contents if a Paint's blur filter yields an empty coverage rect (flutter/engine#47496)
2023-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 776fad25647a to eecb650a0fb9 (1 revision) (flutter/engine#47514)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58c06e0f

PerformanceModeRequestHandle should dispatch creation and disposal events. (#137642) · cdcacd06
Kostia Sokolovskyi authored Oct 31, 2023

cdcacd06
Fix minor typo in doc of window.dart (#137483) · 64d39370
Hrishikesh Kadam authored Oct 31, 2023

64d39370

fix. typos (#137178) · e7726ea6

Binni Goel authored Oct 31, 2023

## Description

This PR fixes typos in 
- `checkbox.dart`
- `chip_test.dart`
- `color_scheme.dart`
- `color_scheme_test.dart`
- `curves.dart`

e7726ea6

Document the scale argument to NetworkImage (#137456) · 5160c5e1
Todd Volkert authored Oct 31, 2023
```
Add docs to NetworkImage constructor
```
5160c5e1
Revert "Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions)" (#137647) · ad13cbd0
Jason Simmons authored Oct 31, 2023
```
This reverts commit 7a3297eb.

This roll contains a Dart SDK change that is causing crashes in Flutter
apps.
```
ad13cbd0

Move dependency on leak_tracker from dependencies to dev_dependencies in flutter_test. (#137633) · bcf26735

Polina Cherkasova authored Oct 31, 2023

Analyzer's dependency on autosnapshotting causes issues.

Because every version of integration_test from sdk depends on leak_tracker from hosted and autosnapshotting depends on leak_tracker from path, integration_test from sdk is forbidden.
So, because autosnapshotting depends on integration_test from sdk, version solving failed.

bcf26735

Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions) (#137637) · 7a3297eb

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/39be0fc34503...ec3e988099be

2023-10-31 jason-simmons@users.noreply.github.com [Impeller] Do not return a null Contents if a Paint's blur filter yields an empty coverage rect (flutter/engine#47496)
2023-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 776fad25647a to eecb650a0fb9 (1 revision) (flutter/engine#47514)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a3297eb

Roll Flutter Engine from 4da3e5b12540 to 39be0fc34503 (4 revisions) (#137635) · ea50b72d

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/4da3e5b12540...39be0fc34503

2023-10-31 matanlurey@users.noreply.github.com [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495)
2023-10-31 flar@google.com [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430)
2023-10-31 khalidcomilla58@gmail.com [Typo fixed] in DEPS (flutter/engine#47440)
2023-10-31 jonahwilliams@google.com [Impeller] Restore GLES GPU query times. (flutter/engine#47511)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea50b72d

Update `ColorScheme.light`, `ColorScheme.dark`,... · b547e0e4

Taha Tesser authored Oct 31, 2023

Update `ColorScheme.light`, `ColorScheme.dark`, `ColorScheme.highContrastLight`, & `ColorScheme.highContrastDark`  constructors docs for Material 3 (#137149)

fixes [Clarify ColorScheme fromSwatch/fromSeed usage](https://github.com/flutter/flutter/issues/132584)

"This explains how to use `ColorScheme.fromSeed` as a substitute for each `ColorScheme` constructor."

| `ColorScheme.light` (left) to `ColorScheme.fromSeed` (right) | 
| --------------- | 
| ![light](https://github.com/flutter/flutter/assets/48603081/e056e723-5640-4b05-8feb-ca6b517c8682)	|

| `ColorScheme.dark` (left) to `ColorScheme.fromSeed` (right) | 
| --------------- | 
| ![dark](https://github.com/flutter/flutter/assets/48603081/5ff32611-bfb6-49ee-a34e-f935f580e84e)	|

| `ColorScheme.highContrastLight` (left) to `ColorScheme.fromSeed` (right) | 
| --------------- | 
| ![highContrastLight](https://github.com/flutter/flutter/assets/48603081/4b47f2e3-ea8e-4148-85cc-69690e9082c7) |

| `ColorScheme.highContrastDark` (left) to `ColorScheme.fromSeed` (right) | 
| --------------- | 
| ![highContrastDark](https://github.com/flutter/flutter/assets/48603081/3dbd7ec4-c78e-4228-a8ed-673832681563) |

b547e0e4

Roll Flutter Engine from 47465eb4fbe6 to 4da3e5b12540 (2 revisions) (#137632) · 61f89b8c

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/47465eb4fbe6...4da3e5b12540

2023-10-31 katelovett@google.com Bump goldctl (flutter/engine#47391)
2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from 065f0d2302ca to b3360479118f (4 revisions) (flutter/engine#47510)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61f89b8c

Fix. typos (#137465) · 231bfac8

Binni Goel authored Oct 31, 2023

## Description

This PR fixes typos in 
- `date_picker.dart`
- `date_picker_theme.dart`
- `dropdown.dart`

231bfac8

Roll Flutter Engine from 9de8146d21bf to 47465eb4fbe6 (1 revision) (#137626) · f40c9f47

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/9de8146d21bf...47465eb4fbe6

2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from 40223641388b to 065f0d2302ca (2 revisions) (flutter/engine#47509)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f40c9f47

Roll Flutter Engine from 6b9b806151ed to 9de8146d21bf (1 revision) (#137624) · 55cdca43

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/6b9b806151ed...9de8146d21bf

2023-10-31 skia-flutter-autoroll@skia.org Roll Skia from 817fca468240 to 40223641388b (19 revisions) (flutter/engine#47507)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55cdca43

Roll Packages from 2af69541a214 to c9fec61b6cde (12 revisions) (#137623) · 61225b9d

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/packages/compare/2af69541a214...c9fec61b6cde

2023-10-31 stuartmorgan@google.com [image_picker] Prevent multiple active calls on iOS (flutter/packages#5272)
2023-10-30 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Add missing response code to BillingResponse enum (flutter/packages#5120)
2023-10-30 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.4 to 2.22.5 (flutter/packages#5263)
2023-10-30 john@johnmccutchan.com Bump play-service-maps dependency from version 18.1.0 to 18.2.0 (flutter/packages#5243)
2023-10-30 engine-flutter-autoroll@skia.org Roll Flutter from a4ec6278 to e12d1a79 (3 revisions) (flutter/packages#5267)
2023-10-30 43054281+camsim99@users.noreply.github.com [camerax] Loosen restrictions of fallback strategies for choosing resolutions (flutter/packages#5239)
2023-10-30 stuartmorgan@google.com [pigeon] Don't wrap non-nullable primitives in Obj-C (flutter/packages#5214)
2023-10-30 1838962+tatsuyafujisaki@users.noreply.github.com [flutter_lints] Replace "flutter pub add --dev" with "dev:" (flutter/packages#5260)
2023-10-28 engine-flutter-autoroll@skia.org Roll Flutter from 5907c975 to a4ec6278 (18 revisions) (flutter/packages#5255)
2023-10-27 hrkadam.92@gmail.com [go_router] Fixes deep-link with no path on cold start (flutter/packages#5113)
2023-10-27 katelovett@google.com [two_dimensional_scrollables] Fix pinned row painting when one axis is reversed (flutter/packages#5187)
2023-10-27 engine-flutter-autoroll@skia.org Roll Flutter from c555599f to 5907c975 (45 revisions) (flutter/packages#5252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61225b9d

Fix divide-by-zero crash in animation_bench benchmark (#137539) · 4d0c487f

William Hesse authored Oct 31, 2023

If the benchmark runs out of time before it closes the drawer it is animating, it tries to divide by zero when computing the time per frame.

Don't report time per frame for activities with zero frames. This likely only happens for the close frame action, but guards are added to all time per frame computations in this benchmark.

4d0c487f

Roll Flutter Engine from 11a569d97a26 to 6b9b806151ed (1 revision) (#137617) · 0d3cf281

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/11a569d97a26...6b9b806151ed

2023-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a80a8adf898 to 776fad25647a (1 revision) (flutter/engine#47505)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d3cf281

Fix formatting (#137613) · 4f606f79

Daco Harkes authored Oct 31, 2023

Badly formatted code causes distraction when reading, and costs people energy when understanding code.

4f606f79

Roll Flutter Engine from 5ca5cbb6efdb to 11a569d97a26 (1 revision) (#137612) · 69c2ab4f

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/5ca5cbb6efdb...11a569d97a26

2023-10-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0D7msIyC3p_BdEY03... to LCfhx_lTRJI51G0zc... (flutter/engine#47503)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0D7msIyC3p_B to LCfhx_lTRJI5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

69c2ab4f

Roll Flutter Engine from b4de734eb78e to 5ca5cbb6efdb (1 revision) (#137610) · c0d0e646

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/b4de734eb78e...5ca5cbb6efdb

2023-10-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sBjtpAHoetjF77qxg... to rg_Ici1tgAVF93cn9... (flutter/engine#47502)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from sBjtpAHoetjF to rg_Ici1tgAVF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0d0e646

Roll Flutter Engine from 17eff7ab6299 to b4de734eb78e (1 revision) (#137594) · 13c049b4

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/17eff7ab6299...b4de734eb78e

2023-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 9cc76cb23b8c to 2a80a8adf898 (1 revision) (flutter/engine#47501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13c049b4

Roll Flutter Engine from 44309c9f385c to 17eff7ab6299 (2 revisions) (#137587) · deeb6a2d

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/44309c9f385c...17eff7ab6299

2023-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from c8f75afabaf1 to 9cc76cb23b8c (1 revision) (flutter/engine#47498)
2023-10-30 chris@bracken.jp [macOS] Wrap external texture tests in autorelease pool (flutter/engine#47492)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

deeb6a2d

Roll Flutter Engine from 64b0e07e2259 to 44309c9f385c (1 revision) (#137584) · 0d10c2ec

engine-flutter-autoroll authored Oct 31, 2023

https://github.com/flutter/engine/compare/64b0e07e2259...44309c9f385c

2023-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zf2xLsbeoVrbnEDiH... to 0D7msIyC3p_BdEY03... (flutter/engine#47490)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zf2xLsbeoVrb to 0D7msIyC3p_B

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d10c2ec

30 Oct, 2023 3 commits

Roll Flutter Engine from 4f87c20b3c34 to 64b0e07e2259 (4 revisions) (#137582) · 6f19c7b5

engine-flutter-autoroll authored Oct 30, 2023

https://github.com/flutter/engine/compare/4f87c20b3c34...64b0e07e2259

2023-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jCjz-imbNBDjiRVa1... to sBjtpAHoetjF77qxg... (flutter/engine#47482)
2023-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 85e149f894df to c8f75afabaf1 (1 revision) (flutter/engine#47479)
2023-10-30 zanderso@users.noreply.github.com Update package:equatable pin (flutter/engine#47475)
2023-10-30 matanlurey@users.noreply.github.com [Impeller] Switch from `glBlitFramebuffer` to implicit MSAA resolution. (flutter/engine#47282)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jCjz-imbNBDj to sBjtpAHoetjF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f19c7b5

Manual roll Flutter Engine from 84dcb4fb9301 to 4f87c20b3c34 (24 revisions) (#137570) · 149459d2

engine-flutter-autoroll authored Oct 30, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/84dcb4fb9301...4f87c20b3c34

2023-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from
5a666e8d8259 to 85e149f894df (6 revisions) (flutter/engine#47470)
2023-10-30 dacoharkes@google.com [deps] Stop moving NDK folder inside
Android SDK (flutter/engine#47454)
2023-10-30 jonahwilliams@google.com Revert "[Impeller] remove image
upload workarounds." (flutter/engine#47402)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from 89250a0bd6bb to
817fca468240 (3 revisions) (flutter/engine#47465)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from 006424658682 to
89250a0bd6bb (3 revisions) (flutter/engine#47463)
2023-10-30 chinmaygarde@google.com Migrate inja, sqlite, libtess2 to
//flutter/third_party. (flutter/engine#47408)
2023-10-30 zanderso@users.noreply.github.com Revert "Roll Dart SDK from
5a666e8d8259 to 38e8459ca2aa (4 revisions)" (flutter/engine#47459)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from 09818d8c9d3c to
006424658682 (1 revision) (flutter/engine#47458)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from 6e9cd1b79105 to
09818d8c9d3c (1 revision) (flutter/engine#47456)
2023-10-30 kjlubick@users.noreply.github.com Remove call to
SkTypeface::MakeDefault (flutter/engine#47344)
2023-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LbIVijDVwcB56_wgv... to zf2xLsbeoVrbnEDiH... (flutter/engine#47452)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from c732ec7f5d74 to
6e9cd1b79105 (2 revisions) (flutter/engine#47451)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from e45946f89a8b to
c732ec7f5d74 (2 revisions) (flutter/engine#47448)
2023-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
OJfJYAvhpAkE-kvbY... to jCjz-imbNBDjiRVa1... (flutter/engine#47447)
2023-10-30 skia-flutter-autoroll@skia.org Roll Skia from 7545d1468268 to
e45946f89a8b (1 revision) (flutter/engine#47446)
2023-10-29 skia-flutter-autoroll@skia.org Roll Skia from e224e1dc5e2c to
7545d1468268 (1 revision) (flutter/engine#47444)
2023-10-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
v-9_Di17lm_C_mrpZ... to LbIVijDVwcB56_wgv... (flutter/engine#47443)
2023-10-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
s0pbwY5MGxyq0tNrT... to OJfJYAvhpAkE-kvbY... (flutter/engine#47439)
2023-10-29 skia-flutter-autoroll@skia.org Roll Skia from d29cc3fe182f to
e224e1dc5e2c (1 revision) (flutter/engine#47438)
2023-10-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
nreLekedxzmcdb3ww... to v-9_Di17lm_C_mrpZ... (flutter/engine#47436)
2023-10-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
qiHQ7aarDQb_1Rq3G... to s0pbwY5MGxyq0tNrT... (flutter/engine#47431)
2023-10-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
ESkamdoXWIwkdWdP-... to nreLekedxzmcdb3ww... (flutter/engine#47429)
2023-10-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
9YSl2rN0sj5YpYNdQ... to qiHQ7aarDQb_1Rq3G... (flutter/engine#47428)
2023-10-28 skia-flutter-autoroll@skia.org Roll Dart SDK from
5a666e8d8259 to 38e8459ca2aa (4 revisions) (flutter/engine#47426)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ESkamdoXWIwk to zf2xLsbeoVrb
  fuchsia/sdk/core/mac-amd64 from 9YSl2rN0sj5Y to jCjz-imbNBDj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

149459d2

[web] cache the base URL as root index.html (#136594) · 0d52630e

Pavel Mazhnik authored Oct 30, 2023

Fixes https://github.com/flutter/flutter/issues/136593

Caching of the base url was introduced in https://github.com/flutter/flutter/pull/53666 but resources can contain multiple `index.html` files, and currently hash of the **latest** asset will be assigned to the base url, which is not necessarily the root index.html

0d52630e