1. 16 Oct, 2018 1 commit
  2. 13 Oct, 2018 1 commit
    • Michael Goderbauer's avatar
      Remove all service extensions from release mode (#23038) · 8e2ca93f
      Michael Goderbauer authored
      Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size:
      
      Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB)
      APK (compressed): minus 38,136 Bytes (-37.24KB)
      iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB)
      
      For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit
      
      **Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
      8e2ca93f
  3. 05 Oct, 2018 2 commits
  4. 14 Sep, 2018 1 commit
  5. 12 Sep, 2018 1 commit
  6. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  7. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  8. 30 May, 2018 2 commits
  9. 28 May, 2018 1 commit
  10. 22 May, 2018 1 commit
  11. 12 Mar, 2018 2 commits
    • Alexander Aprelev's avatar
      Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f. (#15444) · 2f8474f9
      Alexander Aprelev authored
      * Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f.
      
      Changes since last roll:
      ```
      b6df7a637 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
      a6764dbd5 Add sources for Fuchsia target. (#4763)
      2d5900615 [fuchsia] Remove unused header file. (#4769)
      9717063b7 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
      9a9814312 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
      e74e8b35c [async] Update includes of async headers to new path (#4760)
      e2c4b2760 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
      9c1e48434 Updates for Fuchsia roll. (#4765)
      14c940e27 Switch from fxl::Mutex to std::mutex (#4764)
      debf82c0b Roll Garnet (#4759)
      5bffdefbb Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
      ```
      2f8474f9
    • Jason Simmons's avatar
      Use Dart 2 camel case constants (#15360) · 466d1543
      Jason Simmons authored
      466d1543
  12. 02 Mar, 2018 1 commit
  13. 09 Jan, 2018 1 commit
  14. 21 Dec, 2017 1 commit
  15. 07 Dec, 2017 1 commit
    • Ian Hickson's avatar
      Move image logic from services/ to painting/. (#13409) · 44e228eb
      Ian Hickson authored
      This allows the scheduler library to depend on the services library
      and the painting library to depend on the scheduler library without
      the services library having to depend on the scheduler library.
      
      While I was at it I also cleaned up some of the binding logic: the
      licenses logic can now be overridden (and the test library does so),
      and the image cache can now be overridden as well.
      44e228eb
  16. 21 Sep, 2017 1 commit
  17. 04 Aug, 2017 1 commit
  18. 05 May, 2017 1 commit
  19. 31 Mar, 2017 2 commits
  20. 29 Mar, 2017 1 commit
  21. 18 Feb, 2017 1 commit
  22. 03 Feb, 2017 1 commit
  23. 02 Feb, 2017 1 commit
  24. 09 Dec, 2016 1 commit
  25. 15 Sep, 2016 1 commit
  26. 02 Aug, 2016 1 commit
    • Ian Hickson's avatar
      Hot reload UI polish (#5193) · d7fb51a5
      Ian Hickson authored
      * General improvoments to the loader app:
         * Show a message after 8 seconds if no connection comes in.
         * Show a progress bar as files are being uploaded.
         * Hide the spinner just before launching the application.
      
      * General improvements to the "flutter run" UI:
         * Add "?" key as a silent alias for "h".
         * Make the help text bold so it doesn't get mixed with the logs.
         * Make "R" do a cold restart when hot reload is enabled.
      
      * Supporting features and bug fixes:
         * Add support for string service extensions.
      
      * Other bug fixes:
         * Expose debugDumpRenderTree() outside debug mode.
         * Logger.supportsColor was missing a getter.
         * Mention in the usage docs that --hot requires --resident.
         * Trivial style fixes.
      d7fb51a5
  27. 28 Jul, 2016 1 commit
    • Ian Hickson's avatar
      Some cleanup for hot reload (#5108) · 2b343a93
      Ian Hickson authored
      - show the next error fully after a hot reload
      - hide _AssertionError in stacks
      - immediately rebuild after a reassemble, so that hit tests work
      - catch errors when notifying global key listeners
      2b343a93
  28. 21 Jul, 2016 1 commit
    • Ian Hickson's avatar
      Licenses (#4984) · 69d78325
      Ian Hickson authored
      This makes the about page show the licenses of all the Dart packages that a Flutter app uses.
      
      Issues that this does not yet resolve:
      - I'm still working on getting the full list of licenses for the sky_engine package.
      - Some of the licenses don't print very readably.
      - There's no scrollbar on the license page.
      
      I'll provide fixes for the first two in the coming days, but this should unblock anyone who is wanting to see something here, even if it's not quite complete. :-)
      
      ----
      
      The patch makes the following changes: 
      
      - The license registry is now asynchronous, since the data comes from disk.
      - I moved the default license collector from the foundation package to the services package since it uses the default asset bundle now.
      - The FLX builder now includes the LICENSE files of each Dart package mentioned in the `.packages` file.
      69d78325
  29. 23 Jun, 2016 1 commit
  30. 25 May, 2016 1 commit
  31. 16 May, 2016 1 commit
  32. 04 May, 2016 1 commit
  33. 29 Apr, 2016 1 commit
  34. 22 Apr, 2016 2 commits
  35. 19 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Refactor service extensions (#3397) · 261923e5
      Ian Hickson authored
      Bindings now have a debugRegisterServiceExtensions() method that is
      invoked in debug mode (only). (Once we have a profile mode, there'll be
      a registerProfileServiceExtensions() method that gets called in that
      mode only to register extensions that apply then.)
      
      The BindingBase class provides convenience methods for registering
      service extensions that do the equivalent of:
      
      ```dart
      void extension() { ... }
      bool extension([bool enabled]) { ... }
      double extension([double extension])  { ... }
      Map<String, String> extension([Map<String, String> parameters]) { ... }
      ```
      
      The BindingBase class also itself registers ext.flutter.reassemble,
      which it has call a function on the binding called
      reassembleApplication().
      
      The Scheduler binding now exposes the preexisting
      ext.flutter.timeDilation.
      
      The Renderer binding now exposes the preexisting ext.flutter.debugPaint.
      
      The Renderer binding hooks reassembleApplication to trigger the
      rendering tree to be reprocessed (in particular, to fix up the
      optimisation closures).
      
      All the logic from rendering/debug.dart about service extensions is
      replaced by the above.
      
      I moved basic_types to foundation.
      
      The FlutterWidgets binding hooks reassembleApplication to trigger the
      widget tree to be entirely rebuilt.
      
      Flutter Driver now uses ext.flutter.driver instead of
      ext.flutter_driver, and is hooked using the same binding mechanism.
      Eventually we'll probably move the logic into the Flutter library so
      that you just get it without having to invoke a special method first.
      261923e5