- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 18 Sep, 2023 1 commit
-
-
Michael Goderbauer authored
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2. Part of https://github.com/flutter/flutter/issues/134476.
-
- 23 Aug, 2023 1 commit
-
-
Kate Lovett authored
Part of https://github.com/flutter/flutter/issues/133171
-
- 18 Feb, 2023 1 commit
-
-
Qun Cheng authored
Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 24 Jan, 2023 2 commits
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
Greg Spencer authored
* Remove ThemeData.buttonColor references * Fix test * Remove more buttonColors * Macro the definition of color scheme * remove doc reference
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 25 Aug, 2022 1 commit
-
-
Darren Austin authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 27 Apr, 2022 1 commit
-
-
Pierre-Louis authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 11 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 06 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 08 Mar, 2022 1 commit
-
-
Kate Lovett authored
-
- 01 Mar, 2022 1 commit
-
-
Viren Khatri authored
* migrates lib/foundation and lib/widgets * migrates lib/painting and lib/material * migrates lib/cupertino, lib/gestures, lib/services, lib/semantics and lib/rendering * fixes failing tests * migrates test/ * improves hashing of lists
-
- 10 May, 2021 1 commit
-
-
Hans Muller authored
-
- 23 Jan, 2021 1 commit
-
-
Kate Lovett authored
-
- 02 Nov, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 27 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 06 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate material to nullsafety * address review comments * address review comments * fix build
-
- 05 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 03 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
This reverts commit 81439922.
-
- 02 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate some material files to nullsafety * review
-
- 24 Aug, 2020 1 commit
-
-
Hans Muller authored
-
- 29 Jul, 2020 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 04 Jun, 2020 1 commit
-
-
Michael Rienstra authored
-
- 06 May, 2020 1 commit
-
-
Kate Lovett authored
-
- 06 Apr, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 11 Mar, 2020 1 commit
-
-
Greg Spencer authored
This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class. It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
-
- 09 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/material * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 22 Nov, 2019 1 commit
-
-
Alexandre Ardhuin authored
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic * make BuildContext.inheritFromWidgetOfExactType generic * make BuildContext.ancestorInheritedElementForWidgetOfExactType generic * make BuildContext.ancestorWidgetOfExactType generic * fix snippet * bump scoped_model on temp version * update names * Revert "bump scoped_model on temp version" This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0. * address review comments * fix ci * address review comments * repeat the deprecation notice * fix uppercase * use of recommanded deprecation syntax * address review comment
-
- 16 Nov, 2019 1 commit
-
-
Ian Hickson authored
-
- 17 Oct, 2019 1 commit
-
-
Shi-Hao Hong authored
This reverts commit 19899db2.
-
- 14 Oct, 2019 1 commit
-
-
Keshava Muraari authored
* Set default colorScheme for ButtonThemeData
-
- 24 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
-