1. 15 Dec, 2023 1 commit
  2. 07 Dec, 2023 1 commit
    • Jasper van Riet's avatar
      Introduce `exitDuration` to Tooltip for mouse pointer devices (#138321) · 3c422dd7
      Jasper van Riet authored
      This PR introduces a new property `exitDuration` to Tooltip, the counterpart to `waitDuration`. The need for this is shown by #136586. This changes the behaviour of `showDuration` on mouse pointer devices. This is because the use cases for the current behaviour on touch screen devices vs mouse pointer devices is fundamentally different.
      
      <details>
      <summary>Demo: tooltip with showDuration set</summary>
      
      Tooltip disappears after 100 ms when moving away the mouse. Tooltip will not disappear when hovered.
      
      https://github.com/flutter/flutter/assets/5138348/81d36dc9-78e0-4723-a84b-2552843ee181
      
      </details>
      
      Currently, when `showDuration` is set, this adjusts the time it takes for the tooltip to hide _after_ a mouse pointer has left the tooltip. This is not the same use case as its effect on touch screen devices, where it dictates how long the tooltip stays on screen after a long press. That is needed because the tooltip takes up screen space and there is not an intuitive way to hide it, whereas when using a mouse users expect to simply have to hover somewhere else. Having the tooltip stay around will look broken.
      
      Thus, this PR splits the two use cases. `showDuration` no longer affects mouse pointer devices at all*. There is a precedent for such mouse pointer-only behaviour in `waitDuration`. Instead, I have split up the two use cases and created the new property `exitDuration`, which will still allow for tweaking the time it takes for the tooltip to hide after the user has moved their mouse pointer somewhere else.
      
      *Note: Should `showDuration` affect [this line](https://github.com/flutter/flutter/blob/e33d4b86270e3c012ba13d68d6e90f2eabc4912b/packages/flutter/lib/src/material/tooltip.dart#L610)?
      
      Fixes #136586.
      
      Note: I noticed that when I made the change, no tests were broken. Hopefully, the tests added here help that in the future. I also noticed that in the _existing_ tests, the `waitDuration` tests contain assertions that implicate that it is the role of `waitDuration` to change this behaviour, but that's not currently (nor in the new behaviour) true, so I have fixed those tests.
      3c422dd7
  3. 06 Dec, 2023 1 commit
  4. 06 Oct, 2023 1 commit
  5. 05 Sep, 2023 1 commit
  6. 14 Aug, 2023 1 commit
  7. 09 Aug, 2023 1 commit
  8. 08 Aug, 2023 1 commit
  9. 07 Aug, 2023 1 commit
  10. 22 Jul, 2023 1 commit
  11. 16 Jun, 2023 1 commit
  12. 13 Jun, 2023 1 commit
    • Qun Cheng's avatar
      Update unit tests in material library for Material 3 (#128725) · a5f8b64e
      Qun Cheng authored
      Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true.
      
      All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version.
      
      related to #127064
      a5f8b64e
  13. 16 Feb, 2023 1 commit
  14. 02 Feb, 2023 1 commit
  15. 01 Feb, 2023 1 commit
  16. 23 Dec, 2022 1 commit
  17. 20 Dec, 2022 2 commits
  18. 17 Aug, 2022 1 commit
  19. 25 May, 2022 1 commit
  20. 20 May, 2022 2 commits
  21. 19 May, 2022 1 commit
  22. 12 May, 2022 1 commit
  23. 06 May, 2022 1 commit
  24. 21 Apr, 2022 1 commit
  25. 27 Jul, 2021 1 commit
  26. 23 Jun, 2021 1 commit
  27. 04 Jun, 2021 1 commit
  28. 21 May, 2021 1 commit
  29. 14 May, 2021 1 commit
  30. 13 May, 2021 1 commit
  31. 04 May, 2021 2 commits
  32. 26 Apr, 2021 1 commit
  33. 23 Apr, 2021 1 commit
  34. 21 Apr, 2021 1 commit
  35. 01 Apr, 2021 1 commit
  36. 04 Feb, 2021 1 commit
  37. 27 Jan, 2021 1 commit