- 15 Dec, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 07 Dec, 2023 1 commit
-
-
Jasper van Riet authored
This PR introduces a new property `exitDuration` to Tooltip, the counterpart to `waitDuration`. The need for this is shown by #136586. This changes the behaviour of `showDuration` on mouse pointer devices. This is because the use cases for the current behaviour on touch screen devices vs mouse pointer devices is fundamentally different. <details> <summary>Demo: tooltip with showDuration set</summary> Tooltip disappears after 100 ms when moving away the mouse. Tooltip will not disappear when hovered. https://github.com/flutter/flutter/assets/5138348/81d36dc9-78e0-4723-a84b-2552843ee181 </details> Currently, when `showDuration` is set, this adjusts the time it takes for the tooltip to hide _after_ a mouse pointer has left the tooltip. This is not the same use case as its effect on touch screen devices, where it dictates how long the tooltip stays on screen after a long press. That is needed because the tooltip takes up screen space and there is not an intuitive way to hide it, whereas when using a mouse users expect to simply have to hover somewhere else. Having the tooltip stay around will look broken. Thus, this PR splits the two use cases. `showDuration` no longer affects mouse pointer devices at all*. There is a precedent for such mouse pointer-only behaviour in `waitDuration`. Instead, I have split up the two use cases and created the new property `exitDuration`, which will still allow for tweaking the time it takes for the tooltip to hide after the user has moved their mouse pointer somewhere else. *Note: Should `showDuration` affect [this line](https://github.com/flutter/flutter/blob/e33d4b86270e3c012ba13d68d6e90f2eabc4912b/packages/flutter/lib/src/material/tooltip.dart#L610)? Fixes #136586. Note: I noticed that when I made the change, no tests were broken. Hopefully, the tests added here help that in the future. I also noticed that in the _existing_ tests, the `waitDuration` tests contain assertions that implicate that it is the role of `waitDuration` to change this behaviour, but that's not currently (nor in the new behaviour) true, so I have fixed those tests.
-
- 06 Dec, 2023 1 commit
-
-
Taha Tesser authored
Updated unit tests for `Tooltip` to have M2 and M3 versions. More info in #139076
-
- 06 Oct, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/134656 `_skipMarkNeesLayout` was meant to only skip `markNeedsLayout` calls. Re-painting is still needed when a child gets added/removed from the `Overlay`.
-
- 05 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 14 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 09 Aug, 2023 1 commit
-
-
Zachary Anderson authored
Reverts flutter/flutter#131998 Reverting for https://github.com/flutter/flutter/issues/132222
-
- 08 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 07 Aug, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/59413 This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`. The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :) mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.
-
- 22 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 16 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
It's time to say good bye to an old friend. It has outlived its usefulness. Farewell, AbstractNode! ð«¡
-
- 13 Jun, 2023 1 commit
-
-
Qun Cheng authored
Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true. All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version. related to #127064
-
- 16 Feb, 2023 1 commit
-
-
Hans Muller authored
-
- 02 Feb, 2023 1 commit
-
-
Eilidh Southren authored
This reverts commit d2788080.
-
- 01 Feb, 2023 1 commit
-
-
Eilidh Southren authored
* Check whether slider is mounted before interaction, no-op if unmounted (#113556) * Check whether slider is unmounted before interaction * Update slider.dart * Update Slider * Add test * Update slider_test.dart * Update packages/flutter/test/material/slider_test.dart Co-authored-by:
Taha Tesser <tessertaha@gmail.com> Co-authored-by:
Taha Tesser <tessertaha@gmail.com> * exposed tooltip longPress action when available * updated tooltip test * updated date picker test --------- Co-authored-by:
Mingyu <lyming90@gmail.com> Co-authored-by:
Taha Tesser <tessertaha@gmail.com> Co-authored-by:
Harper Liu <harperl0818@gmail.com>
-
- 23 Dec, 2022 1 commit
-
-
Xilai Zhang authored
* Revert "Exposed tooltip longPress action when available (#117338)" This reverts commit 38e3930f. * Revert "fixes android_semantics_integration_test to expect long press for tootip"
-
- 20 Dec, 2022 2 commits
-
-
Michael Goderbauer authored
* Enable lint * note about discarded_futures * note about use_decorated_box * update note on require_trailing_commas
-
harperl-lgtm authored
* Exposed tooltip longPress action when available (Trigger mode is long press)
-
- 17 Aug, 2022 1 commit
-
-
Bernardo Ferrari authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 20 May, 2022 2 commits
-
-
Casey Hillers authored
-
Tong Mu authored
-
- 19 May, 2022 1 commit
-
-
Jonah Williams authored
-
- 12 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 06 May, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Apr, 2022 1 commit
-
-
chunhtai authored
-
- 27 Jul, 2021 1 commit
-
-
Matan Shukry authored
-
- 23 Jun, 2021 1 commit
-
-
Greg Spencer authored
-
- 04 Jun, 2021 1 commit
-
-
chunhtai authored
-
- 21 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 14 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 13 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 04 May, 2021 2 commits
-
-
Ian Hickson authored
- 26 Apr, 2021 1 commit
-
- 23 Apr, 2021 1 commit
-
-
Ian Hickson authored
* Migrate to ChannelBuffers.push * Move TestDefaultBinaryMessenger to its own file * Apply deprecations and fix usages
-
- 21 Apr, 2021 1 commit
-
-
Phil Quitslund authored
-
- 01 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 Feb, 2021 1 commit
-
-
Sam Rawlins authored
-
- 27 Jan, 2021 1 commit
-
-
Alexandre Ardhuin authored
-