- 17 Jan, 2024 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/141644
-
- 12 Jan, 2024 1 commit
-
-
Anis Alibegić authored
Fair amount of typos spotted and fixed. Some of them are in comments, some of them are in code and some of them are in nondart files. There is no need for issues since it's a typo fix. I have doubts about [packages/flutter_tools/lib/src/ios/core_devices.dart](https://github.com/flutter/flutter/compare/master...anisalibegic:flutter:master#diff-fdbc1496b4bbe7e2b445a567fd385677af861c0093774e3d8cc460fdd5b794fa), I have a feeling it might broke some things on the other end, even though it's a typo.
-
- 07 Dec, 2023 1 commit
-
-
Jasper van Riet authored
This PR introduces a new property `exitDuration` to Tooltip, the counterpart to `waitDuration`. The need for this is shown by #136586. This changes the behaviour of `showDuration` on mouse pointer devices. This is because the use cases for the current behaviour on touch screen devices vs mouse pointer devices is fundamentally different. <details> <summary>Demo: tooltip with showDuration set</summary> Tooltip disappears after 100 ms when moving away the mouse. Tooltip will not disappear when hovered. https://github.com/flutter/flutter/assets/5138348/81d36dc9-78e0-4723-a84b-2552843ee181 </details> Currently, when `showDuration` is set, this adjusts the time it takes for the tooltip to hide _after_ a mouse pointer has left the tooltip. This is not the same use case as its effect on touch screen devices, where it dictates how long the tooltip stays on screen after a long press. That is needed because the tooltip takes up screen space and there is not an intuitive way to hide it, whereas when using a mouse users expect to simply have to hover somewhere else. Having the tooltip stay around will look broken. Thus, this PR splits the two use cases. `showDuration` no longer affects mouse pointer devices at all*. There is a precedent for such mouse pointer-only behaviour in `waitDuration`. Instead, I have split up the two use cases and created the new property `exitDuration`, which will still allow for tweaking the time it takes for the tooltip to hide after the user has moved their mouse pointer somewhere else. *Note: Should `showDuration` affect [this line](https://github.com/flutter/flutter/blob/e33d4b86270e3c012ba13d68d6e90f2eabc4912b/packages/flutter/lib/src/material/tooltip.dart#L610)? Fixes #136586. Note: I noticed that when I made the change, no tests were broken. Hopefully, the tests added here help that in the future. I also noticed that in the _existing_ tests, the `waitDuration` tests contain assertions that implicate that it is the role of `waitDuration` to change this behaviour, but that's not currently (nor in the new behaviour) true, so I have fixed those tests.
-
- 09 Nov, 2023 1 commit
-
-
hangyu authored
issue: https://github.com/flutter/flutter/issues/137438 Use case: I want to add action button is tooltip and thus want to disable tap to dismiss a tooltip. ![image](https://github.com/flutter/flutter/assets/108393416/39c606fd-d301-4ed4-a411-4916823e5757)
-
- 03 Nov, 2023 1 commit
-
-
Chris Bobbe authored
As discussed at https://github.com/flutter/flutter/pull/133007#issuecomment-1743916183, this is a docs change meant to help people in the absence of a fix for #133006, which is being closed as WONTFIX.
-
- 23 Oct, 2023 1 commit
-
-
LongCatIsLooong authored
`OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (#134921) Fixes https://github.com/flutter/flutter/issues/134456
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 13 Jul, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/129969 by making tooltip text unselectable (for now). Also fixes some other issues uncovered when I was writing the tests. Currently `getTransformTo` only works on ancestors. I'll try to add a new method that computes the transform from 2 arbitrary render objects in the same render tree in a follow-up PR and make `Selectable` use that method instead.
-
- 21 Jun, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/129025 Also - simplifies OverlayPortal code a bit and adds an assert. - `Tooltip` shouldn't rebuild when hiding/showing the tooltip
-
- 10 Jun, 2023 1 commit
-
-
LongCatIsLooong authored
https://github.com/flutter/flutter/issues/7151 isn't a problem with OverlayPortal so the test is removed. Also removed some `mounted` checks since they're no longer needed.
-
- 26 May, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/127575 The `_handleMouseEnter` and `_handleMouseExit` calls are balanced, but the tooltip could be dismissed by an external `PointerDown` event interacting with a different UI component so the ` assert(_activeHoveringPointerDevices.isNotEmpty);` does not really make sense.
-
- 25 May, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/117627 ### Behavior changes: 1. If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for `waitDuration`. 2. A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones. 3. The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.
-
- 18 May, 2023 1 commit
-
-
Mahdi Bagheri authored
Fixing #126206 and #113388 issues *The IgnorePointer is preventing the richMessage touch events being recognized. Just removing that from* *Solves #126206 and #113388*
-
- 03 Feb, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 02 Feb, 2023 1 commit
-
-
Eilidh Southren authored
This reverts commit d2788080.
-
- 01 Feb, 2023 1 commit
-
-
Eilidh Southren authored
* Check whether slider is mounted before interaction, no-op if unmounted (#113556) * Check whether slider is unmounted before interaction * Update slider.dart * Update Slider * Add test * Update slider_test.dart * Update packages/flutter/test/material/slider_test.dart Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> * exposed tooltip longPress action when available * updated tooltip test * updated date picker test --------- Co-authored-by: Mingyu <lyming90@gmail.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Harper Liu <harperl0818@gmail.com>
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 23 Dec, 2022 1 commit
-
-
Xilai Zhang authored
* Revert "Exposed tooltip longPress action when available (#117338)" This reverts commit 38e3930f. * Revert "fixes android_semantics_integration_test to expect long press for tootip"
-
- 20 Dec, 2022 1 commit
-
-
harperl-lgtm authored
* Exposed tooltip longPress action when available (Trigger mode is long press)
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 02 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 22 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 19 Aug, 2022 1 commit
-
-
Tomasz Gucio authored
-
- 02 Aug, 2022 1 commit
-
-
xubaolin authored
-
- 22 Jun, 2022 1 commit
-
-
Bruno Leroux authored
-
- 21 Jun, 2022 1 commit
-
-
Albin PK authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 20 May, 2022 2 commits
-
-
Bruno Leroux authored
-
Bruno Leroux authored
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
-
- 19 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 12 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 09 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 06 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 27 Apr, 2022 1 commit
-
-
Pierre-Louis authored
-
- 21 Apr, 2022 1 commit
-
-
chunhtai authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 25 Mar, 2022 1 commit
-
-
Taha Tesser authored
`Tooltip`: Add an example for `TooltipTriggerMode.manual` and add tests for existing `Tooltip` examples (#100554)
-
- 22 Mar, 2022 1 commit
-
-
Taha Tesser authored
-
- 25 Feb, 2022 1 commit
-
-
xubaolin authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-