- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 30 Aug, 2023 1 commit
-
-
Bruno Leroux authored
## Description This PR exposes `barrierDismissible` in `PageRoute`, `MaterialPageRoute` and `CupertinoPageRoute` constructors. Setting this property to true will enable the escape key binding. ## Related Issue Fixes https://github.com/flutter/flutter/issues/132138. ## Tests Adds one test.
-
- 07 Jul, 2023 1 commit
-
-
Hans Muller authored
Reverts flutter/flutter#114303 The breaking API change in flutter/flutter#114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: https://github.com/flutter/flutter/issues/130062. Fixes https://github.com/flutter/flutter/issues/130062
-
- 05 Jul, 2023 1 commit
-
-
ipcjs authored
When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem. #99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 25 Aug, 2022 1 commit
-
-
Jonah Williams authored
-
- 22 Jul, 2022 1 commit
-
-
Jonah Williams authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 26 Mar, 2022 1 commit
-
-
Alex Li authored
-
- 25 Mar, 2022 2 commits
-
-
-
Alex Li authored
-
- 19 Aug, 2021 1 commit
-
-
Hans Muller authored
-
- 18 Aug, 2021 2 commits
-
-
Jenn Magder authored
This reverts commit a1ae4fea.
- 17 Aug, 2021 1 commit
-
-
Alex Li authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 19 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 29 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 02 Nov, 2020 2 commits
-
-
Greg Spencer authored
-
Michael Goderbauer authored
-
- 06 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate material to nullsafety * address review comments * address review comments * fix build
-
- 29 Sep, 2020 1 commit
-
-
Konstantin Scheglov authored
-
- 27 Sep, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 30 Jul, 2020 1 commit
-
-
Michael Goderbauer authored
* Fix even more unresolved doc references in material * ++ * ++
-
- 29 Jul, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 25 Jun, 2020 1 commit
-
-
chunhtai authored
* Add material page, cupertino page, and transition page classes * update * update comments * fix test * addressing comments * make page getter private
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 20 Feb, 2020 1 commit
-
-
Albertus Angga Raharja authored
This PR is a follow up of https://github.com/flutter/flutter/pull/42640 Some changes of that PR includes redundant changes using FlutterError.fromParts constructor even though it's not necessary. Some minor changes are: - Remove one unnecessary todo - Fix indent consistencies
-
- 03 Dec, 2019 1 commit
-
-
XinLei authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 28 Oct, 2019 1 commit
-
-
Albertus Angga Raharja authored
* Add structured errors in Animations, TabView, ChangeNotifier * Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan * Add structured errors in Debug * Fix test errors * Add structured errors in Scaffold and Stepper * Add structured errors in part of Rendering Layer * Fix failing test due to FloatingPoint precision * Fix failing tests due to precision error and not using final * Fix failing test due to floating precision error with RegEx instead * Add structured error in CustomLayout and increase test coverage * Add structured error & its test in ListBody * Add structured error in ProxyBox and increase test coverage * Add structured error message in Viewport * Fix styles and add more assertions on ErrorHint and DiagnosticProperty * Add structured error in scheduler/binding and scheduler/ticker Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured error in AssetBundle and TextInput Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured errors in several widgets #1 Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Remove unused import Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add assertions on hint messages Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Fix catch spacing Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured error in several widgets part 2 and increase code coverage Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured error in flutter_test/widget_tester * Fix floating precision accuracy by using RegExp Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Remove todo to add tests in Scaffold showBottomSheet Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Fix reviews by indenting lines and fixing the assertion orders Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Fix failing tests due to renaming class Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Try skipping the NetworkBundleTest Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Remove leading space in material/debug error hint Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 Jan, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 18 Dec, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Oct, 2018 1 commit
-
-
Mouad Debbar authored
-
- 25 Sep, 2018 1 commit
-
-
Hans Muller authored
MaterialPageRoute transitions are now defined by the Theme. Added (optional) support for Android P style page transitions.
-
- 23 Sep, 2018 1 commit
-
-
Ian Hickson authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 06 Sep, 2018 1 commit
-
-
liyuqian authored
The average frame time of page transitions on Moto G4 is now very close to 16ms (the last 10 measurements on our dashboard are between 15.5ms to 16.7ms and half of them are below 16ms). It is now much faster than when we disabled it (which was at about 35ms). So I think that we should be able to enable it by default. I'll leave the flag there until we implement the retained rendering to bring the frame time comfortably below 16ms. See https://github.com/flutter/flutter/issues/13736
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-