1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the material library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      a1e49be2
  2. 30 Aug, 2023 1 commit
  3. 07 Jul, 2023 1 commit
  4. 05 Jul, 2023 1 commit
    • ipcjs's avatar
      fix a bug when android uses CupertinoPageTransitionsBuilder... (#114303) · aaaea51d
      ipcjs authored
      When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem.
      
      #99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>
      aaaea51d
  5. 24 Jan, 2023 1 commit
  6. 25 Aug, 2022 1 commit
  7. 22 Jul, 2022 1 commit
  8. 14 Apr, 2022 1 commit
  9. 26 Mar, 2022 1 commit
  10. 25 Mar, 2022 2 commits
  11. 19 Aug, 2021 1 commit
  12. 18 Aug, 2021 2 commits
  13. 17 Aug, 2021 1 commit
  14. 31 Mar, 2021 1 commit
  15. 19 Mar, 2021 1 commit
  16. 29 Jan, 2021 1 commit
  17. 02 Nov, 2020 2 commits
  18. 06 Oct, 2020 1 commit
  19. 29 Sep, 2020 1 commit
  20. 27 Sep, 2020 1 commit
  21. 30 Jul, 2020 1 commit
  22. 29 Jul, 2020 1 commit
  23. 25 Jun, 2020 1 commit
  24. 11 Jun, 2020 1 commit
  25. 20 Feb, 2020 1 commit
  26. 03 Dec, 2019 1 commit
  27. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  28. 28 Oct, 2019 1 commit
  29. 21 Feb, 2019 1 commit
  30. 30 Jan, 2019 1 commit
  31. 18 Dec, 2018 1 commit
  32. 15 Oct, 2018 1 commit
  33. 25 Sep, 2018 1 commit
  34. 23 Sep, 2018 1 commit
  35. 12 Sep, 2018 1 commit
  36. 06 Sep, 2018 1 commit
    • liyuqian's avatar
      Enable fading animation during page transitions. (#21394) · 6c4b38b7
      liyuqian authored
      The average frame time of page transitions on Moto G4 is now very
      close to 16ms (the last 10 measurements on our dashboard are
      between 15.5ms to 16.7ms and half of them are below 16ms).
      
      It is now much faster than when we disabled it (which was at about
      35ms). So I think that we should be able to enable it by default.
      I'll leave the flag there until we implement the retained rendering
      to bring the frame time comfortably below 16ms.
      
      See https://github.com/flutter/flutter/issues/13736
      6c4b38b7
  37. 05 Jun, 2018 1 commit