Commits · 0dea82e6848b46dedff43553a4f41348f17728c2 · abdullh.alsoleman / Front-End

22 Jan, 2024 15 commits

Remove unneeded expectation in test (#141822) · 0dea82e6

Greg Spencer authored Jan 22, 2024

## Description

This removes an unneeded expectation in the test for the AppLifecycleListener.  It's unneeded because the test immediately resets the state anyhow.  I'm removing it because the web implementation sets the value when initializing, so it's never initially null there.

## Related PR
 - https://github.com/flutter/engine/pull/44720#issuecomment-1898482363

0dea82e6

Roll Flutter Engine from 1efe8ba6bc04 to d653559ae183 (3 revisions) (#141972) · 1f8085d8

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/engine/compare/1efe8ba6bc04...d653559ae183

2024-01-22 bdero@google.com [Impeller] Add golden for Image ColorSource effect transform. (flutter/engine#49930)
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from 9cb4de5da15a to cc042f38288e (1 revision) (flutter/engine#49934)
2024-01-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from p0njgljtokVLYfzqK... to uQK4l0QeH_PlZO6cF... (flutter/engine#49933)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from p0njgljtokVL to uQK4l0QeH_Pl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f8085d8

Add documentation which explains that `debugPrint` also logs in release mode (#141595) · 174bbf25

Jonas Uekötter authored Jan 22, 2024

It's confusing that `debugPrint` also prints in release mode, given that a lot (most?) other things prefixed with `debug` don't do anything in release mode. Therefore, this adds some documentation that this is indeed logging in release mode and adds an example how to disable this.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

174bbf25

Fix `RangeSlider` throws a null-check error after `clearSemantics` is called (#141965) · 5aa6cb85
Taha Tesser authored Jan 22, 2024
```
fixes [Null-check operator on RangeSlider's _startSemanticsNode](https://github.com/flutter/flutter/issues/141953)
```
5aa6cb85

Roll Flutter Engine from c49989292fc1 to 1efe8ba6bc04 (1 revision) (#141969) · cf8d20f7

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/engine/compare/c49989292fc1...1efe8ba6bc04

2024-01-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a91ef52d200 to dc389e4a01f3 (3 revisions) (flutter/engine#49932)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf8d20f7

[web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator` (#138446) · 59e892d3

Hassan Toor authored Jan 22, 2024

When a `TextField` is rendered before a `Navigator`, it breaks in semantics mode.  This is because the framework generates the incorrect semantics tree (excludes the TextField) and when that tree gets sent to the engine, we don't get the signal to create the corresponding `<input>` element.

This happens for a few reasons:
* `ModalBarrier` uses `BlockSemantics` to drop the semantics of routes beneath the current route in `Navigator`
* `ModalBarrier` mistakenly recognizes the widget outside of the `Navigator` to be its sibling
*  So we end up dropping the semantics node of the `TextField` rendered before it. 

The fix is to let `Navigator` generate a semantics node so that `ModalBarrier` doesn't mistakenly think widgets outside of `Navigator` are its siblings.  

`Navigator` doesn't currently do this, which causes all the nodes generated from its widget subtree to be directly attached to the parent semantics node above `Navigator` - since this is also the parent of `TextField`, it considers them siblings. 

Fixes https://github.com/flutter/flutter/issues/129324

59e892d3

Roll Flutter Engine from 40c5e9ce6596 to c49989292fc1 (1 revision) (#141966) · 3ee8ff28

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/engine/compare/40c5e9ce6596...c49989292fc1

2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from f4b79968de2a to 9cb4de5da15a (1 revision) (flutter/engine#49931)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ee8ff28

Roll Packages from 129e08c1dff1 to e4cbf235ec4d (11 revisions) (#141962) · bfa245fa

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/packages/compare/129e08c1dff1...e4cbf235ec4d

2024-01-21 engine-flutter-autoroll@skia.org Roll Flutter from ddf60fb0 to 5dea6b99 (5 revisions) (flutter/packages#5951)
2024-01-21 stuartmorgan@google.com Update platform label rules for shared iOS/macOS (flutter/packages#5801)
2024-01-20 stuartmorgan@google.com [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944)
2024-01-20 stuartmorgan@google.com [pigeon] Improve style of generated Swift code (flutter/packages#5938)
2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 684247a3 to ddf60fb0 (12 revisions) (flutter/packages#5949)
2024-01-20 41930132+hellohuanlin@users.noreply.github.com [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927)
2024-01-19 magder@google.com [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928)
2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f77f8243 to 684247a3 (39 revisions) (flutter/packages#5948)
2024-01-19 john@johnmccutchan.com Expose registered widget libraries and local widget library widgets. (flutter/packages#5936)
2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937)
2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ef1af02aead6 to 67457e669f79 (1 revision) (flutter/packages#5932)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfa245fa

Mark defaultTargetPlatform as constant for non-debug non-web builds. (#141105) · 7ca4b7b8

Tess Strickland authored Jan 22, 2024

This PR adds the Dart VM `vm:platform-const-if` pragma introduced in
https://github.com/dart-lang/sdk/commit/57a1168875 to the
`defaultTargetPlatform` property, allowing it to be computed as if it
was a constant field in non-debug AOT builds. In particular, this means
that platform-specific code executed conditionally based on this
property can be tree-shaken in release builds. Note that this PR changes
`defaultTargetPlatform` to only allow overriding via
`debugDefaultTargetPlatformOverride` in debug builds, and makes it so
that compilation throws an error if code assigns
to`debugDefaultTargetPlatformOverride` in other build modes.

Related issue: #14233

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

7ca4b7b8

Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink (#141777) · 9574d585

Taha Tesser authored Jan 22, 2024

This updates the previous attempt https://github.com/flutter/flutter/pull/135855 and removes the complications when testing M3 ink sparkle effect. 
Thanks to this [PR](https://github.com/flutter/flutter/pull/138757) by @Piinks 

fixes [ExpansionTile InkSplash doesn't respect Shape's borderRadius](https://github.com/flutter/flutter/issues/125779)
fixes [`ExpansionTile.backgroundColor` &  `ExpansionTile.collapsedBackgroundColor` removes splash effect](https://github.com/flutter/flutter/issues/107113)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
          child: Padding(
        padding: EdgeInsets.symmetric(horizontal: 24.0),
        child: ExpansionTile(
          collapsedBackgroundColor: Color(0x25ff0000),
          backgroundColor: Color(0x250000ff),
          collapsedShape: RoundedRectangleBorder(
            borderRadius: BorderRadius.all(Radius.circular(30.0)),
            side: BorderSide(color: Colors.black, width: 2.0),
          ),
          shape: RoundedRectangleBorder(
            borderRadius: BorderRadius.all(Radius.circular(30.0)),
            side: BorderSide(color: Colors.black, width: 2.0),
          ),
          clipBehavior: Clip.hardEdge,
          title: Text('Expansion Tile'),
          children: <Widget>[
            FlutterLogo(size: 50),
            FlutterLogo(size: 50),
            FlutterLogo(size: 50),
            FlutterLogo(size: 50),

          ],
        ),
      )),
    );
  }
}
```

</details>

### Before

<img width="789" alt="Screenshot 2024-01-18 at 18 16 15" src="https://github.com/flutter/flutter/assets/48603081/8c6a6f1e-6986-4acf-8dec-e223a682c0d7">

<img width="789" alt="Screenshot 2024-01-18 at 18 16 44" src="https://github.com/flutter/flutter/assets/48603081/f55f6a26-2128-48a1-b24d-3c14e4f6ecdc">

### After 
<img width="789" alt="Screenshot 2024-01-18 at 18 20 27" src="https://github.com/flutter/flutter/assets/48603081/7ec8b888-7319-460d-8488-9cd44c9246a6">

<img width="789" alt="Screenshot 2024-01-18 at 18 20 53" src="https://github.com/flutter/flutter/assets/48603081/80d66d5b-7eb2-4f47-ab4d-d7f469a731fa">

9574d585

Reapply "Native assets: roll deps" (#141748) (#141864) · 634b326e

Daco Harkes authored Jan 22, 2024

Fixes https://github.com/flutter/flutter/issues/141827

Reland: https://dart-review.googlesource.com/c/sdk/+/346960 has rolled into g3, so the imports should now resolve in g3 as well.

> [!CAUTION]
> _Do NOT merge if "Google Testing" bot didn't run!_

Rolls the packages from https://github.com/dart-lang/native in the native assets implementation.

Most notable we're refactoring `package:native_assets_cli` for `build.dart` use.
Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for `build.dart` writers. Hence all the import updates.

No behavior in Flutter apps should change.

This PR also updates the template to use the latests version of `package:native_assets_cli` which no longer exposes all the implementation details.

634b326e

Roll Flutter Engine from 11c585f48b77 to 40c5e9ce6596 (1 revision) (#141956) · ce97e34d

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/engine/compare/11c585f48b77...40c5e9ce6596

2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from 8774ef8a314e to f4b79968de2a (1 revision) (flutter/engine#49929)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce97e34d

Update `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` tests for Material 3 (#141868) · 0ef46388
Taha Tesser authored Jan 22, 2024
```
Updated unit tests for `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` to have M2 and M3 versions.

More info in #139076
```
0ef46388

Roll Flutter Engine from c485c574fb1d to 11c585f48b77 (1 revision) (#141952) · 5caa8b89

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/engine/compare/c485c574fb1d...11c585f48b77

2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from 97a00523af28 to 8774ef8a314e (1 revision) (flutter/engine#49927)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5caa8b89

Roll Flutter Engine from a7b207d5a1fe to c485c574fb1d (1 revision) (#141951) · fb3a1e2b

engine-flutter-autoroll authored Jan 22, 2024

https://github.com/flutter/engine/compare/a7b207d5a1fe...c485c574fb1d

2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from c42ac527ff0e to 97a00523af28 (1 revision) (flutter/engine#49926)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb3a1e2b

21 Jan, 2024 4 commits

Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) (#141945) · 5dea6b99

engine-flutter-autoroll authored Jan 21, 2024

https://github.com/flutter/engine/compare/2b31ad2fb819...a7b207d5a1fe

2024-01-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kOnlSGX_aTAK7vvLc... to p0njgljtokVLYfzqK... (flutter/engine#49924)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kOnlSGX_aTAK to p0njgljtokVL

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5dea6b99

[flutter_tools] update analyze_once_test.dart to be null-safe (#141790) · 92094802

Christopher Fujino authored Jan 21, 2024

Fixes https://github.com/flutter/flutter/issues/141743

I should have made this change in https://github.com/flutter/flutter/pull/124039, but it escaped my grep search.

92094802

Adjust the position of require File.expand_path (#141521) · f340d207

林洵锋 authored Jan 21, 2024

On `Podfile`:

```ruby
flutter_application_path = '../flutter_module'
load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')

target 'OCProject' do
  # Comment the next line if you don't want to use dynamic frameworks
  use_frameworks!

  # Pods for OCProject
  # install_all_flutter_pods(flutter_application_path)
  # install_flutter_engine_pod(flutter_application_path)
  # install_flutter_application_pod(flutter_application_path)
  install_flutter_plugin_pods(flutter_application_path)

end

post_install do |installer|
  flutter_post_install(installer)
end
```
Encountering the following error after executing `pod install`:

```shell
pod install

[!] Invalid `Podfile` file: undefined method `flutter_relative_path_from_podfile' for #<Pod::Podfile:0x000000010e74c520 @defined_in_file=#<Pathname:/Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile>, @internal_hash={}, @root_target_definitions=[#<Pod::Podfile::TargetDefinition label=Pods>], @current_target_definition=#<Pod::Podfile::TargetDefinition label=Pods>>

  relative = flutter_relative_path_from_podfile(export_script_directory)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^.

 #  from /Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile:17
 #  -------------------------------------------
 #    # install_flutter_plugin_pods(flutter_application_path)
 >    install_flutter_application_pod(flutter_application_path)
 #
 #  -------------------------------------------
```

The `flutter_relative_path_from_podfile` method is in `flutter_tools/bin/podhelper.rb`, but now `flutter_tools/bin/podhelper.rb` is only required in `install_all_flutter_pods` in `podhelper.rb.tmpl`.

Sometimes we only need to use the `install_flutter_plugin_pods` method in podhelper.rb. For example, using `Shorebird` in an iOS hybird app scenario, we need to build `Flutter.xcframework` and `App.xcframework` and embed them into the iOS native project. In order to avoid unnecessary conflicts, use `install_flutter_plugin_pods` method to install Flutter plugin pods.

[Shorebird - Code Push In Hybrid Apps](https://docs.shorebird.dev/guides/hybrid-app/ios)

So I adjust the position of `require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)`.

f340d207

Add RadioListItem use-case to a11y_assessments (#140984) · a9faaf26

Yegor authored Jan 21, 2024

Adds a use-case screen for `RadioListTile`, similar to the `CheckBoxListTile`. This screen can help test scenarios such as the one reported in https://github.com/flutter/flutter/issues/126805.

a9faaf26

20 Jan, 2024 8 commits

Roll Flutter Engine from 704ef3399012 to 2b31ad2fb819 (1 revision) (#141937) · 954d30f0

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/704ef3399012...2b31ad2fb819

2024-01-20 skia-flutter-autoroll@skia.org Roll Skia from 3cac1efbdd7a to c42ac527ff0e (1 revision) (flutter/engine#49921)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

954d30f0

Roll Flutter Engine from 1385f76018ab to 704ef3399012 (1 revision) (#141932) · ddf60fb0

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/1385f76018ab...704ef3399012

2024-01-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from geXIwPzzJiSXrZEEb... to kOnlSGX_aTAK7vvLc... (flutter/engine#49919)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from geXIwPzzJiSX to kOnlSGX_aTAK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ddf60fb0

Roll Flutter Engine from 6f6649bdfef2 to 1385f76018ab (1 revision) (#141926) · 3c1cb8ac

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/6f6649bdfef2...1385f76018ab

2024-01-20 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 8d697eaa395c to 7a91ef52d200 (5 revisions) (flutter/engine#49917)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c1cb8ac

Roll Flutter Engine from 4d67f267b115 to 6f6649bdfef2 (1 revision) (#141920) · 3225cfeb

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/4d67f267b115...6f6649bdfef2

2024-01-20 skia-flutter-autoroll@skia.org Roll Skia from 61a2dcff4194 to 3cac1efbdd7a (4 revisions) (flutter/engine#49916)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3225cfeb

Roll Flutter Engine from 53a2436cf75c to 4d67f267b115 (1 revision) (#141917) · 61c3455b

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/53a2436cf75c...4d67f267b115

2024-01-20 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Metal. (flutter/engine#49785)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61c3455b

Roll Flutter Engine from a9b87c6288d2 to 53a2436cf75c (1 revision) (#141916) · 0d73663d

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/a9b87c6288d2...53a2436cf75c

2024-01-20 jonahwilliams@google.com [Impeller] use string view for labels in more places to defer allocatons. (flutter/engine#49905)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d73663d

Roll Flutter Engine from d00e55f7f8ed to a9b87c6288d2 (3 revisions) (#141914) · 3842c24a

engine-flutter-autoroll authored Jan 20, 2024

https://github.com/flutter/engine/compare/d00e55f7f8ed...a9b87c6288d2

2024-01-20 jonahwilliams@google.com [Impeller] null check vertex buffer. (flutter/engine#49915)
2024-01-19 30870216+gaaclarke@users.noreply.github.com [Impeller] adds vulkan golden images (flutter/engine#49849)
2024-01-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" (flutter/engine#49908)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3842c24a

Remove more textScaleFactor references (#141816) · 5892a003

LongCatIsLooong authored Jan 20, 2024

Remove more `textScaleFactor` references from flutter/flutter.  

- Some changes are related to label scaling: the padding EdgeInsets values of some chip subclasses scale linearly between predetermined "max" padding values and "min" padding values. Before they scale with the `textScaleFactor` scalar, now they scale with the font size and are still capped at the original "max" and "min" values.
- The rest of them are tests or size heuristics that depend on `textScaleFactor`, these are replaced by an effective text scale factor computed using a default font size (which is determined in a pretty random fashion, but it will only make a difference on Android 14+).

No API changes in this batch. There are still some references left that I intend to remove in a different batch that would introduce API changes.

5892a003

19 Jan, 2024 13 commits

Roll Flutter Engine from 517fc2bbfa51 to d00e55f7f8ed (1 revision) (#141909) · bc254ce3

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/517fc2bbfa51...d00e55f7f8ed

2024-01-19 737941+loic-sharma@users.noreply.github.com [Windows] Refactor EGL initialization (flutter/engine#49895)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc254ce3

Roll Flutter Engine from f2b441a26416 to 517fc2bbfa51 (2 revisions) (#141904) · cd6fe510

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/f2b441a26416...517fc2bbfa51

2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from fabb71dcf9b7 to 61a2dcff4194 (1 revision) (flutter/engine#49904)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from c09908c48f14 to fabb71dcf9b7 (3 revisions) (flutter/engine#49902)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd6fe510

Fix "Delete" tooltip is shown disabled on chips with `onDeleted` callback (#141770) · 788614d1

Taha Tesser authored Jan 19, 2024

fixes [Disabled chips with `onDeleted` callback shows "Delete" tooltip on hover](https://github.com/flutter/flutter/issues/141336)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  bool _isEnable = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              label: const Text('RawChip'),
              onPressed: () {},
              isEnabled: _isEnable,
              onDeleted: () {},
            ),
            FilterChip(
              label: const Text('FilterChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
              onDeleted: () {},
            ),
            InputChip(
              label: const Text('InputChip'),
              isEnabled: _isEnable,
              onDeleted: () {},
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton.extended(
        onPressed: () {
          setState(() {
            _isEnable = !_isEnable;
          });
        },
        label: Text(_isEnable ? 'Disable' : 'Enable'),
      ),
    );
  }
}
```

</details>

### Preview

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/f80ae5f7-0a6d-4041-ade3-cbc2b5c78188" height="450" /> | <img src="https://github.com/flutter/flutter/assets/48603081/04e62854-e3f1-4b65-9753-183d288f3cfe" height="450" /> |

788614d1

Run module_test_ios on arm and x64 (#141815) · 6f7aed59
godofredoc authored Jan 19, 2024
```
This will ensure the test runs on the supported platforms.
```
6f7aed59
`SearchAnchor` search view clear button only shows up when text input is not empty (#141755) · 05854afa
Qun Cheng authored Jan 19, 2024

05854afa

Use Integer instead of int in map in flutter.groovy (#141895) · 684247a3

Reid Baker authored Jan 19, 2024

packages Roller breakage 
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/5504/overview
Fixes flutter/flutter/issues/141897
```
FAILURE: Build failed with an exception.

* Where:
Script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 168

* What went wrong:
Could not compile script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy'.
> startup failed:
  script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy': 168: primitive type parameters not allowed here;
     solution: use the corresponding wrapper type, such as Integer for int @ line 168, column 41.
     e static final Map<String, int> ABI_VERS
```

Covered by tests in packages.

684247a3

Roll Flutter Engine from c953c83112ba to f2b441a26416 (4 revisions) (#141894) · f0e9d232

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/c953c83112ba...f2b441a26416

2024-01-19 jonahwilliams@google.com Reland: Encode directly to command buffer. (flutter/engine#49821)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 2536dc6fef1d to c09908c48f14 (6 revisions) (flutter/engine#49899)
2024-01-19 dnfield@google.com [Impeller] Documentation for SurfaceContextVK (flutter/engine#49882)
2024-01-19 32242716+ricardoamador@users.noreply.github.com Adding ignore paths to cache test (flutter/engine#49874)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0e9d232

Native assets: package in framework on iOS and MacOS (#140907) · 2e229be2

Daco Harkes authored Jan 19, 2024

Packages the native assets for iOS and MacOS in frameworks.

Issue:

* https://github.com/flutter/flutter/issues/140544
* https://github.com/flutter/flutter/issues/129757

## Details

* [x] This packages dylibs from the native assets feature in frameworks. It packages every dylib in a separate framework.
* [x] The dylib name is updated to use `@rpath` instead of `@executable_path`.
* [x] The dylibs for flutter-tester are no longer modified to change the install name. (Previously it was wrongly updating the install name to the location the dylib would have once deployed in an app.)
* [x] Use symlinking on MacOS.

2e229be2

Revert "Make tests more resilient to Skia gold failures and refactor... · 77c3807c

Ian Hickson authored Jan 19, 2024

Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (#141814)

Reverts https://github.com/flutter/flutter/pull/140101

That PR somehow made non-matching gold tests not fail at HEAD.

Fixes https://github.com/flutter/flutter/issues/141880
- Blocked by https://github.com/flutter/flutter/issues/140169
  - https://github.com/flutter/flutter/pull/141427

77c3807c

Roll Flutter Engine from 538975f2511b to c953c83112ba (3 revisions) (#141886) · 49447fc6

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/538975f2511b...c953c83112ba

2024-01-19 flar@google.com [Impeller] switch Rect fields to LTRB implementation (flutter/engine#49816)
2024-01-19 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49847)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from fb3f61d932e6 to 2536dc6fef1d (2 revisions) (flutter/engine#49892)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

49447fc6

Add `showDragHandle` to `showBottomSheet` (#141754) · ba4a11da
Qun Cheng authored Jan 19, 2024

ba4a11da

Roll Flutter Engine from 9a6c64de8a46 to 538975f2511b (8 revisions) (#141881) · 3563372f

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/9a6c64de8a46...538975f2511b

2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 0a78d1f0ef48 to fb3f61d932e6 (1 revision) (flutter/engine#49891)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 961ad2c3fcf5 to 0a78d1f0ef48 (1 revision) (flutter/engine#49890)
2024-01-19 103135467+sealesj@users.noreply.github.com Re-enable osv-scanner on pushes to main (flutter/engine#49729)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 273b0628a969 to 961ad2c3fcf5 (1 revision) (flutter/engine#49889)
2024-01-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dTy8CK4YxnUsW305O... to geXIwPzzJiSXrZEEb... (flutter/engine#49888)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from b6fa819eb54c to 273b0628a969 (1 revision) (flutter/engine#49887)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from e073a4fad57a to b6fa819eb54c (1 revision) (flutter/engine#49886)
2024-01-19 leroux_bruno@yahoo.fr [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dTy8CK4YxnUs to geXIwPzzJiSX

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3563372f

Make pumpWidget's arguments named (#141728) · cc544169

Michael Goderbauer authored Jan 19, 2024

Much nicer calling API and simplifies evolving this API in the future.

I wish we could write a dart fix for this, but that's blocked on https://github.com/dart-lang/sdk/issues/54668.

cc544169