- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 29 Oct, 2020 2 commits
- 26 Oct, 2020 1 commit
-
-
Yegor authored
-
- 21 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 19 Oct, 2020 1 commit
-
-
Greg Spencer authored
- - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus. This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry. This PR includes: - Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation"). - Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored. - Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them. - Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 05 Oct, 2020 1 commit
-
-
Tong Mu authored
* Migrate
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 17 Sep, 2020 1 commit
-
-
Matěj Žídek authored
-
- 16 Sep, 2020 1 commit
-
-
Michael R Fairhurst authored
-
- 27 Aug, 2020 2 commits
-
-
Matt Carroll authored
-
Ian Hickson authored
-
- 26 Aug, 2020 1 commit
-
-
Remi Rousselet authored
* Use a LinkedList in ChangeNotifier implementation to take O(N^2) notification time to O(N)
-
- 14 Aug, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 12 Aug, 2020 2 commits
-
-
Alexandre Ardhuin authored
-
Jonah Williams authored
-
- 06 Aug, 2020 2 commits
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
Alexandre Ardhuin authored
-
- 05 Aug, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 28 Jul, 2020 1 commit
-
-
- 24 Jul, 2020 1 commit
-
-
Todd Volkert authored
Fixes https://github.com/flutter/flutter/issues/62223
-
- 23 Jul, 2020 2 commits
-
-
Greg Spencer authored
-
Todd Volkert authored
-
- 20 Jul, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 16 Jul, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 15 Jul, 2020 2 commits
-
-
Jonah Williams authored
-
Alexandre Ardhuin authored
* migrate foundation to nullsafety * address review comments
-
- 07 Jul, 2020 1 commit
-
- 06 Jul, 2020 2 commits
-
-
Andre authored
* Implement stack trace demangling in the framework.
- 23 Jun, 2020 1 commit
-
-
Dan Field authored
-
- 18 Jun, 2020 1 commit
-
-
Jonah Williams authored
A frequent request from the last Flutter developer survey was for an easier method of testing light/dark mode changes. Currently, a user needs to manually change the theme settings or adjust phone settings to see the difference. Instead we should add a toggle from the CLI, and eventually devtools/Intellij/Vscode that allows developers to override the current setting. Fixes #59495 Adds flutter.ext.brightnessOverride service protocol which either queries the current platform brightness, or overrides it to a new value. This accepts either Brightness.light or Brightness.dark as a value. Adds a CLI toggle b which allows the setting to be toggled manually. Requires an update to the MediaQuery, to conditionally use a debug override when not in release mode
-
- 17 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 16 Jun, 2020 3 commits
-
-
Greg Spencer authored
Remove dependency on package:collection by moving mergeSort into foundation/collections.dart (#59521) This removes a dependency from Flutter (package:collection) by copying the implementation of mergeSort into Flutter's foundation/collections.dart. Also, removed a reference to UnmodifiableSetView from the shortcuts code by just returning a copy instead.
-
Greg Spencer authored
-
Michael Goderbauer authored
* Word substitutions * ++
-