Commits · 0da0479702ca2b803529d489efba68f89f61e98f · abdullh.alsoleman / Front-End

05 Aug, 2023 3 commits

Manual roll Flutter Engine from 4f4734cd48da to a0d650e37f5d (3 revisions) (#131967) · 0da04797

engine-flutter-autoroll authored Aug 05, 2023

Manual roll requested by jacksongardner@google.com

Cannot build log URL because revision "a0d650e37f5d" is invalid: Luci builds of "Linux Web Framework tests" for a0d650e37f5d715468d8797519c622998ff5ab27 was FAILURE

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from a0b59bac20fc to 8a3277696c52 (1 revision) (flutter/engine#44405)
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZvUiUZL9vUp2LcvHG... to 3uzA1Z-yaMQE_Cz5f... (flutter/engine#44403)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 6dc76e862f90 to 7cf7e2da3557 (1 revision) (flutter/engine#44402)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZvUiUZL9vUp2 to 3uzA1Z-yaMQE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0da04797

Mark the ci_yaml roller task so that it is not backfilled. (#131966) · 45383def

Ricardo Amador authored Aug 05, 2023

In order to avoid new tasks from not being scheduled we are not going to backfill the autoroller because it can sometimes play transactions out of order causing issues with tasks that are scheduled but not known.

*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/127063

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

45383def

mark linux packages_autoroller flaky because of token issue (#131970) · a2fa60cc
Christopher Fujino authored Aug 05, 2023
```
unblock tree from https://github.com/flutter/flutter/issues/131968
```
a2fa60cc

04 Aug, 2023 21 commits

Sped up the time to find macrobenchmarks. (#131959) · 11025e4a

gaaclarke authored Aug 04, 2023

This reduce the execution time of macrobenchmarks driver tests.

I tried to find the exact size to scroll the screen but I couldn't find a way to do that with driver tests.

11025e4a

Roll Flutter Engine from c254deb8fbda to 4f4734cd48da (2 revisions) (#131955) · 53082f65

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/c254deb8fbda...4f4734cd48da

2023-08-04 chris@bracken.jp [Darwin] Enable ARC in darwin/common unit tests (flutter/engine#44396)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 45c0a830d805 to 6dc76e862f90 (2 revisions) (flutter/engine#44399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53082f65

Roll Flutter Engine from a7bea8621f4b to c254deb8fbda (3 revisions) (#131950) · b7acafa0

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/a7bea8621f4b...c254deb8fbda

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 85938bb68e75 to 45c0a830d805 (3 revisions) (flutter/engine#44397)
2023-08-04 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Take Screenshot and Handle Pointer Movement (flutter/engine#43972)
2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from b3372378e487 to a0b59bac20fc (1 revision) (flutter/engine#44393)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b7acafa0

Predictive back support for root routes (#120385) · dedd100e

Justin McCandless authored Aug 04, 2023

This PR aims to support Android's predictive back gesture when popping the entire Flutter app.  Predictive route transitions between routes inside of a Flutter app will come later.

<img width="200" src="https://user-images.githubusercontent.com/389558/217918109-945febaa-9086-41cc-a476-1a189c7831d8.gif" />

### Trying it out

If you want to try this feature yourself, here are the necessary steps:

  1. Run Android 33 or above.
  1. Enable the feature flag for predictive back on the device under "Developer
     options".
  1. Create a Flutter project, or clone [my example project](https://github.com/justinmc/flutter_predictive_back_examples).
  1. Set `android:enableOnBackInvokedCallback="true"` in
     android/app/src/main/AndroidManifest.xml (already done in the example project).
  1. Check out this branch.
  1. Run the app. Perform a back gesture (swipe from the left side of the
     screen).

You should see the predictive back animation like in the animation above and be able to commit or cancel it.

### go_router support

go_router works with predictive back out of the box because it uses a Navigator internally that dispatches NavigationNotifications!

~~go_router can be supported by adding a listener to the router and updating SystemNavigator.setFrameworkHandlesBack.~~

Similar to with nested Navigators, nested go_routers is supported by using a PopScope widget.

<details>

<summary>Full example of nested go_routers</summary>

```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:go_router/go_router.dart';

import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() => runApp(_MyApp());

class _MyApp extends StatelessWidget {
  final GoRouter router = GoRouter(
    routes: <RouteBase>[
      GoRoute(
        path: '/',
        builder: (BuildContext context, GoRouterState state) => _HomePage(),
      ),
      GoRoute(
        path: '/nested_navigators',
        builder: (BuildContext context, GoRouterState state) => _NestedGoRoutersPage(),
      ),
    ],
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: router,
    );
  }
}

class _HomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Nested Navigators Example'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text('Home Page'),
            const Text('A system back gesture here will exit the app.'),
            const SizedBox(height: 20.0),
            ListTile(
              title: const Text('Nested go_router route'),
              subtitle: const Text('This route has another go_router in addition to the one used with MaterialApp above.'),
              onTap: () {
                context.push('/nested_navigators');
              },
            ),
          ],
        ),
      ),
    );
  }
}

class _NestedGoRoutersPage extends StatefulWidget {
  @override
  State<_NestedGoRoutersPage> createState() => _NestedGoRoutersPageState();
}

class _NestedGoRoutersPageState extends State<_NestedGoRoutersPage> {
  late final GoRouter _router;
  final GlobalKey<NavigatorState> _nestedNavigatorKey = GlobalKey<NavigatorState>();

  // If the nested navigator has routes that can be popped, then we want to
  // block the root navigator from handling the pop so that the nested navigator
  // can handle it instead.
  bool get _popEnabled {
    // canPop will throw an error if called before build. Is this the best way
    // to avoid that?
    return _nestedNavigatorKey.currentState == null ? true : !_router.canPop();
  }

  void _onRouterChanged() {
    // Here the _router reports the location correctly, but canPop is still out
    // of date.  Hence the post frame callback.
    SchedulerBinding.instance.addPostFrameCallback((Duration duration) {
      setState(() {});
    });
  }

  @override
  void initState() {
    super.initState();

    final BuildContext rootContext = context;
    _router = GoRouter(
      navigatorKey: _nestedNavigatorKey,
      routes: [
        GoRoute(
          path: '/',
          builder: (BuildContext context, GoRouterState state) => _LinksPage(
            title: 'Nested once - home route',
            backgroundColor: Colors.indigo,
            onBack: () {
              rootContext.pop();
            },
            buttons: <Widget>[
              TextButton(
                onPressed: () {
                  context.push('/two');
                },
                child: const Text('Go to another route in this nested Navigator'),
              ),
            ],
          ),
        ),
        GoRoute(
          path: '/two',
          builder: (BuildContext context, GoRouterState state) => _LinksPage(
            backgroundColor: Colors.indigo.withBlue(255),
            title: 'Nested once - page two',
          ),
        ),
      ],
    );

    _router.addListener(_onRouterChanged);
  }

  @override
  void dispose() {
    _router.removeListener(_onRouterChanged);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return PopScope(
      popEnabled: _popEnabled,
      onPopped: (bool success) {
        if (success) {
          return;
        }
        _router.pop();
      },
      child: Router<Object>.withConfig(
        restorationScopeId: 'router-2',
        config: _router,
      ),
    );
  }
}

class _LinksPage extends StatelessWidget {
  const _LinksPage ({
    required this.backgroundColor,
    this.buttons = const <Widget>[],
    this.onBack,
    required this.title,
  });

  final Color backgroundColor;
  final List<Widget> buttons;
  final VoidCallback? onBack;
  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: backgroundColor,
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(title),
            //const Text('A system back here will go back to Nested Navigators Page One'),
            ...buttons,
            TextButton(
              onPressed: onBack ?? () {
                context.pop();
              },
              child: const Text('Go back'),
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

### Resources

Fixes https://github.com/flutter/flutter/issues/109513
Depends on engine PR https://github.com/flutter/engine/pull/39208 ✔ 
Design doc: https://docs.google.com/document/d/1BGCWy1_LRrXEB6qeqTAKlk-U2CZlKJ5xI97g45U7azk/edit#
Migration guide: https://github.com/flutter/website/pull/8952

dedd100e

Roll Flutter Engine from e9f80bff0703 to a7bea8621f4b (3 revisions) (#131948) · daf58279

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/e9f80bff0703...a7bea8621f4b

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 5eef2e2b94b4 to 85938bb68e75 (1 revision) (flutter/engine#44392)
2023-08-04 dnfield@google.com [Impeller] DlCanvas implementation wrapping Aiks canvas (flutter/engine#44248)
2023-08-04 30870216+gaaclarke@users.noreply.github.com [Impeller] Added a doc page to point out important impeller benchmarks (flutter/engine#44333)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

daf58279

Roll Flutter Engine from badca1f7f8c9 to e9f80bff0703 (6 revisions) (#131943) · ceb70d1a

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/badca1f7f8c9...e9f80bff0703

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from c40343629a6b to 5eef2e2b94b4 (1 revision) (flutter/engine#44391)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 03874e298589 to c40343629a6b (4 revisions) (flutter/engine#44389)
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FAGt3OEY8Yi1-SaFj... to jMLeVECzwzDoe9dYS... (flutter/engine#44388)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 636077ca3a50 to 03874e298589 (1 revision) (flutter/engine#44386)
2023-08-04 vegorov@google.com Roll buildroot to a067408d923ccf80742571bb7a71705499f5779e (flutter/engine#44385)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 100bf3248bf0 to 636077ca3a50 (1 revision) (flutter/engine#44384)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from FAGt3OEY8Yi1 to jMLeVECzwzDo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ceb70d1a

Mention `showTimePicker` function be can be used to show dialog with the time... · 05f9a96e

Taha Tesser authored Aug 04, 2023

Mention `showTimePicker` function be can be used to show dialog with the time picker in the `TimePickerDialog` docs (#131932)

fixes https://github.com/flutter/flutter/issues/131931

Every time I search for the time picker in the API docs I end up in the `TimePickerDialog` docs.

We should link `showTimePicker` so it can be easier to reach it and mention it can be used directly to show a dialog with a time picker.

05f9a96e

Check for simulator runtime in flutter doctor (#131795) · b39604e0

Victoria Ashworth authored Aug 04, 2023

Redo of https://github.com/flutter/flutter/pull/130728 - code is the same as before. That PR was stuck in Google testing and then I messed up the rebase so started over.

----

Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately. This adds a validation to `flutter doctor` to warn when the needed simulator runtime is missing.

Validation message looks like:
```
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    ! iOS 17.0 Simulator not installed; this may be necessary for iOS and macOS development.
      To download and install the platform, open Xcode, select Xcode > Settings > Platforms,
      and click the GET button for the required platform.

      For more information, please visit:
        https://developer.apple.com/documentation/xcode/installing-additional-simulator-runtimes
```

It may also show an error like this when something goes wrong when checking for the simulator:
```
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    â Unable to find the iPhone Simulator SDK.
```

Note: I'm unsure of in the future if the SDK and the simulator runtime will need to match the exact version or just the major. For now, it only checks against the major version.

Part 3 of https://github.com/flutter/flutter/issues/129558.

b39604e0

Roll Packages from d00c1f9eb01c to ce53da1bd741 (3 revisions) (#131935) · 1cf39074

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/packages/compare/d00c1f9eb01c...ce53da1bd741

2023-08-04 ditman@gmail.com [image_picker_web] Listens to file input cancel event. (flutter/packages#4453)
2023-08-04 maurits@vnbskm.nl [in_app_purchase] Updates handling of subscription price changes in README. (flutter/packages#4643)
2023-08-03 stuartmorgan@google.com [pigeon] Consolidate main Dart unit tests (flutter/packages#4641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1cf39074

Roll Flutter Engine from d15a02a8191c to badca1f7f8c9 (1 revision) (#131928) · 2ba9f7bd

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/d15a02a8191c...badca1f7f8c9

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 6415ba55bf6a to b3372378e487 (1 revision) (flutter/engine#44383)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ba9f7bd

Upgrade packages. (#131927) · 2c102959
Polina Cherkasova authored Aug 04, 2023

2c102959

Roll Flutter Engine from 0725a6f519d0 to d15a02a8191c (2 revisions) (#131924) · 6636b64c

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/0725a6f519d0...d15a02a8191c

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 9e35fa235af9 to 100bf3248bf0 (1 revision) (flutter/engine#44381)
2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 5573a23b0312 to 6415ba55bf6a (1 revision) (flutter/engine#44380)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6636b64c

Roll Flutter Engine from c912e3417e68 to 0725a6f519d0 (2 revisions) (#131917) · 3507f48e

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/c912e3417e68...0725a6f519d0

2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KPSWBhOvG6piddBQG... to ZvUiUZL9vUp2LcvHG... (flutter/engine#44377)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 3b36347d4449 to 9e35fa235af9 (1 revision) (flutter/engine#44374)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from KPSWBhOvG6pi to ZvUiUZL9vUp2

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3507f48e

Roll Flutter Engine from 03137a3b9b81 to c912e3417e68 (2 revisions) (#131913) · 229386cd

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/03137a3b9b81...c912e3417e68

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 03cc525d4485 to 3b36347d4449 (1 revision) (flutter/engine#44373)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 1f884c208390 to 03cc525d4485 (1 revision) (flutter/engine#44371)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

229386cd

Roll Flutter Engine from de0ec1c971ab to 03137a3b9b81 (1 revision) (#131912) · 3349ec62

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/de0ec1c971ab...03137a3b9b81

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from eb7670788799 to 5573a23b0312 (1 revision) (flutter/engine#44370)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3349ec62

Roll Flutter Engine from e3f75650ac5f to de0ec1c971ab (2 revisions) (#131910) · a353826b

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/e3f75650ac5f...de0ec1c971ab

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from a3d2051afa4a to 1f884c208390 (5 revisions) (flutter/engine#44369)
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qo3dJIXjK-Ia8j42J... to FAGt3OEY8Yi1-SaFj... (flutter/engine#44366)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Qo3dJIXjK-Ia to FAGt3OEY8Yi1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a353826b

make `--dart-define` override redundant values in `--dart-define-from-file` (#131088) · 30692ee4
Andrew Kolos authored Aug 04, 2023
```
Fixes #130604
```
30692ee4

Roll Flutter Engine from ca8d852eddfc to e3f75650ac5f (1 revision) (#131907) · b2381348

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/ca8d852eddfc...e3f75650ac5f

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from e3d2b4a190aa to eb7670788799 (1 revision) (flutter/engine#44363)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2381348

Roll Flutter Engine from 098ec489585e to ca8d852eddfc (2 revisions) (#131905) · f7b68919

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/098ec489585e...ca8d852eddfc

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 0a376550f218 to a3d2051afa4a (4 revisions) (flutter/engine#44362)
2023-08-03 ychris@google.com Revert "Build iOS unittest target in unopt builds" (flutter/engine#44356)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7b68919

Roll Flutter Engine from 4c62dd81d136 to 098ec489585e (2 revisions) (#131903) · 821a825e

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/4c62dd81d136...098ec489585e

2023-08-03 dnfield@google.com [Impeller] Fail loudly if --enable-software-rendering is used. (flutter/engine#44346)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 3b3c1a617544 to 0a376550f218 (3 revisions) (flutter/engine#44353)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

821a825e

Roll Flutter Engine from 0c1de9b8afba to 4c62dd81d136 (4 revisions) (#131902) · cfdf7295

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/0c1de9b8afba...4c62dd81d136

2023-08-03 matanlurey@users.noreply.github.com [Impeller] Run clangd tidy, opting out in 2 cases. (flutter/engine#44351)
2023-08-03 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Update text editing test skips" (flutter/engine#37655)
2023-08-03 jason-simmons@users.noreply.github.com [Impeller] Discard invalid command buffer handles after destroying a command pool (flutter/engine#44194)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from bae32428c1c7 to 3b3c1a617544 (1 revision) (flutter/engine#44345)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfdf7295

03 Aug, 2023 15 commits

Roll Flutter Engine from b08e1410a06a to 0c1de9b8afba (9 revisions) (#131897) · fd000dcd

engine-flutter-autoroll authored Aug 03, 2023

https://github.com/flutter/engine/compare/b08e1410a06a...0c1de9b8afba

2023-08-03 yjbanov@google.com [web] fix clicks on merged semantic nodes
(flutter/engine#43620)
2023-08-03 john@johnmccutchan.com Remove WARNINGs from JNI load path as
we can't suppress them (flutter/engine#44348)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 872dc53233cf to
bae32428c1c7 (3 revisions) (flutter/engine#44341)
2023-08-03 ychris@google.com Build iOS unittest target in unopt builds
(flutter/engine#44301)
2023-08-03 chris@bracken.jp [darwin] Move common targets to
common/BUILD.gn (flutter/engine#44335)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 2babe68de295 to
872dc53233cf (2 revisions) (flutter/engine#44339)
2023-08-03 kjlubick@users.noreply.github.com Migrate GL calls of
GrBackend* (flutter/engine#44334)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 36072a994f11 to
2babe68de295 (1 revision) (flutter/engine#44336)
2023-08-03 skia-flutter-autoroll@skia.org Roll Clang from 07c592048780
to 020d2fb7711d (flutter/engine#44332)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

fd000dcd

Fix TimePicker token issue link (#131863) · 0192f883

Taha Tesser authored Aug 03, 2023

Fix issue reference for https://github.com/flutter/flutter/issues/131247 (it was added in the bug fix PR https://github.com/flutter/flutter/pull/131253)

0192f883

[Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan... · f0e39349

gaaclarke authored Aug 03, 2023

[Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan and opengles (#131864)

issue: https://github.com/flutter/flutter/issues/131784

f0e39349

Revert "Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions)" (#131896) · 94890097
Zachary Anderson authored Aug 03, 2023
```
Reverts flutter/flutter#131880
```
94890097

Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions) (#131880) · 8f85bb35

engine-flutter-autoroll authored Aug 03, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/4cc0b3dab001...b08e1410a06a

2023-08-03 john@johnmccutchan.com Add @Keep annotations to avoid dead code elimination of classes only referenced by JNI (flutter/engine#44337)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from bd3ee535e246 to 36072a994f11 (2 revisions) (flutter/engine#44329)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from dcd09f5726b7 to e3d2b4a190aa (1 revision) (flutter/engine#44330)
2023-08-03 30870216+gaaclarke@users.noreply.github.com [Impeller] updated validation layers documentation (flutter/engine#44328)
2023-08-03 41930132+hellohuanlin@users.noreply.github.com [ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reusable (flutter/engine#44303)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 768050436c0a to bd3ee535e246 (2 revisions) (flutter/engine#44327)
2023-08-03 john@johnmccutchan.com Re-Re-Land Support for rendering Android Platform Views into a HardwareBuffer backed texture (flutter/engine#44326)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 8a377a9545b8 to 768050436c0a (1 revision) (flutter/engine#44320)
2023-08-03 bdero@google.com [Flutter GPU] Export symbols from engine, stub for testing on CI. (flutter/engine#44280)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f85bb35

Added new gallery benchmark test that forces opengles. (#131796) · 4247e1ef

gaaclarke authored Aug 03, 2023

fixes https://github.com/flutter/flutter/issues/131782

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Xilai Zhang <xilaizhang@google.com>

4247e1ef

Roll Packages from 4e4961a24b3d to d00c1f9eb01c (10 revisions) (#131866) · 4f9a7e29

engine-flutter-autoroll authored Aug 03, 2023

https://github.com/flutter/packages/compare/4e4961a24b3d...d00c1f9eb01c

2023-08-03 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.1 to 2.21.2 (flutter/packages#4637)
2023-08-03 engine-flutter-autoroll@skia.org Roll Flutter from b3f99ffe to c00d2419 (12 revisions) (flutter/packages#4640)
2023-08-03 jpnurmi@gmail.com [path_provider] Add getApplicationCachePath() - implementations (flutter/packages#4619)
2023-08-03 109253501+pdblasi-google@users.noreply.github.com [various] Removed references to deprecated `TestWindow` APIs (flutter/packages#4558)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.3.0 (flutter/packages#4432)
2023-08-02 jhy03261997@gmail.com [go_router_builder] Add go_router StatefulShellRoute support to go_router_builder (flutter/packages#4238)
2023-08-02 reidbaker@google.com [Tooling] Add google owned cache for dependencies as an option in ci (flutter/packages#4567)
2023-08-02 engine-flutter-autoroll@skia.org Roll Flutter from 1d59196b to b3f99ffe (32 revisions) (flutter/packages#4634)
2023-08-02 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Support `ShellRouteData` without `const` constructor (flutter/packages#4627)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.0 to 2.21.1 (flutter/packages#4573)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4f9a7e29

manual pub package roll (#131804) · 0d628b0f
Christopher Fujino authored Aug 03, 2023
```
manually ran `flutter update-packages --force-upgrade`
```
0d628b0f

remove Mac_ios ios_app_with_extensions_test (#131806) · 13ff16cb

Chris Yang authored Aug 03, 2023

Removing the extension test that unnecessarily running with devices.

The new hostonly tests were added in https://github.com/flutter/flutter/pull/131441

13ff16cb

Roll Flutter Engine from 46f3e099ad04 to 4cc0b3dab001 (3 revisions) (#131854) · 4df8d23e

engine-flutter-autoroll authored Aug 03, 2023

https://github.com/flutter/engine/compare/46f3e099ad04...4cc0b3dab001

2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from b81084128325 to 8a377a9545b8 (1 revision) (flutter/engine#44319)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from fac111d4acb3 to dcd09f5726b7 (1 revision) (flutter/engine#44317)
2023-08-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WwFjJuQF_rpToCYPJ... to Qo3dJIXjK-Ia8j42J... (flutter/engine#44316)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WwFjJuQF_rpT to Qo3dJIXjK-Ia

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4df8d23e

Adds a11y assessment sample app (#131716) · 3d74b0b7

chunhtai authored Aug 03, 2023

This app will be use for a11y assessments. See [design doc](http://go/flutter-gar-reporting-q3-2023)    (internal only)

3d74b0b7

Remove target Staging_build_linux framework_tests_misc (#126959) · 22f029e5

Mahmoud Zayad authored Aug 03, 2023

I deleted the target mentioned in the issue listed below. This is my first time contributing to open source please explain if I did anything wrong in the process or wrong with the changes. 

Best

*List which issues are fixed by this PR. You must list at least one issue.*
Resolves [#126278](https://github.com/flutter/flutter/issues/126278)

22f029e5

Manual roll Flutter Engine from 4c1157b9da54 to 46f3e099ad04 (3 revisions) (#131848) · b4c75017

engine-flutter-autoroll authored Aug 03, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/4c1157b9da54...46f3e099ad04

2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3b9af2825d47 to fac111d4acb3 (2 revisions) (flutter/engine#44315)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from d9d5ef855d75 to b81084128325 (2 revisions) (flutter/engine#44313)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from c0956a252f30 to d9d5ef855d75 (2 revisions) (flutter/engine#44311)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b4c75017

Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revisions) (#131830) · c00d2419

engine-flutter-autoroll authored Aug 03, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/9304c0074d29...4c1157b9da54

2023-08-03 jacksongardner@google.com Revert Android Hardware Texture PRs (flutter/engine#44310)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 87df1bbcea5e to 3b9af2825d47 (2 revisions) (flutter/engine#44308)
2023-08-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Hx7ap5qcoqRIknnnG... to WwFjJuQF_rpToCYPJ... (flutter/engine#44306)
2023-08-03 jason-simmons@users.noreply.github.com Check whether the lookup of android.hardware.HardwareBuffer found a class (flutter/engine#44304)
2023-08-02 bdero@google.com [Impeller] Add placeholder filter input. (flutter/engine#44290)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 6c1bab070220 to 6a09e41ce6ea (1 revision) (flutter/engine#44300)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from fd5bd67d532f to c0956a252f30 (1 revision) (flutter/engine#44296)
2023-08-02 chris@bracken.jp [iOS] Fix use-after-free in setBinaryMessenger (flutter/engine#44294)
2023-08-02 louiseh0313@gmail.com Add Search Web to selection controls on iOS (flutter/engine#43324)
2023-08-02 jason-simmons@users.noreply.github.com Improve logging in the clang-tidy script (flutter/engine#44228)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 335c6b86d70b to 6c1bab070220 (1 revision) (flutter/engine#44291)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 25f5a32367ad to fd5bd67d532f (2 revisions) (flutter/engine#44289)
2023-08-02 john@johnmccutchan.com Be sure to clear exceptions after a failed JNI lookup (flutter/engine#44293)
2023-08-02 derekx@google.com Handle deprecation of Dart_TimelineEvent Embedder API (flutter/engine#42497)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from ccc17f784e5d to 25f5a32367ad (4 revisions) (flutter/engine#44283)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 01ee134bb223 to 335c6b86d70b (2 revisions) (flutter/engine#44287)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 7104d0e8863f to ccc17f784e5d (2 revisions) (flutter/engine#44279)
2023-08-02 41930132+hellohuanlin@users.noreply.github.com [ios][autocorrection]disable auto-correction highlight in iOS 17 (flutter/engine#44176)
2023-08-02 john@johnmccutchan.com Reland Introduce TextureRegistry.ImageTexture and HardwareBufferExternalTextureGL (flutter/engine#44278)
2023-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from afbaf4216fc8 to 87df1bbcea5e (1 revision) (flutter/engine#44276)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 93764a98b866 to 7104d0e8863f (4 revisions) (flutter/engine#44273)
2023-08-02 jason-simmons@users.noreply.github.com [Impeller] Fix leak of wrapped TextureMTL objects in the Metal embedder API (flutter/engine#44245)
2023-08-02 737941+loic-sharma@users.noreply.github.com Revert "Listen to window notifications to update application lifecycle" (flutter/engine#44275)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 514c66ce0471 to 93764a98b866 (1 revision) (flutter/engine#44270)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Hx7ap5qcoqRI to WwFjJuQF_rpT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c00d2419

Assert against infinite values of control points in CatmullRomSpline (#131820) · b3a4decd

Kate Lovett authored Aug 03, 2023

When providing infinite values for the control points of CatmullRomSpline, a StackOverflowError occurs. This asserts against that and provides a helpful error message. 

Fixes https://github.com/flutter/flutter/issues/131246

b3a4decd

02 Aug, 2023 1 commit

Update stack_frame.dart to parse unexpected error format to null. (#131786) · 0ad45f24

Polina Cherkasova authored Aug 02, 2023

Fixes https://github.com/flutter/flutter/issues/131627

Originally this code sometimes was returning null and sometimes was failing, when stack frame is in unexpected format.

This PR updates for one of the code paths from failing to returning null.

0ad45f24