- 23 Nov, 2023 1 commit
-
-
- 16 Nov, 2023 1 commit
-
-
Ian Hickson authored
-
- 18 Oct, 2023 1 commit
-
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/130277 This PR does two things: 1. introduce a hidden `flutter build _preview` command, that will build a debug windows desktop app and copy it into the SDK's binary cache. This command is only intended to be run during packaging. 2. introduce a new device type, called `PreviewDevice`, which relies on the prebuilt desktop debug app from step 1, copies it into the target app's assets build folder, and then hot reloads their dart code into it.
-
- 23 Aug, 2023 1 commit
-
-
Ian Hickson authored
-
- 10 Aug, 2023 1 commit
-
-
Christopher Fujino authored
Fixes: https://github.com/flutter/flutter/issues/124970 Part of https://github.com/flutter/flutter/issues/47161 Before this change, there were two places we overrode the `Artifacts` in a Zone: 1. if/when we parse local-engine CLI options: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart#L281 2. an additional override for fuchsia platform dill (no longer used, deleted in this PR): https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/commands/attach.dart#L274 Note 1 above creates a new instance of `Artifacts.getLocalEngine()`. In this flow, there exist two instances of `Artifacts`: 1. The default fallback instance of `CachedArtifacts` (which gets all artifacts from flutter/bin/cache), instantiated in context_runner.dart: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/context_runner.dart#L137 2. An instance of `CachedLocalEngineArtifacts` created in the command runner once the CLI options have been parsed: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart#L281 The regression happened when we direct injected the Artifacts 1 from above BEFORE we parsed the local-engine flag, and then used this in the second zone override, and then when creating the `FlutterDevice` there are multiple calls to `globals.artifacts` returned it when it should have returned Artifacts 2: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/resident_runner.dart#L80 Device.artifactOverrides was originally introduced in https://github.com/flutter/flutter/pull/32071, but is no longer used, so I deleted it. I also removed direct injection of `Artifacts` to the attach sub-command, because that class now no longer references artifacts. I believe the ideal true fix for this would be to: 1. Migrate all leaf calls to `globals.artifacts` to use direct injection (in this case, the offending invocations were in [`FlutterDevice.create()`](https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/resident_runner.dart#L80-L218), but I'm not sure that something else would not have broken later) 2. Ensure we are always direct injecting the desired instance of `Artifacts`--that is, if the user desires local engine artifacts, that we are passing an instance of `CachedLocalEngineArtifacts`. a. Alternatively, and probably simpler, teach `CachedArtifacts` to know about the local engine. This would mean parsing the global CLI options BEFORE we ever construct any instance of `Artifacts`. As an overall recommendation for implementing https://github.com/flutter/flutter/issues/47161, in the overall tree of tool function calls, we should probably migrate the leaves first (that is, migrate the sub-commands last). We should also audit and reconsider any usage of `runZoned()` or `context.run()` for the purpose overriding zoneValues.
-
- 22 Jun, 2023 1 commit
-
-
Christopher Fujino authored
On the current stable branch (3.10.x), `flutter format` no longer works, and gives an error. This change just deletes the code. Fixes https://github.com/flutter/flutter/issues/115809
-
- 24 Mar, 2023 1 commit
-
-
Janice Collins authored
Suppress analytics flag pass through to analysis server
-
- 22 Mar, 2023 1 commit
-
-
Christopher Fujino authored
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
-
- 20 Mar, 2023 1 commit
-
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag #2
-
- 17 Mar, 2023 2 commits
-
-
Christopher Fujino authored
This reverts commit 7c3088cf.
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag
-
- 16 Mar, 2023 1 commit
-
-
Christopher Fujino authored
[flutter_tools] throw tool exit on invocation of flutter format
-
- 02 Dec, 2022 1 commit
-
-
Jackson Gardner authored
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified. This also uses precompiled platform kernel files for both ddc and dart2js
-
- 08 Nov, 2022 2 commits
-
-
Jesús S Guerrero authored
* update flutter build command * update tests * fix analyze suggestions
-
Alex Wallen authored
* Alphabetize setup calls * Add --flavor as an option for install * Add verbose logging in install command * Test that flavors build succeeds with proper flavor and fails with bogus one. * Remove unused import * The import was used... * SQUASH * Add flavor install test * Rename test * Add flavors install integration tests * correct error message * remove unused imports * Delete copy test * update test target * Refactor mechanism to read buildInfo * Remove unused import * Set affected test targets to bringup: true Co-authored-by:
a-wallen <stephenwallen@google.com>
-
- 27 Oct, 2022 2 commits
-
-
Jenn Magder authored
-
Christopher Fujino authored
-
- 18 Oct, 2022 1 commit
-
-
Jesús S Guerrero authored
-
- 03 Oct, 2022 1 commit
-
-
Gary Qian authored
-
- 14 Sep, 2022 1 commit
-
-
Elias Yishak authored
-
- 02 Sep, 2022 1 commit
-
-
Christopher Fujino authored
-
- 19 Aug, 2022 2 commits
-
-
Jesús S Guerrero authored
-
Tae Hyung Kim authored
* init * fix * fix 2 * fix 3 * tests * fix tests * clarify help text * fix all tests * fix formatting? * add second test * unused import * remove print * trailing spaces * artifacts is never null * fix
-
- 18 Aug, 2022 1 commit
-
-
jensjoha authored
-
- 15 Jul, 2022 1 commit
-
-
Jesús S Guerrero authored
-
- 24 Jun, 2022 1 commit
-
-
Jesús S Guerrero authored
-
- 15 Jun, 2022 1 commit
-
-
Jonah Williams authored
-
- 02 Feb, 2022 1 commit
-
-
Jason Simmons authored
-
- 12 Nov, 2021 1 commit
-
-
Christopher Fujino authored
-
- 02 Nov, 2021 1 commit
-
-
Jenn Magder authored
-
- 27 Oct, 2021 1 commit
-
-
Danny Tuppeny authored
-
- 29 Sep, 2021 1 commit
-
-
Kenzie (Schmoll) Davisson authored
-
- 30 Aug, 2021 1 commit
-
-
Sigurd Meldgaard authored
* Use `dart __deprecated_pub` instead of `pub` to invoke pub from tools The top level `pub` commmand has been deprecated and will print a message. It is however implemented via the __deprecated_pub command that prints no message.
-
- 13 Jul, 2021 1 commit
-
-
Jonah Williams authored
This reverts commit 53d8cba3.
-
- 12 Jul, 2021 2 commits
-
-
Ian Hickson authored
-
Jonah Williams authored
-
- 07 Jul, 2021 1 commit
-
-
Hannes Winkler authored
[custom-devices] general improvements, add custom-devices subcommand, better error handling (#82043)
-
- 01 Jul, 2021 1 commit
-
-
Ahmed Ashour authored
-
- 10 Jun, 2021 1 commit
-
-
Jonah Williams authored
-
- 24 May, 2021 1 commit
-
-
Jenn Magder authored
-