- 21 Jun, 2016 1 commit
-
-
Ian Hickson authored
Anywhere that accepted IconData now accepts either an Icon or an ImageIcon. Places that used to take an IconData in an `icon` argument, notably IconButton and DrawerItem, now take a Widget in that slot. You can wrap the value that used to be passed in in an Icon constructor to get the same result. Icon itself now takes the icon as a positional argument, for brevity. ThemeData now has an iconTheme as well as a primaryIconTheme, the same way it has had a textTheme and primaryTextTheme for a while. IconTheme.of() always returns a value now (though that value itself may have nulls in it). It defaults to the ThemeData.iconTheme. IconThemeData.fallback() is a new method that returns an icon theme data structure with all fields filled in. IconTheme.merge() is a new constructor that takes a context and creates a widget that mixes in the new values with the inherited values. Most places that introduced an IconTheme widget now use IconTheme.merge. IconThemeData.merge and IconThemeData.copyWith act in a way analogous to the similarly-named members of TextStyle. ImageIcon is introduced. It acts like Icon but takes an ImageProvider instead of an IconData. Also: Fix the analyzer to actually check the stocks app.
-
- 16 Jun, 2016 1 commit
-
-
Ian Hickson authored
Overview ======== This patch refactors images to achieve the following goals: * it allows references to unresolved assets to be passed around (previously, almost every layer of the system had to know about whether an image came from an asset bundle or the network or elsewhere, and had to manually interact with the image cache). * it allows decorations to use the same API for declaring images as the widget tree. It requires some minor changes to call sites that use images, as discussed below. Widgets ------- Change this: ```dart child: new AssetImage( name: 'my_asset.png', ... ) ``` ...to this: ```dart child: new Image( image: new AssetImage('my_asset.png'), ... ) ``` Decorations ----------- Change this: ```dart child: new DecoratedBox( decoration: new BoxDecoration( backgroundImage: new BackgroundImage( image: DefaultAssetBundle.of(context).loadImage('my_asset.png'), ... ), ... ), child: ... ) ``` ...to this: ```dart child: new DecoratedBox( decoration: new BoxDecoration( backgroundImage: new BackgroundImage( image: new AssetImage('my_asset.png'), ... ), ... ), child: ... ) ``` DETAILED CHANGE LOG =================== The following APIs have been replaced in this patch: * The `AssetImage` and `NetworkImage` widgets have been split in two, with identically-named `ImageProvider` subclasses providing the image-loading logic, and a single `Image` widget providing all the widget tree logic. * `ImageResource` is now `ImageStream`. Rather than configuring it with a `Future<ImageInfo>`, you complete it with an `ImageStreamCompleter`. * `ImageCache.load` and `ImageCache.loadProvider` are replaced by `ImageCache.putIfAbsent`. The following APIs have changed in this patch: * `ImageCache` works in terms of arbitrary keys and caches `ImageStreamCompleter` objects using those keys. With the new model, you should never need to interact with the cache directly. * `Decoration` can now be `const`. The state has moved to the `BoxPainter` class. Instead of a list of listeners, there's now just a single callback and a `dispose()` method on the painter. The callback is passed in to the `createBoxPainter()` method. When invoked, you should repaint the painter. The following new APIs are introduced: * `AssetBundle.loadStructuredData`. * `SynchronousFuture`, a variant of `Future` that calls the `then` callback synchronously. This enables the asynchronous and synchronous (in-the-cache) code paths to look identical yet for the latter to avoid returning to the event loop mid-paint. * `ExactAssetImage`, a variant of `AssetImage` that doesn't do anything clever. * `ImageConfiguration`, a class that describes parameters that configure the `AssetImage` resolver. The following APIs are entirely removed by this patch: * `AssetBundle.loadImage` is gone. Use an `AssetImage` instead. * `AssetVendor` is gone. `AssetImage` handles everything `AssetVendor` used to handle. * `RawImageResource` and `AsyncImage` are gone. The following code-level changes are performed: * `Image`, which replaces `AsyncImage`, `NetworkImage`, `AssetImage`, and `RawResourceImage`, lives in `image.dart`. * `DecoratedBox` and `Container` live in their own file now, `container.dart` (they reference `image.dart`). DIRECTIONS FOR FUTURE RESEARCH ============================== * The `ImageConfiguration` fields are mostly aspirational. Right now only `devicePixelRatio` and `bundle` are implemented. `locale` isn't even plumbed through, it will require work on the localisation logic. * We should go through and make `BoxDecoration`, `AssetImage`, and `NetworkImage` objects `const` where possible. * This patch makes supporting animated GIFs much easier. * This patch makes it possible to create an abstract concept of an "Icon" that could be either an image or a font-based glyph (using `IconData` or similar). (see https://github.com/flutter/flutter/issues/4494) RELATED ISSUES ============== Fixes https://github.com/flutter/flutter/issues/4500 Fixes https://github.com/flutter/flutter/issues/4495 Obsoletes https://github.com/flutter/flutter/issues/4496
-
- 12 Jun, 2016 1 commit
-
-
Adam Barth authored
We now use the `@required` annotation to encourage developers to explicitly set onPressed and onChanged callbacks to null when that would disable the widget. Fixes #287
-
- 28 Apr, 2016 1 commit
-
-
Adam Barth authored
Cassowary doesn't have any additional dependencies and this simplifies things. Fixes #2442
-
- 22 Apr, 2016 1 commit
-
-
Ian Hickson authored
The old names were getting silly and started stepping on valuable namespace. The new names are consistent and clear.
-
- 21 Apr, 2016 1 commit
-
-
Ian Hickson authored
Previously the widgets layer only provided a concrete binding, which makes it awkward to extend it compared to other bindings. This moves widgets to the same style as the other layers. In a subsequent patch I'll use this to make the tests layer saner.
-
- 20 Apr, 2016 1 commit
-
-
Ian Hickson authored
The 'routes' table is a point of confusion with new developers. By providing a 'home' argument that sets the '/' route, we can delay the point at which we teach developers about 'routes' until the point where they want to have a second route.
-
- 31 Mar, 2016 2 commits
-
-
Kris Giesing authored
-
Kris Giesing authored
Adds BuildOwner to manage the dirty list and build processing for widgets/elements, and adds a widget unit test to make sure separation is enforced. Fixes #2723
-
- 24 Mar, 2016 1 commit
-
-
Hixie authored
Previously, border with '0' was ambiguous. Sometimes we treated it as hairline borders, sometimes as "don't show the border", though even in the latter case we did some graphics work sometimes. Now we have an explicit BorderStyle.none flag to not draw the border efficiently.
-
- 21 Mar, 2016 1 commit
-
-
Ian Hickson authored
Also misc cleanup: - reorder members to be more consistent and fit the style guide - remove use of _Pair - made Variable.applyUpdate and Variable.owner public - added docs to Priority, tweaked the code a bit - added some docs to Result - removed the internal-error Result (replaced with asserts) - removed unused Results - made Result const - merged some files together since they had used privates a lot I'm sorry this is completely unreviewable. I did the move from `lib/*` to `lib/src/*` first, then did the `part`-to-`import` change, and then found out how many of the files involved privates, which I wasn't expecting. I can redo this as multiple commits if that would make it easier to review.
-
- 14 Mar, 2016 1 commit
-
-
Hixie authored
-
- 13 Mar, 2016 3 commits
-
-
Adam Barth authored
* justifyContent -> mainAxisAlignment * alignItems -> crossAxisAlignment * FlexJustifyContent -> MainAxisAlignment * FlexAlignItems -> CrossAxisAlignment Fixes #231
-
Adam Barth authored
* left -> leading (Removes an LTR bias) * center -> title (Widget was actually centered) * right -> actions (Removes an LTR bias, asymmetric with leading) Fixes #2348
-
Adam Barth authored
Fixes #2353
-
- 12 Mar, 2016 3 commits
-
-
Adam Barth authored
This patch renames StatelessComponent to StatelessWidget and StatefulComponent to StatefulWidget. Fixes #2308
-
Adam Barth authored
Fixes #1482
-
Adam Barth authored
Fixes #1382
-
- 11 Mar, 2016 1 commit
-
-
Adam Barth authored
We'll need this for RTL support because the RTL state will live in the widget tree. Also, remove the `oldWidget` argument to updateRenderObject because there aren't any clients for it.
-
- 02 Mar, 2016 2 commits
-
-
Hixie authored
Makes it easier to use without a SizeObserver
-
Adam Barth authored
Rather than managing all the Material Design icons manually, we now manage them using an icon font. The icon font contains glyphs for each icon in an efficient vector format. This patch updates the FLX tooling to include the MaterialIcons font and updates the Icon widget to use the font instead of asset images. Fixes #2313 Fixes #2218 Fixes #2009 Fixes #994
-
- 24 Feb, 2016 1 commit
-
-
Adam Barth authored
Now we just have one TextSpan class that handles both simple strings, trees of children, and styling both. This approach simplifies the interface for most clients. This patch also removes StyledText, which was weakly typed and tricky to use correctly. The replacement is RichText, which is strongly typed and uses TextSpan.
-
- 16 Feb, 2016 1 commit
-
-
Adam Barth authored
This object represents a rect the auto-layout system.
-
- 15 Feb, 2016 2 commits
-
-
Adam Barth authored
This patch makes it easier to use the auto layout API: * We no longer use operator== because that requires an ugly cast by the API user. * Also, "leftEdge" is now just "left" for less verbosity. * AutoLayoutChild not implies its key from the AutoLayoutParam object. * We now correctly layout every child of a RenderAutoLayout object even if the solver doesn't flush any updates to that child.
-
Adam Barth authored
This patch teaches the widget framework how to use Cassowary-based autolayout. To integrate autolayout with widgets, I had to refactor how RenderAutoLayout worked a bit. Now RenderAutoLayout follows the same delegate pattern we use for custom paint and custom layout.
-
- 13 Feb, 2016 1 commit
-
-
Adam Barth authored
Our examples have been growing organically over time. This patch cleans them up to illustrate specific aspects of Flutter.
-