Commits · 0cc2eff20463bacb76782f9401812f89a9d26bdb · abdullh.alsoleman / Front-End

17 Oct, 2023 20 commits

Revert "[SingleChildScrollView] Correct the offset pixels if it is out of... · 0cc2eff2
Kate Lovett authored Oct 17, 2023
```
Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" (#136744)
```
0cc2eff2

Skip injecting Bonjour settings when port publication is disabled (#136562) · 0383d8ba

Victoria Ashworth authored Oct 17, 2023

Some of our tests in CI are triggering the `NSLocalNetworkUsageDescription` dialog when they're not supposed to (https://github.com/flutter/flutter/issues/129836) since it's disabled via flags (`--no-publish-port` for flutter/flutter and `--disable-vm-service-publication` for flutter/engine).

Normally, we inject `NSLocalNetworkUsageDescription` (and other bonjour settings) to the Info.plist during the project build for debug and profile mode since by default they will publish the VM Service port over mDNS.

To help diagnose the issue, though, this PR changes it so that we don't inject `NSLocalNetworkUsageDescription` (and other bonjour settings) when port publication is disabled since it shouldn't be needed. Hopefully, this will give us better error messages or cause the app to crash and end the test early (rather than timeout after 30 minutes).

0383d8ba

Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) (#136739) · 24a762b7

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/3ecbe924a598...62a90a91cee3

2023-10-17 30870216+gaaclarke@users.noreply.github.com [Impeller] added trace statements for colorsources (flutter/engine#47007)
2023-10-17 chinmaygarde@google.com Move the secondary build tree into the engine. (flutter/engine#46989)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

24a762b7

Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) (#136732) · 5227d006

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/0a4d8b99a95b...3ecbe924a598

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from d937d10a0ba9 to 8b3f2ef48a90 (3 revisions) (flutter/engine#47005)
2023-10-17 jacksongardner@google.com Include symbol maps in CanvasKit and Skwasm builds. (flutter/engine#46973)
2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y9mDBoH4BSC6pWFXV... to VtEx0R7lepGAvwAMU... (flutter/engine#47004)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Y9mDBoH4BSC6 to VtEx0R7lepGA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5227d006

Reenable NexusLowRes API 29 (#136686) · d42b4bb5

Ricardo Amador authored Oct 17, 2023

Reenable the NexusLowRes API version 29 tests. 

*List which issues are fixed by this PR. You must list at least one issue.*
fixes https://buganizer.corp.google.com/issues/302753598
fixes flutter/flutter#135784

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

d42b4bb5

Reenable the nexus 6p tests (#136689) · c76761ea

Ricardo Amador authored Oct 17, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c76761ea

Removed TBD translations for optional remainingTextFieldCharacterCounZero message (#136684) · 6eea6e27
Hans Muller authored Oct 17, 2023
```
Fixes https://github.com/flutter/flutter/issues/136090
```
6eea6e27

Roll Flutter Engine from 86f685c87e06 to 0a4d8b99a95b (2 revisions) (#136727) · 7cfd3d47

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/86f685c87e06...0a4d8b99a95b

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from f7e15ba449f7 to d937d10a0ba9 (7 revisions) (flutter/engine#47003)
2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gJiEzqLWUvPVgoq8b... to E0Ui7KmD3u5JSKEk5... (flutter/engine#47000)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gJiEzqLWUvPV to E0Ui7KmD3u5J

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7cfd3d47

Roll Flutter Engine from 793fb7d85690 to 86f685c87e06 (1 revision) (#136725) · b0e56a39

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/793fb7d85690...86f685c87e06

2023-10-17 15619084+vashworth@users.noreply.github.com Only run web mac tests on macOS 12 (flutter/engine#46965)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b0e56a39

Roll Packages from 872d6d26c48b to d4390624a624 (4 revisions) (#136724) · 5739397e

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/packages/compare/872d6d26c48b...d4390624a624

2023-10-17 ditman@gmail.com [gis_web] Adds FedCM toggle. (flutter/packages#5123)
2023-10-17 tarrinneal@gmail.com [quick_actions] Convert android to pigeon (flutter/packages#5099)
2023-10-16 70025277+Nitin-Poojary@users.noreply.github.com [flutter_image] added example app (flutter/packages#4353)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter from b00216b3 to afc39160 (12 revisions) (flutter/packages#5156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5739397e

Roll Flutter Engine from 9c744ad5433a to 793fb7d85690 (1 revision) (#136721) · 13dc8a3c

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/9c744ad5433a...793fb7d85690

2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 82c073d657eb to 2418bda7a457 (1 revision) (flutter/engine#46997)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13dc8a3c

Roll Flutter Engine from 7d47532bb56f to 9c744ad5433a (1 revision) (#136719) · f2365f9d

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/7d47532bb56f...9c744ad5433a

2023-10-17 kjlubick@users.noreply.github.com Replace use of SkFont::refTypefaceOrDefault() (flutter/engine#46969)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2365f9d

Roll Flutter Engine from ace31a8eaea4 to 7d47532bb56f (1 revision) (#136717) · 387f75e3

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/ace31a8eaea4...7d47532bb56f

2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d0a805e4ee1 to 82c073d657eb (1 revision) (flutter/engine#46995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

387f75e3

Roll Flutter Engine from 077494a09872 to ace31a8eaea4 (1 revision) (#136713) · ecdaee82

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/077494a09872...ace31a8eaea4

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from c30529427b7d to f7e15ba449f7 (1 revision) (flutter/engine#46994)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ecdaee82

Roll Flutter Engine from 8be0b5398d41 to 077494a09872 (1 revision) (#136712) · 619a5b39

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/8be0b5398d41...077494a09872

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 31310feb67dc to c30529427b7d (2 revisions) (flutter/engine#46992)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

619a5b39

Roll Flutter Engine from 90bbe8ee4ac3 to 8be0b5398d41 (1 revision) (#136705) · c960cd5d

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/90bbe8ee4ac3...8be0b5398d41

2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from f3e1cd38e8b0 to 7d0a805e4ee1 (2 revisions) (flutter/engine#46991)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c960cd5d

Roll Flutter Engine from 6855e78a1aac to 90bbe8ee4ac3 (1 revision) (#136700) · d8c25396

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/6855e78a1aac...90bbe8ee4ac3

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 205b728a8623 to 31310feb67dc (2 revisions) (flutter/engine#46990)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d8c25396

Roll Flutter Engine from 2159fdb8461d to 6855e78a1aac (1 revision) (#136697) · f69e45c4

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/2159fdb8461d...6855e78a1aac

2023-10-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bMDZdOFfPiVkjIdiv... to gJiEzqLWUvPVgoq8b... (flutter/engine#46985)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bMDZdOFfPiVk to gJiEzqLWUvPV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f69e45c4

Roll Flutter Engine from 2d55e29dfa79 to 2159fdb8461d (8 revisions) (#136695) · 6074ff5e

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/2d55e29dfa79...2159fdb8461d

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 751358929d1f to 205b728a8623 (1 revision) (flutter/engine#46982)
2023-10-17 jason-simmons@users.noreply.github.com Revert "Fix `Platform.script` for flutter_tester" (flutter/engine#46981)
2023-10-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 12f6559bd6ed to f3e1cd38e8b0 (1 revision) (flutter/engine#46977)
2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6E-cSq679DjzBMcqY... to Y9mDBoH4BSC6pWFXV... (flutter/engine#46974)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 8919fecf15c1 to 751358929d1f (4 revisions) (flutter/engine#46972)
2023-10-16 jonahwilliams@google.com [Impeller] GPUTracer for Metal. (flutter/engine#46846)
2023-10-16 dnfield@google.com Fix `Platform.script` for flutter_tester (flutter/engine#46911)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 85c8dca08cbe to 8919fecf15c1 (1 revision) (flutter/engine#46966)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 6E-cSq679Djz to Y9mDBoH4BSC6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6074ff5e

Add docs to SchedulerBinding (#136433) · 4f6c2ccc
Todd Volkert authored Oct 17, 2023
```
Add documentation that I went looking for and didn't find :-)
```
4f6c2ccc

16 Oct, 2023 20 commits

Roll Flutter Engine from 83224dcd662e to 2d55e29dfa79 (3 revisions) (#136675) · 0acd1f21

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/83224dcd662e...2d55e29dfa79

2023-10-16 matej.knopp@gmail.com [macOS] FlutterMutatorView should clip to bounds (flutter/engine#46463)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 0e5207fb4971 to 85c8dca08cbe (1 revision) (flutter/engine#46964)
2023-10-16 john@johnmccutchan.com Allow Image backed platform view rendering target on Android >= 29 again (flutter/engine#46958)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0acd1f21

Roll Flutter Engine from c24f30343cf6 to 83224dcd662e (1 revision) (#136671) · 1dd49a8f

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/c24f30343cf6...83224dcd662e

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 68de6e352585 to 0e5207fb4971 (1 revision) (flutter/engine#46960)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1dd49a8f

Do not hold on to stale canvas reference in _RenderSegmentedButton (#136658) · 2df7244f

Dan Field authored Oct 16, 2023

Fixes https://github.com/flutter/flutter/issues/135747

Before this change, the render object was storing the `context.canvas` and using it after painting children. If those children were composited (e.g. because of an `Opacity` layer), the canvas it stored was disposed and not valid for use anymore.

2df7244f

Avoid use of Platform.script in isolates_test.dart (#136669) · c03dac9a

Dan Field authored Oct 16, 2023

Avoid using string replacement on a bogus string to get the relative directory of this test.

https://github.com/flutter/engine/pull/46911 will fix the behavior of Platform.script so it actually has the file being executed, but that will not be the file the test author wrote, it will be `listener.dart.dill` generated by tool code and running in a temp directory for this particular test.

We may want to come up with a more robust way of providing the test for framework test users, but we should do so in a way that will not limit the ability to run multiple tests in a single process if that offers performance benefits.

c03dac9a

Roll Flutter Engine from ca8cf6bc256d to c24f30343cf6 (3 revisions) (#136665) · b1d9642b

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/ca8cf6bc256d...c24f30343cf6

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 675f088b9ac4 to 68de6e352585 (1 revision) (flutter/engine#46956)
2023-10-16 30870216+gaaclarke@users.noreply.github.com [Impeller] implements a retry mechanism for dart:ui/Image.toByteData. (flutter/engine#46840)
2023-10-16 jason-simmons@users.noreply.github.com [Impeller] Adjust clip coverage operations to handle per-pass clip stacks (flutter/engine#46912)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b1d9642b

update analytics in generate api docs site to use new UA4 (#136497) · 4dcd1598
Christopher Fujino authored Oct 16, 2023
```
Change the analytics instance that the generated api.flutter.dev and master-api.flutter.dev use.
```
4dcd1598

Roll Flutter Engine from 64734a266683 to ca8cf6bc256d (2 revisions) (#136662) · bb7f0b23

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/64734a266683...ca8cf6bc256d

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 2db9c220ba00 to 675f088b9ac4 (2 revisions) (flutter/engine#46954)
2023-10-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 64a485bb79bd to 12f6559bd6ed (1 revision) (flutter/engine#46953)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb7f0b23

Roll Flutter Engine from 850de4ce0e75 to 64734a266683 (2 revisions) (#136659) · 06c1b1ec

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/850de4ce0e75...64734a266683

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 44a0f98aa71a to 2db9c220ba00 (1 revision) (flutter/engine#46949)
2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from c03c9a02f6ef to 44a0f98aa71a (1 revision) (flutter/engine#46947)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06c1b1ec

Fix prefer_mixin TODOs (#136480) · d564d39f

Michael Goderbauer authored Oct 16, 2023

Fixes https://github.com/flutter/flutter/issues/123172
Fixes https://github.com/dart-lang/sdk/issues/51813

In combination with https://github.com/flutter/flutter/pull/136418.

d564d39f

Cupertino search field test leak tracking and Fix.... · ce3e81d1

Binni Goel authored Oct 16, 2023

Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed.  (#136615)

ce3e81d1

Roll Flutter Engine from 6cc678c528d1 to 850de4ce0e75 (1 revision) (#136650) · bfed9c58

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/6cc678c528d1...850de4ce0e75

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 238ab1631282 to c03c9a02f6ef (1 revision) (flutter/engine#46946)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfed9c58

Roll Flutter Engine from 505c720fd10f to 6cc678c528d1 (1 revision) (#136646) · 545317ab

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/505c720fd10f...6cc678c528d1

2023-10-16 jason-simmons@users.noreply.github.com Avoid a deadlock in the flutter_tester process when deleting the Impeller Vulkan context during shutdown (flutter/engine#46860)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

545317ab

Roll Packages from fd84e6545a45 to 872d6d26c48b (5 revisions) (#136644) · 22c2ce72

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/packages/compare/fd84e6545a45...872d6d26c48b

2023-10-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.2 to 2.22.3 (flutter/packages#5151)
2023-10-15 engine-flutter-autoroll@skia.org Roll Flutter from 3865e49a to b00216b3 (34 revisions) (flutter/packages#5147)
2023-10-13 737941+loic-sharma@users.noreply.github.com [ci] Add x64 specific Windows platform (flutter/packages#5133)
2023-10-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.1 to 2.22.2 (flutter/packages#5138)
2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter from 83134ac7 to 3865e49a (80 revisions) (flutter/packages#5140)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

22c2ce72

Roll Flutter Engine from cfff75967b06 to 505c720fd10f (1 revision) (#136636) · afc39160

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/cfff75967b06...505c720fd10f

2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from CQhXLIfBTsZWBA4XM... to bMDZdOFfPiVkjIdiv... (flutter/engine#46943)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from CQhXLIfBTsZW to bMDZdOFfPiVk

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afc39160

Roll Flutter Engine from bd038d688ed3 to cfff75967b06 (1 revision) (#136635) · bc526d1b

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/bd038d688ed3...cfff75967b06

2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D-ejMxpgAyRoO6DUr... to 6E-cSq679DjzBMcqY... (flutter/engine#46942)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from D-ejMxpgAyRo to 6E-cSq679Djz

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc526d1b

Roll Flutter Engine from 15dee700867b to bd038d688ed3 (1 revision) (#136626) · 0b035e02

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/15dee700867b...bd038d688ed3

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 36503efe4154 to 238ab1631282 (1 revision) (flutter/engine#46940)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b035e02

Roll Flutter Engine from 41b3b4f90cd9 to 15dee700867b (1 revision) (#136625) · 88f30291

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/41b3b4f90cd9...15dee700867b

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from a83914bb86c9 to 36503efe4154 (1 revision) (flutter/engine#46939)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88f30291

Fix `NavigationRail`'s indicator inkwell doesn't support transparent color. (#136359) · 17c664fb

Taha Tesser authored Oct 16, 2023

fixes [NavigationRail can't have a transparent Hover color because there is always opacity set](https://github.com/flutter/flutter/issues/135866)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.green).copyWith(
          primary: Colors.transparent,
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({Key? key}) : super(key: key);

  @override
  State<StatefulWidget> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  int _selectedIndex = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('NavigationRail Example'),
      ),
      body: Row(
        children: <Widget>[
          NavigationRail(
            selectedIndex: _selectedIndex,
            onDestinationSelected: (int index) {
              setState(() {
                _selectedIndex = index;
              });
            },
            labelType: NavigationRailLabelType.all,
            destinations: const <NavigationRailDestination>[
              NavigationRailDestination(
                icon: Icon(Icons.favorite_border),
                selectedIcon: Icon(Icons.favorite),
                label: Text('First'),
              ),
              NavigationRailDestination(
                icon: Icon(Icons.bookmark_border),
                selectedIcon: Icon(Icons.book),
                label: Text('Second'),
              ),
              NavigationRailDestination(
                icon: Icon(Icons.star_border),
                selectedIcon: Icon(Icons.star),
                label: Text('Third'),
              ),
            ],
          ),
          const VerticalDivider(thickness: 1, width: 1),
          Expanded(
            child: Center(
              child: Text('Selected Index: $_selectedIndex'),
            ),
          )
        ],
      ),
    );
  }
}
```

</details>

17c664fb

Roll Flutter Engine from 12122eac2820 to 41b3b4f90cd9 (1 revision) (#136623) · 7124b69e

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/12122eac2820...41b3b4f90cd9

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 798ef5becc8d to a83914bb86c9 (1 revision) (flutter/engine#46938)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7124b69e

Roll Flutter Engine from 539ad5b232a6 to 12122eac2820 (2 revisions) (#136619) · 6d5691b4

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/539ad5b232a6...12122eac2820

2023-10-16 leroux_bruno@yahoo.fr Reland - [Android] Add support for text processing actions (flutter/engine#46817)
2023-10-16 dkwingsmt@users.noreply.github.com Revert "Reland: Enforce the rule of calling FlutterView.Render (#45300)" (flutter/engine#46919)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d5691b4