- 10 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
* Do not crash when toggeling Semantics on, off, on * review comments
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/12553 The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached. This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here. (This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
-
- 09 Jan, 2018 10 commits
-
-
Hans Muller authored
-
xster authored
* Lock events during runApp's warm up frame * move to scheduler binding * let the one scheduleWarmUpFrame api always lock * tweak test
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
Michael Goderbauer authored
to align with `SemanticsAction` and other enum-like types.
-
Ian Hickson authored
-
Ian Hickson authored
Fixes the last bits of #5759.
-
Ian Hickson authored
-
Ian Hickson authored
-
amirh authored
-
- 08 Jan, 2018 1 commit
-
-
Hans Muller authored
-
- 06 Jan, 2018 1 commit
-
-
Brian Egan authored
-
- 05 Jan, 2018 2 commits
-
-
Volodymyr Lykhonis authored
Unsubscribe should remove RouteAware for all routes.
-
-
- 04 Jan, 2018 2 commits
- 03 Jan, 2018 2 commits
-
-
xster authored
-
Michael Goderbauer authored
Fixes #13743 Fixes #12379 Follow-up to #13745 Also adds an option to hide gestures introduced by `InkWell` and `InkResponse` from the semantics tree (see also `GestureDetector.excludeFromSemantics`).
-
- 02 Jan, 2018 1 commit
-
-
Leaf Petersen authored
* Remaining code changes for Dart 2.0 SDK roll
-
- 22 Dec, 2017 3 commits
-
-
Todd Volkert authored
This reverts the change to `user_accounts_drawer_header.dart` (and the associated test), as it was causing regressions in layout of the drawer header. https://github.com/flutter/flutter/issues/13743
-
xster authored
* Create CupertinoScrollbar * handle main axis margin * Adaptive material scrollbar and tests * Small tweaks * reapply changes on head * Docs * start * Refactored ScrollbarPainter to be more immutable * fix tests * fix bug: one animationcontroller pointed to multiple painters * some docs tweak * remove unused import * review * review * add dispose
-
Michael Goderbauer authored
**tl;dr:** A `RenderObject` can only be an effective semantics boundary if it actually owned a `SemanticsNode` in the previous tree generation. When using the `BlockSemantics` widget it is possible to introduce `RenderObject`s that are configured to be a semantics boundary, but because their semantics are blocked by `BlockSemantics` they will not (immediately) end up owning a `SemanticsNode`. When now a descendant of such a node-less semantics boundary marks itself as needing a semantics update we walk up the tree until we find the closest semantics boundary (which is our node-less `RenderObject`). We now incorrectly assume that this semantics boundary has a valid `SemanticsNode` and only regenerate the semantics subtree below this node. However, because the identified semantics boundary doesn't actually own a valid `SemanticsNode` asserts are throwing (e.g. `Child with id xx is invisible and should not be added to tree.`). To fix this problem, we can just abort the walk if we reach a semantics boundary without a semantics node because (for now) we know that the semantics information of this branch will not make it into the final semantics tree. If the semantics block is ever removed, the current algorithm re-generates the semantics for the entire branch and the semantics will be up-to-date then despite the abort. I've added a test to verify this to make sure it continues to work even when we change the algorithm. Fixes https://github.com/flutter/flutter/issues/13326. /cc @gavindoughtie FYI
-
- 21 Dec, 2017 8 commits
-
-
amirh authored
-
Ian Hickson authored
This attempts to apply some of what we learnt from UX studies, namely that people wonder how to add multiple children to widget that take one child.
-
Ian Hickson authored
This is a collection of fixes I've run into recently.
-
Ian Hickson authored
Hopefully this will fix the performance regression in https://github.com/flutter/flutter/pull/13680 but with an easier way to flip the switch.
-
Leaf Petersen authored
Small code changes as part of moving the framework SDK forward to a 2.0 dev version.
-
Ian Hickson authored
This cleans up lerp, lerpFrom, lerpTo, and scale methods, and their documentation. Fixes https://github.com/flutter/flutter/issues/12377.
-
Yegor authored
* localize a11y tab labels in the TabBar * break import cycle * test boilerplate * fix German translation * more test boilerplate fixes
-
Yegor authored
* other accounts a11y; show accounts button a11y * layout with bigger tap areas; all semantics * internationalize UserAccountsDrawerHeader a11y labels * better Russian translation * break import cycle * address comments
-
- 20 Dec, 2017 3 commits
-
-
Ian Hickson authored
Fixes #12877 by reverting #9472
-
Yegor authored
* support increase and decrease SemanticsActions in time picker * test roll over
-
Michael Goderbauer authored
* selected ListTile is selected * review comment * analyzer fix
-
- 19 Dec, 2017 2 commits
-
-
Ian Hickson authored
Prevent header from thinking it can wrap and then overflowing. Fix default footer string which lost its colon (localized values are fine). Make the "rows per page" drop-down include at least one value even when the table lacks many items. (Previously it would assert if your table was too short.) Make the footer scrollable. Fix some todos and improve some debug output. Tests for much of the above.
-
Michael Goderbauer authored
* IconButton is a button, semantically * fix datepicker test
-
- 16 Dec, 2017 2 commits
-
-
Ian Hickson authored
No need to update the compositing bits all the time.
-
Chris Bracken authored
Applies any additional bottom, left, and right media padding inside the snackbar, if present. This accounts for the iPhone X home indicator widget and horizontal padding for the sensor housing notch in landscape orientation.
-
- 15 Dec, 2017 1 commit
-
-
xster authored
* split doc paragraph * specify shouldRepaint argument nullability * review
-