Commits · 0be1c490fcc6554fe5305f1b0a8278e247de55d3 · abdullh.alsoleman / Front-End

27 Dec, 2023 1 commit

Roll Flutter Engine from 38b9f3f96ff6 to 9c73cad6ae1a (1 revision) (#140630) · 0be1c490

engine-flutter-autoroll authored Dec 27, 2023

https://github.com/flutter/engine/compare/38b9f3f96ff6...9c73cad6ae1a

2023-12-26 737941+loic-sharma@users.noreply.github.com [Windows] Move DWM composition status to Windows proc table for mocking (flutter/engine#49397)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0be1c490

26 Dec, 2023 3 commits

Roll Flutter Engine from bdf261b536bd to 38b9f3f96ff6 (1 revision) (#140625) · 90c42182

engine-flutter-autoroll authored Dec 26, 2023

https://github.com/flutter/engine/compare/bdf261b536bd...38b9f3f96ff6

2023-12-26 737941+loic-sharma@users.noreply.github.com [Windows] Remove `PlatformWindow` and `RenderTarget` abstractions (flutter/engine#49312)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90c42182

Roll Packages from 23d2d9c01366 to fa74d3e1e71a (1 revision) (#140619) · 6c1e11ec

engine-flutter-autoroll authored Dec 26, 2023

https://github.com/flutter/packages/compare/23d2d9c01366...fa74d3e1e71a

2023-12-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.21 to 1.9.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5747)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6c1e11ec

Roll Flutter Engine from 8b839eda79d4 to bdf261b536bd (1 revision) (#140611) · a86e91f3

engine-flutter-autoroll authored Dec 26, 2023

https://github.com/flutter/engine/compare/8b839eda79d4...bdf261b536bd

2023-12-26 skia-flutter-autoroll@skia.org Roll Dart SDK from cf2d9652297b to add161c68e6d (1 revision) (flutter/engine#49390)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a86e91f3

23 Dec, 2023 2 commits

Roll Flutter Engine from deac5607d000 to 8b839eda79d4 (1 revision) (#140570) · 02d1d64e

engine-flutter-autoroll authored Dec 23, 2023

https://github.com/flutter/engine/compare/deac5607d000...8b839eda79d4

2023-12-23 skia-flutter-autoroll@skia.org Roll Dart SDK from c1f9520b30d7 to cf2d9652297b (1 revision) (flutter/engine#49382)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

02d1d64e

Roll Flutter Engine from 5981a3c68e70 to deac5607d000 (1 revision) (#140555) · cd718db7

engine-flutter-autoroll authored Dec 23, 2023

https://github.com/flutter/engine/compare/5981a3c68e70...deac5607d000

2023-12-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 25961234c1bc to c1f9520b30d7 (1 revision) (flutter/engine#49376)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd718db7

22 Dec, 2023 10 commits

Roll Flutter Engine from 0476141a016f to 5981a3c68e70 (1 revision) (#140552) · 29d42dde

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/0476141a016f...5981a3c68e70

2023-12-22 skia-flutter-autoroll@skia.org Roll Dart SDK from eec6568c209f to 25961234c1bc (1 revision) (flutter/engine#49373)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29d42dde

Roll Packages from 4c3bc496bed2 to 23d2d9c01366 (6 revisions) (#140550) · 4bc7a44e

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/packages/compare/4c3bc496bed2...23d2d9c01366

2023-12-22 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.1 to 1.3.3 (flutter/packages#5737)
2023-12-21 54558023+keyonghan@users.noreply.github.com Disable `presubmit: false` targets for recipes CQ (flutter/packages#5735)
2023-12-21 47866232+chunhtai@users.noreply.github.com [go_router] Refactored RouteMatchList and imperative APIs (flutter/packages#5497)
2023-12-21 54558023+keyonghan@users.noreply.github.com Add env_variables in ci.yaml (flutter/packages#5730)
2023-12-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2e9cb0aa71a3 to 78666c8dc57e (1 revision) (flutter/packages#5734)
2023-12-21 engine-flutter-autoroll@skia.org Roll Flutter from da0cd696 to 11def8ef (16 revisions) (flutter/packages#5732)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4bc7a44e

Roll Flutter Engine from 5448105a76f7 to 0476141a016f (1 revision) (#140549) · bba4c1f9

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/5448105a76f7...0476141a016f

2023-12-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 151b363886f9 to eec6568c209f (1 revision) (flutter/engine#49369)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bba4c1f9

Use double quotes over single quotes in gradle build files (#140512) · 48ae5ff6

Reid Baker authored Dec 22, 2023

Following https://developer.android.com/build/migrate-to-kotlin-dsl
2/n Use double quotes instead of single quotes.

Should be a no-op change. If you see a behavioral change please flag it.

48ae5ff6

Roll Flutter Engine from a8da67fed23b to 5448105a76f7 (1 revision) (#140540) · ede594f8

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/a8da67fed23b...5448105a76f7

2023-12-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 69423a5dd254 to 151b363886f9 (1 revision) (flutter/engine#49357)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ede594f8

Roll Flutter Engine from 1ba8fc0765f9 to a8da67fed23b (1 revision) (#140536) · 6126e4b4

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/1ba8fc0765f9...a8da67fed23b

2023-12-22 skia-flutter-autoroll@skia.org Roll Dart SDK from fe94d9b88531 to 69423a5dd254 (1 revision) (flutter/engine#49354)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6126e4b4

Roll Flutter Engine from 737e6f8ce85e to 1ba8fc0765f9 (4 revisions) (#140531) · 8024c5e4

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/737e6f8ce85e...1ba8fc0765f9

2023-12-22 dnfield@google.com Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337)
2023-12-21 flar@google.com [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334)
2023-12-21 flar@google.com [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342)
2023-12-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix incorrect surface manager comment (flutter/engine#49335)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8024c5e4

Migrate verify_codesigned. (#139328) · c73bffe7

godofredoc authored Dec 22, 2023

This is part of the migration of adhoc tests to shard tests.

Bug: https://github.com/flutter/flutter/issues/139153

c73bffe7

[web] unskip canvaskit tests that pass now (#140480) · c02ace6b
Yegor authored Dec 22, 2023
```
Unskip a few CanvasKit tests that pass now.
```
c02ace6b

Roll Flutter Engine from 1b1b2a12a597 to 737e6f8ce85e (5 revisions) (#140527) · 08e58bab

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/1b1b2a12a597...737e6f8ce85e

2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343)
2023-12-21 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336)
2023-12-21 magder@google.com Turn on scenario app screenshots (flutter/engine#49066)
2023-12-21 chris@bracken.jp Revert onrender change (flutter/engine#49333)
2023-12-21 yjbanov@google.com [web] autofocus in new routes (flutter/engine#47727)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08e58bab

21 Dec, 2023 15 commits

Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) (#140519) · b417fb82

engine-flutter-autoroll authored Dec 21, 2023

Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions)

https://github.com/flutter/engine/compare/c70f0a495ace...1b1b2a12a597

2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329)
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326)
2023-12-21 flar@google.com Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309)
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318)
2023-12-21 dnfield@google.com [Impeller] Make IPLR files multi-platform (flutter/engine#49253)
2023-12-21 ditman@gmail.com [web] Defer injection of platform views until needed. (flutter/engine#48960)
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311)
2023-12-21 skia-flutter-autoroll@skia.org Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310)
2023-12-21 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262)
2023-12-21 30870216+gaaclarke@users.noreply.github.com Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302)
2023-12-20 dkwingsmt@users.noreply.github.com Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266)
2023-12-20 barpac02@gmail.com SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148)
2023-12-20 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed Rect::Contains (flutter/engine#49294)
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295)
2023-12-20 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298)
2023-12-20 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206)
2023-12-20 dkwingsmt@users.noreply.github.com Multi-view pointer event (flutter/engine#46213)
2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758)
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289)
2023-12-20 bdero@google.com [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283)
2023-12-20 sergiy.dubovik@supercell.com [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824)
2023-12-20 zanderso@users.noreply.github.com Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244)
2023-12-20 15619084+vashworth@users.noreply.github.com Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242)
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288)
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287)
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285)
2023-12-20 kevinjchisholm@gmail.com [release] Update release config (flutter/engine#49254)
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274)
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269)
2023-12-20 goderbauer@google.com Sync lints with flutter/flutter (flutter/engine#49192)
2023-12-19 1961493+harryterkelsen@users.noreply.github.com [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214)
2023-12-19 barpac02@gmail.com [Docs] Add more info about running tests on iOS (flutter/engine#48859)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...

b417fb82

Roll pub packages (#140525) · 9c2a7560
flutter-pub-roller-bot authored Dec 21, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
9c2a7560
Run mac staging tests with Xcode 15 (#140518) · 2da1ff2d
Victoria Ashworth authored Dec 21, 2023
```
Run macOS staging tests with Xcode 15 and macOS 13. Also, cleanup some comments.
```
2da1ff2d

Make tests more resilient to Skia gold failures and refactor flutter_goldens... · 62f15949

Ian Hickson authored Dec 21, 2023

Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)

Originally landed in https://github.com/flutter/flutter/pull/139549
Originally reverted in https://github.com/flutter/flutter/pull/140085

- Remove all use of global variables.
- Always pass in all dependencies, only create them in main or in tests.
- Pass in the "print" primitive.
- Make all network traffic retry (except when run locally, when it just auto-passes).
- Enable tests to be run in random order.
- Better error messages

62f15949

Fix flavor conditional asset bundling for macos (#140433) · 9e104eb7

Andrew Kolos authored Dec 21, 2023

Fixes https://github.com/flutter/flutter/issues/140430
Fixes https://github.com/flutter/flutter/issues/140432 while we are at it

9e104eb7

Enable `android_preview_tool_integration_tests` check (#140470) · a3e0fa56

Gray Mackall authored Dec 21, 2023

Enables the check that was added in https://github.com/flutter/flutter/pull/131901.

Has been passing since https://github.com/flutter/flutter/pull/140099 (30 runs). Not sure what the normal number of successful runs we wait for is before enabling, let me know if we should wait for more data.

a3e0fa56

[flutter_tools] Ensure flutter daemon clients can detect preview device (#140112) · 674fbd26
Christopher Fujino authored Dec 21, 2023
```
Part of https://github.com/flutter/flutter/issues/130277
```
674fbd26

Add send_text_input_action case to deserialization_factory to allow... · 90badf70

Non Vachara authored Dec 21, 2023

Add send_text_input_action case to deserialization_factory to allow sendTextInputAction usages through flutter_driver. (#139197)

**As a follow up to https://github.com/flutter/flutter/pull/131776.**

**Summary:**
Previously in https://github.com/flutter/flutter/pull/106561, SendTextInputAction was added to Flutter Driver.
But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue.

**Issue:**
An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since https://github.com/flutter/flutter/pull/106561.

Previous works has been done in https://github.com/flutter/flutter/pull/131776, I merely added tests.

Best regards.

90badf70

Reverts "[web] Re-enable test now that source of flakiness is fixed" (#140515) · cb50d4a8

auto-submit[bot] authored Dec 21, 2023

Reverts flutter/flutter#140462
Initiated by: cbracken
This change reverts the following previous change:
Original Description:
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here https://github.com/flutter/engine/pull/49214

Fixes https://github.com/flutter/flutter/issues/137669

As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.

cb50d4a8

Reland: "Fix how Gradle resolves Android plugin" (#137115) · f5ac225c

Gustl22 authored Dec 21, 2023

Relands #97823

When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed.
Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform.

Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`.

Fixes #97729
Cause of the error: https://github.com/flutter/flutter/blob/5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c/packages/flutter_tools/gradle/flutter.gradle#L421C25-L421C25

Fixes #98048
The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases.

Related to #48918, see [_writeFlutterPluginsListLegacy](https://github.com/flutter/flutter/blob/27bc1cf61a5b54bf655062be63050123abb617e4/packages/flutter_tools/lib/src/flutter_plugins.dart#L248).
Co-authored-by: Emmanuel Garcia <egarciad@google.com>

f5ac225c

Roll Packages from dc5b267f3cd1 to 4c3bc496bed2 (1 revision) (#140511) · 430254e1

engine-flutter-autoroll authored Dec 21, 2023

https://github.com/flutter/packages/compare/dc5b267f3cd1...4c3bc496bed2

2023-12-20 15619084+vashworth@users.noreply.github.com Remove workarounds for `check_podspecs` needed for older version of Cocoapods (flutter/packages#5724)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

430254e1

Update README.md (#140382) · 11def8ef

Michael Thomsen authored Dec 21, 2023

Update the "fast results" subsection of readme with recent developments.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>

11def8ef

Revert "Integrate testWidgets with leak tracking. (#138057)" (#140502) · 8407dd2d
Jim Graham authored Dec 21, 2023
```
The PR is breaking the `flutter_test_performance` test and making the
tree red.
```
8407dd2d
Integrate testWidgets with leak tracking. (#138057) · d746007f
Polina Cherkasova authored Dec 21, 2023
```
Contributes to: https://github.com/flutter/flutter/issues/135856

TODO:
```
d746007f
Fix import pattern (#140425) · c0acd8c4
Qun Cheng authored Dec 21, 2023
```
This PR is just to fix the import pattern to follow the convention.
```
c0acd8c4

20 Dec, 2023 9 commits

Update job permissions (#140476) · cf3760bc

godofredoc authored Dec 20, 2023

Updates to use contents: write and pull-requests: write.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

cf3760bc

Roll pub packages (#140472) · 2d75f76b
flutter-pub-roller-bot authored Dec 20, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
2d75f76b
Remove outdated ignores from tool (#140467) · 68e346e4
Michael Goderbauer authored Dec 20, 2023
```
These were not ignoring anything (anymore).
```
68e346e4
Remove outdated ignores from framework (#140465) · c4fda233
Michael Goderbauer authored Dec 20, 2023
```
These were not ignoring anything (anymore).
```
c4fda233

Reland `find.textRange.ofSubstring` changes (#140469) · e2e8bcb1

LongCatIsLooong authored Dec 20, 2023

Extracted from https://github.com/flutter/flutter/pull/139717 as-is. Landing this change first so we can avoid doing a g3fix.

e2e8bcb1

Part 1/n migration steps for kotlin migration (#140452) · d6e435a7

Reid Baker authored Dec 20, 2023

Following https://developer.android.com/build/migrate-to-kotlin-dsl
1/n Add parentheses to method calls 

Should be a no-op change. If you see a behavioral change please flag it.

d6e435a7

Reverts "Make `TextSpan` hit testing precise." (#140468) · 9003f138

auto-submit[bot] authored Dec 20, 2023

Reverts flutter/flutter#139717
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/131435, #104594, #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).

Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.

The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.

Potential issues:

1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.

This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.

9003f138

[web] Re-enable test now that source of flakiness is fixed (#140462) · 11bfb3c4

Harry Terkelsen authored Dec 20, 2023

The test was flaky before due to overflowing GPU memory during the test.
The memory leak was fixed here
https://github.com/flutter/engine/pull/49214

Fixes https://github.com/flutter/flutter/issues/137669

As a side effect of the fix, this test also runs much faster, from about
3 minutes on my Macbook down to about 25 seconds.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

11bfb3c4

Eliminate Cirrus build status badge (#140461) · 7b0bfa8c

Chris Bracken authored Dec 20, 2023

We have no tasks running on Cirrus any more. This eliminates the "Build
Status - Cirrus" badge/link as well as the "Build status" link
reference, which was unused.

@CaseyHillers has filed a bug to add a Cocoon endpoint to replace it:
https://github.com/flutter/flutter/issues/140460

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

7b0bfa8c