- 20 Feb, 2024 1 commit
-
-
Nate authored
This PR is the 9áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496) I did a pass through all of `packages/flutter/lib/src/` and found an abundance of `switch` statements to improve. Whereas #143496 focused on in-depth refactoring, this PR is full of simple, straightforward changes. (I ended up making some more complicated changes in `rendering/` and will file those separately after this PR is done.)
-
- 07 Feb, 2024 1 commit
-
-
- 12 Jan, 2024 1 commit
-
-
Anis Alibegić authored
Fair amount of typos spotted and fixed. Some of them are in comments, some of them are in code and some of them are in nondart files. There is no need for issues since it's a typo fix. I have doubts about [packages/flutter_tools/lib/src/ios/core_devices.dart](https://github.com/flutter/flutter/compare/master...anisalibegic:flutter:master#diff-fdbc1496b4bbe7e2b445a567fd385677af861c0093774e3d8cc460fdd5b794fa), I have a feeling it might broke some things on the other end, even though it's a typo.
-
- 02 Jan, 2024 1 commit
-
-
Polina Cherkasova authored
Contributes to https://github.com/flutter/flutter/issues/140622
-
- 20 Dec, 2023 1 commit
-
-
Michael Goderbauer authored
These were not ignoring anything (anymore).
-
- 18 Dec, 2023 1 commit
-
-
Bartek Pacia authored
This PR applies [the suggestion made here](https://github.com/flutter/devtools/pull/6942#issuecomment-1852773200).
-
- 16 Dec, 2023 1 commit
-
-
Bartek Pacia authored
Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (#139942) This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now. This is mainly targeted at https://github.com/flutter/flutter/issues/17988 Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961 part 2: [flutter] use `SemanticsUpdateBuilderNew` https://github.com/flutter/flutter/pull/138331 part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/48882 **part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here part 5: [engine] remove `SemanticsBuilderNew`
-
- 11 Dec, 2023 1 commit
-
-
Bartek Pacia authored
This PR adds `String? identifier` to `Semantics` and `SemanticsProperties`. The `identifier` will be exposed on Android as `resource-id` and on iOS as `accessibilityIdentifier`. Mainly targeted at #17988 Initial Engine PR with Android support: https://github.com/flutter/engine/pull/47961 iOS Engine PR: https://github.com/flutter/engine/pull/48858 ### Migration This change breaks the SemanticsUpdateBuilder API which is on the Framework<-->Engine border. For more details see [engine PR](https://github.com/flutter/engine/pull/47961). Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961 **part 2: [flutter] use `SemanticsUpdateBuilderNew`** <-- we are here part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`* part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again. part 5: [engine] remove `SemanticsBuilderNew`
-
- 15 Nov, 2023 1 commit
-
-
Binni Goel authored
-
- 06 Nov, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 01 Nov, 2023 1 commit
-
-
Dan Field authored
Fixes https://github.com/flutter/flutter/issues/137696 This will get the tree green again. The problem is that `CustomSemanticsAction` has static state in it, and todays test seed order makes things unhappy.
-
- 27 Oct, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/54665
-
- 24 Oct, 2023 1 commit
-
-
cui fliter authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* fix some typos *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 13 Sep, 2023 1 commit
-
-
chrisdlangham authored
removes unused variable in the example code of semantic events https://api.flutter.dev/flutter/semantics/FocusSemanticEvent-class.html
-
- 31 Jul, 2023 1 commit
-
-
Qun Cheng authored
-
- 17 Jul, 2023 1 commit
-
-
Greg Price authored
These methods and/or their docs were recently copied (in #128467 and #128973) from their classes' former shared base class AbstractNode. Their wording was fittingly abstract there, but that abstraction is a bit puzzling for a reader finding them on these more concrete classes and not aware of the AbstractNode history. So make them more concrete, in similar terms to the other methods around them. Also copy some useful points between corresponding methods on different classes (like that the parent of the root is null), and try to clean up the prose on [RenderObject.depth]. We focus on the more outward-facing parts of the API, letting methods like `redepthChildren` continue to talk generically about "nodes".
-
- 14 Jul, 2023 1 commit
-
-
Michael Goderbauer authored
Small clean up. A file probably doesn't need multiple way to refer to dart:ui concepts.
-
- 14 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 09 Jun, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/35112
-
- 05 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
- 31 May, 2023 1 commit
-
-
hangyu authored
issue: #94523 engine pr: https://github.com/flutter/engine/pull/41777
-
- 12 Apr, 2023 1 commit
-
-
Bernardo Ferrari authored
`SemanticsFlag`/`SemanticsAction` cleanup (part 4)
-
- 07 Apr, 2023 1 commit
-
-
chunhtai authored
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
-
- 31 Mar, 2023 1 commit
-
-
Bernardo Ferrari authored
`SemanticsFlag`/`SemanticsAction` enum migration (part 2)
-
- 23 Mar, 2023 2 commits
-
-
Michael Goderbauer authored
-
Jacob MacDonald authored
implement Iterator and Comparable instead of extending them
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 01 Mar, 2023 1 commit
-
- 28 Feb, 2023 2 commits
-
-
Michael Goderbauer authored
Fix how tests count open SemanticsHandles
-
Michael Goderbauer authored
showOnScreen does not crash if target node doesn't exist anymore
-
- 27 Feb, 2023 1 commit
-
- 24 Feb, 2023 1 commit
-
-
Michael Goderbauer authored
Move semantic-related bindings to SemanticsBinding
-
- 23 Feb, 2023 1 commit
-
-
chunhtai authored
* Fix text.rich to merge widget span * migrate to new API * update * addressing comment * addressing comments * update * addressing comment * Update
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* Remove unnecessary null checks in flutter/animation * Remove unnecessary null checks in flutter/semantics * Remove unnecessary null checks in flutter/scheduler
-
- 16 Dec, 2022 1 commit
-
- 11 Dec, 2022 2 commits
-
-
Ian Hickson authored
-
Casey Hillers authored
Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)" (#116839) This reverts commit 352ad3a9.
-
- 07 Dec, 2022 1 commit
-
-
chunhtai authored
* Adds semantics merger API and fix input decorator * addressing comments * abstractnode to object * feature complete * addressing comments * fix comments * conditionally add sort order * fix bool * fix test * more fix * fix tests
-
- 17 Nov, 2022 1 commit
-
-
Ahmed Ashour authored
Fixes #115468
-