- 27 Feb, 2020 11 commits
-
-
Jonah Williams authored
-
Kaushik Iska authored
Working around https://github.com/flutter/flutter/issues/46173
-
Jonah Williams authored
-
Jonah Williams authored
-
engine-flutter-autoroll authored
* 8af3b1b4d Roll src/third_party/skia f0a13d04c233..7f5e3c7e43c7 (6 commits) (flutter/engine#16810) * 060a7733a Roll fuchsia/sdk/core/linux-amd64 from QU3ft... to 94el1... (flutter/engine#16821)
-
Zachary Anderson authored
This reverts commit f1cd47ef.
-
Zachary Anderson authored
-
Jonah Williams authored
-
Greg Spencer authored
When Focus.unfocus is called, the caller usually just thinks about wanting to remove focus from the node, but really, unfocus is a request to automatically pass the focus to another (hopefully useful) node. This PR removes the focusPrevious flag from unfocus, and replaces it with a disposition enum that indicates where the focus should go from here. The other value of the UnfocusDisposition enum is UnfocusDisposition.scope. UnfocusDisposition.previouslyFocusedChild is closest to what focusPrevious used to do: focus the nearest enclosing scope and use its focusedChild field to walk down the tree, finding the leaf focusedChild. This PR modifies it slightly so that it walks up to the nearest focusable enclosing scope before trying to focus the children. This change addresses #48903 A new mode: UnfocusDisposition.scope will focus the nearest focusable enclosing scope of this node without trying to use the FocusScopeNode.focusedChild value to descend to the leaf focused child. This is useful as a default for both text field finalization and for what happens when canRequestFocus is set to false. It allows the scope to stay focused so that nextFocus/previousFocus still work as expected, but removes the focus from primary focus. In addition to those changes, unfocus called on a FocuScope that wasn't the primary focus used to unfocus the primary focus instead. I removed that behavior, since it was buggy: if the primary focus was inside of a child scope, and you called unfocus on the parent scope, then the child scope could have focused another of its children instead, leaving the scope that you called unfocus on with hasFocus returning true still. If you want to remove the focus from the primary focus instead of the scope, that's easy enough to do: just call primaryFocus.unfocus(). Fixes #48903
-
Dan Field authored
-
- 26 Feb, 2020 21 commits
-
-
Ferhat authored
-
Jenn Magder authored
-
Christopher Fujino authored
-
Jenn Magder authored
-
Jonah Williams authored
-
Alexander Aprelev authored
* Fix expression evaluation test leaking flutter_tester processes. Let flutter_tester process complete, wait for it completion, kill the test only if didn't complete on time. * Type annotation
-
Lynn authored
-
Greg Spencer authored
This implements VisualDensity changes for text fields*. By default, the layout of the text field does not change. If the ThemeData.visualDensity is set to a value other than zero, then the density of the UI will increase or decrease. See the VisualDensity docs for more information. (*In reality, the changes are on the InputDecorator class, not on the text field.) I also fixed a problem that I think I found with _Decoration where it doesn't compare isDense or isCollapsed as part of its operator==.
-
Miguel Beltran authored
-
engine-flutter-autoroll authored
* 05dd02368 Roll src/third_party/dart 73f6d15665a3..7aa824076c34 (11 commits) (flutter/engine#16780) * 9f439d9ef Roll src/third_party/skia 19304d88c8be..6d927b63a311 (3 commits) (flutter/engine#16782) * effd8a069 Roll src/third_party/skia 6d927b63a311..a6572f78d084 (3 commits) (flutter/engine#16783) * af90e8b11 Manually add third_party/dart/pkg/stagehand to DEPS (flutter/engine#16785) * ae999f090 Roll fuchsia/sdk/core/mac-amd64 from O6w2L... to 8gjOI... (flutter/engine#16787) * d0897c321 Roll src/third_party/dart 7aa824076c34..2ce1df76309d (11 commits) (flutter/engine#16788) * 7af8d3ee9 Roll src/third_party/skia a6572f78d084..c8d092a060ad (1 commits) (flutter/engine#16789) * fb3dc8603 Roll src/third_party/dart 2ce1df76309d..85f6d51c3fd1 (6 commits) (flutter/engine#16792) * 468b371ff Roll src/third_party/skia c8d092a060ad..7a6db4cbf48b (2 commits) (flutter/engine#16795) * ff921cd60 fuchsia: remove use of replace_as_executable (flutter/engine#16690) * d590e9841 Evict BitmapCanvas(s) from cache when canvas allocation fails (flutter/engine#16793) * 52070e3df Fix handler unregistration in C++ channels (flutter/engine#16794) * 592b3ff21 Roll src/third_party/skia 7a6db4cbf48b..d8575452ebf3 (3 commits) (flutter/engine#16799) * 9ac76ad5a [web] changing user limits for macos (flutter/engine#16797) * 7685e080b [web] Guard the remaining calls to window.onPlatformMessage (flutter/engine#16791) * 328654311 Roll src/third_party/skia d8575452ebf3..adc9bbb2aaca (2 commits) (flutter/engine#16801) * 29cff9eb5 Roll fuchsia/sdk/core/mac-amd64 from 8gjOI... to 3B3a6... (flutter/engine#16803) * fc3a15e7f Roll src/third_party/skia adc9bbb2aaca..7b96793ccc5b (3 commits) (flutter/engine#16804) * f1a9dc1c9 Roll src/third_party/skia 7b96793ccc5b..f0a13d04c233 (1 commits) (flutter/engine#16805) * ecabc1037 Roll src/third_party/dart 85f6d51c3fd1..418923733006 (30 commits) (flutter/engine#16813)
-
Jonah Williams authored
-
engine-flutter-autoroll authored
* 858185cd5 Roll src/third_party/skia 659cc1c90705..19304d88c8be (5 commits) (flutter/engine#16778) * ecdfc91d1 Roll fuchsia/sdk/core/linux-amd64 from PGfiE... to QU3ft... (flutter/engine#16779)
-
Jonah Williams authored
-
Jonah Williams authored
-
Jonah Williams authored
This reverts commit 59cc3cdf.
-
Vyacheslav Egorov authored
This reverts commit 492fb638. Reason for revert: Dart HHH infrastructure including Golem builders are using older images which have older curl which does not support these flags. Upgrading images takes long time - so in the interim we are forced to revert to avoid accumulating gap in coverage.
-
Fedor Korotkov authored
Retry downloading Dart SDK at least 3 times with a 5 seconds wait in between retries
-
Christopher Fujino authored
-
Alexandre Ardhuin authored
-
- 25 Feb, 2020 8 commits
-
-
Dan Field authored
-
Zachary Anderson authored
-
stuartmorgan authored
Adds utility code for managing list of plugin projects within a solution file, updating them as the plugins change. This is a prototype of an approach to solution-level portion of Windows plugin tooling; it may not be what the final plugin handling on Windows uses, but it makes things much better in the short term, and gives us a baseline to evaluate other possible solution management systems against. Part of #32719
-
Greg Spencer authored
Remove deprecated DefaultFocusTraversal widget
-
Ferhat authored
-
Nate Bosch authored
Fixes #51010 The test package differentiates between passing and not passing this argument. A previous version had a bug that treated passing `0` identically to not passing the argument, and the flutter test runner relied on this bug by always passing a value and using a default of `0`. - Remove the argument defaults throughout to make it clear that `null` is a valid value and the default. - Remove the argument defaulting on the argument parser. - Update the wording of the usage for this argument, this will also be updated on the `package:test` side.
-
Zachary Anderson authored
-
Christopher Fujino authored
-