Commits · 08b06137349ed47ab0d883301cced89ed32d7e83 · abdullh.alsoleman / Front-End

28 May, 2023 3 commits

Roll Flutter Engine from 57e491a46e05 to 340936f7c03c (1 revision) (#127767) · 08b06137

engine-flutter-autoroll authored May 28, 2023

https://github.com/flutter/engine/compare/57e491a46e05...340936f7c03c

2023-05-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from quUGdiiyRbktsRim0... to eMdFANziUJ6ruPzTB... (flutter/engine#42388)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from quUGdiiyRbkt to eMdFANziUJ6r

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08b06137

Roll Flutter Engine from a37b1a38d97a to 57e491a46e05 (1 revision) (#127765) · 7b6befdb

engine-flutter-autoroll authored May 28, 2023

https://github.com/flutter/engine/compare/a37b1a38d97a...57e491a46e05

2023-05-28 zanderso@users.noreply.github.com Revert "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (flutter/engine#42384)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b6befdb

Roll Flutter Engine from b1698020bd57 to a37b1a38d97a (1 revision) (#127761) · e7c0d995

engine-flutter-autoroll authored May 28, 2023

https://github.com/flutter/engine/compare/b1698020bd57...a37b1a38d97a

2023-05-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ZriEcC35K72RWcSKL... to 4JHzZE8eUAzUVTDo0... (flutter/engine#42385)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from ZriEcC35K72R to 4JHzZE8eUAzU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e7c0d995

27 May, 2023 6 commits

Roll Flutter Engine from 9e97c7379c7f to b1698020bd57 (1 revision) (#127758) · bca76440

engine-flutter-autoroll authored May 27, 2023

https://github.com/flutter/engine/compare/9e97c7379c7f...b1698020bd57

2023-05-27 skia-flutter-autoroll@skia.org Roll Skia from 408059b57e25 to 643fae1b1559 (1 revision) (flutter/engine#42383)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bca76440

Roll Flutter Engine from 0f38a0f0a18a to 9e97c7379c7f (1 revision) (#127755) · 003bd4a1

engine-flutter-autoroll authored May 27, 2023

https://github.com/flutter/engine/compare/0f38a0f0a18a...9e97c7379c7f

2023-05-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2-z8tqXe3ZkKqeb3e... to quUGdiiyRbktsRim0... (flutter/engine#42382)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 2-z8tqXe3ZkK to quUGdiiyRbkt

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

003bd4a1

Roll Flutter Engine from 1187168472a7 to 0f38a0f0a18a (1 revision) (#127752) · c23aadc7

engine-flutter-autoroll authored May 27, 2023

https://github.com/flutter/engine/compare/1187168472a7...0f38a0f0a18a

2023-05-27 skia-flutter-autoroll@skia.org Roll Skia from 8d475ae01f09 to 408059b57e25 (2 revisions) (flutter/engine#42381)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c23aadc7

Roll Flutter Engine from 3426cb827efb to 1187168472a7 (1 revision) (#127745) · fe22aaca

engine-flutter-autoroll authored May 27, 2023

https://github.com/flutter/engine/compare/3426cb827efb...1187168472a7

2023-05-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from f94C9eArSWIUjOTM6... to ZriEcC35K72RWcSKL... (flutter/engine#42379)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from f94C9eArSWIU to ZriEcC35K72R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fe22aaca

Roll Flutter Engine from 795db50e7453 to 3426cb827efb (9 revisions) (#127738) · a9c82e2c

engine-flutter-autoroll authored May 27, 2023

https://github.com/flutter/engine/compare/795db50e7453...3426cb827efb

2023-05-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 14162b5f5a1a to e0caea366989 (3 revisions) (flutter/engine#42376)
2023-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c6-zqvlx2YtyGwGzJ... to f94C9eArSWIUjOTM6... (flutter/engine#42367)
2023-05-26 gspencergoog@users.noreply.github.com Adding app lifecycle notification for macOS and Linux, add `hidden` state. (flutter/engine#40542)
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from bc65e3f5efa0 to 14162b5f5a1a (3 revisions) (flutter/engine#42366)
2023-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9aZkaKhX4GslPUnbX... to 2-z8tqXe3ZkKqeb3e... (flutter/engine#42365)
2023-05-26 54558023+keyonghan@users.noreply.github.com Fix ci yaml roller caused by incorrect format (flutter/engine#42364)
2023-05-26 chris@bracken.jp [macOS] Extract more PlatformViewMutator code (flutter/engine#42361)
2023-05-26 zanderso@users.noreply.github.com Enable bugprone-unchecked-optional-access, disable in files with warnings (flutter/engine#42359)
2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from ac897edeb16a to 8d475ae01f09 (9 revisions) (flutter/engine#42363)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9aZkaKhX4Gsl to 2-z8tqXe3ZkK
fuchsia/sdk/core/mac-amd64 from c6-zqvlx2Yty to f94C9eArSWIU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a9c82e2c

Updated the `ToggleButtons` API doc to link to `SegmentedButton` (#127021) · 9bce7901
Taha Tesser authored May 27, 2023
```
fixes https://github.com/flutter/flutter/issues/124884
```
9bce7901

26 May, 2023 31 commits

Remove more `test_api/src` imports (#127716) · 0b9cd865

Nate Bosch authored May 26, 2023

Replace imports of `src/remote_listener.dart` with `backend.dart` which exports `RemoteListener`.

Remove the unused imports of `src/backend/stack_trace_formatter.dart` (no uses of `StackTraceFormatter`) and
`src/backend/suite_channel_manager.dart` (no uses of `SuiteChannelManager`).

0b9cd865

Move shared inline widget logic to `RenderInlineWidgetContainerDefaults` (#127308) · b5df180a

LongCatIsLooong authored May 26, 2023

- Added `InlineWidgetContainerDefaults` for deduping inline widget code
- Added a helper function `WidgetSpan.extractFromInlineSpan` for extracting `WidgetSpan`s and automatically applying text scaling (at widget level)
- Removed `TextPainter.inlinePlaceholderScales`. I'm going to deprecate the `scale` argument in `TextPainter.addPlaceholder` next, as scaling is now done at the widget level.
- Added runtime check and comments to make sure nobody is extending `PlaceholderSpan` directly (unfortunately we can't remove `PlaceholderSpan`  without moving RenderEditable and RenderParagraph to the widgets library).

b5df180a

Roll Flutter Engine from 3b5b5fc96b8f to 795db50e7453 (1 revision) (#127720) · 49901d34

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/3b5b5fc96b8f...795db50e7453

2023-05-26 rmolivares@renzo-olivares.dev [macOS] Do not bounce editing state back to framework on setEditState (flutter/engine#42091)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

49901d34

Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (#127511) · 5bf63186

Phil Quitslund authored May 26, 2023

The newly updated lint will soon flag for-each in collections.

See discussion: https://github.com/dart-lang/linter/pull/4383

/cc @goderbauer

5bf63186

Roll Flutter Engine from eed12f36f595 to 3b5b5fc96b8f (1 revision) (#127713) · 1a062a09

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/eed12f36f595...3b5b5fc96b8f

2023-05-26 mdebbar@google.com [web] Correct JS property name for baseUri (flutter/engine#42357)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a062a09

Remove references to deprecated `ThemeData.primaryColorBrightness` (#127238) · 0da6f04f

Greg Spencer authored May 26, 2023

## Description

Removes references to `ThemeData.primaryColorBrightness`, deprecated in https://github.com/flutter/flutter/pull/93396 and subject to remove now because of our [deprecation policy](https://github.com/flutter/flutter/wiki/Tree-hygiene#deprecations).

## Related PRs
 - https://github.com/flutter/flutter/pull/93396

## Tests
 - Removed unneeded tests, removed references.

0da6f04f

TwoDimensional scrolling foundation (#125437) · 0f1a95d1

Kate Lovett authored May 26, 2023

From the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation) â  updated 4/25

Fixes https://github.com/flutter/flutter/issues/125505

Follow up issues:
- https://github.com/flutter/flutter/issues/126297
- https://github.com/flutter/flutter/issues/126298
- https://github.com/flutter/flutter/issues/126299
-  https://github.com/flutter/flutter/issues/122348

This adds a mostly abstract foundation for 2D scrolling in Flutter.

With these base classes, developers will be able to construct widgets that scroll in both dimensions and can lazily load their children for the best performance. This implementation is meant to be flexible in order to support different kinds of 2D compositions, from tables to scatter plots. 

The upcoming TableView, TreeView, etc widgets (coming soon in flutter/packages) are built on top of this foundation.

0f1a95d1

Roll Flutter Engine from 858d9753453c to eed12f36f595 (2 revisions) (#127702) · 15fa5b53

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/858d9753453c...eed12f36f595

2023-05-26 30870216+gaaclarke@users.noreply.github.com Started executing vulkan unit tests with validation on macos (flutter/engine#42337)
2023-05-26 dnfield@google.com [Impeller] Avoid encoding metal commands while the GPU is unavailable when decoding images. (flutter/engine#42349)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15fa5b53

Remove button announcement for `MenuItemButton` and `SubmenuButton` (#127620) · a4de77a2
Qun Cheng authored May 26, 2023

a4de77a2

Reland "Update labeler action wildcards #127524" (#127690) · 20637188

Casey Hillers authored May 26, 2023

See last commit for the addition. This passes in yaml lint

https://github.com/flutter/flutter/issues/126002

20637188

Revert "Log all lines from ios-deploy (#127502)" (#127684) · 8e6a9e3a

Victoria Ashworth authored May 26, 2023

This reverts commit a19b3436.

We added this logging to try and determine if the reason for Dart VM errors (https://github.com/flutter/flutter/issues/121231) was caused by some issue with the streams.
A recent test proves that is not the case:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_view_ios__start_up/11046/overview
The test shows the Dart VM url in the device log. However, the test log does NOT show a log for the Dart VM url but does show the stack trace, which all come from the main stream, which means it's not an issue with the secondary streams not receiving the log.

So reverting the debugging we added.

8e6a9e3a

Roll Flutter Engine from ec7b0ae3599f to 858d9753453c (2 revisions) (#127700) · bd10c79b

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/ec7b0ae3599f...858d9753453c

2023-05-26 mdebbar@google.com [web] Use the new js_util.callMethod(Object, Object) (flutter/engine#42352)
2023-05-26 jacksongardner@google.com Don't use a factory constructor on the finalization registry. (flutter/engine#42350)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd10c79b

Add M3 date range picker tests and fix header background theme color (#127662) · 5d555eb2
Taha Tesser authored May 26, 2023

5d555eb2

Support minifcation for apps that depend on AGP 8 and integration_test (#127628) · 9376a2ac

Reid Baker authored May 26, 2023

- Set exported proguard rules for consumers of integration_test using AGP 8.0 
- Updated proguard usage in example to test setting custom proguard rules works.

#127388

Documentation for how consumerProguardFiles works. https://developer.android.com/studio/projects/android-library#Considerations

Unknown why we had to use ** instead of matching exactly.

9376a2ac

Bump Snippet version (#127688) · 5c0eb2d9

Greg Spencer authored May 26, 2023

## Description

Bumps the version for snippets to the latest version.

## Related Issues
 - https://github.com/flutter/flutter/issues/127320

## Tests
 - No test changes needed.

5c0eb2d9

[Linux] Use up_client_get_devices2 when possible (#127699) · be9dbfa9

Chris Bracken authored May 26, 2023

The Linux platform channels sample makes a call to the libupower function `up_client_get_devices`, which was deprecated in libupower 0.99.8 in favour of `up_client_get_devices2`.

In order to build both for users on older versions of libupower, such as 0.99.7, which ships with Ubuntu 18.04 (Bionic), as well as users on newer versions where `up_client_get_devices` is deprecated, this adds a preprocessor check and selects the function available on the host system on which the build takes place.

The Flutter devicelab prod bots have been migrated to Ubuntu 20.04 LTS (Focal) which includes 0.99.11, but the trybots are still in the process of being migrated. This allows the build to work on both, and makes life easier for users running on a variety of Linux distributions.

No tests are added or modified since `up_client_get_devices` and `up_client_get_devices2` have the same semantics.

See: https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices
See: https://gitlab.freedesktop.org/upower/upower/-/blob/master/libupower-glib/up-version.h.in

Note: the `UP_CHECK_VERSION` macro has been around since 2010 (13 years ago), when DKP was forked into libupower. https://gitlab.freedesktop.org/upower/upower/-/commit/27fada20be7feba6783abc5b6cad91ee274ad3df

Issue: https://github.com/flutter/flutter/issues/127611

be9dbfa9

Roll Flutter Engine from 84f2fc16e55d to ec7b0ae3599f (3 revisions) (#127698) · 51d6de18

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/84f2fc16e55d...ec7b0ae3599f

2023-05-26 godofredoc@google.com Checkout android and emsdk deps in linux. (flutter/engine#42339)
2023-05-26 110993981+htoor3@users.noreply.github.com [web] - Fix autofill group input ordering (flutter/engine#42268)
2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from 1622df035714 to ac897edeb16a (1 revision) (flutter/engine#42348)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51d6de18

Fix `TextField` error in production environment because it wrongly uses... · c1558f69

fzyzcjy authored May 26, 2023

Fix `TextField` error in production environment because it wrongly uses ancestor render boxes (#126324)

Fixes a crash in a reparented TextField due to frame render phase timing

c1558f69

Interactive viewer doesn't appear to respect the trackpadScrollCausesScale parameter (#127114) · 28605398
Jonathan Green authored May 26, 2023
```
Fix a bug when using InteractiveViewer.trackpadScrollCausesScale
```
28605398
Remove release timeline (#127685) · a655b057
Casey Hillers authored May 26, 2023
```
Fixes https://github.com/flutter/flutter/issues/127592
```
a655b057

Manual roll Flutter Engine from 8573f3b63a1f to 84f2fc16e55d (7 revisions) (#127676) · 8f09fa5d

engine-flutter-autoroll authored May 26, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/8573f3b63a1f...84f2fc16e55d

2023-05-26 zanderso@users.noreply.github.com Revert Dart SDK to 398e847c0b24ad2e57194844410613b7dadcb74f (flutter/engine#42347)
2023-05-26 jason-simmons@users.noreply.github.com Apply the drawShadow bounds workaround to the Web HTML backend (flutter/engine#42304)
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from f17b745f5c3c to 398e847c0b24 (1 revision) (flutter/engine#42345)
2023-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AgIKKqtBtb6RJnyI9... to c6-zqvlx2YtyGwGzJ... (flutter/engine#42344)
2023-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DNwJQMQZladAsKTjv... to 9aZkaKhX4GslPUnbX... (flutter/engine#42343)
2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from 7e20e6679785 to 1622df035714 (1 revision) (flutter/engine#42342)
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from bc65e3f5efa0 to f17b745f5c3c (1 revision) (flutter/engine#42341)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from DNwJQMQZladA to 9aZkaKhX4Gsl
fuchsia/sdk/core/mac-amd64 from AgIKKqtBtb6R to c6-zqvlx2Yty

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f09fa5d

Roll Packages from 995bfc5f9857 to 9f8dcc562b55 (4 revisions) (#127671) · ee162e4b

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/packages/compare/995bfc5f9857...9f8dcc562b55

2023-05-25 54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/packages#4074)
2023-05-25 10687576+bparrishMines@users.noreply.github.com [url_launcher_android] Fix `unawaited_futures` lint errors (flutter/packages#4086)
2023-05-25 stuartmorgan@google.com [url_launcher] Convert Android to Pigeon (flutter/packages#4045)
2023-05-25 pq@users.noreply.github.com [multiple packages] Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (flutter/packages#4073)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee162e4b

Roll Flutter Engine from 474fcbbe445e to 8573f3b63a1f (1 revision) (#127647) · 369192ae

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/474fcbbe445e...8573f3b63a1f

2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from a47a68da8291 to 7e20e6679785 (1 revision) (flutter/engine#42340)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

369192ae

Roll Flutter Engine from f63fcf5a274e to 474fcbbe445e (1 revision) (#127644) · 02c6873d

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/f63fcf5a274e...474fcbbe445e

2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from be337bef2ad5 to a47a68da8291 (1 revision) (flutter/engine#42338)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

02c6873d

Roll Flutter Engine from b6fcbe31ba1a to f63fcf5a274e (1 revision) (#127642) · 5654eafb

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/b6fcbe31ba1a...f63fcf5a274e

2023-05-26 jacksongardner@google.com Proper memory management in Skwasm (flutter/engine#42328)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5654eafb

Roll Flutter Engine from bec5da5bff7c to b6fcbe31ba1a (1 revision) (#127641) · f8bbbef4

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/bec5da5bff7c...b6fcbe31ba1a

2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from f2de22b5f0f6 to be337bef2ad5 (1 revision) (flutter/engine#42336)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f8bbbef4

Roll Flutter Engine from 593d4d6b1f9b to bec5da5bff7c (2 revisions) (#127638) · 3ec57515

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/593d4d6b1f9b...bec5da5bff7c

2023-05-26 skia-flutter-autoroll@skia.org Roll Skia from bd677c195886 to f2de22b5f0f6 (1 revision) (flutter/engine#42335)
2023-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 5697e9123611 to bc65e3f5efa0 (2 revisions) (flutter/engine#42334)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ec57515

Roll Flutter Engine from f4dc96aef71b to 593d4d6b1f9b (1 revision) (#127635) · 6c2041e1

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/f4dc96aef71b...593d4d6b1f9b

2023-05-26 jason-simmons@users.noreply.github.com [Impeller] Disable the wide gamut settings flag on iOS simulators (flutter/engine#42331)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6c2041e1

Roll Flutter Engine from ff04d2fdd12b to f4dc96aef71b (2 revisions) (#127633) · 77acfe9c

engine-flutter-autoroll authored May 26, 2023

https://github.com/flutter/engine/compare/ff04d2fdd12b...f4dc96aef71b

2023-05-25 dkwingsmt@users.noreply.github.com [macOS] Multi-view thread synchronizer (flutter/engine#41915)
2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0e78305875a4 to 5697e9123611 (1 revision) (flutter/engine#42327)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

77acfe9c

Remove a bad assert from tooltip implementation (#127629) · 56808b48

LongCatIsLooong authored May 26, 2023

Fixes https://github.com/flutter/flutter/issues/127575

The `_handleMouseEnter` and `_handleMouseExit` calls are balanced, but the tooltip could be dismissed by an external `PointerDown` event interacting with a different UI component so the ` assert(_activeHoveringPointerDevices.isNotEmpty);` does not really make sense.

56808b48

Remove rounding from TextPainter (#127099) · 43de3365

LongCatIsLooong authored May 26, 2023

To opt-in, run the tests with: `SKPARAGRAPH_REMOVE_ROUNDING_HACK=1 flutter test --dart-define=SKPARAGRAPH_REMOVE_ROUNDING_HACK=1 `

Migration plans:
1. Turn the flags on in CI, migrate customer tests if needed
1. Migrate internal customers
2. Remove the flag from skparagraph. Remove the framework flag with a manual engine roll.

Also fixes https://github.com/flutter/flutter/issues/52038

43de3365