Commits · 089e93a15c4529e8ef87eaf056a07e634c91f1da · abdullh.alsoleman / Front-End

21 Sep, 2023 6 commits

Roll Flutter Engine from 3e66ffa6aae6 to a4b1ef79596a (1 revision) (#135206) · 089e93a1

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/3e66ffa6aae6...a4b1ef79596a

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

089e93a1

Form fields onChange callback should be called on reset (#134295) · 07cc3f7a

Bruno Leroux authored Sep 21, 2023

## Description

This PR fixes form fields in order to call the `onChange` callback when the form is reset.

This change is based on the work done in https://github.com/flutter/flutter/pull/123108.

I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`. 

## Related Issue

Fixes https://github.com/flutter/flutter/issues/123009.

## Tests

Adds 3 tests.

07cc3f7a

Roll Flutter Engine from 88aad1056781 to 3e66ffa6aae6 (2 revisions) (#135200) · 518b7751

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/88aad1056781...3e66ffa6aae6

2023-09-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zuOP7YCHHocXuZJcD... to 3DKf4d8UFviYKRI28... (flutter/engine#46133)
2023-09-21 jonahwilliams@google.com [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zuOP7YCHHocX to 3DKf4d8UFviY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

518b7751

Roll Flutter Engine from 76e5e35ab395 to 88aad1056781 (1 revision) (#135198) · b90a13f3

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/76e5e35ab395...88aad1056781

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a7bcbb9a39f3 to 81b9c7fd19b2 (1 revision) (flutter/engine#46129)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b90a13f3

Roll Flutter Engine from 89d864552acd to 76e5e35ab395 (21 revisions) (#135192) · c416aa47

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/89d864552acd...76e5e35ab395

2023-09-21 matanlurey@users.noreply.github.com Tidy up `DlPaint` and friends. (flutter/engine#46120)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 86f48da2c812 to a7bcbb9a39f3 (1 revision) (flutter/engine#46128)
2023-09-21 30870216+gaaclarke@users.noreply.github.com [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127)
2023-09-20 jonahwilliams@google.com [Impeller] Remove removal of save layer from clip. (flutter/engine#46113)
2023-09-20 jason-simmons@users.noreply.github.com [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106)
2023-09-20 matanlurey@users.noreply.github.com Clang tidy-ify `DlColor` and friends. (flutter/engine#46122)
2023-09-20 godofredoc@google.com Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b78c91996051 to 86f48da2c812 (4 revisions) (flutter/engine#46121)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119)
2023-09-20 matanlurey@users.noreply.github.com Make `dl_color_(filter|source)` tidy. (flutter/engine#46111)
2023-09-20 matanlurey@users.noreply.github.com Make `dl_(image|mask|path)_(filter|effect).h` tidy! (flutter/engine#46110)
2023-09-20 matanlurey@users.noreply.github.com Migrate from `LOG_X` to `kLogX`. (flutter/engine#46107)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118)
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes in Impeller. (flutter/engine#46116)
2023-09-20 ychris@google.com [ios] fix asset url not found when loading app extension (flutter/engine#46073)
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes. (flutter/engine#46114)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from c19115e8f712 to b3c1f49821d8 (3 revisions) (flutter/engine#46112)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (flutter/engine#46108)
2023-09-20 mdebbar@google.com [web] Move context menu handling to its own class (flutter/engine#46042)
2023-09-20 matanlurey@users.noreply.github.com Delete `ci/lint.sh`, which is no longer used. (flutter/engine#46049)
2023-09-20 mdebbar@google.com [web] Make `PlatformViewManager` a clear singleton (flutter/engine#46044)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c416aa47

Rename `debugProfilePlatformChannels` to a constant that works in release mode (#134922) · f92884c7

Jia Hao authored Sep 21, 2023

When it comes to startup profiling, it is very helpful to look at platform channels. `debugProfilePlatformChannels` today only works in debug and profile mode. Unfortunately, using profile mode is less accurate for startup profiling, because of the service isolate introducing additional overhead.

This PR allows this toggle to work in release mode. Note that there are two parts to `debugProfilePlatformChannels`:

- Adding timeline events
- Logging statistics about platform channels

I also considered adding a separate toggle to limit the scope of this change to the former, but that seems like complexity that we might not need at this time.

Towards #102189

f92884c7

20 Sep, 2023 34 commits

Mark ReastaurationManager not disposed (#134832) · a0406ccc
derdilla authored Sep 20, 2023

a0406ccc
cover more tests with leak tracing (#134834) · 237db2bb
derdilla authored Sep 20, 2023

237db2bb
Fix leak in hardware_keyboard_test.dart (#134380) · 2868bc13
derdilla authored Sep 20, 2023

2868bc13
Fix memory leak in _SelectableTextState (#135049) · 04854e8a
Kostia Sokolovskyi authored Sep 20, 2023

04854e8a

Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) (#135169) · 1bfd6a1f

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/39c0f2ea1f53...89d864552acd

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 565d95f72f2e to f4238844089f (3 revisions) (flutter/engine#46105)
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed05ca364d5e to d5d05146868a (1 revision) (flutter/engine#46104)
2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aHtib4LBcLwx7JwK-... to QcxgV9KlY7j3o3b4j... (flutter/engine#46102)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 9bc5eeb93a1e to 565d95f72f2e (1 revision) (flutter/engine#46100)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aHtib4LBcLwx to QcxgV9KlY7j3

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1bfd6a1f

[deps] Update package:web dependency. (#135174) · a4bc8946

David Iglesias authored Sep 20, 2023

This PR is the result of running:

```console
$ flutter upgrade-packages --force-upgrade
```

### Issues

* Fixes https://github.com/flutter/flutter/issues/135075
* Supersedes #135081

a4bc8946

finer grained logging of Chromium launch sequence (#135078) · d6d2e89f

Yegor authored Sep 20, 2023

Log the details of how Chromium is about to be launched prior to running
the Chromium command, as well as the path to the Chromium executable.

This should improve our understanding of what's happening here:
https://github.com/flutter/flutter/issues/132654#issuecomment-1726630123

d6d2e89f

Upgrade AGP version in tracing_tests (#134671) · b433b175
Gray Mackall authored Sep 20, 2023
```
Related to https://github.com/flutter/flutter/issues/134419
```
b433b175
Cover cupertino/form_section_test with leak tracing (#135158) · a96bf714
derdilla authored Sep 20, 2023

a96bf714
Cover more test/widgets tests with leak tracking #7 (#134943) · e6d160a5
Kostia Sokolovskyi authored Sep 20, 2023

e6d160a5

Enable strict-inference (#135043) · b0a90aee

Michael Goderbauer authored Sep 20, 2023

Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks

b0a90aee

Cover more test/widgets tests with leak tracking #10 (#135143) · 96a4ae9d
Kostia Sokolovskyi authored Sep 20, 2023

96a4ae9d
cover more tests with leak tracing (#134833) · 9b767e6c
derdilla authored Sep 20, 2023

9b767e6c

codeisn extension safe iOS framework (#134966) · 22e40881

Chris Yang authored Sep 20, 2023

Update the conductor to code sign extension safe iOS frameworks
The new frameworks are added in
https://github.com/flutter/engine/pull/45781/files

part of https://github.com/flutter/flutter/issues/124291

Also includes an Engine roll includes:

https://github.com/flutter/engine/commit/9232e76c30455ee1c0c1584001bdbb01000f8212

https://github.com/flutter/engine/commit/39c0f2ea1f536eb7dc057d9147f23e3fec4a56c9

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

22e40881

Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) (#135151) · 4d8e390c

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/6f256257b79f...55314d08d792

2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kGkqpvcPI1TGmR4Sc... to zuOP7YCHHocXuZJcD... (flutter/engine#46097)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 56ce5bb201c6 to f54c214a739b (4 revisions) (flutter/engine#46098)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kGkqpvcPI1TG to zuOP7YCHHocX

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d8e390c

Remove 'must be non-null' and 'must not be null' comments in widgets library (#134992) · 6e5134b0

Greg Spencer authored Sep 20, 2023

## Description

This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.

This PR removes them from the widgets library.

This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.

In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.

This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).

## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994

## Tests
 - Documentation only change.

6e5134b0

Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) (#135147) · 52969a09

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/5f82fc2f6f24...6f256257b79f

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from fd317812bd27 to 56ce5bb201c6 (4 revisions) (flutter/engine#46096)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52969a09

[Android] Add Java/AGP/Gradle incompatibility warning to `flutter create` (#131444) · 594ff98a

Camille Simon authored Sep 20, 2023

Adds warning to `flutter create` command that checks if detected Java version is compatible with the template AGP and template Gradle versions. If a developer is building for Android and their Java version is incompatible with either the AGP or Gradle versions that Flutter currently supports by default for new Flutter projects, then

- a warning will show noting the incompatibility and
- steps will be shown to fix the issue, the recommended option being to configure a new compatible Java version given that Flutter knows we can support the template Gradle/AGP versions and updating them manually may be risky (feedback on this approach would be greatly appreciated!)

Given that the template AGP and Gradle versions are compatible, this PR assumes that the detected Java version may only conflict with one of the template AGP or Gradle versions because:
 - the minimum Java version for a given AGP version is less than the maximum Java version compatible for the minimum Gradle version required for that AGP version (too low a Java version will fail AGP compatibility test, but not Gradle compatibility).
- the maximum Java version compatible with minimum Gradle version for a given AGP version is higher than minimum Java version required for that AGP version (too high a Java version will fail Gradle compatibility test, but not AGP compatibility test).

Fixes https://github.com/flutter/flutter/issues/130515 in the sense that `flutter create foo`; `cd foo`; `flutter run` should always be successful.

594ff98a

Roll Packages from d4e245421737 to 51e74b97508a (12 revisions) (#135145) · 3a78e5c5

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/packages/compare/d4e245421737...51e74b97508a

2023-09-19 stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c9 to 89365041 (15 revisions) (flutter/packages#4947)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b132 to b7d0e8c9 (11 revisions) (flutter/packages#4944)
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3a78e5c5

Remove 'must not be null' comments from various libraries. (#134984) · 8cda3bea

Greg Spencer authored Sep 20, 2023

## Description

This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.

This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries.  Each of them only had a few, so I lumped them together.

This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.

In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.

This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).

## Related PRs
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994

## Tests
 - Documentation only change.

8cda3bea

Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) (#135142) · a1f8c99f

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/6535421b30d3...5f82fc2f6f24

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d7f2d1083979 to fd317812bd27 (2 revisions) (flutter/engine#46094)
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (flutter/engine#46093)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a1f8c99f

Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) (#135139) · 7212a079

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/67d4aaef3c7b...6535421b30d3

2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (flutter/engine#46092)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7212a079

Cover more test/widgets tests with leak tracking #8 (#135045) · 98ebab58
Kostia Sokolovskyi authored Sep 20, 2023

98ebab58
Cover more test/widgets tests with leak tracking #9 (#135054) · c3db0209
Kostia Sokolovskyi authored Sep 20, 2023

c3db0209

Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) (#135128) · d0004c95

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/83b4df415bf3...67d4aaef3c7b

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 7d9d5ac84d8f to d7f2d1083979 (1 revision) (flutter/engine#46091)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0004c95

Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) (#135102) · cb4b402c

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/df4e6c079682...83b4df415bf3

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 14e9b3c91c64 to 7d9d5ac84d8f (1 revision) (flutter/engine#46090)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from e3aa86332255 to 14e9b3c91c64 (1 revision) (flutter/engine#46089)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb4b402c

Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) (#135101) · aae6c6d7

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/9c6b2500282b...df4e6c079682

2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from e9b9e9a4f541 to e3aa86332255 (1 revision) (flutter/engine#46088)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aae6c6d7

Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) (#135098) · 3c25a9f2

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/24f7ac38dfa2...9c6b2500282b

2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from b8f006d88c07 to b3fd178ce59f (3 revisions) (flutter/engine#46087)
2023-09-20 bdero@google.com [Impeller] Ensure that reused textures are cleared before getting sampled by backdrop textures (flutter/engine#46084)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d6325ec2f053 to e9b9e9a4f541 (1 revision) (flutter/engine#46086)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c25a9f2

Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) (#135096) · 1e56af5a

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/36379b62bec8...24f7ac38dfa2

2023-09-20 bdero@google.com [Impeller] Use BlackTransparent clear color when backdrop filters are present. (flutter/engine#46085)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 5d916c04e9fc to d6325ec2f053 (1 revision) (flutter/engine#46083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e56af5a

Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) (#135095) · a5db10e4

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/81b93fc4a2cc...36379b62bec8

2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZhY53WD7bFJSA3xoO... to aHtib4LBcLwx7JwK-... (flutter/engine#46082)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 1a8885b9e03c to 5d916c04e9fc (6 revisions) (flutter/engine#46081)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZhY53WD7bFJS to aHtib4LBcLwx

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a5db10e4

Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) (#135093) · e300fda7

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/5a924a9017d7...81b93fc4a2cc

2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 06g6i7-5u8O-FOTSi... to kGkqpvcPI1TGmR4Sc... (flutter/engine#46079)
2023-09-20 godofredoc@google.com Use magic envs to pass commit and temp folder. (flutter/engine#46015)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 06g6i7-5u8O- to kGkqpvcPI1TG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e300fda7

Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2

Greg Spencer authored Sep 20, 2023

## Description

This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.

This PR removes them from the material library.

This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.

In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.

This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).

## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994

## Tests
 - Documentation only change.

a1e49be2

Unpin url launcher (remake) (#134958) · f4b5fc18

Gray Mackall authored Sep 20, 2023

More up to date version of https://github.com/flutter/flutter/pull/133786.

Fixes https://github.com/flutter/flutter/issues/111304

f4b5fc18

Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (#135085) · 6cf7ca01

engine-flutter-autoroll authored Sep 20, 2023

https://github.com/flutter/engine/compare/a7af55c56aa6...5a924a9017d7

2023-09-19 chinmaygarde@google.com [Impeller] Fix validation error about incorrect aspect on buffer to texture copies. (flutter/engine#46078)
2023-09-19 jonahwilliams@google.com [Impeller] Affinity adjustments for Vulkan backend. (flutter/engine#46063)
2023-09-19 chinmaygarde@google.com [Impeller] Fix validation errors in RendererTest. (flutter/engine#46076)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (flutter/engine#46075)
2023-09-19 30870216+gaaclarke@users.noreply.github.com [Impeller] adds hardware gate for wide gamut (flutter/engine#46051)
2023-09-19 jacksongardner@google.com Properly transfer objects between the main thread and web worker. (flutter/engine#46061)
2023-09-19 30870216+gaaclarke@users.noreply.github.com Made the warning about downgrading wide gamut happen at the correct time (flutter/engine#46064)
2023-09-19 matanlurey@users.noreply.github.com Conform to clang_tidy in `client_wrapper` headers. (flutter/engine#46058)
2023-09-19 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds unit test to make sure we can encode bgr101010xr to png. (flutter/engine#46007)
2023-09-19 ychris@google.com [ios] scenario test make parent view controller hide status bar (flutter/engine#46065)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cf7ca01