Commits · 0883cb2e962d485c722c1e5628366ba759815454 · abdullh.alsoleman / Front-End

20 Oct, 2023 7 commits

Roll Packages from 09c6b1152070 to be915be92708 (6 revisions) (#136964) · 0883cb2e

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/packages/compare/09c6b1152070...be915be92708

2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Finalize migration to x64 specific Windows platform (flutter/packages#5174)
2023-10-19 15619084+vashworth@users.noreply.github.com [image_picker_ios] Update UITests for Xcode 15/iOS 17 (flutter/packages#5176)
2023-10-19 stuartmorgan@google.com [ci] Add emulator tests on older Android version (flutter/packages#4616)
2023-10-19 engine-flutter-autoroll@skia.org Roll Flutter from 189196d1 to c2bd2c11 (11 revisions) (flutter/packages#5183)
2023-10-19 stuartmorgan@google.com [tool] Fix `filter-packages-to` when everything is changed (flutter/packages#5182)
2023-10-19 tarrinneal@gmail.com [pigeon] add flutter api protocol (flutter/packages#5181)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0883cb2e

Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (#136959) · 483ac618

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/de780872533c...9b88ff83fd82

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 17f05db514c3 to e836c3aa2b98 (1 revision) (flutter/engine#47154)
2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 5291f485514f to 17f05db514c3 (4 revisions) (flutter/engine#47151)
2023-10-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eKYGl_wBcnT-n0J8n... to tcVA-iW-vOHPnwh_P... (flutter/engine#47149)
2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from aadeeb497dbe to ba96a157a8eb (1 revision) (flutter/engine#47147)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eKYGl_wBcnT- to tcVA-iW-vOHP

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

483ac618

Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (#136952) · 72e454d9

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/1e107c21328a...de780872533c

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 1d63da5da8e8 to 5291f485514f (3 revisions) (flutter/engine#47143)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

72e454d9

Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (#136949) · f33b82e5

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/fd33e7e75eac...1e107c21328a

2023-10-20 skia-flutter-autoroll@skia.org Roll Dart SDK from f71ddbe0a500 to aadeeb497dbe (1 revision) (flutter/engine#47141)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f33b82e5

Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (#136942) · 8b2c643c

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/9dd59f7fcff9...fd33e7e75eac

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from 4c1ee6935b7b to 1d63da5da8e8 (1 revision) (flutter/engine#47140)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b2c643c

Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (#136935) · eefafdac

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/cc3356c0e68f...9dd59f7fcff9

2023-10-20 skia-flutter-autoroll@skia.org Roll Skia from e5c37860c792 to 4c1ee6935b7b (1 revision) (flutter/engine#47136)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eefafdac

Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (#136934) · 07042fa2

engine-flutter-autoroll authored Oct 20, 2023

https://github.com/flutter/engine/compare/504a99d93f42...cc3356c0e68f

2023-10-19 matanlurey@users.noreply.github.com Remove unused `fbo` parameter in GLES `SetAsFramebufferAttachment()`. (flutter/engine#47133)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0hLSNJ_DCTzRvTVJe... to jkQctnDMmHydahKfZ... (flutter/engine#47132)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 0hLSNJ_DCTzR to jkQctnDMmHyd

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

07042fa2

19 Oct, 2023 22 commits

Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (#136930) · 84db74c9

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/503b84295462...504a99d93f42

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b540ed3ba8e7 to e5c37860c792 (2 revisions) (flutter/engine#47126)
2023-10-19 chris@bracken.jp [macOS] Fail early when no a11y notification (flutter/engine#47129)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z2mOZ5cuPJWvKn22P... to eKYGl_wBcnT-n0J8n... (flutter/engine#47128)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Z2mOZ5cuPJWv to eKYGl_wBcnT-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

84db74c9

Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (#136928) · bfe174bb

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/3b0469b0c718...503b84295462

2023-10-19 dkwingsmt@users.noreply.github.com Reland 2 (part 2): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47095)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfe174bb

Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match... · 548843b9

Kate Lovett authored Oct 19, 2023

Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (#136905)

Reverts flutter/flutter#132291

We have found this introduced flakiness in many of our tests.

Fixes https://github.com/flutter/flutter/issues/135728

548843b9

[flutter_tools] move build_preview_test from commands/permeable to integration shard (#136912) · fd160466
Christopher Fujino authored Oct 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/136907 by moving the test to the tools integration shard, which DOES have VS code installed.
```
fd160466

Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (#136922) · 27cf404d

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/b40042ebb95b...3b0469b0c718

2023-10-19 jason-simmons@users.noreply.github.com [Impeller] Use a weak pointer factory in GPUSurfaceGLImpeller that supports the raster thread merger (flutter/engine#47081)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from ea86103e06b1 to f71ddbe0a500 (1 revision) (flutter/engine#47124)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27cf404d

do not include entries from `--dart-define-from-file` files in the gradle... · 25bed918

Andrew Kolos authored Oct 19, 2023

do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (#136865)

Fixes https://github.com/flutter/flutter/issues/130599 and https://github.com/flutter/flutter/issues/136444

25bed918

Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (#136915) · b5d8d77e

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/bfd2ffb9a8bc...b40042ebb95b

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (flutter/engine#47118)
2023-10-19 jiahaog@users.noreply.github.com Fix use of nested designators (flutter/engine#45869)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b5d8d77e

Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (#136910) · bbdcaea6

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/9d49175618f5...bfd2ffb9a8bc

2023-10-19 ychris@google.com [iOS] Load additional Cupertino system fonts (flutter/engine#46857)
2023-10-19 jiahaog@users.noreply.github.com Add missing import (flutter/engine#47083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbdcaea6

Allow users to customize search algorithm in `DropdownMenu` (#136848) · 40776d01

Qun Cheng authored Oct 19, 2023

Fixes #136735

This PR is to add a searchCallback to allow users to customize the search algorithm. This feature is used to fix b/305662376 which needs an exact match algorithm.

40776d01

Upgrade Flutter deps to pull in latest vm_service and dwds (#136734) · 01eef7ca

Elliott Brooks authored Oct 19, 2023

Generated by running `flutter update-packages --force-upgrade`

Updates vm_service to [12.0.0](https://pub.dev/packages/vm_service/versions/12.0.0) and dwds to [22.0.0](https://pub.dev/packages/dwds/versions/22.0.0)

The changes to `packages/flutter_tools/lib/src/isolated/devfs_web.dart` are for the new interface of DWDS introduced in https://github.com/dart-lang/webdev/pull/2243

FYI @bkonyi

01eef7ca

[Reland] Skip injecting Bonjour settings when port publication is disabled (#136842) · 3c3d414e
Victoria Ashworth authored Oct 19, 2023
```
Reland https://github.com/flutter/flutter/pull/136751 with fixes.
```
3c3d414e
_DefaultTabControllerState should dispose all created TabContoller instances. (#136608) · 9fa9fd36
Kostia Sokolovskyi authored Oct 19, 2023

9fa9fd36
Reland: "Add code for updating `focusedChild` when removing grandchildren from scope" (#136899) · 0abb017c
Greg Spencer authored Oct 19, 2023

0abb017c

Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (#136901) · f82299ef

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/418dce4feaf7...9d49175618f5

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b31b189be018 to 04449cda5a0a (1 revision) (flutter/engine#47105)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f82299ef

Unmark linux_android platform_channels_benchmarks as flaky (#136838) · f8c00983

Gray Mackall authored Oct 19, 2023

Unmarking this test as flaky in favor of a fix for the [underlying issue](https://github.com/flutter/flutter/issues/135035). None of the other impacted tests have been marked as flaky, so I think it is better for this one to not be treated differently.

f8c00983

Roll Packages from 14aa69e2e54c to 09c6b1152070 (4 revisions) (#136896) · ced0e741

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/packages/compare/14aa69e2e54c...09c6b1152070

2023-10-19 engine-flutter-autoroll@skia.org Manual roll Flutter from 6eea6e27 to 189196d1 (44 revisions) (flutter/packages#5178)
2023-10-18 47866232+chunhtai@users.noreply.github.com [go_router] adds ability to dynamically update routing table. (flutter/packages#5079)
2023-10-18 devoncarew@google.com [flutter_lints] rev flutter_lints to 3.0; increase dep on package:lints (flutter/packages#5177)
2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2f708eb8396e to 6c4930c4ac86 (1 revision) (flutter/packages#5173)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ced0e741

Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (#136895) · f9bec6cf

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/28cb2508b8e0...418dce4feaf7

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 8cf64b0795af to b31b189be018 (1 revision) (flutter/engine#47103)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b425a25a6dd to ea86103e06b1 (1 revision) (flutter/engine#47101)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9bec6cf

Reverts "Fixes ability to call nextFocus() on a node to focus its descendant" (#136894) · c2bd2c11

auto-submit[bot] authored Oct 19, 2023

Reverts flutter/flutter#136773
Initiated by: itsjustkevin
This change reverts the following previous change:
Original Description:
fixes https://github.com/flutter/flutter/issues/134854

c2bd2c11

Roll Flutter Engine from d0d7b4d61265 to 28cb2508b8e0 (1 revision) (#136878) · 8ab87670

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/d0d7b4d61265...28cb2508b8e0

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 62acc1e162cc to 8cf64b0795af (2 revisions) (flutter/engine#47097)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8ab87670

Roll Flutter Engine from 8d51b64e9440 to d0d7b4d61265 (13 revisions) (#136872) · 136249f2

engine-flutter-autoroll authored Oct 19, 2023

https://github.com/flutter/engine/compare/8d51b64e9440...d0d7b4d61265

2023-10-19 flar@google.com Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094)
2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092)
2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084)
2023-10-18 chinmaygarde@google.com Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078)
2023-10-18 fujino@google.com migrate const_finder to use the implementation from package:kernel (flutter/engine#47077)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076)
2023-10-18 jason-simmons@users.noreply.github.com [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068)
2023-10-18 chinmaygarde@google.com [Impeller] Document ReactorGLES. (flutter/engine#47070)
2023-10-18 matej.knopp@gmail.com [web] Ensure handled key event is not propagated to IME (flutter/engine#46829)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv
fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

136249f2

Reverts "Add code for updating `focusedChild` when removing grandchildren from scope" (#136862) · cbf50a95

auto-submit[bot] authored Oct 19, 2023

Reverts flutter/flutter#136771
Initiated by: gspencergoog
This change reverts the following previous change:
Original Description:
## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.

cbf50a95

Reverts "Use Layer.toImage for golden tests on CanvasKit" (#136860) · c881808e

auto-submit[bot] authored Oct 19, 2023

Reverts flutter/flutter#135249
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.

c881808e

18 Oct, 2023 11 commits

Bump flutter_lints to 3.0 (#136841) · 571039f6
Michael Goderbauer authored Oct 18, 2023
```
Follow-up to https://github.com/flutter/packages/pull/5177
```
571039f6

Add code for updating `focusedChild` when removing grandchildren from scope (#136771) · 24922425

Greg Spencer authored Oct 18, 2023

## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.

24922425

Use Layer.toImage for golden tests on CanvasKit (#135249) · 747128ff

Harry Terkelsen authored Oct 18, 2023

Changes golden tests on CanvasKit to use Layer.toImage instead of
browser APIs for screenshots. This brings it more in line with other
platforms and should also fix some async timing bugs with tests.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

747128ff

Roll Flutter Engine from b67edb05d3f7 to 8d51b64e9440 (4 revisions) (#136846) · 9391a88b

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/b67edb05d3f7...8d51b64e9440

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074)
2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073)
2023-10-18 dkwingsmt@users.noreply.github.com Reland 2 (part 1): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47062)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9391a88b

Roll Flutter Engine from 6caee3236d37 to b67edb05d3f7 (5 revisions) (#136844) · d9fdbd3d

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/6caee3236d37...b67edb05d3f7

2023-10-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603)
2023-10-18 zanderso@users.noreply.github.com Reland: Remove the frontend server wrapper (flutter/engine#47010)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9fdbd3d

Null-assert the value given to a Completer expecting a non-null value (#136776) · 25d2cdaa

Sam Rawlins authored Oct 18, 2023

The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value.

The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253.

Fixes https://github.com/flutter/flutter/issues/136775

25d2cdaa

Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (#136834) · 189196d1

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/ab86c53c19cd...6caee3236d37

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063)
2023-10-18 matanlurey@users.noreply.github.com Add `--lint-all=<regex>` as an option for `clang_tidy`, refactor lint targets (flutter/engine#46522)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

189196d1

Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (#136839) · c32ffa65

auto-submit[bot] authored Oct 18, 2023

Reverts flutter/flutter#136751
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.

c32ffa65

Convert menus to use OverlayPortal (#130534) · 13a0d475

Greg Spencer authored Oct 18, 2023

## Description

This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/124830

## Tests
 - No tests yet (hence it is a draft)

13a0d475

[Reland] Skip injecting Bonjour settings when port publication is disabled (#136751) · 1599cbeb
Victoria Ashworth authored Oct 18, 2023
```
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
```
1599cbeb

Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (#136832) · 697242c9

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/0eff5d191856...ab86c53c19cd

2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

697242c9