- 02 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
Fixes https://github.com/flutter/flutter/issues/131627 Originally this code sometimes was returning null and sometimes was failing, when stack frame is in unexpected format. This PR updates for one of the code paths from failing to returning null.
-
- 17 Jul, 2023 2 commits
-
-
Polina Cherkasova authored
-
Michael Goderbauer authored
This change enables Flutter to generate multiple Scenes to be rendered into separate FlutterViews from a single widget tree. Each Scene is described by a separate render tree, which are all associated with the single widget tree. This PR implements the framework-side mechanisms to describe the content to be rendered into multiple views. Separate engine-side changes are necessary to provide these views to the framework and to draw the framework-generated Scene into them. ## Summary of changes The details of this change are described in [flutter.dev/go/multiple-views](https://flutter.dev/go/multiple-views). Below is a high-level summary organized by layers. ### Rendering layer changes * The `RendererBinding` no longer owns a single `renderView`. In fact, it doesn't OWN any `RenderView`s at all anymore. Instead, it offers an API (`addRenderView`/`removeRenderView`) to add and remove `RenderView`s that then will be MANAGED by the binding. The `RenderView` itself is now owned by a higher-level abstraction (e.g. the `RawView` Element of the widgets layer, see below), who is also in charge of adding it to the binding. When added, the binding will interact with the `RenderView` to produce a frame (e.g. by calling `compositeFrame` on it) and to perform hit tests for incoming pointer events. Multiple `RenderView`s can be added to the binding (typically one per `FlutterView`) to produce multiple Scenes. * Instead of owning a single `pipelineOwner`, the `RendererBinding` now owns the root of the `PipelineOwner` tree (exposed as `rootPipelineOwner` on the binding). Each `PipelineOwner` in that tree (except for the root) typically manages its own render tree typically rooted in one of the `RenderView`s mentioned in the previous bullet. During frame production, the binding will instruct each `PipelineOwner` of that tree to flush layout, paint, semantics etc. A higher-level abstraction (e.g. the widgets layer, see below) is in charge of adding `PipelineOwner`s to this tree. * Backwards compatibility: The old `renderView` and `pipelineOwner` properties of the `RendererBinding` are retained, but marked as deprecated. Care has been taken to keep their original behavior for the deprecation period, i.e. if you just call `runApp`, the render tree bootstrapped by this call is rooted in the deprecated `RendererBinding.renderView` and managed by the deprecated `RendererBinding.pipelineOwner`. ### Widgets layer changes * The `WidgetsBinding` no longer attaches the widget tree to an existing render tree. Instead, it bootstraps a stand-alone widget tree that is not backed by a render tree. For this, `RenderObjectToWidgetAdapter` has been replaced by `RootWidget`. * Multiple render trees can be bootstrapped and attached to the widget tree with the help of the `View` widget, which internally is backed by a `RawView` widget. Configured with a `FlutterView` to render into, the `RawView` creates a new `PipelineOwner` and a new `RenderView` for the new render tree. It adds the new `RenderView` to the `RendererBinding` and its `PipelineOwner` to the pipeline owner tree. * The `View` widget can only appear in certain well-defined locations in the widget tree since it bootstraps a new render tree and does not insert a `RenderObject` into an ancestor. However, almost all Elements expect that their children insert `RenderObject`s, otherwise they will not function properly. To produce a good error message when the `View` widget is used in an illegal location, the `debugMustInsertRenderObjectIntoSlot` method has been added to Element, where a child can ask whether a given slot must insert a RenderObject into its ancestor or not. In practice, the `View` widget can be used as a child of the `RootWidget`, inside the `view` slot of the `ViewAnchor` (see below) and inside a `ViewCollection` (see below). In those locations, the `View` widget may be wrapped in other non-RenderObjectWidgets (e.g. InheritedWidgets). * The new `ViewAnchor` can be used to create a side-view inside a parent `View`. The `child` of the `ViewAnchor` widget renders into the parent `View` as usual, but the `view` slot can take on another `View` widget, which has access to all inherited widgets above the `ViewAnchor`. Metaphorically speaking, the view is anchored to the location of the `ViewAnchor` in the widget tree. * The new `ViewCollection` widget allows for multiple sibling views as it takes a list of `View`s as children. It can be used in all the places that accept a `View` widget. ## Google3 As of July 5, 2023 this change passed a TAP global presubmit (TGP) in google3: tap/OCL:544707016:BASE:545809771:1688597935864:e43dd651 ## Note to reviewers This change is big (sorry). I suggest focusing the initial review on the changes inside of `packages/flutter` first. The majority of the changes describe above are implemented in (listed in suggested review order): * `rendering/binding.dart` * `widgets/binding.dart` * `widgets/view.dart` * `widgets/framework.dart` All other changes included in the PR are basically the fallout of what's implemented in those files. Also note that a lot of the lines added in this PR are documentation and tests. I am also very happy to walk reviewers through the code in person or via video call, if that is helpful. I appreciate any feedback. ## Feedback to address before submitting ("TODO")
-
- 13 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 12 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 06 Jul, 2023 1 commit
-
-
Michael Goderbauer authored
PLUS: clean-up of all the unreachable stuff.
-
- 05 Jul, 2023 1 commit
-
-
Myles Moylan authored
This PR is adding a file of two simple unit tests in order to improve code coverage (covering two simple classes within the annotations.dart file). The issue this is fixing is the lack of complete test coverage for the annotations.dart file.
-
- 21 Jun, 2023 1 commit
-
-
Yegor authored
## FlutterTimeline Add a new class `FlutterTimeline` that's a drop-in replacement for `Timeline` from `dart:developer`. In addition to forwarding invocations of `startSync`, `finishSync`, `timeSync`, and `instantSync` to `dart:developer`, provides the following extra methods that make is easy to collect timings for code blocks on a frame-by-frame basis: * `debugCollect()` - aggregates timings since the last reset, or since the app launched. * `debugReset()` - forgets all data collected since the previous reset, or since the app launched. This allows clearing data from previous frames so timings can be attributed to the current frame. * `now` - this was enhanced so that it works on the web by calling `window.performance.now` (in `Timeline` this is a noop in Dart web compilers). * `collectionEnabled` - a field that controls whether `FlutterTimeline` stores timings in memory. By default this is disabled to avoid unexpected overhead (although the class is designed for minimal and predictable overhead). Specific benchmarks can enable collection to report to Skia Perf. ## Semantics benchmarks Add `BenchMaterial3Semantics` that benchmarks the cost of semantics when constructing a screen full of Material 3 widgets from nothing. It is expected that semantics will have non-trivial cost in this case, but we should strive to keep it much lower than the rendering cost. This is the case already. This benchmark shows that the cost of semantics is <10%. Add `BenchMaterial3ScrollSemantics` that benchmarks the cost of scrolling a previously constructed screen full of Material 3 widgets. The expectation should be that semantics will have trivial cost, since we're just shifting some widgets around. As of today, the numbers are not great, with semantics taking >50% of frame time, which is what prompted this PR in the first place. As we optimize this, we want to see this number improve.
-
- 14 Jun, 2023 1 commit
-
-
Polina Cherkasova authored
Contributes to https://github.com/dart-lang/leak_tracker/issues/59
-
- 12 Jun, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 07 Jun, 2023 1 commit
-
-
fzyzcjy authored
... found when looking at leak tracker today. By the way, shall we add some kind of automatic link linter, which goes through all links and see whether they are alive?
-
- 26 May, 2023 1 commit
-
-
Phil Quitslund authored
The newly updated lint will soon flag for-each in collections. See discussion: https://github.com/dart-lang/linter/pull/4383 /cc @goderbauer
-
- 16 May, 2023 1 commit
-
- 08 May, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/126096. Fixes https://github.com/flutter/flutter/issues/126097. Fixes https://github.com/flutter/flutter/issues/126102. Fixes https://github.com/flutter/flutter/issues/126098. Fixes https://github.com/flutter/flutter/issues/126147. Work towards https://github.com/flutter/flutter/issues/126100. Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100).
-
- 04 May, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 02 May, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 18 Apr, 2023 1 commit
-
-
Michael Goderbauer authored
These are currently unused and will not work in a multi-view environment where we will have multiple render trees. Work towards https://github.com/flutter/flutter/issues/121573.
-
- 12 Apr, 2023 1 commit
-
-
Nabeel Parkar authored
Bug report 2 issue template
-
- 04 Apr, 2023 2 commits
-
-
Christopher Fujino authored
Re-land of https://github.com/flutter/flutter/pull/123297 without any of the commits at the end attempting to fix customer-testing. Fixes https://github.com/flutter/flutter/issues/118810
-
Michael Goderbauer authored
-
- 03 Apr, 2023 1 commit
-
-
Casey Hillers authored
Revert "[flutter_tools] Remove --no-sound-null-safety #3"
-
- 30 Mar, 2023 1 commit
-
-
Greg Price authored
Remove no-shuffle from framework tests, part 1: easy cases
-
- 29 Mar, 2023 1 commit
-
-
Christopher Fujino authored
[flutter_tools] Remove --no-sound-null-safety #3
-
- 28 Mar, 2023 1 commit
-
-
Loïc Sharma authored
[Focus] Add run key command to dump the focus tree
-
- 22 Mar, 2023 1 commit
-
-
Christopher Fujino authored
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
-
- 20 Mar, 2023 1 commit
-
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag #2
-
- 17 Mar, 2023 2 commits
-
-
Christopher Fujino authored
This reverts commit 7c3088cf.
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag
-
- 16 Mar, 2023 3 commits
-
-
Ian Hickson authored
Assert that runApp is called in the same zone as binding.ensureInitialized
-
yaakovschectman authored
Revert "Assert that runApp is called in the same zone as binding.ensureInitialized (#117113)" (#122830) Revert "Assert that runApp is called in the same zone as binding.ensureInitialized"
-
Ian Hickson authored
Assert that runApp is called in the same zone as binding.ensureInitialized
-
- 01 Mar, 2023 1 commit
-
-
Daniel Austin authored
implement override of toString() in order to print useful message in release mode as well as debug mode (#118263) Added `_ErrorDescription.toString()`
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 13 Feb, 2023 1 commit
-
-
Ian Hickson authored
-
- 03 Feb, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 21 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Dec, 2022 1 commit
-
-
Michael Thomsen authored
-
- 29 Nov, 2022 1 commit
-
-
Michael Thomsen authored
* Ignore NullThrownError deprecation * Fix whitespace
-
- 18 Nov, 2022 1 commit
-
-
chunhtai authored
* Disallow dispose during listener callback * addressing comment * add comments to code * Addressing comments * fix test
-
- 14 Nov, 2022 1 commit
-
-
Siva authored
* Fix test in preparation of the Dart VM switching to being null safe by default. * Fix analyze error. * Format. * Remove print. * Fix analyzer lint. * Fix warnings.
-