- 22 Oct, 2023 1 commit
-
-
Todd Volkert authored
Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all. This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback. #testexempt -- we have no way to test calls to the timeline.
-
- 22 Sep, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 05 Jun, 2023 1 commit
-
-
Kate Lovett authored
#### (plus some more docs) Fixes https://github.com/flutter/flutter/issues/76760 Fixes https://github.com/flutter/flutter/issues/82391 Fixes https://github.com/flutter/flutter/issues/45619 Fixes #117316 Fixes #110956 Fixes #127282 Fixes #32563 Fixes #46089 Fixes #79077 Part of fixing #62833 This fixes (a bunch of) issues that have been reported differently over the years, but all have the same root cause. Sometimes the NestedScrollView would incorrectly calculate whether or not there is enough content to allow scrolling. This would only apply to drag scrolling (not mouse wheel scrolling for example). This did not relate to how the extent of the NestedScrollView is computed, but just the logic that enabled the actual drag gestures. This fixes that. :)
-
- 01 Jun, 2023 1 commit
-
-
Kate Lovett authored
Adds an error message where we previously would crash without any help. Came across this while working on https://github.com/flutter/flutter/pull/127718 Fixes https://github.com/flutter/flutter/issues/128074
-
- 12 Apr, 2023 1 commit
-
-
xubaolin authored
DraggableScrollableSheet & NestedScrollView should respect NeverScrollableScrollPhysics
-
- 31 Mar, 2023 1 commit
-
-
Kate Lovett authored
Fix docs and error messages for scroll directions + sample code
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 03 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
This reverts commit c956121a.
-
- 27 Dec, 2022 1 commit
-
-
Xilai Zhang authored
This reverts commit 999356b7.
-
- 22 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
* Remove single-view assumption from ScrollPhysics * fix scrollable_dispose_test.dart * add deprecated method back
-
- 13 Dec, 2022 1 commit
-
-
Callum Moffat authored
* Fix scroll jump when NestedScrollPosition is inertia-cancelled. * Switch to using pointerScroll(0)
-
- 31 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 08 Sep, 2022 1 commit
-
-
Kate Lovett authored
-
- 19 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 17 Aug, 2022 1 commit
-
-
Callum Moffat authored
-
- 28 Jul, 2022 1 commit
-
-
xubaolin authored
-
- 09 Jun, 2022 1 commit
-
-
Kate Lovett authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 21 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Jan, 2022 1 commit
-
-
Kate Lovett authored
-
- 13 Dec, 2021 1 commit
-
-
Greg Spencer authored
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 04 Oct, 2021 1 commit
-
-
Greg Spencer authored
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder. I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed. I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
-
- 25 Aug, 2021 1 commit
-
-
Greg Spencer authored
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 14 Jun, 2021 1 commit
-
-
Kate Lovett authored
-
- 30 Apr, 2021 1 commit
-
-
Kate Lovett authored
-