- 18 Jan, 2023 1 commit
-
-
Paul Berry authored
* Fix applyBoxFit's handling of fitWidth and fitHeight. Previously, in `fitWidth` mode, if the input size had a wider aspect ratio than the output size, `applyBoxFit` would make the source rect taller than the input size in order to match the aspect ratio of the destination rect. Similarly, in `fitHeight` mode, if the input size had a taller aspect ratio than the output size, `applyBoxFit` would make the source rect wider than the input size in to match the aspect ratio of the destination rect. This is in contrast to all the other modes, which never output a source rect that's larger than the input size. Most of the time this worked as intended (since attempting to blit pixels that are outside the source image has no effect), however it meant that if a user attempted to create a `BoxDecoration` that used both `fitWidth` and `repeatY` (e.g. in an attempt to tile a background image), the image would not actually appear to repeat, since the logic in `paintImage` for determining the proper tiling stride is based on the destination image size, meaning that the entire destination rect would be covered in a single tile. This change modifies `applyBoxFit` so that in `fitWidth` mode, if the input size has a wider aspect ratio than the output size, it uses formulas that are equivalent to `contain`, whereas if the input size has a taller aspect ratio than the output size, it uses formulas that are equivalent to `cover`. And vice versa for `fitHeight` mode. This produces source and destination rects that match the behaviour specified in https://api.flutter.dev/flutter/painting/BoxFit.html. * Apply suggestions from code review Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Apr, 2022 1 commit
-
-
Phil Quitslund authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 26 Aug, 2021 1 commit
-
-
nt4f04uNd authored
* Add missing parameters to DecorationImage * tune docs * fix test
-
- 03 Aug, 2021 1 commit
-
-
Darren Austin authored
-
- 23 Jun, 2021 1 commit
-
-
Greg Spencer authored
-
- 23 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Apr, 2021 1 commit
-
-
Phil Quitslund authored
-
- 16 Mar, 2021 2 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 0cbe5975.
-
- 15 Mar, 2021 1 commit
-
-
Ian Hickson authored
-
- 18 Nov, 2020 1 commit
-
-
Jonah Williams authored
-
- 14 Oct, 2020 1 commit
-
-
HeavenOSK authored
* modify: add prefix `Alignment.` for toString of Alignment
-
- 08 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Oct, 2020 1 commit
-
-
Dan Field authored
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (https://github.com/flutter/flutter/pull/67176) - Fix CanvasKit dispose impl (https://github.com/flutter/engine/pull/21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d9.
-
- 03 Oct, 2020 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 01 Oct, 2020 2 commits
-
-
Dan Field authored
* Dispose of images after using them Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf. Makes all stateful holders of ui.Image objects properly clone and dispose of them. Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created. Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
- 22 Sep, 2020 1 commit
-
-
Dan Field authored
Remove fake image implementations, add createTestImage to flutter_test
-
- 04 Aug, 2020 1 commit
-
-
Jonah Williams authored
-
- 16 Jul, 2020 1 commit
-
-
Bogdan Lukin authored
-
- 11 Jun, 2020 2 commits
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
Darren Austin authored
-
- 18 Apr, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 26 Mar, 2020 1 commit
-
-
Dan Field authored
-
- 10 Feb, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 27 Jan, 2020 1 commit
-
-
Dan Field authored
-
- 17 Jan, 2020 1 commit
-
-
Anthony authored
[a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985)
-
- 16 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Dec, 2019 1 commit
-
-
Scott Hyndman authored
-
- 16 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 28 Oct, 2019 1 commit
-
-
Albertus Angga Raharja authored
* Add structured errors in Animations, TabView, ChangeNotifier * Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan * Add structured errors in Debug * Fix test errors * Add structured errors in Scaffold and Stepper * Add structured errors in part of Rendering Layer * Fix failing test due to FloatingPoint precision * Fix failing tests due to precision error and not using final * Fix failing test due to floating precision error with RegEx instead * Add structured error in CustomLayout and increase test coverage * Add structured error & its test in ListBody * Add structured error in ProxyBox and increase test coverage * Add structured error message in Viewport * Fix styles and add more assertions on ErrorHint and DiagnosticProperty * Add structured error in scheduler/binding and scheduler/ticker Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in AssetBundle and TextInput Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured errors in several widgets #1 Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove unused import Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add assertions on hint messages Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix catch spacing Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in several widgets part 2 and increase code coverage Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in flutter_test/widget_tester * Fix floating precision accuracy by using RegExp Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove todo to add tests in Scaffold showBottomSheet Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix reviews by indenting lines and fixing the assertion orders Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix failing tests due to renaming class Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Try skipping the NetworkBundleTest Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove leading space in material/debug error hint Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com>
-