- 07 Sep, 2018 13 commits
-
-
Chris Bracken authored
Now that Dart 1 support has been eliminated, generator should always be populated to a kernel compiler instance. Also moves the constructor to the top of the class, and orders final fields before non-final fields, as dictated by the style guide.
-
Chris Bracken authored
This tickled a bug in KernelCompiler.compile() where the fingerprinter doesn't include the outputFilePath in its list of dependencies. As such, if the output .dill file is missing or corrupted, the fingerprint still matches and re-compile is skipped, even though it shouldn't be. I'll fix that in a followup, then look at how this triggered that issue. My hypothesis is that that it's due to the aot kernel compile and bundle kernel compile have separate output directories for the .dill files (build/ vs build/aot) but the same output directory for the associated depfiles (due to this patch). This reverts commit 43a106e9.
-
Jonah Williams authored
This reverts commit 6e7f3e6f.
-
jslavitz authored
* added shortcuts and delete functionality * added first test * afew chnages * a few changes * hope this works * small change * small changes * fixed nits * final changes: * fixed initializing formals * update comment * minor change: * added line * final changes
-
Chris Bracken authored
The --snapshot argument was only necessary in Dart 1. The --depfile argument was only used in Dart 2 mode to pass to the kernel compiler, but was inconsistent with the 'build aot' command, where the depfile was always set to build/kernel_compile.d. This patch updates 'build bundle' to emit the depfile to a location consistent with the 'build aot' command; since it's not intended to be user-configurable and flutter.gradle hardcodes the location to build/kernel_compile.d either way, this patch also eliminates the ability to configure the filename altogether.
-
Jacob Richman authored
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)" (#21448) This reverts commit 5b5a5b82.
-
Ben Konyi authored
-
Jonah Williams authored
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
Alexandre Ardhuin authored
-
creativecreatorormaybenot authored
* Added music_note icon
-
CaiJingLong authored
-
Mehmet Fidanboylu authored
This reverts commit 343b5703. Reverting because the assert introduced in framework.dart(inheritFromElement) is breaking certain Mulligan pages. @hixie suspects it might be due to global keys.
-
- 06 Sep, 2018 15 commits
-
-
Jason Simmons authored
-
Jonah Williams authored
-
sir-boformer authored
* Scale high-pixel-ratio images with BoxFit.none/BoxFit.scaleDown correctly * add test cases for image scale * make analyzer happy * Make sure that test images always have a scale to make all tests pass * add a new author * use new keyword in tests
-
Hans Muller authored
-
Amir Hardon authored
This recognizer can be passed in AndroidView's gesureRecognizers when we want all touch events in the view bounds to be immediately dispatched to the Android view.
-
jslavitz authored
* monodrag fix * added a test * added test and changes * fixed import * removed comments
-
Jason Simmons authored
-
Chris Bracken authored
--preview-dart-2 is no longer necessary as it is now the default for the standalone Dart VM.
-
Danny Tuppeny authored
I'm working on fixing up all tests that rely on fs.currentDirectory to allow us to run concurrently. This one proved to be really tricky because it calls a lot of code and spawns multiple processes that have a mix of absolute and relative paths passed to them. I managed to handle some of it with a ChrootFileSystem, but the paths passed to the external processes were wrong. The functionality here is covered by all of the integration tests that use flutter_tester that were added after this, including flutter_run_test.dart, lifetime_test.dart etc. in this same folder but because they're run through `flutter run` as a separate process they get to set their own working directories without affecting other tests if run concurrently.
-
liyuqian authored
The average frame time of page transitions on Moto G4 is now very close to 16ms (the last 10 measurements on our dashboard are between 15.5ms to 16.7ms and half of them are below 16ms). It is now much faster than when we disabled it (which was at about 35ms). So I think that we should be able to enable it by default. I'll leave the flag there until we implement the retained rendering to bring the frame time comfortably below 16ms. See https://github.com/flutter/flutter/issues/13736
-
Amir Hardon authored
Setting the default clip behavior made bottom app bar to no longer clip its children. With this parameter users could opt-in to clipping.
-
Danny Tuppeny authored
* Add a detach command to detach without terminating (#21376) * Add a detach command to detach without terminating Fixes #21154. * Bump protocol version for app.detach * Tweak to detach/quit text * Change logPrefix to named param * Fix the text that the devicelab attach test looks for
-
Devon Carew authored
-
Danny Tuppeny authored
* Rename test file * Fix detection to work regardless of whether there are other devices On Windows we get one message, but on Mac we get another (because of the Simulator always being available).
-
Jonah Williams authored
-
- 05 Sep, 2018 12 commits
-
-
Danny Tuppeny authored
Revert "Allow FlutterTester to be provided with the working directory for execution (#21119)" (#21453) This reverts commit 857bdc7a.
-
Danny Tuppeny authored
* Allow FlutterTester to be provided with the working directory for execution Previously this test set fs.currentDirectory which prevents running tests concurrently. This allows setting the working directory for a FlutterTester in the cosntructor (optionally) and passes it through from the test (without setting fs.currentDirectory). * Remove trailing whitespace
-
Amir Hardon authored
-
Danny Tuppeny authored
-
Danny Tuppeny authored
* Add a detach command to detach without terminating Fixes #21154. * Bump protocol version for app.detach * Tweak to detach/quit text * Change logPrefix to named param
-
Danny Tuppeny authored
Move asset_bundle_package_test to MemoryFileSystem to avoid setting fs.currentDirectory in tests (#21427) * Update asset_bundle_package_test to use MemoryFileSystem This updates all tests in this file to use a memory filesystem (same as I did for asset_bundle_package_font_test) based on the current platform. There were already a few minor tests at the bottom using a MemoryFileSystem and being run for all platforms - however this complicated the shared code I changed above to support Windows natively so I changed them to also work the same as others (that is, they just run the native platforms so require running on all to get full coverage - though this is the case for almost all other tests anyway). * Move fixPath to the correct place
-
Danny Tuppeny authored
-
Chris Bracken authored
-
Jonah Williams authored
-
Matteo Crippa authored
-
Danny Tuppeny authored
* Add a failing test for #21418 * Filter workflows to only those applicable to the current platform Fixes #21418.
-
tonyzhao1 authored
* First step in Flutter Doctor refactor. Assigns categories to all validators. * Revert "Roll engine e54bc4ea1832..a84b210b3d26 (6 commits) (#20453)" This reverts commit 05c2880a. * Split iOS and Android workflows into workflow and validator classes. * Change ValidatorCategory to handle standalone validators that share a category (e.g. IntelliJ). Also make Android Studio and Android toolchain use separate categories. At this stage, flutter doctor output matches what it was previously. (The summary() method itself has not yet been changed ) * Change doctor summary code to support validator categories. Output is still unchanged. * Handle small formatting issues. * Flip Flutter category's isGroup field to false until it's actually needed. * Revert auto-generated formatting changes to keep those lines from muddying the pull. * Small fixes pointed out by analyzer. * Properly fix analyzer issues around const constructors. * Small changes to address comments. * Add tests to verify grouped validator behavior and validationtype merging. * Update doctor.dart * Add comments for clarification.
-