1. 27 Aug, 2019 1 commit
  2. 21 Aug, 2019 1 commit
  3. 19 Aug, 2019 2 commits
  4. 16 Jul, 2019 1 commit
    • liyuqian's avatar
      Fix flaky peer connection (#36089) · 180aa0c0
      liyuqian authored
      Fixes https://github.com/flutter/flutter/issues/36091.
      
      Previously, a sendRequest will be sent even if the peer is closed during
      a driver test. That will cause a time out without any error information.
      Such issue is unreproducible on my Mac Book Pro, but 100% reproducible
      on our new Mac mini (2018).
      
      The closing issue is tracked in https://github.com/flutter/flutter/issues/36268
      
      Additional to this fix, we should also patch the jason_rpc_2 so the peer
      will throw exception if sendRequest is attempted while the connection is
      closed.
      
      **Test**:
      tiles_scroll_perf_iphonexs__timeline_summary failed without this patch.
      It will pass after this patch.
      
      I'm not sure how to add a unit test for this. Please let me know if you have
      some ideas.
      
      This patch will generate the following warning log on the new Mac Mini
      ```
      flutter: Observatory listening on http://127.0.0.1:50192/cZPDF4sW7MM=/  
      Installing and launching...                                        10.2s
      00:00 +0: scrolling performance test (setUpAll)
      [info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:1069/cZPDF4sW7MM=/
      [trace] FlutterDriver: Isolate found with number: 3684677742843303
      [trace] FlutterDriver: Isolate is paused at start.
      [trace] FlutterDriver: Attempting to resume isolate
      [trace] FlutterDriver: Waiting for service extension
      [info ] FlutterDriver: Connected to Flutter application.
      00:00 +0: scrolling performance test complex_layout_scroll_perf
      [warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
      [warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
      00:10 +1: scrolling performance test tiles_scroll_perf
      [warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
      [warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
      00:20 +2: scrolling performance test (tearDownAll)
      00:20 +2: All tests passed!
      Stopping application instance.
      ```
      180aa0c0
  5. 02 Jul, 2019 1 commit
  6. 09 May, 2019 1 commit
  7. 04 May, 2019 1 commit
  8. 22 Mar, 2019 1 commit
  9. 19 Mar, 2019 1 commit
  10. 07 Mar, 2019 1 commit
  11. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  12. 21 Feb, 2019 1 commit
  13. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  14. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  15. 15 Nov, 2018 1 commit
  16. 16 Oct, 2018 1 commit
  17. 01 Oct, 2018 1 commit
  18. 12 Sep, 2018 1 commit
  19. 28 Aug, 2018 1 commit
  20. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  21. 02 Aug, 2018 1 commit
  22. 27 Jul, 2018 1 commit
  23. 23 Jul, 2018 1 commit
  24. 16 Jul, 2018 2 commits
  25. 21 Jun, 2018 1 commit
  26. 20 Jun, 2018 1 commit
  27. 19 Jun, 2018 1 commit
  28. 05 Jun, 2018 1 commit
  29. 28 Mar, 2018 1 commit
    • Alexander Aprelev's avatar
      Again move mockito to 300plus2 (#15981) · bffae215
      Alexander Aprelev authored
      * Revert "Revert "Move mockito to 3.0.0-alpha. (#15949)" (#15979)"
      
      This reverts commit e59651f9.
      
      * More thenReturn to thenAnswer when mocking Futures
      
      * Revert "More thenReturn to thenAnswer when mocking Futures"
      
      This reverts commit 194d2cf41754ad171efd6bb5898cf73bce5a75ab as we are reverting engine roll.
      
      * Revert "Revert "More thenReturn to thenAnswer when mocking Futures""
      
      This reverts commit 52c9e96b304b220f66d78a252fccea0c8e0ef24c.
      
      * Add dependency override
      
      * Fix issue
      bffae215
  30. 27 Mar, 2018 3 commits
    • Chris Bracken's avatar
      Apply Mockito-related type fixes (#16002) · 39eeec47
      Chris Bracken authored
      Type-related fixes in flutter_driver and fuchsia_remote_debug_protocol
      tests.
      39eeec47
    • Chris Bracken's avatar
      Revert "Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab (#15885)" (#15980) · 49c87d01
      Chris Bracken authored
      This caused a test failure in the integration_ui_ios devicelab test.
      
      ```
      stdout: [   +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m
      stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m
      stdout: [   +5 ms]   DriverError: Failed to fulfill Tap: Flutter application not responding
      stdout: [        ]   Original error: TimeoutException after 0:00:07.500000: Future not completed
      stdout: [        ]   Original stack trace:
      stdout: [        ]   #0      FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18)
      stdout: [        ]
      stdout: [        ]   #1      FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11)
      stdout: [        ]
      stdout: [        ]   #2      main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20)
      ```
      
      This reverts commit 067be92a.
      49c87d01
    • Siva's avatar
      Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab (#15885) · 067be92a
      Siva authored
      Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab
      067be92a
  31. 16 Feb, 2018 1 commit
    • Vyacheslav Egorov's avatar
      Fix several Dart 2 issues in the flutter_driver. (#14749) · aa7e9637
      Vyacheslav Egorov authored
      * All lists produced by JSON parsing are List<dynamic>. If more
      speficic type is required then they need to be explicitly cast, e.g.
      using castFrom helper;
      * Function of type (ByText) -> Finder is not a subtype of
      (SerializableFinder) -> Finder because ByText is in the contravariant
      position;
      * In Dart 2 typed(any) should be used instead of any in mockito based
      tests.
      aa7e9637
  32. 05 Feb, 2018 1 commit
  33. 19 Dec, 2017 1 commit
    • Alan Russian's avatar
      Change async stubbing to use thenAnswer. (#13521) · 30720bd1
      Alan Russian authored
      * Change async stubbing to use thenAnswer.
      
      Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79
      
      * Update all Mockito deps to 3.0.0.
      
      * Revert "Update all Mockito deps to 3.0.0."
      
      This reverts commit e8ab9d37c33d3d7fe384abde64ea5b4d72623c75.
      
      I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.
      
      * Change thenAnswer((_) => to thenAnswer((invocation) =>
      
      * Add Invocation type to thenAnswer lambdas
      30720bd1
  34. 23 Nov, 2017 1 commit
    • Chris Bracken's avatar
      Reorganise flutter driver implementation sources (#13163) · cf37a472
      Chris Bracken authored
      This patch reorganises flutter_driver's lib/src directory into three
      subdirectories:
      
      * driver: sources transitively imported/exported by flutter_driver.dart,
        which defines the API used by driver tests executed on the host machine.
      
      * extension: sources transitively imported/exported by
        driver_extension.dart, which defines the API used to instrument a
        Flutter app running on the target device for use with a driver test.
      
      * common: sources common to both driver and extension code.
      
      This makes rolling Flutter into repositories that use Bazel (or
      Bazel-like build systems) significantly more robust, due to the simpler
      glob patterns involved.
      cf37a472
  35. 22 Nov, 2017 1 commit