1. 11 Oct, 2018 3 commits
    • jslavitz's avatar
      Fix test template (#22982) · 673d56d1
      jslavitz authored
      * added test
      673d56d1
    • Alexander Aprelev's avatar
      [dart] Roll engine to dart roll · e274ed86
      Alexander Aprelev authored
      e274ed86
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  2. 10 Oct, 2018 5 commits
  3. 09 Oct, 2018 6 commits
  4. 08 Oct, 2018 3 commits
    • matthew-carroll's avatar
      Publish make-host-app-editable command with CLI docs. (#22635) · 4f298e67
      matthew-carroll authored
      Publish make-host-app-editable command with CLI docs.
      4f298e67
    • Andrew Davies's avatar
      [flutter_driver] Adds fuchsia compat for connect() (#22633) · 9ceb9ab3
      Andrew Davies authored
      Adds a Fuchsia compatibility function that allows for connecting to a
      specific Isolate by name when running Flutter Driver on a Fuchsia
      device.  This will check over multiple Dart VM's in an attempt to find
      an Isolate by its name.
      9ceb9ab3
    • Greg Spencer's avatar
      Fix gradle error in devicelab tests (#22814) · e0b182e6
      Greg Spencer authored
      Fixes a gradle error where it was failing to find a plugin because of an absolute path in the .flutter-plugins file instead of a relative path.
      
      I had originally removed this variable because I thought it was redundant with the projectDir, but apparently I was wrong about that (one resolves to a relative path, and one resolves to an absolute path).
      
      This PR reverts that part of the change and reintroduces the (not really) redundant variable.
      e0b182e6
  5. 06 Oct, 2018 2 commits
    • Greg Spencer's avatar
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to... · 2d81adf7
      Greg Spencer authored
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
      
      This reverts commit e4386321
      because it breaks 160 benchmarks, and several devicelab tests,
      due to changing the format of the output.
      2d81adf7
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      e4386321
  6. 05 Oct, 2018 7 commits
  7. 04 Oct, 2018 4 commits
    • Greg Spencer's avatar
      Fixes a common crash in getAdbDevices when adb executable isn't found. (#22676) · 40a7a9cf
      Greg Spencer authored
      Apparently, this accounts for 13% of our crashes in Beta.
      40a7a9cf
    • Greg Spencer's avatar
      Rename module --> application in flutter create command. (#22565) · 9f23866a
      Greg Spencer authored
      This renames the "module" template to the "application" template, and makes "application" the default. The existing "app" template is now deprecated.
      
      flutter create also now recognizes the type of project in an existing directory, and is able to recreate it without having the template type explicitly specified (although you can still do that). It does this now by first looking in the .metadata file for the new project_type field, and if it doesn't find that, then it looks at the directory structure. Also, the .metadata file is now overwritten even on an existing directory so that 1) the project_type can be added to legacy projects, and 2) the version of Flutter that updated the project last is updated.
      
      I also cleaned up a bunch of things in create_test.dart, added many more tests, and added an example test to the test/ directory in the generated output of the application template.
      
      Fixes #22530
      Fixes #22344
      9f23866a
    • Jason Simmons's avatar
      Use "gradle tasks --all" to query build variants (#21761) · e031613a
      Jason Simmons authored
      Previously flutter_tools had used "gradle properties" to find the build types
      and flavors supported by the Gradle project.  Tasks should work more reliably
      across different versions of the Android Gradle plugin.
      
      Fixes https://github.com/flutter/flutter/issues/20781
      e031613a
    • Alexandre Ardhuin's avatar
      sort_constructors_first (#22575) · 2ea1d81c
      Alexandre Ardhuin authored
      2ea1d81c
  8. 03 Oct, 2018 3 commits
  9. 02 Oct, 2018 3 commits
  10. 01 Oct, 2018 4 commits