- 11 Oct, 2018 3 commits
-
-
jslavitz authored
* added test
-
Alexander Aprelev authored
-
Greg Spencer authored
This attempts to re-land #22656. There are two changes from the original: I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text. I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences. As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor. * Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 10 Oct, 2018 5 commits
-
-
Greg Spencer authored
We decided that redefining the default for templates was premature. We're going to go back to having "module" in experimental land again, and we'll try again when we have the feature set fully baked. This keeps the writing of the .metadata files, and writing the template type to them, because that was a good improvement, and there are still a bunch of added tests that improve our coverage.
-
Philip authored
* Remove new keyword from default template app
-
Jason Simmons authored
This is required in order to support "flutter run --profile"
-
Danny Tuppeny authored
* Allow passing a restart reason through to analytics * Update to avoid overlaps with other code * Remove TODO as this is the real live value * Improve formatting + constant name
-
Jorge Coca authored
Fixes https://github.com/flutter/flutter/issues/19507
-
- 09 Oct, 2018 6 commits
-
-
Greg Spencer authored
Fixes #22451
-
Stanislav Baranov authored
-
Stanislav Baranov authored
Gradle plugin support for adding flutter as subproject to another Android app
-
Jason Simmons authored
This is required in order to support "flutter run --profile"
-
Greg Spencer authored
-
- 08 Oct, 2018 3 commits
-
-
matthew-carroll authored
Publish make-host-app-editable command with CLI docs.
-
Andrew Davies authored
Adds a Fuchsia compatibility function that allows for connecting to a specific Isolate by name when running Flutter Driver on a Fuchsia device. This will check over multiple Dart VM's in an attempt to find an Isolate by its name.
-
Greg Spencer authored
Fixes a gradle error where it was failing to find a plugin because of an absolute path in the .flutter-plugins file instead of a relative path. I had originally removed this variable because I thought it was redundant with the projectDir, but apparently I was wrong about that (one resolves to a relative path, and one resolves to an absolute path). This PR reverts that part of the change and reintroduces the (not really) redundant variable.
-
- 06 Oct, 2018 2 commits
-
-
Greg Spencer authored
Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759) This reverts commit e4386321 because it breaks 160 benchmarks, and several devicelab tests, due to changing the format of the output.
-
Greg Spencer authored
Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 05 Oct, 2018 7 commits
-
-
Greg Spencer authored
This all happened because I was trying to be a little too helpful... Part of the job of the "create" command is to recreate missing pieces of existing projects, and now that the default has changed, I wanted to make it so that if someone had created a default flutter create project before, that they could run a default flutter create there again, and not have it trashed by using the new default template (application) over the old one (app). This meant I had to detect what type of project it was. Unfortunately, in the past we didn't write anything in the .metadata file to identify the type of project, and since the goal was regenerating missing files, I can't count on anything existing, so it's just a heuristic match. This simplifies the heuristics down to just detecting the difference between "app" and "application" projects, and only detect the other types if they're explicitly listed in the .metadata file (I changed the code in my original PR to add the project type to the .metadata file). People used to have to specify the type for those anyhow, so it shouldn't be a surprise to users. So, the main difference in the new heuristics from my last attempt is that if you have a directory that has some other stuff it (like maybe a "plugin" project), then we'll recreate (pronounced "mess up") the project using the "application" template, but that was true before (except it would use the "app" template). Fixes #22726
-
Yegor authored
* first pass * revert WidgetsBindingObserver * disable prefer_mixin * docs and more mixins * newer engine; binding fixes * upgrade dependencies * fix test binding * remove whitespace * remove the obsolete `enableSuperMixins: true` * upgrade dartdoc to 0.22.0 * temporarily use git version of dartdoc * fix pub global activate syntax * use dartdoc 0.23.0
-
Jason Simmons authored
-
Danny Tuppeny authored
https://github.com/flutter/flutter/issues/22338#issuecomment-425794734 shows almost 1 minute being spent on the `Resolving Dependencies` step alone. Possibly this needs to go higher still, but this should be a good start.
-
tonyzhao1 authored
-
Alexandre Ardhuin authored
-
- 04 Oct, 2018 4 commits
-
-
Greg Spencer authored
Apparently, this accounts for 13% of our crashes in Beta.
-
Greg Spencer authored
This renames the "module" template to the "application" template, and makes "application" the default. The existing "app" template is now deprecated. flutter create also now recognizes the type of project in an existing directory, and is able to recreate it without having the template type explicitly specified (although you can still do that). It does this now by first looking in the .metadata file for the new project_type field, and if it doesn't find that, then it looks at the directory structure. Also, the .metadata file is now overwritten even on an existing directory so that 1) the project_type can be added to legacy projects, and 2) the version of Flutter that updated the project last is updated. I also cleaned up a bunch of things in create_test.dart, added many more tests, and added an example test to the test/ directory in the generated output of the application template. Fixes #22530 Fixes #22344
-
Jason Simmons authored
Previously flutter_tools had used "gradle properties" to find the build types and flavors supported by the Gradle project. Tasks should work more reliably across different versions of the Android Gradle plugin. Fixes https://github.com/flutter/flutter/issues/20781
-
Alexandre Ardhuin authored
-
- 03 Oct, 2018 3 commits
-
-
Michael Goderbauer authored
-
Danny Tuppeny authored
* Block setting of fs.currentDirectory in tests This isn't perfect, it only covers tests using testUsingContext, but that is the huge majority of tests. * Tweak error message.
-
Michael Goderbauer authored
-
- 02 Oct, 2018 3 commits
-
-
Danny Tuppeny authored
* Change file paths to URIs to fix "Could not run configuration in engine" on Windows Plus unskip test that was failing due to this. Fixes #21348. * Remove unused import
-
Alexandre Ardhuin authored
-
jensjoha authored
-
- 01 Oct, 2018 4 commits
-
-
Yegor authored
-
Jason Simmons authored
The asset subsystem uses URIs to represent asset locations. The font manifest should also use URI-encoded paths instead of unencoded paths taken directly from the manifest YAML. Fixes https://github.com/flutter/flutter/issues/19452
-
Alexandre Ardhuin authored
-
Jonah Williams authored
This reverts commit b07d986f.
-