1. 19 Jun, 2023 5 commits
    • Jason Simmons's avatar
      Fix an ordering dependency in the flutter_tools upgrade test (#129131) · 03d50d1f
      Jason Simmons authored
      Cache.flutterRoot is set within testUsingContext and will be
      uninitialized the first time test suite setup is invoked.
      03d50d1f
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 164c6b49dfb5 to 280491d4cc21 (1 revision) (#129102) · 323c2969
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/164c6b49dfb5...280491d4cc21
      
      2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision) (flutter/engine#42975)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      323c2969
    • Taha Tesser's avatar
      Fix `InputDecoration.applyDefaults` ignoring some properties (#129010) · 165d2377
      Taha Tesser authored
      fixes [`InputDecoration.applyDefaults` ignores some properties](https://github.com/flutter/flutter/issues/127330)
      
      <details> 
      <summary>code sample</summary> 
      
      ```dart
      import 'package:flutter/material.dart';
      
      void main() => runApp(const MyApp());
      
      class MyApp extends StatelessWidget {
        const MyApp({super.key});
      
        @override
        Widget build(BuildContext context) {
          return MaterialApp(
            debugShowCheckedModeBanner: false,
            theme: ThemeData(useMaterial3: true),
            home: const Example(),
          );
        }
      }
      
      class Example extends StatelessWidget {
        const Example({super.key});
      
        @override
        Widget build(BuildContext context) {
          const TextStyle textStyle = TextStyle(color: Color(0xFF00FFFF));
          const Color color = Color(0xFF00FF00);
          const InputBorder inputBorder = OutlineInputBorder(
            borderSide: BorderSide(
              color: Color(0xFF0000FF),
            ),
          );
      
          final InputDecoration appliedDefaults =
              const InputDecoration().applyDefaults(
            const InputDecorationTheme(
              labelStyle: textStyle,
              floatingLabelStyle: textStyle,
              helperStyle: textStyle,
              helperMaxLines: 2,
              hintStyle: textStyle,
              errorStyle: textStyle,
              errorMaxLines: 2,
              floatingLabelBehavior: FloatingLabelBehavior.never,
              floatingLabelAlignment: FloatingLabelAlignment.center,
              isDense: true,
              contentPadding: EdgeInsets.all(1.0),
              iconColor: color,
              prefixStyle: textStyle,
              prefixIconColor: color,
              suffixStyle: textStyle,
              suffixIconColor: color,
              counterStyle: textStyle,
              filled: true,
              fillColor: color,
              focusColor: color,
              hoverColor: color,
              errorBorder: inputBorder,
              focusedBorder: inputBorder,
              focusedErrorBorder: inputBorder,
              disabledBorder: inputBorder,
              enabledBorder: inputBorder,
              border: InputBorder.none,
              alignLabelWithHint: true,
              constraints: BoxConstraints(
                  minWidth: 10, maxWidth: 20, minHeight: 30, maxHeight: 40),
            ),
          );
      
          return Scaffold(
            appBar: AppBar(
              title: const Text('InputDecoration().applyDefaults'),
            ),
            // Centered FilledButton.
            body: Center(
              child: SingleChildScrollView(
                child: Column(
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: <Widget>[
                    ColoredBox(
                      color: appliedDefaults.labelStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.labelStyle.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.floatingLabelStyle
                              .toString()
                              .contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.floatingLabelStyle.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.helperStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.helperStyle.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.hintStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.hintStyle.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.errorStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.errorStyle.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.iconColor.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.iconColor.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.prefixStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.prefixStyle.toString()),
                    ),
                    ColoredBox(
                      color:
                          appliedDefaults.prefixIconColor.toString().contains('null')
                              ? Colors.red
                              : Colors.green,
                      child: Text(appliedDefaults.prefixIconColor.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.suffixStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.suffixStyle.toString()),
                    ),
                    ColoredBox(
                      color:
                          appliedDefaults.suffixIconColor.toString().contains('null')
                              ? Colors.red
                              : Colors.green,
                      child: Text(appliedDefaults.suffixIconColor.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.counterStyle.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.counterStyle.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.fillColor.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.fillColor.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.focusColor.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.focusColor.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.hoverColor.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.hoverColor.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.errorBorder.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.errorBorder.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.focusedBorder.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.focusedBorder.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.focusedErrorBorder
                              .toString()
                              .contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.focusedErrorBorder.toString()),
                    ),
                    ColoredBox(
                      color:
                          appliedDefaults.disabledBorder.toString().contains('null')
                              ? Colors.red
                              : Colors.green,
                      child: Text(appliedDefaults.disabledBorder.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.enabledBorder.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.enabledBorder.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.border.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.border.toString()),
                    ),
                    ColoredBox(
                      color: appliedDefaults.constraints.toString().contains('null')
                          ? Colors.red
                          : Colors.green,
                      child: Text(appliedDefaults.constraints.toString()),
                    ),
                  ],
                ),
              ),
            ),
          );
        }
      }
      ``` 
      	
      </details>
      
      ### Before
      
      ![before screenshot](https://github.com/flutter/flutter/assets/48603081/ae564e15-4029-4feb-810f-e46b9312a257)
      
      ### After
      ![after screenshot](https://github.com/flutter/flutter/assets/48603081/8924a1d8-ffde-494b-bf44-66dab4d28845)
      165d2377
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from d298f0bf720c to 164c6b49dfb5 (1 revision) (#129100) · 59e30ef4
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/d298f0bf720c...164c6b49dfb5
      
      2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 5a9e97eebbed to b2ec326cc4f3 (1 revision) (flutter/engine#42974)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      59e30ef4
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 7ffa1355f718 to d298f0bf720c (24 revisions) (#129092) · 0dadf408
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/7ffa1355f718...d298f0bf720c
      
      2023-06-18 jonahwilliams@google.com Fix prefer_final_in_foreach analysis
      errors (flutter/engine#42971)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
      xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
      aBEyk5N2HlwOqvpwo... to BuzniDS9u_hdghV5f... (flutter/engine#42970)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from dc2e0ebbd045 to
      f489be63a30a (1 revision) (flutter/engine#42968)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from 85b4788bc3f1 to
      dc2e0ebbd045 (1 revision) (flutter/engine#42967)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
      -PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966)
      2023-06-18 bdero@google.com [Impeller] Use 32 bit for positional stuff
      in the rrect blur (flutter/engine#42797)
      2023-06-18 jonahwilliams@google.com Revert "[Impeller] correct default
      PSO pixel format and sample count." (flutter/engine#42962)
      2023-06-18 jonahwilliams@google.com [Impeller] dont use concurrent
      runner to decode images on Android. (flutter/engine#42944)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
      I1G8Ll0KcxmAoMT8u... to aBEyk5N2HlwOqvpwo... (flutter/engine#42964)
      2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from c56f38d79fe0 to
      85b4788bc3f1 (2 revisions) (flutter/engine#42963)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
      Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
      d1faf69c8253 to 5a9e97eebbed (1 revision) (flutter/engine#42958)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from 2a9e11fd9d37 to
      c56f38d79fe0 (1 revision) (flutter/engine#42955)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
      JMStJe6efcLuWMT_I... to I1G8Ll0KcxmAoMT8u... (flutter/engine#42954)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
      1a04f451a934 to d1faf69c8253 (1 revision) (flutter/engine#42953)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
      b3bcbdf7de8d to 1a04f451a934 (1 revision) (flutter/engine#42951)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from dc11c7ddb33f to
      2a9e11fd9d37 (1 revision) (flutter/engine#42950)
      2023-06-17 bdero@google.com [Impeller] Print malioc errors on CI
      (flutter/engine#42906)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
      8eaed3382237 to b3bcbdf7de8d (10 revisions) (flutter/engine#42949)
      2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
      -NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948)
      2023-06-17 a-siva@users.noreply.github.com Fix analyzer warnings
      (prefer_final_in_for_each is now the default) (flutter/engine#42943)
      2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
      fXVcR5tdj5wSd_OUz... to JMStJe6efcLuWMT_I... (flutter/engine#42942)
      2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 64fa632d3b01 to
      dc11c7ddb33f (3 revisions) (flutter/engine#42939)
      
      Also rolling transitive DEPS:
        fuchsia/sdk/core/linux-amd64 from -NW1eatBbmjv to fgS2avQGq4x_
        fuchsia/sdk/core/mac-amd64 from fXVcR5tdj5wS to BuzniDS9u_hd
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
      the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter:
      https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      0dadf408
  2. 17 Jun, 2023 1 commit
  3. 16 Jun, 2023 13 commits
  4. 15 Jun, 2023 13 commits
  5. 14 Jun, 2023 8 commits