Commits · 03891a457809eeee070ac315c4c4af3703b25509 · abdullh.alsoleman / Front-End

09 Feb, 2024 11 commits

Roll Packages from 29d8cc006b0e to 11152d2bc8f3 (4 revisions) (#143217) · 03891a45

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/packages/compare/29d8cc006b0e...11152d2bc8f3

2024-02-09 jsharp83@gmail.com [webview_flutter] Add interface for showing javascript dialog message (flutter/packages#4704)
2024-02-09 32931186+erdzan12@users.noreply.github.com [pigeon] Implement Screaming Snake Case Conversion for Kotlin Enum Cases (flutter/packages#5918)
2024-02-09 43054281+camsim99@users.noreply.github.com [camerax] Small fixes to starting/stopping video capture (flutter/packages#6068)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter from 8431cae8 to eb5d0a43 (33 revisions) (flutter/packages#6079)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

03891a45

Roll Flutter Engine from 350dc662e5af to 1508b11bf791 (1 revision) (#143214) · 5f89a503

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/350dc662e5af...1508b11bf791

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 64a25300fe1c to 68cb550de88d (2 revisions) (flutter/engine#50491)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f89a503

barrierColor property in DialogTheme (#142490) · f0bb9d57
David Martos authored Feb 09, 2024

f0bb9d57

Roll Flutter Engine from f6dddb257a4f to 350dc662e5af (1 revision) (#143208) · 8b228b9e

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/f6dddb257a4f...350dc662e5af

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 9bcc54924128 to 64a25300fe1c (3 revisions) (flutter/engine#50489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b228b9e

Roll Flutter Engine from 377f1b068541 to f6dddb257a4f (1 revision) (#143207) · 950e0025

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/377f1b068541...f6dddb257a4f

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from c36362d95df0 to 9bcc54924128 (1 revision) (flutter/engine#50488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

950e0025

Roll Flutter Engine from 1f3b15738adb to 377f1b068541 (1 revision) (#143204) · 88dead01

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/1f3b15738adb...377f1b068541

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 672bb50b6d8f to c36362d95df0 (3 revisions) (flutter/engine#50485)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88dead01

Roll Flutter Engine from f9a169e0e0c1 to 1f3b15738adb (1 revision) (#143201) · 189fe6b7

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/f9a169e0e0c1...1f3b15738adb

2024-02-09 dnfield@google.com [Impeller] Move impeller/image to impeller/playground/image (flutter/engine#50480)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

189fe6b7

Roll Flutter Engine from 7b579dc30979 to f9a169e0e0c1 (2 revisions) (#143199) · 34585771

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/7b579dc30979...f9a169e0e0c1

2024-02-09 chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter in the Android embedder. (flutter/engine#50472)
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 59943f4e92b9 to 672bb50b6d8f (3 revisions) (flutter/engine#50476)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

34585771

Layout animated GIFs only once (#143188) · 0aa9b5e1

Michael Goderbauer authored Feb 09, 2024

Fixes https://github.com/flutter/flutter/issues/138610.

When `RenderImage` receives a new `Image` it only needs to fire up the layout machinery when the dimensions of the image have changed compared to the previous image. If the dimensions are the same, a repaint is sufficient.

0aa9b5e1

Roll Flutter Engine from 95feed196aab to 7b579dc30979 (1 revision) (#143195) · 5f1a3c16

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/95feed196aab...7b579dc30979

2024-02-08 ditman@gmail.com Reland "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50457)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f1a3c16

Roll Flutter Engine from eabac2fa7a26 to 95feed196aab (2 revisions) (#143192) · 808588c7

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/eabac2fa7a26...95feed196aab

2024-02-08 chinmaygarde@google.com [Impeller] Delete the archivist framework. (flutter/engine#50474)
2024-02-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CPiPDUwCrjHYf_lAR... to RK2irywND2DKT4l6C... (flutter/engine#50473)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from CPiPDUwCrjHY to RK2irywND2DK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

808588c7

08 Feb, 2024 24 commits

Roll Flutter Engine from 9b37c68b4069 to eabac2fa7a26 (2 revisions) (#143190) · ebeba8f0

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/9b37c68b4069...eabac2fa7a26

2024-02-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/engine#50388)
2024-02-08 chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter tester. (flutter/engine#50454)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ebeba8f0

Roll Flutter Engine from 6f5b6a37107b to 9b37c68b4069 (2 revisions) (#143189) · 87dd27cf

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/6f5b6a37107b...9b37c68b4069

2024-02-08 30870216+gaaclarke@users.noreply.github.com Updated CONTRIBUTING.md to have a testing section (flutter/engine#50469)
2024-02-08 26625149+0xZOne@users.noreply.github.com Fix Core Foundation object leaks. (flutter/engine#50460)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

87dd27cf

Set default flutter source directory for gradle builds (#142934) · 2299ec78

Gustl22 authored Feb 08, 2024

See [#142498](https://github.com/flutter/flutter/pull/142498#discussion_r1478602032)
See this discussion: https://discord.com/channels/608014603317936148/1186378330178601000

2299ec78

[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (#143132) · 4b0abc77

Gray Mackall authored Feb 08, 2024

Re land of https://github.com/flutter/flutter/pull/142000. 
Differences:
1. Fixed the test that was failing in postsubmit. The reason was that the Flutter Gradle Plugin was being applied after KGP in that test, so we couldn't find the KGP version. This caused a log, and the test expects no logs. I moved FGP to after KGP
2. Added to the logs for when we can't find AGP. Change is from
>  "Warning: unable to detect project AGP version. Skipping version checking."

to 
> ~"Warning: unable to detect project AGP version. Skipping version checking. \nThis may be because you have applied the Flutter Gradle Plugin after AGP."~

update: the above is wrong, changed to 
> "Warning: unable to detect project KGP version. Skipping version checking. \nThis may be because you have applied AGP after the Flutter Gradle Plugin."

3. Added a note to the app-level build.gradle templates that FGP must go last
> // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugin.

4b0abc77

Roll Flutter Engine from fb99a84de07e to 6f5b6a37107b (2 revisions) (#143183) · d1d69027

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/fb99a84de07e...6f5b6a37107b

2024-02-08 110993981+htoor3@users.noreply.github.com [web] - Fix `inputmode` on Android Firefox (flutter/engine#46901)
2024-02-08 bdero@google.com [Impeller] Vulkan: Don't fail initialization if stencil-only textures aren't supported. (flutter/engine#50455)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d1d69027

Revert Dual Web Compile changes (#143175) · 2efeeb47

Jackson Gardner authored Feb 08, 2024

Dual Web Compile has had some issues where `flutter test` is not respecting the `--web-renderer` flag for some reason. I haven't gotten entirely to the bottom of the issue, but for now we need to rever these changes while I investigate. This reverts the following PRs:

https://github.com/flutter/flutter/pull/143128
https://github.com/flutter/flutter/pull/141396

While doing this revert, I had a few merge conflicts with https://github.com/flutter/flutter/pull/142760, and I tried to resolve the merge conflicts within the spirit of that PR's change, but @chingjun I might need your input on whether the imports I have modified are okay with regards to the change you were making.

2efeeb47

Cross-link SliverFixedExtentList/SliverPrototypeExtentList/SliverVariedExtentList (#143184) · 8d3c7b6f
Michael Goderbauer authored Feb 08, 2024
```
Fixes https://github.com/flutter/flutter/issues/141678.
```
8d3c7b6f

[flutter_tool] Retry a gradle build on connection timeout (#143084) · fbc9f2d5

Zachary Anderson authored Feb 08, 2024

This PR will likely not help with the issue on our CI discussed in
https://github.com/flutter/flutter/issues/142637, but will do one retry
for our users if they hit the same issue.

fbc9f2d5

Correct menu position when menu is constrained (#143121) · cc4abe92

Qun Cheng authored Feb 08, 2024

Fixes #142896

The original code below is to always place the selected item above(overlap) the popup button so that the selected item can always be visible: https://github.com/flutter/flutter/blob/f8a77225f360556322934a9a831ffc9c9f3125da/packages/flutter/lib/src/material/popup_menu.dart#L723-L732

But when menu height is constrained and the menu itself is super long, the selected item still assumes there is enough space to push up all the items whose index is smaller than the selected index. As a result, every time when the menu is open, the calculation provides a different result to be the offset for the selected index, and then with a constrained height, the menu looks jumping all over the place based on the different selected index.

https://github.com/flutter/flutter/assets/36861262/ad761f95-0ff5-4311-a81d-dac56df879c5

Even though the original calculation is to make the selected item visible when open the menu, the menu doesn't auto scroll and only expands itself as much as possible to show the selected one. In this case, if the screen it too small to show the selected item, we still cannot see it. This can be fixed by using `Scrollable.ensureVisible()`(#143118).

So we remove the calculation in this PR and the menu will always show up based on the top left of the anchor(button).

https://github.com/flutter/flutter/assets/36861262/03272f26-9440-4ac4-a701-9a0b41776ff9

cc4abe92

Enable the whole logcat log (#143119) · e64a372d
keyonghan authored Feb 08, 2024
```
Help with https://github.com/flutter/flutter/issues/142572.
```
e64a372d

Roll Flutter Engine from 3fb60b8f37c3 to fb99a84de07e (1 revision) (#143169) · aed2ae54

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/3fb60b8f37c3...fb99a84de07e

2024-02-08 jonahwilliams@google.com [Impeller] remove extra buffer usage in compute. (flutter/engine#50415)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aed2ae54

Roll Flutter Engine from f53fbd8393ce to 3fb60b8f37c3 (1 revision) (#143165) · efd1d1f5

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/f53fbd8393ce...3fb60b8f37c3

2024-02-08 30870216+gaaclarke@users.noreply.github.com [Impeller] blur: drop eighth downsample barrier (flutter/engine#50405)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efd1d1f5

Reland "Move native assets to `isolated/` directory" (#143055) · 4e70bfae

Daco Harkes authored Feb 08, 2024

Reland of https://github.com/flutter/flutter/pull/142709.

The revert of the revert is in the first commit, the fix in the commit on top.

The move of the fakes for packages/flutter_tools/test/general.shard/resident_runner_test.dart was erroneous before, as it was trying to use setters instead of a private field. This PR changes the private `_devFS` field in the fake to be a public `fakeDevFS` in line with other fakes.

## Original PR description

Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.

This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.

In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:

* bin/fuchsia_tester.dart
* lib/executable.dart

The build_system/targets dir is already excluded in other build systems.

So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.

Context:

* https://github.com/flutter/flutter/issues/142041

4e70bfae

Highlight the links to the release branches more prominently in the CP issue template (#143000) · 38c6a5ac
Zachary Anderson authored Feb 08, 2024
```
Unfortunately, there's no option to preview these changes in the GitHub UI, so I may need to iterate on this...
```
38c6a5ac

Reland "Update gradle lockfiles template (#140115)" (#143081) · deaa6002

Bartek Pacia authored Feb 08, 2024

Trying to reland #140115 which I had to revert in #142889 because [it broke the tree](https://github.com/flutter/flutter/pull/140115#issuecomment-1925774719).

In this PR I fixed the post-submit following tests:

deaa6002

Roll Packages from e4ea6bf72e1b to 29d8cc006b0e (5 revisions) (#143161) · eb5d0a43

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/packages/compare/e4ea6bf72e1b...29d8cc006b0e

2024-02-07 td@technodisaster.com [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125)
2024-02-07 jason-simmons@users.noreply.github.com [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076)
2024-02-07 58767497+GiftShower@users.noreply.github.com Add transitionDuration parameter (flutter/packages#5854)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter from e6ba809b to 8431cae8 (23 revisions) (flutter/packages#6075)
2024-02-07 ltv.luongthevinh@gmail.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eb5d0a43

Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) (#143160) · 004d96a1

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/6d524588c0f9...f53fbd8393ce

2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from fe4aa8a3ea53 to 59943f4e92b9 (1 revision) (flutter/engine#50463)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

004d96a1

Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) (#143147) · 92c7ba81

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/22e1241e9823...6d524588c0f9

2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 97f12df11af2 to fe4aa8a3ea53 (2 revisions) (flutter/engine#50462)
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 8e08ece134da to 97f12df11af2 (1 revision) (flutter/engine#50461)
2024-02-08 xilaizhang@google.com [github actions] update license year (flutter/engine#50458)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92c7ba81

Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) (#143140) · 720f73a4

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/084bd0b8f5ac...22e1241e9823

2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 91a9154d0dfa to 8e08ece134da (1 revision) (flutter/engine#50459)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

720f73a4

Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) (#143139) · be659e0b

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/104804aa374e...084bd0b8f5ac

2024-02-08 robert.ancell@canonical.com Clear objects before setting them. (flutter/engine#50344)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be659e0b

Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) (#143138) · 28904c0c

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/45137ea6ba29...104804aa374e

2024-02-08 26625149+0xZOne@users.noreply.github.com [ios] Fix memory leak in ChildClippingView (flutter/engine#50389)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

28904c0c

Pass along web renderer into debugging options in the test command. (#143128) · 71c6cd0c

Jackson Gardner authored Feb 08, 2024

We need to pass along the web renderer in the debugging options to make sure that the resident web runner sets up the targets correctly.

71c6cd0c

Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) (#143135) · b586bd91

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/4ea7bd07328b...45137ea6ba29

2024-02-07 goderbauer@google.com Report display sizes in physical pixels on MacOS (flutter/engine#50221)
2024-02-07 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with multiple packages (flutter/engine#50219)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b586bd91

Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) (#143131) · 6af69544

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/322a461dc74f...4ea7bd07328b

2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from 8332438cbeb9 to 91a9154d0dfa (2 revisions) (flutter/engine#50452)
2024-02-07 jonahwilliams@google.com [Impeller] move path out of PathBuilder in TakePath. (flutter/engine#50444)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6af69544

07 Feb, 2024 5 commits

Add a unit test for `NavigationRail` (#143108) · d85497d9

Qun Cheng authored Feb 07, 2024

Adding `SingleChildScrollView` to `NavigationRail` may cause exception if the nav rail has some expanded widgets inside, like the issue: https://github.com/flutter/flutter/issues/143061. This PR is just to add a unit test to avoid causing this breaking again.

d85497d9

Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) (#143123) · 52f897be

engine-flutter-autoroll authored Feb 07, 2024

https://github.com/flutter/engine/compare/b1ba9f329f76...322a461dc74f

2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from eacaa2d3600c to 8332438cbeb9 (6 revisions) (flutter/engine#50451)
2024-02-07 dnfield@google.com [Impeller] Log non-default graphics backend usages, use IMPORTANT rather than ERROR (flutter/engine#50448)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52f897be

Reverts "Improve build output for all platforms" (#143125) · cc4e0795

auto-submit[bot] authored Feb 07, 2024

Reverts flutter/flutter#128236

Initiated by: vashworth

Reason for reverting: Causing `Mac_pixel_7pro run_release_test` and `Mac_arm64_android run_release_test` to fail: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_pixel_7pro%20run_release_test/547/overview 
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/10516/overview

Original PR Author: guidezpl

Reviewed By: {christopherfujino, loic-sharma}

This change reverts the following previous change:
Original Description:
Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

cc4e0795

Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) (#143120) · aeb87eb5

engine-flutter-autoroll authored Feb 07, 2024

https://github.com/flutter/engine/compare/e4a5acc14b44...b1ba9f329f76

2024-02-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kvEXgoydRYnW3UvX2... to CPiPDUwCrjHYf_lAR... (flutter/engine#50447)
2024-02-07 matanlurey@users.noreply.github.com Fix Android `scenario_app` to actually run and block on CI (flutter/engine#50414)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kvEXgoydRYnW to CPiPDUwCrjHY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aeb87eb5

Improve build output for all platforms (#128236) · 2fceeb0e

Pierre-Louis authored Feb 07, 2024

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

2fceeb0e