1. 10 Jan, 2020 1 commit
  2. 09 Jan, 2020 3 commits
  3. 08 Jan, 2020 1 commit
  4. 07 Jan, 2020 4 commits
  5. 06 Jan, 2020 1 commit
  6. 03 Jan, 2020 1 commit
  7. 02 Jan, 2020 2 commits
  8. 31 Dec, 2019 1 commit
    • Ian Hickson's avatar
      Add many more global analyses. (#47875) · e768c92f
      Ian Hickson authored
      * Update packages.
      
      * Add many more global analyses.
      
      * Catch trailing spaces and trailing newlines in all text files.
        Before we were only checking newly added files, but that means we
        missed some.
      
      * Port the trailing spaces logic to work on Windows too.
      
      * Correct all the files with trailing spaces and newlines.
      
      * Refactor some of the dev/bots logic into a utils.dart library.
        Notably, the "exit" and "print" shims for testing are now usable
        from test.dart, analyze.dart, and run_command.dart.
      
      * Add an "exitWithError" function that prints the red lines and
        then exits. This is the preferred way to exit from test.dart,
        analyze.dart, and run_command.dart.
      
      * More consistency in the output of analyze.dart.
      
      * Refactor analyze.dart to use the _allFiles file enumerating logic
        more widely.
      
      * Add some double-checking logic to the _allFiles logic to catch
        cases where changes to that logic end up catching fewer files
        than expected (helps prevent future false positives).
      
      * Add a check to prevent new binary files from being added to
        the repository. Grandfather in the binaries that we've already
        added.
      
      * Update all the dependencies (needed because we now import crypto in
        dev/bots/analyze.dart).
      e768c92f
  9. 30 Dec, 2019 2 commits
  10. 27 Dec, 2019 1 commit
  11. 23 Dec, 2019 1 commit
  12. 21 Dec, 2019 2 commits
  13. 20 Dec, 2019 1 commit
  14. 19 Dec, 2019 5 commits
  15. 18 Dec, 2019 3 commits
  16. 17 Dec, 2019 1 commit
  17. 16 Dec, 2019 2 commits
  18. 13 Dec, 2019 1 commit
  19. 12 Dec, 2019 2 commits
  20. 06 Dec, 2019 1 commit
  21. 05 Dec, 2019 3 commits
    • Greg Spencer's avatar
      Fixes Focus and FocusScope's assignment of canRequestFocus. (#46168) · e3005e69
      Greg Spencer authored
      This fixes an issue where lines like this:
      
          focusNode.canRequestFocus = widget.canRequestFocus ?? focusNode.canRequestFocus;
      
      Were causing the canRequestFocus bit to copy the status of the enclosing scope, since canRequestFocus also looks to the enclosing scope to decide if it can focus.
      e3005e69
    • Greg Spencer's avatar
      Normalizes all of the "See also" blocks in comments. (#46121) · c6fe7bb9
      Greg Spencer authored
      This normalizes all of the "See also" blocks in comments so that they conform in style.
      
      They all look like this now:
      
        /// See also:
        ///
        ///  * [MyFavoriteWidget], because it's cool.
        class Foo {}
      
      I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.
      
      This is my penance for adding so many bullets that are "-" instead of "*". :-)
      c6fe7bb9
    • Greg Spencer's avatar
      Overridable default platform key bindings (#45102) · f7d16161
      Greg Spencer authored
      This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.
      
      I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
      f7d16161
  22. 04 Dec, 2019 1 commit