1. 04 Feb, 2021 1 commit
  2. 27 Jan, 2021 1 commit
  3. 26 Jan, 2021 1 commit
  4. 07 Jan, 2021 2 commits
  5. 06 Jan, 2021 2 commits
  6. 17 Dec, 2020 1 commit
  7. 15 Dec, 2020 1 commit
  8. 09 Dec, 2020 2 commits
  9. 08 Dec, 2020 2 commits
  10. 05 Dec, 2020 3 commits
  11. 04 Dec, 2020 1 commit
  12. 02 Dec, 2020 1 commit
  13. 23 Nov, 2020 1 commit
  14. 20 Nov, 2020 1 commit
  15. 17 Nov, 2020 1 commit
  16. 05 Nov, 2020 1 commit
  17. 04 Nov, 2020 1 commit
  18. 26 Oct, 2020 1 commit
  19. 20 Oct, 2020 1 commit
  20. 19 Oct, 2020 2 commits
    • Jenn Magder's avatar
    • Greg Spencer's avatar
      Mark keys that match a shortcut, but have no action defined as "not handled". (#67359) · 8c03ff8c
      Greg Spencer authored
      - - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus.
      
      This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry.
      
      This PR includes:
      
      - Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation").
      - Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored.
      - Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them.
      - Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
      Unverified
      8c03ff8c
  21. 16 Oct, 2020 1 commit
  22. 12 Oct, 2020 1 commit
  23. 01 Oct, 2020 1 commit
  24. 25 Sep, 2020 1 commit
  25. 23 Sep, 2020 1 commit
  26. 22 Sep, 2020 1 commit
  27. 21 Sep, 2020 1 commit
  28. 19 Sep, 2020 1 commit
  29. 16 Sep, 2020 1 commit
  30. 15 Sep, 2020 1 commit
    • Greg Spencer's avatar
      Fix the `character` field of the `RawKeyEvent` to hold correct data on... · 199a7c19
      Greg Spencer authored
      Fix the `character` field of the `RawKeyEvent` to hold correct data on non-Android platforms. (#65667)
      
      This fixes a problem where the character field of the RawKeyEvent was not being set at all for non-Android platforms.
      
      I also updated the key maps, and corrected a problem with the Windows key map where the backquote character wasn't correctly mapped.
      Unverified
      199a7c19
  31. 13 Sep, 2020 1 commit
  32. 10 Sep, 2020 1 commit
  33. 11 Aug, 2020 1 commit