1. 03 Aug, 2017 1 commit
  2. 27 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Increase the touch slop. (#11419) · 87445e59
      Ian Hickson authored
      It was 8.0. It's now arbitrarily 18.0.
      
      Changing this required adjusting some tests. Adjusting the tests
      required debugging the tests. Debugging the tests required some tools
      to help debugging gesture recognizers and gesture arenas, so I added
      some. It also required updating some toString() methods which resulted
      in some changes to the tree diagnostics logic.
      
      Also I cleaned up some docs while I was at it.
      87445e59
  3. 12 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
  4. 15 Mar, 2017 2 commits
  5. 08 Mar, 2017 1 commit
  6. 04 Mar, 2017 1 commit
  7. 22 Jan, 2017 1 commit
  8. 17 Jan, 2017 1 commit
    • Adam Barth's avatar
      Fix several minor bugs and add many tests (#7506) · 2b742289
      Adam Barth authored
      * MultiTapGestureRecognizer previously would assert if there was no
         competition.
       * GestureArenaTeam would always select the first recongizer as the
         winner even if a later recognizer actually accepted the pointer
         sequence.
       * debugPrintStack would fail a type check if maxFrames was non-null.
       * FractionalOffset.lerp would throw a null-pointer exception if its
         second argument was null.
      
      Also, add a number of tests for previously untested lines of code.
      2b742289
  9. 16 Nov, 2016 1 commit
  10. 15 Nov, 2016 1 commit
  11. 28 Oct, 2016 1 commit
  12. 07 Jun, 2016 1 commit
  13. 01 Jun, 2016 1 commit
    • Adam Barth's avatar
      Deploy mustCallSuper (#4285) · a0e7cdba
      Adam Barth authored
      This patch starts using the mustCallSuper annotation for several of the key
      lifecycle callbacks in the framework. I haven't added it to didUpdateConfig
      because there are a large number of non-compliant overrides. We should discuss
      whether we want to use it there.
      a0e7cdba
  14. 25 May, 2016 1 commit
  15. 17 May, 2016 1 commit
  16. 22 Apr, 2016 1 commit
  17. 14 Mar, 2016 1 commit
  18. 25 Feb, 2016 2 commits
    • Adam Barth's avatar
      Remove PointerRouter and GestureArena arguments · 4b1a9ff1
      Adam Barth authored
      There's no reason to make clients supply a PointerRounter and a
      GestureArena when constructing gesture recognizers. These objects are
      statics and the gesture recognizers can just grab them directly.
      
      Also, remove the callback constructor arguments. Almost no code used
      them. Instead, people seem to prefer using the `..` operator to set
      callbacks on the recognizers. Removing the arguments removes a bunch of
      boilerplate.
      4b1a9ff1
    • Hixie's avatar
      Just-in-time mutations of GestureDetector · 0df3730d
      Hixie authored
      This allows us to adjust exactly which gestures we're listening for
      during layout, which I'll use to kill a SizeObserver.
      0df3730d
  19. 11 Feb, 2016 1 commit
    • Hixie's avatar
      Provide a Draggable that starts on drag · 8e279f32
      Hixie authored
      This lets it cooperate with other gestures like tap.
      
      The way I implemented this was to refactor the entire Draggable gesture
      logic to use a new kind of gesture detector called
      MultiDragGestureRecognizer. It works a bit like
      MultiTapGestureRecognizer but for drags.
      
      Also some tweaks to the velocity estimator.
      8e279f32
  20. 14 Dec, 2015 1 commit
  21. 10 Dec, 2015 1 commit
  22. 05 Dec, 2015 1 commit
    • Ian Hickson's avatar
      PointerInput refactor · f1625556
      Ian Hickson authored
      Instead of PointerInputEvent having a "type" field, we now have a
      different class for each pointer type.
      
      This has ripple effects throughout the system.
      
      I also did code cleanup in affected files while I was there.
      f1625556
  23. 05 Nov, 2015 1 commit
    • Hixie's avatar
      Make Draggable use gestures · 255ed0b9
      Hixie authored
      Draggable is now itself a gesture arena member. This means it won't
      conflict with other gesture recognisers in the same path.
      
      This also allows variants of Draggable that are triggered by other
      gestures.
      
      Also, some cleanup of DoubleTapGestureRecognizer, GestureDetector, and
      PrimaryPointerGestureRecognizer.
      
      Also, make MultiTapGestureRecognizer support a timeout for longpress.
      
      Also, make Draggable data be typed.
      
      Also, hide warnings about constructor warnings for now. Analyzer doesn't
      support them yet. (Have to do this on a per-line basis)
      
      Directions for future research:
       - animating the avatar (enter/exit transitions)
       - interaction with the navigator (canceling a drag on page navigation, etc)
       - double-tap draggable
      255ed0b9
  24. 04 Nov, 2015 2 commits
    • Hixie's avatar
      Gesture class hierarchy tune-up · ba3f60f8
      Hixie authored
      Make all the *GestureRecognizer classes inherit from a class called
      GestureRecognizer. Give the old GestureRecognizer a name that is more
      precise about its purpose. Remove the members of GestureArenaMember that
      aren't used by GestureArenas.
      ba3f60f8
    • Hixie's avatar
      Fix double tap constants, add a doubletap test · 7925e060
      Hixie authored
      Document the Gesture Detector constants.
      
      Remove kEdgeSlop since it's obsolete on Android.
      
      Add a test that verifies that when the first tap is canceled, the second
      tap can become the first tap of a subsequent two-tap sequence.
      7925e060
  25. 03 Nov, 2015 4 commits
  26. 27 Oct, 2015 3 commits
  27. 26 Oct, 2015 2 commits
  28. 23 Oct, 2015 2 commits
  29. 20 Oct, 2015 1 commit
  30. 13 Oct, 2015 1 commit